luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

ui: Fixes an issue with the version footer when scrolling (#11850)

This commit is contained in:
John Cowen 2021-12-15 13:55:31 +00:00 committed by GitHub
parent 62967ece3d
commit ad0afe3f60
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.changelog/11850.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:bugfix
ui: Fixes an issue with the version footer wandering when scrolling
```

12
ui/packages/consul-ui/app/components/app/index.scss
View File

@ -4,9 +4,6 @@
.app .notifications { .app .notifications {
@extend %app-notifications; @extend %app-notifications;
} }
.app footer {
@extend %footer;
}
%app-notifications { %app-notifications {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
@ -31,6 +28,9 @@
pointer-events: auto; pointer-events: auto;
} }
[role='contentinfo'] {
@extend %footer;
}
[role='banner'] { [role='banner'] {
@extend %main-header-horizontal; @extend %main-header-horizontal;
} }
@ -68,7 +68,7 @@ main {
@extend %transition-pushover; @extend %transition-pushover;
} }
%footer { %footer {
position: absolute; position: fixed;
z-index: 50; z-index: 50;
color: rgb(var(--tone-gray-400)); color: rgb(var(--tone-gray-400));
@ -77,11 +77,11 @@ main {
width: 250px; width: 250px;
padding-left: 25px; padding-left: 25px;
} }
.app footer { %footer {
top: calc(100vh - 42px); top: calc(100vh - 42px);
top: calc(max(100vh, 460px) - 42px); top: calc(max(100vh, 460px) - 42px);
} }
html.has-partitions.has-nspaces .app footer { html.has-partitions.has-nspaces .app [role='contentinfo'] {
top: calc(100vh - 42px); top: calc(100vh - 42px);
top: calc(max(100vh, 640px) - 42px); top: calc(max(100vh, 640px) - 42px);
} }