luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

UI: Begin unskipping some more trivial tests (#4574) 

WIP Unskip some lower level trivial tests.

This is the beginning of work to unskip some of the more trivial tests that I'd skipped a while back (if the thing they are testing broke, they would have failed higher up in other acceptance tests).

I'd rather keep the tests, as they do test things in a more isolated manner, and the plan was to always come back and work to unskip them time allowing.

I didn't get to far into this work in progress here, but I'd rather merge what I've done all the same and come back at a later date and continue.
This commit is contained in:
John Cowen 2018-08-29 09:59:02 +01:00 committed by GitHub
parent 31c5e19e2f
commit accdefd18e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 30 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
ui-v2/app/templates/components/action-group.hbs
View File

@ -1,8 +1,12 @@
<input type="radio" name="actions" id="actions_{{index}}" checked={{if (eq checked 'checked') 'checked' }} onchange={{action onchange}} value={{index}} />
<label for="actions_{{index}}">
<span>Open</span>
</label>
<label for="actions_close">
<span>Close</span>
</label>
{{yield}}
{{! action groups are block only components, you MUST specify a list of actions in the component body }}
{{! therefore if you call this component as an inline component, nothing is produced }}
{{#if hasBlock }}
<input type="radio" name="actions" id="actions_{{index}}" checked={{if (eq checked 'checked') 'checked' }} onchange={{action onchange}} value={{index}} />
<label for="actions_{{index}}">
<span>Open</span>
</label>
<label for="actions_close">
<span>Close</span>
</label>
{{yield}}
{{/if}}

13
ui-v2/tests/integration/components/action-group-test.js
View File

@ -1,11 +1,20 @@
import { moduleForComponent, test, skip } from 'ember-qunit';
import { moduleForComponent, test } from 'ember-qunit';
import hbs from 'htmlbars-inline-precompile';
moduleForComponent('action-group', 'Integration | Component | action group', {
integration: true,
});
skip("it doesn't render anything when used inline");
test("it doesn't render anything when used inline", function(assert) {
this.render(hbs`{{action-group}}`);
assert.equal(
this.$()
.text()
.trim(),
''
);
});
test('it renders', function(assert) {
// Set any properties with this.set('myProperty', 'value');
// Handle any actions with this.on('myAction', function(val) { ... });

22
ui-v2/tests/integration/components/code-editor-test.js
View File

@ -1,32 +1,24 @@
import { moduleForComponent, skip } from 'ember-qunit';
import { moduleForComponent, test } from 'ember-qunit';
import hbs from 'htmlbars-inline-precompile';
moduleForComponent('code-editor', 'Integration | Component | code editor', {
integration: true,
});
skip('it renders', function(assert) {
test('it renders', function(assert) {
// Set any properties with this.set('myProperty', 'value');
// Handle any actions with this.on('myAction', function(val) { ... });
this.render(hbs`{{code-editor}}`);
assert.equal(
this.$()
.text()
.trim(),
'1' // this comes with some strange whitespace
);
// this test is just to prove it renders something without producing
// an error. It renders the number 1, but seems to also render some sort of trailing space
// so just check for presence of CodeMirror
assert.equal(this.$().find('.CodeMirror').length, 1);
// Template block usage:
this.render(hbs`
{{#code-editor}}{{/code-editor}}
`);
assert.equal(
this.$()
.text()
.trim(),
'1'
);
assert.equal(this.$().find('.CodeMirror').length, 1);
});