luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

Remove t.Parallel from TestACLResolver_DownPolicy 

These tests run in under 10ms, t.Parallel does nothing but slow them down and
make failures harder to debug when one panics.
This commit is contained in:
Daniel Nephin 2021-09-23 17:45:17 -04:00
parent 4505cb2920
commit a6a7069ecf
1 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
agent/consul/acl_test.go
View File

@ -780,8 +780,6 @@ func TestACLResolver_ResolveRootACL(t *testing.T) {
}
func TestACLResolver_DownPolicy(t *testing.T) {
t.Parallel()
requireIdentityCached := func(t *testing.T, r *ACLResolver, id string, present bool, msg string) {
t.Helper()
@ -806,7 +804,6 @@ func TestACLResolver_DownPolicy(t *testing.T) {
}
t.Run("Deny", func(t *testing.T) {
t.Parallel()
delegate := &ACLResolverTestDelegate{
enabled: true,
datacenter: "dc1",
@ -831,7 +828,6 @@ func TestACLResolver_DownPolicy(t *testing.T) {
})
t.Run("Allow", func(t *testing.T) {
t.Parallel()
delegate := &ACLResolverTestDelegate{
enabled: true,
datacenter: "dc1",
@ -856,7 +852,6 @@ func TestACLResolver_DownPolicy(t *testing.T) {
})
t.Run("Expired-Policy", func(t *testing.T) {
t.Parallel()
delegate := &ACLResolverTestDelegate{
enabled: true,
datacenter: "dc1",
@ -893,7 +888,6 @@ func TestACLResolver_DownPolicy(t *testing.T) {
})
t.Run("Expired-Role", func(t *testing.T) {
t.Parallel()
delegate := &ACLResolverTestDelegate{
enabled: true,
datacenter: "dc1",
@ -925,7 +919,6 @@ func TestACLResolver_DownPolicy(t *testing.T) {
})
t.Run("Extend-Cache-Policy", func(t *testing.T) {
t.Parallel()
delegate := &ACLResolverTestDelegate{
enabled: true,
datacenter: "dc1",
@ -956,7 +949,6 @@ func TestACLResolver_DownPolicy(t *testing.T) {
})
t.Run("Extend-Cache-Role", func(t *testing.T) {
t.Parallel()
delegate := &ACLResolverTestDelegate{
enabled: true,
datacenter: "dc1",
@ -988,7 +980,6 @@ func TestACLResolver_DownPolicy(t *testing.T) {
})
t.Run("Extend-Cache-Expired-Policy", func(t *testing.T) {
t.Parallel()
delegate := &ACLResolverTestDelegate{
enabled: true,
datacenter: "dc1",
@ -1025,7 +1016,6 @@ func TestACLResolver_DownPolicy(t *testing.T) {
})
t.Run("Extend-Cache-Expired-Role", func(t *testing.T) {
t.Parallel()
delegate := &ACLResolverTestDelegate{
enabled: true,
datacenter: "dc1",
@ -1058,7 +1048,6 @@ func TestACLResolver_DownPolicy(t *testing.T) {
})
t.Run("Async-Cache-Expired-Policy", func(t *testing.T) {
t.Parallel()
delegate := &ACLResolverTestDelegate{
enabled: true,
datacenter: "dc1",
@ -1106,7 +1095,6 @@ func TestACLResolver_DownPolicy(t *testing.T) {
})
t.Run("Async-Cache-Expired-Role", func(t *testing.T) {
t.Parallel()
delegate := &ACLResolverTestDelegate{
enabled: true,
datacenter: "dc1",
@ -1149,7 +1137,6 @@ func TestACLResolver_DownPolicy(t *testing.T) {
})
t.Run("Extend-Cache-Client-Policy", func(t *testing.T) {
t.Parallel()
delegate := &ACLResolverTestDelegate{
enabled: true,
datacenter: "dc1",
@ -1185,7 +1172,6 @@ func TestACLResolver_DownPolicy(t *testing.T) {
})
t.Run("Extend-Cache-Client-Role", func(t *testing.T) {
t.Parallel()
delegate := &ACLResolverTestDelegate{
enabled: true,
datacenter: "dc1",
@ -1222,7 +1208,6 @@ func TestACLResolver_DownPolicy(t *testing.T) {
})
t.Run("Async-Cache", func(t *testing.T) {
t.Parallel()
delegate := &ACLResolverTestDelegate{
enabled: true,
datacenter: "dc1",
@ -1264,8 +1249,6 @@ func TestACLResolver_DownPolicy(t *testing.T) {
})
t.Run("PolicyResolve-TokenNotFound", func(t *testing.T) {
t.Parallel()
_, rawToken, _ := testIdentityForToken("found")
foundToken := rawToken.(*structs.ACLToken)
secretID := foundToken.SecretID
@ -1331,8 +1314,6 @@ func TestACLResolver_DownPolicy(t *testing.T) {
})
t.Run("PolicyResolve-PermissionDenied", func(t *testing.T) {
t.Parallel()
_, rawToken, _ := testIdentityForToken("found")
foundToken := rawToken.(*structs.ACLToken)
secretID := foundToken.SecretID