acl: stop replication on leadership lost

It seems like this was missing. Previously this was only called by init of ACLs during an upgrade.
Now that legacy ACLs are  removed, nothing was calling stop.

Also remove an unused method from client.

agent/consul/acl_client.go

@@ -3,7 +3,6 @@ package consul
 import (
 	"github.com/hashicorp/consul/acl"
 	"github.com/hashicorp/consul/agent/structs"
-	"github.com/hashicorp/consul/lib/serf"
 )
 
 var clientACLCacheConfig *structs.ACLCachesConfig = &structs.ACLCachesConfig{
@@ -80,8 +79,3 @@ func (c *Client) ResolveTokenAndDefaultMeta(token string, entMeta *structs.Enter
 
 	return authz, err
 }
-
-func (c *Client) updateSerfTags(key, value string) {
-	// Update the LAN serf
-	serf.UpdateTag(c.serf, key, value)
-}

agent/consul/leader.go

@@ -344,6 +344,8 @@ func (s *Server) revokeLeadership() {
 
 	s.stopConfigReplication()
 
+	s.stopACLReplication()
+
 	s.stopConnectLeader()
 
 	s.stopACLTokenReaping()