luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

ui: Replaces destroyRecord with unloadRecord for KV 404's (#5837) 

Just because Consul gives us a 404 this doesn't guarantee the KV doesn't
exist, it doesn't even mean we don't have access to it. Furthermore we
should never destroyRecord's without user interaction (therefore only via the
repo.delete method).

This switches destroyRecord to unloadRecord which performs the
additional legwork to keep ember-data in sync with the actual truth.

unloadRecord unloads the record from ember-data rather than sending an API
delete request, which would have been the intent here.
This commit is contained in:
John Cowen 2019-06-04 15:56:20 +01:00 committed by GitHub
parent 52b71aaf96
commit 9999ccf503
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui-v2/app/services/repository/kv.js
View File

@ -59,7 +59,7 @@ export default RepositoryService.extend({
const id = JSON.stringify([dc, key]); const id = JSON.stringify([dc, key]);
const record = get(this, 'store').peekRecord(this.getModelName(), id); const record = get(this, 'store').peekRecord(this.getModelName(), id);
if (record) { if (record) {
record.destroyRecord(); record.unloadRecord();
} }
} }
throw e; throw e;