luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

structs: prevent service-defaults upstream configs from using wildcard names or namespaces (#10475)

This commit is contained in:
R.B. Boyer 2021-06-23 15:48:54 -05:00 committed by GitHub
parent dd2bf56b1d
commit 952df8b491
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.changelog/10475.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:improvement
structs: prevent service-defaults upstream configs from using wildcard names or namespaces
```

6
agent/structs/config_entry.go
View File

@ -789,6 +789,12 @@ func (cfg UpstreamConfig) validate(named bool) error {
if cfg.Name == "" { if cfg.Name == "" {
return fmt.Errorf("Name is required") return fmt.Errorf("Name is required")
} }
if cfg.Name == WildcardSpecifier {
return fmt.Errorf("Wildcard name is not supported")
}
if cfg.EnterpriseMeta.NamespaceOrDefault() == WildcardSpecifier {
return fmt.Errorf("Wildcard namespace is not supported")
}
} else { } else {
if cfg.Name != "" { if cfg.Name != "" {
return fmt.Errorf("Name must be empty") return fmt.Errorf("Name must be empty")