luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

Use range vs for 

Returning a new array vs mutating an array in place so we can use range now.
This commit is contained in:
Sean Chittenden 2016-03-25 13:08:08 -07:00
parent 643997623e
commit 89311a5859
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
consul/server_manager/server_manager.go
View File

@ -260,8 +260,7 @@ func (sm *ServerManager) RemoveServer(server *server_details.ServerDetails) {
serverCfg := sm.getServerConfig()
// Remove the server if known
n := len(serverCfg.servers)
for i := 0; i < n; i++ {
for i, _ := range serverCfg.servers {
if serverCfg.servers[i].Name == server.Name {
newServers := make([]*server_details.ServerDetails, 0, len(serverCfg.servers)-1)
newServers = append(newServers, serverCfg.servers[:i]...)