luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

http: set consistency header properly 

A recent change in 1.9.x inverted the order of these two lines, which caused the
X-Consul-Effective-Consistency header to be missing for the servie health endpoints
This commit is contained in:
Daniel Nephin 2021-05-05 14:16:24 -04:00
parent 5c7b0e6339
commit 72f52255ff
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.changelog/10189.txt Normal file
View File

@ -0,0 +1,4 @@
```release-note:bug
http: fix a bug that caused the `X-Consul-Effective-Consistency` header to be missing on
request for service health
```

2
agent/health_endpoint.go
View File

@ -227,8 +227,8 @@ func (s *HTTPHandlers) healthServiceNodes(resp http.ResponseWriter, req *http.Re
if args.QueryOptions.UseCache { if args.QueryOptions.UseCache {
setCacheMeta(resp, &md) setCacheMeta(resp, &md)
} }
out.QueryMeta.ConsistencyLevel = args.QueryOptions.ConsistencyLevel()
setMeta(resp, &out.QueryMeta) setMeta(resp, &out.QueryMeta)
out.ConsistencyLevel = args.QueryOptions.ConsistencyLevel()
// FIXME: argument parsing should be done before performing the rpc // FIXME: argument parsing should be done before performing the rpc
// Filter to only passing if specified // Filter to only passing if specified