luxolus/open-consul
2
0
Fork 0
Code Issues 1 Pull requests Packages Releases Wiki Activity

remove a race condition in sdk testutil server stop (#10342)

Browse source 
* remove a race condition in sdk testutil server stop

* ensure the process has actually stopped
This commit is contained in:
David Bariod 2021-06-09 17:30:26 +02:00 committed by GitHub
parent 99fc5354e7
commit 728165f31e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sdk/testutil/server.go
View file

@ -342,7 +342,7 @@ func (s *TestServer) Stop() error {
return err
case <-time.After(10 * time.Second):
s.cmd.Process.Signal(syscall.SIGABRT)
s.cmd.Wait()
<-waitDone
return fmt.Errorf("timeout waiting for server to stop gracefully")
}
}