From 6f98c853b817ad59124d1477735b7383b555980c Mon Sep 17 00:00:00 2001 From: "Chris S. Kim" Date: Wed, 24 Aug 2022 13:30:52 -0400 Subject: [PATCH] Add check for zero-length server addresses --- .../services/peerstream/subscription_manager.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/agent/grpc-external/services/peerstream/subscription_manager.go b/agent/grpc-external/services/peerstream/subscription_manager.go index ce22b0cd7..138449e71 100644 --- a/agent/grpc-external/services/peerstream/subscription_manager.go +++ b/agent/grpc-external/services/peerstream/subscription_manager.go @@ -833,7 +833,10 @@ func (m *subscriptionManager) subscribeServerAddrs( serverAddrs = append(serverAddrs, grpcAddr) } - // TODO(peering): handle empty addresses here? + if len(serverAddrs) == 0 { + m.logger.Warn("did not find any server addresses with external gRPC ports to publish") + continue + } updateCh <- cache.UpdateEvent{ CorrelationID: subServerAddrs,