From c6b3cae106f54b248f38892e641c1579a51bbfe7 Mon Sep 17 00:00:00 2001
From: Chavez <matthew@el-chavez.me>
Date: Thu, 4 Dec 2014 21:32:59 -0800
Subject: [PATCH 1/3] consul: Fix failing globalRPC test

---
 consul/server_test.go | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/consul/server_test.go b/consul/server_test.go
index 0d0d1d588..8c61d2514 100644
--- a/consul/server_test.go
+++ b/consul/server_test.go
@@ -489,6 +489,12 @@ func TestServer_globalRPCErrors(t *testing.T) {
 	defer os.RemoveAll(dir1)
 	defer s1.Shutdown()
 
+	testutil.WaitForResult(func() (bool, error) {
+		return len(s1.remoteConsuls) == 1, nil
+	}, func(err error) {
+		t.Fatalf("Server did not join LAN successfully")
+	})
+
 	// Check that an error from a remote DC is returned
 	err := s1.globalRPC("Bad.Method", nil, &fakeGlobalResp{})
 	if err == nil {

From 7c1aad7b1dc4d4fe7c3cb4ab5e5ce34e70b06f59 Mon Sep 17 00:00:00 2001
From: Chavez <matthew@el-chavez.me>
Date: Fri, 5 Dec 2014 10:36:01 -0800
Subject: [PATCH 2/3] agent: agent test fixes

---
 command/agent/agent_test.go | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/command/agent/agent_test.go b/command/agent/agent_test.go
index 8e78f24a4..ee50e563c 100644
--- a/command/agent/agent_test.go
+++ b/command/agent/agent_test.go
@@ -386,8 +386,10 @@ func TestAgent_ConsulService(t *testing.T) {
 
 func TestAgent_PersistService(t *testing.T) {
 	config := nextConfig()
+	config.Server = false
 	dir, agent := makeAgent(t, config)
 	defer os.RemoveAll(dir)
+	defer agent.Shutdown()
 
 	svc := &structs.NodeService{
 		ID:      "redis",
@@ -444,6 +446,7 @@ func TestAgent_PurgeService(t *testing.T) {
 	config := nextConfig()
 	dir, agent := makeAgent(t, config)
 	defer os.RemoveAll(dir)
+	defer agent.Shutdown()
 
 	svc := &structs.NodeService{
 		ID:      "redis",
@@ -476,8 +479,10 @@ func TestAgent_PurgeService(t *testing.T) {
 
 func TestAgent_PurgeServiceOnDuplicate(t *testing.T) {
 	config := nextConfig()
+	config.Server = false
 	dir, agent := makeAgent(t, config)
 	defer os.RemoveAll(dir)
+	defer agent.Shutdown()
 
 	svc1 := &structs.NodeService{
 		ID:      "redis",
@@ -523,8 +528,10 @@ func TestAgent_PurgeServiceOnDuplicate(t *testing.T) {
 
 func TestAgent_PersistCheck(t *testing.T) {
 	config := nextConfig()
+	config.Server = false
 	dir, agent := makeAgent(t, config)
 	defer os.RemoveAll(dir)
+	defer agent.Shutdown()
 
 	check := &structs.HealthCheck{
 		Node:        config.NodeName,
@@ -597,6 +604,7 @@ func TestAgent_PurgeCheck(t *testing.T) {
 	config := nextConfig()
 	dir, agent := makeAgent(t, config)
 	defer os.RemoveAll(dir)
+	defer agent.Shutdown()
 
 	check := &structs.HealthCheck{
 		Node:        config.NodeName,
@@ -631,8 +639,10 @@ func TestAgent_PurgeCheck(t *testing.T) {
 
 func TestAgent_PurgeCheckOnDuplicate(t *testing.T) {
 	config := nextConfig()
+	config.Server = false
 	dir, agent := makeAgent(t, config)
 	defer os.RemoveAll(dir)
+	defer agent.Shutdown()
 
 	check1 := &structs.HealthCheck{
 		Node:        config.NodeName,

From 5f4281f98fd327f8705858a184c2274837143ac1 Mon Sep 17 00:00:00 2001
From: Chavez <matthew@el-chavez.me>
Date: Fri, 5 Dec 2014 10:50:23 -0800
Subject: [PATCH 3/3] consul: Server leave test fix

---
 consul/server_test.go | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/consul/server_test.go b/consul/server_test.go
index 8c61d2514..59c220b19 100644
--- a/consul/server_test.go
+++ b/consul/server_test.go
@@ -256,10 +256,12 @@ func TestServer_Leave(t *testing.T) {
 	}
 
 	// Should lose a peer
-	p1, _ = s1.raftPeers.Peers()
-	if len(p1) != 1 {
+	testutil.WaitForResult(func() (bool, error) {
+		p1, _ = s1.raftPeers.Peers()
+		return len(p1) == 1, nil
+	}, func(err error) {
 		t.Fatalf("should have 1 peer: %v", p1)
-	}
+	})
 }
 
 func TestServer_RPC(t *testing.T) {