From 57fb729547946999a475bc599c33e38f5e58e8eb Mon Sep 17 00:00:00 2001
From: Eric Haberkorn <erichaberkorn@gmail.com>
Date: Fri, 28 Oct 2022 10:51:12 -0400
Subject: [PATCH] Fix peering metrics bug (#15178)

This bug was caused by the peering health metric being set to NaN.
---
 .changelog/15178.txt                |  3 +++
 agent/consul/leader_peering.go      | 19 +++++++------------
 agent/consul/leader_peering_test.go |  3 +--
 3 files changed, 11 insertions(+), 14 deletions(-)
 create mode 100644 .changelog/15178.txt

diff --git a/.changelog/15178.txt b/.changelog/15178.txt
new file mode 100644
index 000000000..fadea0913
--- /dev/null
+++ b/.changelog/15178.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+peering: Fix a bug that resulted in /v1/agent/metrics returning an error.
+```
diff --git a/agent/consul/leader_peering.go b/agent/consul/leader_peering.go
index c2e8a40a4..471bb01c8 100644
--- a/agent/consul/leader_peering.go
+++ b/agent/consul/leader_peering.go
@@ -122,19 +122,14 @@ func (s *Server) emitPeeringMetricsOnce(metricsImpl *metrics.Metrics) error {
 		}
 
 		// peering health metric
-		if status.NeverConnected {
-			metricsImpl.SetGaugeWithLabels(leaderHealthyPeeringKeyDeprecated, float32(math.NaN()), labels)
-			metricsImpl.SetGaugeWithLabels(leaderHealthyPeeringKey, float32(math.NaN()), labels)
-		} else {
-			healthy := s.peerStreamServer.Tracker.IsHealthy(status)
-			healthyInt := 0
-			if healthy {
-				healthyInt = 1
-			}
-
-			metricsImpl.SetGaugeWithLabels(leaderHealthyPeeringKeyDeprecated, float32(healthyInt), labels)
-			metricsImpl.SetGaugeWithLabels(leaderHealthyPeeringKey, float32(healthyInt), labels)
+		healthy := 0
+		switch {
+		case status.NeverConnected:
+		case s.peerStreamServer.Tracker.IsHealthy(status):
+			healthy = 1
 		}
+		metricsImpl.SetGaugeWithLabels(leaderHealthyPeeringKeyDeprecated, float32(healthy), labels)
+		metricsImpl.SetGaugeWithLabels(leaderHealthyPeeringKey, float32(healthy), labels)
 	}
 
 	return nil
diff --git a/agent/consul/leader_peering_test.go b/agent/consul/leader_peering_test.go
index fd01737b8..84f4dbbaf 100644
--- a/agent/consul/leader_peering_test.go
+++ b/agent/consul/leader_peering_test.go
@@ -7,7 +7,6 @@ import (
 	"errors"
 	"fmt"
 	"io/ioutil"
-	"math"
 	"net"
 	"testing"
 	"time"
@@ -1445,7 +1444,7 @@ func TestLeader_PeeringMetrics_emitPeeringMetrics(t *testing.T) {
 		healthyMetric3, ok := intv.Gauges[keyHealthyMetric3]
 		require.True(r, ok, fmt.Sprintf("did not find the key %q", keyHealthyMetric3))
 
-		require.True(r, math.IsNaN(float64(healthyMetric3.Value)))
+		require.Equal(r, float32(0), healthyMetric3.Value)
 	})
 }