From 3ae748c7a4f48cac7ae9abb8df3e852a750f38fb Mon Sep 17 00:00:00 2001 From: "R.B. Boyer" Date: Wed, 16 Oct 2019 12:24:29 -0500 Subject: [PATCH] fix flaky multidc acl tests that failed to wait for token replication (#6628) If acls have not yet replicated to the secondary then authz requests will be remotely resolved by the primary. Now these tests explicitly wait until replication has caught up first. --- agent/consul/acl_endpoint_test.go | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/agent/consul/acl_endpoint_test.go b/agent/consul/acl_endpoint_test.go index 3b807e77f..997810713 100644 --- a/agent/consul/acl_endpoint_test.go +++ b/agent/consul/acl_endpoint_test.go @@ -1861,6 +1861,12 @@ func TestACLEndpoint_TokenDelete(t *testing.T) { // Try to join joinWAN(t, s2, s1) + waitForNewACLs(t, s1) + waitForNewACLs(t, s2) + + // Ensure s2 is authoritative. + waitForNewACLReplication(t, s2, structs.ACLReplicateTokens, 1, 1, 0) + acl := ACL{srv: s1} acl2 := ACL{srv: s2} @@ -2005,8 +2011,6 @@ func TestACLEndpoint_TokenDelete(t *testing.T) { var resp string - waitForNewACLs(t, s2) - err = acl2.TokenDelete(&req, &resp) require.NoError(t, err) @@ -4118,6 +4122,9 @@ func TestACLEndpoint_SecureIntroEndpoints_OnlyCreateLocalData(t *testing.T) { waitForNewACLs(t, s1) waitForNewACLs(t, s2) + // Ensure s2 is authoritative. + waitForNewACLReplication(t, s2, structs.ACLReplicateTokens, 1, 1, 0) + acl := ACL{srv: s1} acl2 := ACL{srv: s2} @@ -5286,10 +5293,10 @@ func upsertTestTokenWithPolicyRules(codec rpc.ClientCodec, masterToken string, d func retrieveTestTokenAccessorForSecret(codec rpc.ClientCodec, masterToken string, datacenter string, id string) (string, error) { arg := structs.ACLTokenGetRequest{ - TokenID: "root", + TokenID: id, TokenIDType: structs.ACLTokenSecret, - Datacenter: "dc1", - QueryOptions: structs.QueryOptions{Token: "root"}, + Datacenter: datacenter, + QueryOptions: structs.QueryOptions{Token: masterToken}, } var out structs.ACLTokenResponse