ui: Controller dead code removal (#9367)

* ui: Controller dead code removal

This commit removes a little code that became 'dead' as a result of
previous PRs/commits

* Remove a little more from the settings Controller

* Remove CSS related to being able to set the dashboard_url in settings
This commit is contained in:
John Cowen 2020-12-11 11:43:13 +00:00 committed by GitHub
parent 71cd7c6a16
commit 32a0b757d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 2 additions and 75 deletions

View File

@ -1,3 +0,0 @@
import Controller from '@ember/controller';
export default class DcController extends Controller {}

View File

@ -1,11 +0,0 @@
import Controller from '@ember/controller';
export default class DcServicesInstanceUpstreamsController extends Controller {
queryParams = {
sortBy: 'sort',
search: {
as: 'filter',
replace: true,
},
};
}

View File

@ -3,14 +3,9 @@ import { alias } from '@ember/object/computed';
import Controller from '@ember/controller';
import { get, action } from '@ember/object';
export default class ShowController extends Controller {
@service('dom')
dom;
@service('flashMessages') notify;
@service('flashMessages')
notify;
@alias('items.firstObject')
item;
@alias('items.firstObject') item;
@action
error(e) {

View File

@ -3,26 +3,8 @@ import { get, set } from '@ember/object';
import { inject as service } from '@ember/service';
export default Controller.extend({
repo: service('settings'),
dom: service('dom'),
timeout: service('timeout'),
confirming: false,
applyTransition: function() {
const tick = this.timeout.tick;
set(this, 'confirming', true);
tick().then(() => {
set(this, 'confirming', false);
});
},
actions: {
key: function(e) {
this.applyTransition();
switch (true) {
case e.keyCode === 13:
// disable ENTER
e.preventDefault();
}
},
change: function(e, value, item) {
const event = this.dom.normalizeEvent(e, value);
// TODO: Switch to using forms like the rest of the app
@ -37,13 +19,6 @@ export default Controller.extend({
set(this, 'item.client.blocking', !blocking);
this.send('update', 'client', this.item.client);
break;
case 'urls[service]':
if (typeof get(this, 'item.urls') === 'undefined') {
set(this, 'item.urls', {});
}
set(this, 'item.urls.service', target.value);
this.send('update', 'urls', this.item.urls);
break;
}
},
},

View File

@ -1,4 +1,3 @@
@import 'routes/dc/settings/index';
@import 'routes/dc/services/index';
@import 'routes/dc/nodes/index';
@import 'routes/dc/kv/index';

View File

@ -1,16 +0,0 @@
#urls_service span {
position: relative;
}
#urls_service span::after {
@extend %with-check-circle-fill-color-icon, %as-pseudo;
position: absolute;
top: 3px;
right: 0;
}
#urls_service span::after {
@extend %blink-in-fade-out;
transition-delay: 3s;
}
#urls_service.confirming span::after {
@extend %blink-in-fade-out-active;
}

View File

@ -1,12 +0,0 @@
import { module, test } from 'qunit';
import { setupTest } from 'ember-qunit';
module('Unit | Controller | dc', function(hooks) {
setupTest(hooks);
// Replace this with your real tests.
test('it exists', function(assert) {
let controller = this.owner.lookup('controller:dc');
assert.ok(controller);
});
});