luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

connect: switch the default gateway port from 443 to 8443 (#9116) 

* test: update ingress gateway golden file to port 8443

* test: update Envoy flags_test to port 8443

Co-authored-by: R.B. Boyer <rb@hashicorp.com>
This commit is contained in:
Mike Morris 2020-11-06 20:47:29 -05:00 committed by GitHub
parent 97940f3b1d
commit 2be2be577c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.changelog/9113.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:breaking-change
connect: Switch the default gateway port from 443 to 8443 to avoid assumption of Envoy running as root.
```

2
command/connect/envoy/flags.go
View File

@ -11,7 +11,7 @@ import (
"github.com/hashicorp/go-sockaddr/template"
)
const defaultGatewayPort int = 443
const defaultGatewayPort int = 8443
// ServiceAddressValue implements a flag.Value that may be used to parse an
// addr:port string into an api.ServiceAddress.

4
command/connect/envoy/flags_test.go
View File

@ -31,12 +31,12 @@ func TestServiceAddressValue_Value(t *testing.T) {
func TestServiceAddressValue_String(t *testing.T) {
t.Run("nil receiver", func(t *testing.T) {
var addr *ServiceAddressValue
require.Equal(t, addr.String(), ":443")
require.Equal(t, addr.String(), ":8443")
})
t.Run("default value", func(t *testing.T) {
addr := &ServiceAddressValue{}
require.Equal(t, addr.String(), ":443")
require.Equal(t, addr.String(), ":8443")
})
t.Run("set value", func(t *testing.T) {

2
command/connect/envoy/testdata/ingress-gateway.golden vendored
View File

@ -53,7 +53,7 @@
"address": {
"socket_address": {
"address": "127.0.0.1",
"port_value": 443
"port_value": 8443
}
},
"filter_chains": [