ui: [Port] Ensure the tokens default nspace (and partition) is passed thru to the auth endpoint (#11490)

Most HTTP API calls will use the default namespace of the calling token to additionally filter/select the data used for the response if one is not specified by the frontend.

The internal permissions/authorize endpoint does not do this (you can ask for permissions from different namespaces in on request).

Therefore this PR adds the tokens default namespace in the frontend only to our calls to the authorize endpoint. I tried to do it in a place that made it feel like it's getting added in the backend, i.e. in a place which was least likely to ever require changing or thinking about.

Note:  We are probably going to change this internal endpoint to also inspect the tokens default namespace on the backend. At which point we can revert this commit/PR.

* Add the same support for the tokens default partition

.changelog/11472.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+ui: **(Enterprise only)** When no namespace is selected, make sure to default to the tokens default namespace when requesting permissions
+```

ui/packages/consul-ui/app/adapters/permission.js

@@ -3,6 +3,7 @@ import { inject as service } from '@ember/service';
 
 export default class PermissionAdapter extends Adapter {
   @service('env') env;
+  @service('settings') settings;
 
   requestForAuthorize(request, { dc, ns, partition, resources = [], index }) {
     // the authorize endpoint is slightly different to all others in that it
@@ -29,8 +30,30 @@ export default class PermissionAdapter extends Adapter {
 
   authorize(store, type, id, snapshot) {
     return this.rpc(
-      function(adapter, request, serialized, unserialized) {
+      async (adapter, request, serialized, unserialized) => {
-        return adapter.requestForAuthorize(request, serialized, unserialized);
+        // the authorize endpoint does not automatically take into account the
+        // default namespace of the token on the backend. This means that we
+        // need to add the default namespace of the token on the frontend
+        // instead. Decided this is the best place for it as its almost hidden
+        // from the rest of the app so from an app eng point of view it almost
+        // feels like it does happen on the backend.
+        // Same goes ^ for partitions
+        const nspacesEnabled = this.env.var('CONSUL_NSPACES_ENABLED');
+        const partitionsEnabled = this.env.var('CONSUL_PARTITIONS_ENABLED');
+        if(nspacesEnabled || partitionsEnabled) {
+          const token = await this.settings.findBySlug('token');
+          if(nspacesEnabled) {
+            if(typeof serialized.ns === 'undefined' || serialized.ns.length === 0) {
+              serialized.ns = token.Namespace;
+            }
+          }
+          if(partitionsEnabled) {
+            if(typeof serialized.partition === 'undefined' || serialized.partition.length === 0) {
+              serialized.partition = token.Partition;
+            }
+          }
+        }
+        return adapter.requestForAuthorize(request, serialized);
       },
       function(serializer, respond, serialized, unserialized) {
         // Completely skip the serializer here

ui/packages/consul-ui/tests/unit/adapters/permission-test.js

@@ -1,12 +1,154 @@
 import { module, test } from 'qunit';
 import { setupTest } from 'ember-qunit';
 
+const assertAuthorize = function(assertion, params = {}, token, $, adapter) {
+  const rpc = adapter.rpc;
+  const env = adapter.env;
+  const settings = adapter.settings;
+  adapter.env = {
+    var: str => $[str]
+  };
+  adapter.settings = {
+    findBySlug: _ => token
+  };
+
+  adapter.rpc = function(request, respond) {
+    request(
+      {
+        requestForAuthorize: (request, params) => {
+          assertion(request, params);
+        }
+      },
+      () => {},
+      params,
+      params
+    )
+  };
+  adapter.authorize({}, {modelName: 'permission'}, 1, {});
+  adapter.rpc = rpc;
+  adapter.env = env;
+  adapter.settings = settings;
+}
 module('Unit | Adapter | permission', function(hooks) {
   setupTest(hooks);
 
-  // Replace this with your real tests.
   test('it exists', function(assert) {
     let adapter = this.owner.lookup('adapter:permission');
     assert.ok(adapter);
   });
+
+  test(`authorize adds the tokens default namespace if one isn't specified`, function(assert) {
+    const adapter = this.owner.lookup('adapter:permission');
+    const expected = 'test';
+    const token = {
+      Namespace: expected
+    };
+    const env = {
+      CONSUL_NSPACES_ENABLED: true
+    };
+    const cases = [
+      undefined,
+      {
+        ns: undefined
+      },
+      {
+        ns: ''
+      }
+    ];
+    assert.expect(cases.length);
+    cases.forEach(
+      (params) => {
+        assertAuthorize(
+          (request, params) => {
+            assert.equal(params.ns, expected)
+          },
+          params,
+          token,
+          env,
+          adapter
+        )
+      }
+    );
+  });
+
+  test(`authorize doesn't add the tokens default namespace if one is specified`, function(assert) {
+    assert.expect(1);
+    const adapter = this.owner.lookup('adapter:permission');
+    const notExpected = 'test';
+    const expected = 'default';
+    const token = {
+      Namespace: notExpected
+    };
+    const env = {
+      CONSUL_NSPACES_ENABLED: true
+    };
+    assertAuthorize(
+      (request, params) => {
+        assert.equal(params.ns, expected)
+      },
+      {
+        ns: expected
+      },
+      token,
+      env,
+      adapter
+    )
+  });
+  test(`authorize adds the tokens default partition if one isn't specified`, function(assert) {
+    const adapter = this.owner.lookup('adapter:permission');
+    const expected = 'test';
+    const token = {
+      Partition: expected
+    };
+    const env = {
+      CONSUL_PARTITIONS_ENABLED: true
+    };
+    const cases = [
+      undefined,
+      {
+        partition: undefined
+      },
+      {
+        partition: ''
+      }
+    ];
+    assert.expect(cases.length);
+    cases.forEach(
+      (params) => {
+        assertAuthorize(
+          (request, params) => {
+            assert.equal(params.partition, expected)
+          },
+          params,
+          token,
+          env,
+          adapter
+        )
+      }
+    );
+  });
+
+  test(`authorize doesn't add the tokens default partition if one is specified`, function(assert) {
+    assert.expect(1);
+    const adapter = this.owner.lookup('adapter:permission');
+    const notExpected = 'test';
+    const expected = 'default';
+    const token = {
+      Partition: notExpected
+    };
+    const env = {
+      CONSUL_PARTITIONS_ENABLED: true
+    };
+    assertAuthorize(
+      (request, params) => {
+        assert.equal(params.partition, expected)
+      },
+      {
+        partition: expected
+      },
+      token,
+      env,
+      adapter
+    )
+  });
 });