From ec59d88ac36d3541eabe0893fd606b67629f4efc Mon Sep 17 00:00:00 2001
From: petems
Date: Tue, 12 Feb 2019 23:47:19 +0000
Subject: [PATCH 1/4] Add note about equals signs
---
website/source/docs/agent/cloud-auto-join.html.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/website/source/docs/agent/cloud-auto-join.html.md b/website/source/docs/agent/cloud-auto-join.html.md
index de30ff9e5..e5157a30d 100644
--- a/website/source/docs/agent/cloud-auto-join.html.md
+++ b/website/source/docs/agent/cloud-auto-join.html.md
@@ -18,7 +18,7 @@ In Consul 0.9.1-0.9.3 the values need to be URL encoded but for most
practical purposes you need to replace spaces with `+` signs.
As of Consul 1.0 the values are taken literally and must not be URL
-encoded. If the values contain spaces, backslashes or double quotes then
+encoded. If the values contain spaces, equals, backslashes or double quotes then
they need to be double quoted and the usual escaping rules apply.
```sh
From e036462adf19a680da37f1d6faa1b9b80e380a02 Mon Sep 17 00:00:00 2001
From: petems
Date: Wed, 13 Feb 2019 00:53:51 +0000
Subject: [PATCH 2/4] Update specific perms for Azure
* `listAll` is not valid
---
website/source/docs/agent/cloud-auto-join.html.md | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/website/source/docs/agent/cloud-auto-join.html.md b/website/source/docs/agent/cloud-auto-join.html.md
index e5157a30d..ea721e32e 100644
--- a/website/source/docs/agent/cloud-auto-join.html.md
+++ b/website/source/docs/agent/cloud-auto-join.html.md
@@ -110,8 +110,9 @@ Use these configuration parameters when using Virtual Machine Scale Sets (Consul
- `resource_group` - the name of the resource group to filter on.
- `vm_scale_set` - the name of the virtual machine scale set to filter on.
-When using tags the only permission needed is the `ListAll` method for `NetworkInterfaces`. When using
-Virtual Machine Scale Sets the only role action needed is `Microsoft.Compute/virtualMachineScaleSets/*/read`.
+When using tags the only permission needed is `Microsoft.Network/networkInterfaces`.
+
+When using Virtual Machine Scale Sets the only role action needed is `Microsoft.Compute/virtualMachineScaleSets/*/read`.
### Google Compute Engine
From 7fdb488ba4dd9b6d4108559424e22169f714a6eb Mon Sep 17 00:00:00 2001
From: petems
Date: Wed, 13 Feb 2019 00:54:27 +0000
Subject: [PATCH 3/4] Adds note about secret value
* For future traveler, this literally ate up an entire day of debugging, so hopefully it helped you! :dancer:
---
website/source/docs/agent/cloud-auto-join.html.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/website/source/docs/agent/cloud-auto-join.html.md b/website/source/docs/agent/cloud-auto-join.html.md
index ea721e32e..28e7d3eb7 100644
--- a/website/source/docs/agent/cloud-auto-join.html.md
+++ b/website/source/docs/agent/cloud-auto-join.html.md
@@ -100,7 +100,7 @@ $ consul agent -retry-join "provider=azure tag_name=... tag_value=... tenant_id=
- `provider` (required) - the name of the provider ("azure" in this case).
- `tenant_id` (required) - the tenant to join machines in.
- `client_id` (required) - the client to authenticate with.
-- `secret_access_key` (required) - the secret client key.
+- `secret_access_key` (required) - the secret client key. **NOTE** This value often may have an equals sign in it's value, especially if generated from the Azure Portal, so is important to wrap in single quotes eg. `secret_acccess_key='fpOfcHQJAQBczjAxiVpeyLmX1M0M0KPBST+GU2GvEN4='`
Use these configuration parameters when using tags:
- `tag_name` - the name of the tag to auto-join on.
From 39f8d12ec22871bfea0ea36120261285c2d2f2b1 Mon Sep 17 00:00:00 2001
From: petems
Date: Wed, 13 Feb 2019 00:54:51 +0000
Subject: [PATCH 4/4] Adds newline for bullets
* Formatting was previously broken
---
website/source/docs/agent/cloud-auto-join.html.md | 2 ++
1 file changed, 2 insertions(+)
diff --git a/website/source/docs/agent/cloud-auto-join.html.md b/website/source/docs/agent/cloud-auto-join.html.md
index 28e7d3eb7..51f891250 100644
--- a/website/source/docs/agent/cloud-auto-join.html.md
+++ b/website/source/docs/agent/cloud-auto-join.html.md
@@ -103,10 +103,12 @@ $ consul agent -retry-join "provider=azure tag_name=... tag_value=... tenant_id=
- `secret_access_key` (required) - the secret client key. **NOTE** This value often may have an equals sign in it's value, especially if generated from the Azure Portal, so is important to wrap in single quotes eg. `secret_acccess_key='fpOfcHQJAQBczjAxiVpeyLmX1M0M0KPBST+GU2GvEN4='`
Use these configuration parameters when using tags:
+
- `tag_name` - the name of the tag to auto-join on.
- `tag_value` - the value of the tag to auto-join on.
Use these configuration parameters when using Virtual Machine Scale Sets (Consul 1.0.3 and later):
+
- `resource_group` - the name of the resource group to filter on.
- `vm_scale_set` - the name of the virtual machine scale set to filter on.