diff --git a/agent/xds/clusters.go b/agent/xds/clusters.go index 3069aed88..0bcd66fb9 100644 --- a/agent/xds/clusters.go +++ b/agent/xds/clusters.go @@ -204,10 +204,10 @@ func makePassthroughClusters(cfgSnap *proxycfg.ConfigSnapshot) ([]proto.Message, func (s *ResourceGenerator) clustersFromSnapshotMeshGateway(cfgSnap *proxycfg.ConfigSnapshot) ([]proto.Message, error) { keys := cfgSnap.MeshGateway.GatewayKeys() - // 1 cluster per remote dc + 1 cluster per local service (this is a lower bound - all subset specific clusters will be appended) + // 1 cluster per remote dc/partition + 1 cluster per local service (this is a lower bound - all subset specific clusters will be appended) clusters := make([]proto.Message, 0, len(keys)+len(cfgSnap.MeshGateway.ServiceGroups)) - // generate the remote dc clusters + // Generate the remote clusters for _, key := range keys { if key.Matches(cfgSnap.Datacenter, cfgSnap.ProxyID.PartitionOrEmpty()) { continue // skip local diff --git a/agent/xds/listeners.go b/agent/xds/listeners.go index 47f7cbeb1..276ea58f7 100644 --- a/agent/xds/listeners.go +++ b/agent/xds/listeners.go @@ -1135,8 +1135,7 @@ func (s *ResourceGenerator) makeMeshGatewayListener(name, addr string, port int, l := makePortListener(name, addr, port, envoy_core_v3.TrafficDirection_UNSPECIFIED) l.ListenerFilters = []*envoy_listener_v3.ListenerFilter{tlsInspector} - // TODO (mesh-gateway) - Do we need to create clusters for all the old trust domains as well? - // We need 1 Filter Chain per datacenter + // We need 1 Filter Chain per remote cluster keys := cfgSnap.MeshGateway.GatewayKeys() for _, key := range keys { if key.Matches(cfgSnap.Datacenter, cfgSnap.ProxyID.PartitionOrEmpty()) {