luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity
open-consul/ui/packages/consul-ui/tests/unit/utils/merge-checks-test.js

148 lines
3.6 KiB
JavaScript
Raw Normal View History

ui: Keep track of previous node checks and avoid adding them twice (#9661) * Keep track of previous node checks and avoid adding them twice
2021-01-29 15:57:47 +00:00
import mergeChecks from 'consul-ui/utils/merge-checks';
import { module, test } from 'qunit';
ui: chore - upgrade ember and friends (#14518) * v3.20.2...v3.24.0 * Fix handle undefined outlet in route component * Don't use template helper for optional modal.open Using the optional-helper here will trigger a computation in the same runloop error. This is because we are setting the `modal`-property when the `<Ref>` component gets rendered which will update the `this.modal`-property which will then recompute the `optional`-helper leading to this error. Instead we will create an action that will call the `open`-method on the modal when it is defined. This gets rid of the double computation error as we will not access the modal property twice in the same runloop when `modal` is getting set. * Fix - fn needs to be passed function tab-nav We create functions in the component file instead so that fn-helper stops complaining about the need to pass a function. * Update ember-exam to 6.1 version "Makes it compatible" with ember-qunit v5 * scheduleOnce setMaxHeight paged-collection We need to schedule to get around double-computation error. * Fix - model.data is removed from ember-data This has been private API all along - we need to work around the removal. Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310 * Fix `propContains` instead of `deepEqual` policy Recent model.data works differently than iterating attributes. We use `propContains` instead of `deepEqual`. We are only interested in the properties we assert against and match the previous behavior with this change. * Fix `propContains` instead of `deepEqual` token * Better handling single-records repo test-helper `model.data` has been removed we need to handle proxies and model instances differently. * Fix remaining repository tests with propContains We don't want to match entire objects - we don't care about properties we haven't defined in the assertion. * Don't use template helper for optional modal.open Using a template helper will give us a recomputation error - we work around it by creating an explicit action on the component instead. * Await `I $verb the $pageObject object` step * Fix no more customization ember-can No need to customize, the helper handles destruction fine on its own. * Fix - don't pass `optional` functions to fn We will declare the functions on the component instead. This gives us the same behavior but no error from `fn`, which expects a function to be passed. * Fix - handle `undefined` state on validate modifier StateChart can yield out an undefined `state` we need to handle that in the validate modifier * Fix linting errors tests directory * Warn / turn off new ember linting issues We will tackle them one by one and don't want to autofix issues that could be dangerous to auto-fix. * Auto-fix linting issues * More linting configuration * Fix remaining linting issues * Fix linting issues new files after rebase * ui: Remove ember-cli-uglify config now we are using terser (#14574) Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
2022-09-15 08:43:17 +00:00
module('Unit | Utility | merge-checks', function () {
test('it works', function (assert) {
ui: Keep track of previous node checks and avoid adding them twice (#9661) * Keep track of previous node checks and avoid adding them twice
2021-01-29 15:57:47 +00:00
[
{
desc: 'One list of checks, not exposed',
exposed: false,
checks: [
[
{
ServiceName: 'service-0',
CheckID: 'service-0-check-0',
Node: 'node-0',
Exposable: false,
},
],
],
expected: [
{
ServiceName: 'service-0',
CheckID: 'service-0-check-0',
Node: 'node-0',
Exposable: false,
},
],
},
{
desc: 'One list of checks, exposed',
exposed: true,
checks: [
[
{
ServiceName: 'service-0',
CheckID: 'service-0-check-0',
Node: 'node-0',
Exposable: true,
},
],
],
expected: [
{
ServiceName: 'service-0',
CheckID: 'service-0-check-0',
Node: 'node-0',
Exposable: true,
Exposed: true,
},
],
},
{
desc: 'Two lists of checks, not exposed',
exposed: false,
checks: [
[
{
ServiceName: 'service-0',
CheckID: 'service-0-check-0',
Node: 'node-0',
Exposable: true,
},
],
[
{
ServiceName: 'service-0-proxy',
CheckID: 'service-0-proxy-check-0',
Node: 'node-0',
Exposable: true,
},
],
],
expected: [
{
ServiceName: 'service-0',
CheckID: 'service-0-check-0',
Node: 'node-0',
Exposable: true,
},
{
ServiceName: 'service-0-proxy',
CheckID: 'service-0-proxy-check-0',
Node: 'node-0',
Exposable: true,
},
],
},
{
desc: 'Two lists of checks, with one duplicate node checks, not exposed',
exposed: false,
checks: [
[
{
ServiceName: 'service-0',
CheckID: 'service-0-check-0',
Node: 'node-0',
Exposable: true,
},
{
ServiceName: '',
CheckID: 'service-0-check-1',
Node: 'node-0',
Exposable: true,
},
],
[
{
ServiceName: 'service-0-proxy',
CheckID: 'service-0-proxy-check-0',
Node: 'node-0',
Exposable: true,
},
{
ServiceName: '',
CheckID: 'service-0-check-1',
Node: 'node-0',
Exposable: true,
},
],
],
expected: [
{
ServiceName: 'service-0',
CheckID: 'service-0-check-0',
Node: 'node-0',
Exposable: true,
},
{
ServiceName: '',
CheckID: 'service-0-check-1',
Node: 'node-0',
Exposable: true,
},
{
ServiceName: 'service-0-proxy',
CheckID: 'service-0-proxy-check-0',
Node: 'node-0',
Exposable: true,
},
],
},
ui: chore - upgrade ember and friends (#14518) * v3.20.2...v3.24.0 * Fix handle undefined outlet in route component * Don't use template helper for optional modal.open Using the optional-helper here will trigger a computation in the same runloop error. This is because we are setting the `modal`-property when the `<Ref>` component gets rendered which will update the `this.modal`-property which will then recompute the `optional`-helper leading to this error. Instead we will create an action that will call the `open`-method on the modal when it is defined. This gets rid of the double computation error as we will not access the modal property twice in the same runloop when `modal` is getting set. * Fix - fn needs to be passed function tab-nav We create functions in the component file instead so that fn-helper stops complaining about the need to pass a function. * Update ember-exam to 6.1 version "Makes it compatible" with ember-qunit v5 * scheduleOnce setMaxHeight paged-collection We need to schedule to get around double-computation error. * Fix - model.data is removed from ember-data This has been private API all along - we need to work around the removal. Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310 * Fix `propContains` instead of `deepEqual` policy Recent model.data works differently than iterating attributes. We use `propContains` instead of `deepEqual`. We are only interested in the properties we assert against and match the previous behavior with this change. * Fix `propContains` instead of `deepEqual` token * Better handling single-records repo test-helper `model.data` has been removed we need to handle proxies and model instances differently. * Fix remaining repository tests with propContains We don't want to match entire objects - we don't care about properties we haven't defined in the assertion. * Don't use template helper for optional modal.open Using a template helper will give us a recomputation error - we work around it by creating an explicit action on the component instead. * Await `I $verb the $pageObject object` step * Fix no more customization ember-can No need to customize, the helper handles destruction fine on its own. * Fix - don't pass `optional` functions to fn We will declare the functions on the component instead. This gives us the same behavior but no error from `fn`, which expects a function to be passed. * Fix - handle `undefined` state on validate modifier StateChart can yield out an undefined `state` we need to handle that in the validate modifier * Fix linting errors tests directory * Warn / turn off new ember linting issues We will tackle them one by one and don't want to autofix issues that could be dangerous to auto-fix. * Auto-fix linting issues * More linting configuration * Fix remaining linting issues * Fix linting issues new files after rebase * ui: Remove ember-cli-uglify config now we are using terser (#14574) Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
2022-09-15 08:43:17 +00:00
].forEach((spec) => {
ui: Keep track of previous node checks and avoid adding them twice (#9661) * Keep track of previous node checks and avoid adding them twice
2021-01-29 15:57:47 +00:00
const actual = mergeChecks(spec.checks, spec.exposed);
assert.deepEqual(actual, spec.expected);
});
});
});