2017-10-12 21:55:32 +00:00
|
|
|
package maint
|
2015-01-21 21:37:32 +00:00
|
|
|
|
|
|
|
import (
|
|
|
|
"strings"
|
|
|
|
"testing"
|
|
|
|
|
2020-11-30 17:53:46 +00:00
|
|
|
"github.com/mitchellh/cli"
|
|
|
|
|
pkg refactor
command/agent/* -> agent/*
command/consul/* -> agent/consul/*
command/agent/command{,_test}.go -> command/agent{,_test}.go
command/base/command.go -> command/base.go
command/base/* -> command/*
commands.go -> command/commands.go
The script which did the refactor is:
(
cd $GOPATH/src/github.com/hashicorp/consul
git mv command/agent/command.go command/agent.go
git mv command/agent/command_test.go command/agent_test.go
git mv command/agent/flag_slice_value{,_test}.go command/
git mv command/agent .
git mv command/base/command.go command/base.go
git mv command/base/config_util{,_test}.go command/
git mv commands.go command/
git mv consul agent
rmdir command/base/
gsed -i -e 's|package agent|package command|' command/agent{,_test}.go
gsed -i -e 's|package agent|package command|' command/flag_slice_value{,_test}.go
gsed -i -e 's|package base|package command|' command/base.go command/config_util{,_test}.go
gsed -i -e 's|package main|package command|' command/commands.go
gsed -i -e 's|base.Command|BaseCommand|' command/commands.go
gsed -i -e 's|agent.Command|AgentCommand|' command/commands.go
gsed -i -e 's|\tCommand:|\tBaseCommand:|' command/commands.go
gsed -i -e 's|base\.||' command/commands.go
gsed -i -e 's|command\.||' command/commands.go
gsed -i -e 's|command|c|' main.go
gsed -i -e 's|range Commands|range command.Commands|' main.go
gsed -i -e 's|Commands: Commands|Commands: command.Commands|' main.go
gsed -i -e 's|base\.BoolValue|BoolValue|' command/operator_autopilot_set.go
gsed -i -e 's|base\.DurationValue|DurationValue|' command/operator_autopilot_set.go
gsed -i -e 's|base\.StringValue|StringValue|' command/operator_autopilot_set.go
gsed -i -e 's|base\.UintValue|UintValue|' command/operator_autopilot_set.go
gsed -i -e 's|\bCommand\b|BaseCommand|' command/base.go
gsed -i -e 's|BaseCommand Options|Command Options|' command/base.go
gsed -i -e 's|base.Command|BaseCommand|' command/*.go
gsed -i -e 's|c\.Command|c.BaseCommand|g' command/*.go
gsed -i -e 's|\tCommand:|\tBaseCommand:|' command/*_test.go
gsed -i -e 's|base\.||' command/*_test.go
gsed -i -e 's|\bCommand\b|AgentCommand|' command/agent{,_test}.go
gsed -i -e 's|cmd.AgentCommand|cmd.BaseCommand|' command/agent.go
gsed -i -e 's|cli.AgentCommand = new(Command)|cli.Command = new(AgentCommand)|' command/agent_test.go
gsed -i -e 's|exec.AgentCommand|exec.Command|' command/agent_test.go
gsed -i -e 's|exec.BaseCommand|exec.Command|' command/agent_test.go
gsed -i -e 's|NewTestAgent|agent.NewTestAgent|' command/agent_test.go
gsed -i -e 's|= TestConfig|= agent.TestConfig|' command/agent_test.go
gsed -i -e 's|: RetryJoin|: agent.RetryJoin|' command/agent_test.go
gsed -i -e 's|\.\./\.\./|../|' command/config_util_test.go
gsed -i -e 's|\bverifyUniqueListeners|VerifyUniqueListeners|' agent/config{,_test}.go command/agent.go
gsed -i -e 's|\bserfLANKeyring\b|SerfLANKeyring|g' agent/{agent,keyring,testagent}.go command/agent.go
gsed -i -e 's|\bserfWANKeyring\b|SerfWANKeyring|g' agent/{agent,keyring,testagent}.go command/agent.go
gsed -i -e 's|\bNewAgent\b|agent.New|g' command/agent{,_test}.go
gsed -i -e 's|\bNewAgent|New|' agent/{acl_test,agent,testagent}.go
gsed -i -e 's|\bAgent\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bBool\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bConfig\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bDefaultConfig\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bDevConfig\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bMergeConfig\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bReadConfigPaths\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bParseMetaPair\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bSerfLANKeyring\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bSerfWANKeyring\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|circonus\.agent|circonus|g' command/agent{,_test}.go
gsed -i -e 's|logger\.agent|logger|g' command/agent{,_test}.go
gsed -i -e 's|metrics\.agent|metrics|g' command/agent{,_test}.go
gsed -i -e 's|// agent.Agent|// agent|' command/agent{,_test}.go
gsed -i -e 's|a\.agent\.Config|a.Config|' command/agent{,_test}.go
gsed -i -e 's|agent\.AppendSliceValue|AppendSliceValue|' command/{configtest,validate}.go
gsed -i -e 's|consul/consul|agent/consul|' GNUmakefile
gsed -i -e 's|\.\./test|../../test|' agent/consul/server_test.go
# fix imports
f=$(grep -rl 'github.com/hashicorp/consul/command/agent' * | grep '\.go')
gsed -i -e 's|github.com/hashicorp/consul/command/agent|github.com/hashicorp/consul/agent|' $f
goimports -w $f
f=$(grep -rl 'github.com/hashicorp/consul/consul' * | grep '\.go')
gsed -i -e 's|github.com/hashicorp/consul/consul|github.com/hashicorp/consul/agent/consul|' $f
goimports -w $f
goimports -w command/*.go main.go
)
2017-06-09 22:28:28 +00:00
|
|
|
"github.com/hashicorp/consul/agent"
|
2017-07-06 10:34:00 +00:00
|
|
|
"github.com/hashicorp/consul/agent/structs"
|
2015-01-21 21:37:32 +00:00
|
|
|
)
|
|
|
|
|
2017-10-17 12:07:30 +00:00
|
|
|
func TestMaintCommand_noTabs(t *testing.T) {
|
2017-10-17 14:07:48 +00:00
|
|
|
t.Parallel()
|
2017-10-17 12:07:30 +00:00
|
|
|
if strings.ContainsRune(New(cli.NewMockUi()).Help(), '\t') {
|
2017-10-17 13:44:20 +00:00
|
|
|
t.Fatal("help has tabs")
|
2017-10-17 12:07:30 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-10-17 12:04:51 +00:00
|
|
|
func TestMaintCommand_ConflictingArgs(t *testing.T) {
|
2017-10-17 14:07:48 +00:00
|
|
|
t.Parallel()
|
2017-10-12 21:55:32 +00:00
|
|
|
ui := cli.NewMockUi()
|
|
|
|
c := New(ui)
|
|
|
|
c.flags.SetOutput(ui.ErrorWriter)
|
2015-01-21 21:37:32 +00:00
|
|
|
|
2015-01-22 18:26:17 +00:00
|
|
|
if code := c.Run([]string{"-enable", "-disable"}); code != 1 {
|
2015-01-21 21:37:32 +00:00
|
|
|
t.Fatalf("expected return code 1, got %d", code)
|
|
|
|
}
|
|
|
|
|
2015-01-22 18:26:17 +00:00
|
|
|
if code := c.Run([]string{"-disable", "-reason=broken"}); code != 1 {
|
|
|
|
t.Fatalf("expected return code 1, got %d", code)
|
2015-01-21 21:37:32 +00:00
|
|
|
}
|
2015-01-22 19:20:32 +00:00
|
|
|
|
|
|
|
if code := c.Run([]string{"-reason=broken"}); code != 1 {
|
|
|
|
t.Fatalf("expected return code 1, got %d", code)
|
|
|
|
}
|
|
|
|
|
|
|
|
if code := c.Run([]string{"-service=redis"}); code != 1 {
|
|
|
|
t.Fatalf("expected return code 1, got %d", code)
|
|
|
|
}
|
2015-01-21 21:37:32 +00:00
|
|
|
}
|
|
|
|
|
2017-10-17 12:04:51 +00:00
|
|
|
func TestMaintCommand_NoArgs(t *testing.T) {
|
2020-12-07 18:42:55 +00:00
|
|
|
if testing.Short() {
|
|
|
|
t.Skip("too slow for testing.Short")
|
|
|
|
}
|
|
|
|
|
2017-10-17 14:07:48 +00:00
|
|
|
t.Parallel()
|
2020-03-31 19:59:56 +00:00
|
|
|
a := agent.NewTestAgent(t, ``)
|
2017-05-22 11:59:36 +00:00
|
|
|
defer a.Shutdown()
|
2015-01-22 18:26:17 +00:00
|
|
|
|
|
|
|
// Register the service and put it into maintenance mode
|
2020-11-30 18:26:58 +00:00
|
|
|
addReq := agent.AddServiceRequest{
|
|
|
|
Service: &structs.NodeService{
|
|
|
|
ID: "test",
|
|
|
|
Service: "test",
|
|
|
|
},
|
|
|
|
Source: agent.ConfigSourceLocal,
|
|
|
|
}
|
|
|
|
if err := a.AddService(addReq); err != nil {
|
2015-01-22 18:26:17 +00:00
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
2019-12-10 02:26:41 +00:00
|
|
|
if err := a.EnableServiceMaintenance(structs.NewServiceID("test", nil), "broken 1", ""); err != nil {
|
2015-01-22 18:26:17 +00:00
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Enable node maintenance
|
2017-05-22 11:59:36 +00:00
|
|
|
a.EnableNodeMaintenance("broken 2", "")
|
2015-01-22 18:26:17 +00:00
|
|
|
|
|
|
|
// Run consul maint with no args (list mode)
|
2017-10-12 21:55:32 +00:00
|
|
|
ui := cli.NewMockUi()
|
|
|
|
c := New(ui)
|
|
|
|
c.flags.SetOutput(ui.ErrorWriter)
|
2015-01-21 21:49:10 +00:00
|
|
|
|
2017-05-22 11:59:36 +00:00
|
|
|
args := []string{"-http-addr=" + a.HTTPAddr()}
|
2015-01-22 18:26:17 +00:00
|
|
|
code := c.Run(args)
|
|
|
|
if code != 0 {
|
|
|
|
t.Fatalf("bad: %d. %#v", code, ui.ErrorWriter.String())
|
2015-01-21 21:49:10 +00:00
|
|
|
}
|
|
|
|
|
2015-01-22 18:26:17 +00:00
|
|
|
// Ensure the service shows up in the list
|
|
|
|
out := ui.OutputWriter.String()
|
|
|
|
if !strings.Contains(out, "test") {
|
|
|
|
t.Fatalf("bad:\n%s", out)
|
|
|
|
}
|
|
|
|
if !strings.Contains(out, "broken 1") {
|
|
|
|
t.Fatalf("bad:\n%s", out)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Ensure the node shows up in the list
|
2017-05-22 11:59:36 +00:00
|
|
|
if !strings.Contains(out, a.Config.NodeName) {
|
2015-01-22 18:26:17 +00:00
|
|
|
t.Fatalf("bad:\n%s", out)
|
|
|
|
}
|
|
|
|
if !strings.Contains(out, "broken 2") {
|
|
|
|
t.Fatalf("bad:\n%s", out)
|
2015-01-21 21:49:10 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-10-17 12:04:51 +00:00
|
|
|
func TestMaintCommand_EnableNodeMaintenance(t *testing.T) {
|
2020-12-07 18:42:55 +00:00
|
|
|
if testing.Short() {
|
|
|
|
t.Skip("too slow for testing.Short")
|
|
|
|
}
|
|
|
|
|
2017-10-17 14:07:48 +00:00
|
|
|
t.Parallel()
|
2020-03-31 19:59:56 +00:00
|
|
|
a := agent.NewTestAgent(t, ``)
|
2017-05-22 11:59:36 +00:00
|
|
|
defer a.Shutdown()
|
2015-01-21 21:37:32 +00:00
|
|
|
|
2017-10-12 21:55:32 +00:00
|
|
|
ui := cli.NewMockUi()
|
|
|
|
c := New(ui)
|
|
|
|
c.flags.SetOutput(ui.ErrorWriter)
|
2015-01-21 21:37:32 +00:00
|
|
|
|
|
|
|
args := []string{
|
2017-05-22 11:59:36 +00:00
|
|
|
"-http-addr=" + a.HTTPAddr(),
|
2015-01-21 21:37:32 +00:00
|
|
|
"-enable",
|
|
|
|
"-reason=broken",
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 0 {
|
|
|
|
t.Fatalf("bad: %d. %#v", code, ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
|
|
|
|
if !strings.Contains(ui.OutputWriter.String(), "now enabled") {
|
|
|
|
t.Fatalf("bad: %#v", ui.OutputWriter.String())
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-10-17 12:04:51 +00:00
|
|
|
func TestMaintCommand_DisableNodeMaintenance(t *testing.T) {
|
2020-12-07 18:42:55 +00:00
|
|
|
if testing.Short() {
|
|
|
|
t.Skip("too slow for testing.Short")
|
|
|
|
}
|
|
|
|
|
2017-10-17 14:07:48 +00:00
|
|
|
t.Parallel()
|
2020-03-31 19:59:56 +00:00
|
|
|
a := agent.NewTestAgent(t, ``)
|
2017-05-22 11:59:36 +00:00
|
|
|
defer a.Shutdown()
|
2015-01-21 21:49:10 +00:00
|
|
|
|
2017-10-12 21:55:32 +00:00
|
|
|
ui := cli.NewMockUi()
|
|
|
|
c := New(ui)
|
|
|
|
c.flags.SetOutput(ui.ErrorWriter)
|
2015-01-21 21:49:10 +00:00
|
|
|
|
|
|
|
args := []string{
|
2017-05-22 11:59:36 +00:00
|
|
|
"-http-addr=" + a.HTTPAddr(),
|
2015-01-21 21:49:10 +00:00
|
|
|
"-disable",
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 0 {
|
|
|
|
t.Fatalf("bad: %d. %#v", code, ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
|
|
|
|
if !strings.Contains(ui.OutputWriter.String(), "now disabled") {
|
|
|
|
t.Fatalf("bad: %#v", ui.OutputWriter.String())
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-10-17 12:04:51 +00:00
|
|
|
func TestMaintCommand_EnableServiceMaintenance(t *testing.T) {
|
2020-12-07 18:42:55 +00:00
|
|
|
if testing.Short() {
|
|
|
|
t.Skip("too slow for testing.Short")
|
|
|
|
}
|
|
|
|
|
2017-10-17 14:07:48 +00:00
|
|
|
t.Parallel()
|
2020-03-31 19:59:56 +00:00
|
|
|
a := agent.NewTestAgent(t, ``)
|
2017-05-22 11:59:36 +00:00
|
|
|
defer a.Shutdown()
|
2015-01-21 21:37:32 +00:00
|
|
|
|
|
|
|
// Register the service
|
2020-11-30 18:26:58 +00:00
|
|
|
addReq := agent.AddServiceRequest{
|
|
|
|
Service: &structs.NodeService{
|
|
|
|
ID: "test",
|
|
|
|
Service: "test",
|
|
|
|
},
|
|
|
|
Source: agent.ConfigSourceLocal,
|
|
|
|
}
|
|
|
|
if err := a.AddService(addReq); err != nil {
|
2015-01-21 21:37:32 +00:00
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
|
2017-10-12 21:55:32 +00:00
|
|
|
ui := cli.NewMockUi()
|
|
|
|
c := New(ui)
|
|
|
|
c.flags.SetOutput(ui.ErrorWriter)
|
2015-01-21 21:37:32 +00:00
|
|
|
|
|
|
|
args := []string{
|
2017-05-22 11:59:36 +00:00
|
|
|
"-http-addr=" + a.HTTPAddr(),
|
2015-01-21 21:37:32 +00:00
|
|
|
"-enable",
|
|
|
|
"-service=test",
|
|
|
|
"-reason=broken",
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 0 {
|
|
|
|
t.Fatalf("bad: %d. %#v", code, ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
|
|
|
|
if !strings.Contains(ui.OutputWriter.String(), "now enabled") {
|
|
|
|
t.Fatalf("bad: %#v", ui.OutputWriter.String())
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-10-17 12:04:51 +00:00
|
|
|
func TestMaintCommand_DisableServiceMaintenance(t *testing.T) {
|
2020-12-07 18:42:55 +00:00
|
|
|
if testing.Short() {
|
|
|
|
t.Skip("too slow for testing.Short")
|
|
|
|
}
|
|
|
|
|
2017-10-17 14:07:48 +00:00
|
|
|
t.Parallel()
|
2020-03-31 19:59:56 +00:00
|
|
|
a := agent.NewTestAgent(t, ``)
|
2017-05-22 11:59:36 +00:00
|
|
|
defer a.Shutdown()
|
2015-01-21 21:49:10 +00:00
|
|
|
|
|
|
|
// Register the service
|
2020-11-30 18:26:58 +00:00
|
|
|
addReq := agent.AddServiceRequest{
|
|
|
|
Service: &structs.NodeService{
|
|
|
|
ID: "test",
|
|
|
|
Service: "test",
|
|
|
|
},
|
|
|
|
Source: agent.ConfigSourceLocal,
|
|
|
|
}
|
|
|
|
if err := a.AddService(addReq); err != nil {
|
2015-01-21 21:49:10 +00:00
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
|
2017-10-12 21:55:32 +00:00
|
|
|
ui := cli.NewMockUi()
|
|
|
|
c := New(ui)
|
|
|
|
c.flags.SetOutput(ui.ErrorWriter)
|
2015-01-21 21:49:10 +00:00
|
|
|
|
|
|
|
args := []string{
|
2017-05-22 11:59:36 +00:00
|
|
|
"-http-addr=" + a.HTTPAddr(),
|
2015-01-21 21:49:10 +00:00
|
|
|
"-disable",
|
|
|
|
"-service=test",
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 0 {
|
|
|
|
t.Fatalf("bad: %d. %#v", code, ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
|
|
|
|
if !strings.Contains(ui.OutputWriter.String(), "now disabled") {
|
|
|
|
t.Fatalf("bad: %#v", ui.OutputWriter.String())
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-10-17 12:04:51 +00:00
|
|
|
func TestMaintCommand_ServiceMaintenance_NoService(t *testing.T) {
|
2020-12-07 18:42:55 +00:00
|
|
|
if testing.Short() {
|
|
|
|
t.Skip("too slow for testing.Short")
|
|
|
|
}
|
|
|
|
|
2017-10-17 14:07:48 +00:00
|
|
|
t.Parallel()
|
2020-03-31 19:59:56 +00:00
|
|
|
a := agent.NewTestAgent(t, ``)
|
2017-05-22 11:59:36 +00:00
|
|
|
defer a.Shutdown()
|
2015-01-21 21:37:32 +00:00
|
|
|
|
2017-10-12 21:55:32 +00:00
|
|
|
ui := cli.NewMockUi()
|
|
|
|
c := New(ui)
|
|
|
|
c.flags.SetOutput(ui.ErrorWriter)
|
2015-01-21 21:37:32 +00:00
|
|
|
|
|
|
|
args := []string{
|
2017-05-22 11:59:36 +00:00
|
|
|
"-http-addr=" + a.HTTPAddr(),
|
2015-01-21 21:37:32 +00:00
|
|
|
"-enable",
|
|
|
|
"-service=redis",
|
|
|
|
"-reason=broken",
|
|
|
|
}
|
|
|
|
code := c.Run(args)
|
|
|
|
if code != 1 {
|
|
|
|
t.Fatalf("expected response code 1, got %d", code)
|
|
|
|
}
|
|
|
|
|
2021-07-15 23:55:13 +00:00
|
|
|
if !strings.Contains(ui.ErrorWriter.String(), "Unknown service") {
|
2015-01-21 21:37:32 +00:00
|
|
|
t.Fatalf("bad: %#v", ui.ErrorWriter.String())
|
|
|
|
}
|
|
|
|
}
|