2023-03-28 18:39:22 +00:00
|
|
|
// Copyright (c) HashiCorp, Inc.
|
|
|
|
// SPDX-License-Identifier: MPL-2.0
|
|
|
|
|
2022-12-16 21:49:26 +00:00
|
|
|
package controller
|
|
|
|
|
|
|
|
import (
|
|
|
|
"context"
|
|
|
|
"errors"
|
|
|
|
"fmt"
|
2023-01-26 20:20:37 +00:00
|
|
|
"sync"
|
2022-12-16 21:49:26 +00:00
|
|
|
"sync/atomic"
|
|
|
|
"time"
|
|
|
|
|
2023-05-05 14:38:22 +00:00
|
|
|
"github.com/hashicorp/go-hclog"
|
|
|
|
"golang.org/x/sync/errgroup"
|
|
|
|
|
|
|
|
"github.com/hashicorp/consul/agent/consul/controller/queue"
|
2022-12-16 21:49:26 +00:00
|
|
|
"github.com/hashicorp/consul/agent/consul/state"
|
|
|
|
"github.com/hashicorp/consul/agent/consul/stream"
|
|
|
|
"github.com/hashicorp/consul/agent/structs"
|
|
|
|
)
|
|
|
|
|
|
|
|
// much of this is a re-implementation of
|
|
|
|
// https://github.com/kubernetes-sigs/controller-runtime/blob/release-0.13/pkg/internal/controller/controller.go
|
|
|
|
|
|
|
|
// Transformer is a function that takes one type of config entry that has changed
|
|
|
|
// and transforms that into a set of reconciliation requests to enqueue.
|
|
|
|
type Transformer func(entry structs.ConfigEntry) []Request
|
|
|
|
|
|
|
|
// Controller subscribes to a set of watched resources from the
|
|
|
|
// state store and delegates processing them to a given Reconciler.
|
|
|
|
// If a Reconciler errors while processing a Request, then the
|
|
|
|
// Controller handles rescheduling the Request to be re-processed.
|
|
|
|
type Controller interface {
|
|
|
|
// Run begins the Controller's main processing loop. When the given
|
|
|
|
// context is canceled, the Controller stops processing any remaining work.
|
|
|
|
// The Run function should only ever be called once.
|
|
|
|
Run(ctx context.Context) error
|
|
|
|
// Subscribe tells the controller to subscribe to updates for config entries based
|
|
|
|
// on the given request. Optional transformation functions can also be passed in
|
|
|
|
// to Subscribe, allowing a controller to map a config entry to a different type of
|
|
|
|
// request under the hood (i.e. watching a dependency and triggering a Reconcile on
|
|
|
|
// the dependent resource). This should only ever be called prior to calling Run.
|
|
|
|
Subscribe(request *stream.SubscribeRequest, transformers ...Transformer) Controller
|
|
|
|
// WithBackoff changes the base and maximum backoff values for the Controller's
|
|
|
|
// Request retry rate limiter. This should only ever be called prior to
|
|
|
|
// running Run.
|
|
|
|
WithBackoff(base, max time.Duration) Controller
|
2023-01-26 20:20:37 +00:00
|
|
|
// WithLogger sets the logger for the controller, it should be called prior to Start
|
|
|
|
// being invoked.
|
|
|
|
WithLogger(logger hclog.Logger) Controller
|
2022-12-16 21:49:26 +00:00
|
|
|
// WithWorkers sets the number of worker goroutines used to process the queue
|
|
|
|
// this defaults to 1 goroutine.
|
|
|
|
WithWorkers(i int) Controller
|
|
|
|
// WithQueueFactory allows a Controller to replace its underlying work queue
|
|
|
|
// implementation. This is most useful for testing. This should only ever be called
|
|
|
|
// prior to running Run.
|
2023-05-05 14:38:22 +00:00
|
|
|
WithQueueFactory(fn func(ctx context.Context, baseBackoff time.Duration, maxBackoff time.Duration) queue.WorkQueue[Request]) Controller
|
2023-01-26 20:20:37 +00:00
|
|
|
// AddTrigger allows for triggering a reconciliation request when a
|
|
|
|
// triggering function returns, when the passed in context is canceled
|
|
|
|
// the trigger must return
|
|
|
|
AddTrigger(request Request, trigger func(ctx context.Context) error)
|
|
|
|
// RemoveTrigger removes the triggering function associated with the Request object
|
|
|
|
RemoveTrigger(request Request)
|
2023-02-08 19:50:17 +00:00
|
|
|
// Enqueue adds all of the given requests into the work queue.
|
|
|
|
Enqueue(requests ...Request)
|
2022-12-16 21:49:26 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
var _ Controller = &controller{}
|
|
|
|
|
|
|
|
type subscription struct {
|
|
|
|
request *stream.SubscribeRequest
|
|
|
|
transformers []Transformer
|
|
|
|
}
|
|
|
|
|
|
|
|
// controller implements the Controller interface
|
|
|
|
type controller struct {
|
|
|
|
// reconciler is the Reconciler that processes all subscribed
|
|
|
|
// Requests
|
|
|
|
reconciler Reconciler
|
|
|
|
|
|
|
|
// makeQueue is the factory used for creating the work queue, generally
|
|
|
|
// this shouldn't be touched, but can be updated for testing purposes
|
2023-05-05 14:38:22 +00:00
|
|
|
makeQueue func(ctx context.Context, baseBackoff time.Duration, maxBackoff time.Duration) queue.WorkQueue[Request]
|
2022-12-16 21:49:26 +00:00
|
|
|
// workers is the number of workers to use to process data
|
|
|
|
workers int
|
|
|
|
// work is the internal work queue that pending Requests are added to
|
2023-05-05 14:38:22 +00:00
|
|
|
work queue.WorkQueue[Request]
|
2022-12-16 21:49:26 +00:00
|
|
|
// baseBackoff is the starting backoff time for the work queue's rate limiter
|
|
|
|
baseBackoff time.Duration
|
|
|
|
// maxBackoff is the maximum backoff time for the work queue's rate limiter
|
|
|
|
maxBackoff time.Duration
|
|
|
|
|
|
|
|
// subscriptions is a list of subscription requests for retrieving configuration entries
|
|
|
|
subscriptions []subscription
|
|
|
|
// publisher is the event publisher that should be subscribed to for any updates
|
|
|
|
publisher state.EventPublisher
|
|
|
|
|
2023-01-26 20:20:37 +00:00
|
|
|
// waitOnce ensures we wait until the controller has started
|
|
|
|
waitOnce sync.Once
|
|
|
|
// started signals when the controller has started
|
|
|
|
started chan struct{}
|
|
|
|
|
|
|
|
// group is the error group used in our main start up worker routines
|
|
|
|
group *errgroup.Group
|
|
|
|
// groupCtx is the context of the error group to use in spinning up our
|
|
|
|
// worker routines
|
|
|
|
groupCtx context.Context
|
|
|
|
|
|
|
|
// triggers is a map of cancel functions for out-of-band Request triggers
|
|
|
|
triggers map[Request]func()
|
|
|
|
// triggerMutex is used for accessing the above map
|
|
|
|
triggerMutex sync.Mutex
|
|
|
|
|
2022-12-16 21:49:26 +00:00
|
|
|
// running ensures that we are only calling Run a single time
|
|
|
|
running int32
|
2023-01-26 20:20:37 +00:00
|
|
|
|
|
|
|
// logger is the logger for the controller
|
|
|
|
logger hclog.Logger
|
2022-12-16 21:49:26 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// New returns a new Controller associated with the given state store and reconciler.
|
|
|
|
func New(publisher state.EventPublisher, reconciler Reconciler) Controller {
|
|
|
|
return &controller{
|
|
|
|
reconciler: reconciler,
|
|
|
|
publisher: publisher,
|
|
|
|
workers: 1,
|
|
|
|
baseBackoff: 5 * time.Millisecond,
|
|
|
|
maxBackoff: 1000 * time.Second,
|
2023-05-05 14:38:22 +00:00
|
|
|
makeQueue: queue.RunWorkQueue[Request],
|
2023-01-26 20:20:37 +00:00
|
|
|
started: make(chan struct{}),
|
|
|
|
triggers: make(map[Request]func()),
|
|
|
|
logger: hclog.NewNullLogger(),
|
2022-12-16 21:49:26 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Subscribe tells the controller to subscribe to updates for config entries of the
|
|
|
|
// given kind and with the associated enterprise metadata. This should only ever be
|
|
|
|
// called prior to running Start.
|
|
|
|
func (c *controller) Subscribe(request *stream.SubscribeRequest, transformers ...Transformer) Controller {
|
|
|
|
c.ensureNotRunning()
|
|
|
|
|
|
|
|
c.subscriptions = append(c.subscriptions, subscription{
|
|
|
|
request: request,
|
|
|
|
transformers: transformers,
|
|
|
|
})
|
|
|
|
return c
|
|
|
|
}
|
|
|
|
|
|
|
|
// WithBackoff changes the base and maximum backoff values for the Controller's
|
|
|
|
// Request retry rate limiter. This should only ever be called prior to
|
|
|
|
// running Start.
|
|
|
|
func (c *controller) WithBackoff(base, max time.Duration) Controller {
|
|
|
|
c.ensureNotRunning()
|
|
|
|
|
|
|
|
c.baseBackoff = base
|
|
|
|
c.maxBackoff = max
|
|
|
|
return c
|
|
|
|
}
|
|
|
|
|
|
|
|
// WithWorkers sets the number of worker goroutines used to process the queue
|
|
|
|
// this defaults to 1 goroutine.
|
|
|
|
func (c *controller) WithWorkers(i int) Controller {
|
|
|
|
c.ensureNotRunning()
|
|
|
|
|
|
|
|
if i <= 0 {
|
|
|
|
i = 1
|
|
|
|
}
|
|
|
|
c.workers = i
|
|
|
|
return c
|
|
|
|
}
|
|
|
|
|
2023-01-26 20:20:37 +00:00
|
|
|
// WithLogger sets the internal logger for the controller.
|
|
|
|
func (c *controller) WithLogger(logger hclog.Logger) Controller {
|
|
|
|
c.ensureNotRunning()
|
|
|
|
|
|
|
|
c.logger = logger
|
|
|
|
return c
|
|
|
|
}
|
|
|
|
|
2022-12-16 21:49:26 +00:00
|
|
|
// WithQueueFactory changes the initialization method for the Controller's work
|
|
|
|
// queue, this is predominantly just used for testing. This should only ever be called
|
|
|
|
// prior to running Start.
|
2023-05-05 14:38:22 +00:00
|
|
|
func (c *controller) WithQueueFactory(fn func(ctx context.Context, baseBackoff time.Duration, maxBackoff time.Duration) queue.WorkQueue[Request]) Controller {
|
2022-12-16 21:49:26 +00:00
|
|
|
c.ensureNotRunning()
|
|
|
|
|
|
|
|
c.makeQueue = fn
|
|
|
|
return c
|
|
|
|
}
|
|
|
|
|
|
|
|
// ensureNotRunning makes sure we aren't trying to reconfigure an already
|
|
|
|
// running controller, it panics if Run has already been invoked
|
|
|
|
func (c *controller) ensureNotRunning() {
|
|
|
|
if atomic.LoadInt32(&c.running) == 1 {
|
|
|
|
panic("cannot configure controller once Run is called")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Run begins the Controller's main processing loop. When the given
|
|
|
|
// context is canceled, the Controller stops processing any remaining work.
|
|
|
|
// The Run function should only ever be called once, calling it multiple
|
|
|
|
// times will result in a panic.
|
|
|
|
func (c *controller) Run(ctx context.Context) error {
|
|
|
|
if !atomic.CompareAndSwapInt32(&c.running, 0, 1) {
|
|
|
|
panic("Run cannot be called more than once")
|
|
|
|
}
|
|
|
|
|
2023-01-26 20:20:37 +00:00
|
|
|
c.group, c.groupCtx = errgroup.WithContext(ctx)
|
2022-12-16 21:49:26 +00:00
|
|
|
|
|
|
|
// set up our queue
|
2023-01-26 20:20:37 +00:00
|
|
|
c.work = c.makeQueue(c.groupCtx, c.baseBackoff, c.maxBackoff)
|
|
|
|
|
|
|
|
// we can now add stuff to the queue from other contexts
|
|
|
|
close(c.started)
|
2022-12-16 21:49:26 +00:00
|
|
|
|
|
|
|
for _, sub := range c.subscriptions {
|
|
|
|
// store a reference for the closure
|
|
|
|
sub := sub
|
2023-01-26 20:20:37 +00:00
|
|
|
c.group.Go(func() error {
|
2022-12-16 21:49:26 +00:00
|
|
|
var index uint64
|
|
|
|
|
|
|
|
subscription, err := c.publisher.Subscribe(sub.request)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
defer subscription.Unsubscribe()
|
|
|
|
|
|
|
|
for {
|
|
|
|
event, err := subscription.Next(ctx)
|
|
|
|
switch {
|
|
|
|
case errors.Is(err, context.Canceled):
|
|
|
|
return nil
|
|
|
|
case err != nil:
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
if event.IsFramingEvent() {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
if event.Index <= index {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
index = event.Index
|
|
|
|
|
|
|
|
if err := c.processEvent(sub, event); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
for i := 0; i < c.workers; i++ {
|
2023-01-26 20:20:37 +00:00
|
|
|
c.group.Go(func() error {
|
2022-12-16 21:49:26 +00:00
|
|
|
for {
|
|
|
|
request, shutdown := c.work.Get()
|
|
|
|
if shutdown {
|
|
|
|
// Stop working
|
|
|
|
return nil
|
|
|
|
}
|
2023-01-26 20:20:37 +00:00
|
|
|
c.reconcileHandler(c.groupCtx, request)
|
2022-12-16 21:49:26 +00:00
|
|
|
// Done is called here because it is required to be called
|
|
|
|
// when we've finished processing each request
|
|
|
|
c.work.Done(request)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2023-01-26 20:20:37 +00:00
|
|
|
<-c.groupCtx.Done()
|
2022-12-16 21:49:26 +00:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2023-01-26 20:20:37 +00:00
|
|
|
// AddTrigger allows for triggering a reconciliation request every time that the
|
|
|
|
// triggering function returns, when the passed in context is canceled
|
|
|
|
// the trigger must return
|
|
|
|
func (c *controller) AddTrigger(request Request, trigger func(ctx context.Context) error) {
|
|
|
|
c.wait()
|
|
|
|
|
|
|
|
ctx, cancel := context.WithCancel(c.groupCtx)
|
|
|
|
|
|
|
|
c.triggerMutex.Lock()
|
|
|
|
oldCancel, ok := c.triggers[request]
|
|
|
|
if ok {
|
|
|
|
oldCancel()
|
|
|
|
}
|
|
|
|
c.triggers[request] = cancel
|
|
|
|
c.triggerMutex.Unlock()
|
|
|
|
|
|
|
|
c.group.Go(func() error {
|
|
|
|
if err := trigger(ctx); err != nil {
|
|
|
|
c.logger.Error("error while running trigger, adding re-reconcilation anyway", "error", err)
|
|
|
|
}
|
|
|
|
select {
|
|
|
|
case <-ctx.Done():
|
|
|
|
return nil
|
|
|
|
default:
|
|
|
|
c.work.Add(request)
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
// RemoveTrigger removes the triggering function associated with the Request object
|
|
|
|
func (c *controller) RemoveTrigger(request Request) {
|
|
|
|
c.triggerMutex.Lock()
|
|
|
|
cancel, ok := c.triggers[request]
|
|
|
|
if ok {
|
|
|
|
cancel()
|
|
|
|
delete(c.triggers, request)
|
|
|
|
}
|
|
|
|
c.triggerMutex.Unlock()
|
|
|
|
}
|
|
|
|
|
|
|
|
func (c *controller) wait() {
|
|
|
|
c.waitOnce.Do(func() {
|
|
|
|
<-c.started
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2022-12-16 21:49:26 +00:00
|
|
|
func (c *controller) processEvent(sub subscription, event stream.Event) error {
|
|
|
|
switch payload := event.Payload.(type) {
|
|
|
|
case state.EventPayloadConfigEntry:
|
|
|
|
c.enqueueEntry(payload.Value, sub.transformers...)
|
|
|
|
return nil
|
|
|
|
case *stream.PayloadEvents:
|
|
|
|
for _, event := range payload.Items {
|
|
|
|
if err := c.processEvent(sub, event); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
default:
|
|
|
|
return fmt.Errorf("unhandled event type: %T", payload)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// enqueueEntry adds all of the given entry into the work queue. If given
|
|
|
|
// one or more transformation functions, it will enqueue all of the resulting
|
|
|
|
// reconciliation requests returned from each Transformer.
|
|
|
|
func (c *controller) enqueueEntry(entry structs.ConfigEntry, transformers ...Transformer) {
|
|
|
|
if len(transformers) == 0 {
|
|
|
|
c.work.Add(Request{
|
|
|
|
Kind: entry.GetKind(),
|
|
|
|
Name: entry.GetName(),
|
|
|
|
Meta: entry.GetEnterpriseMeta(),
|
|
|
|
})
|
|
|
|
} else {
|
|
|
|
for _, fn := range transformers {
|
|
|
|
for _, request := range fn(entry) {
|
|
|
|
c.work.Add(request)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-02-08 19:50:17 +00:00
|
|
|
// Enqueue adds all of the given requests into the work queue.
|
|
|
|
func (c *controller) Enqueue(requests ...Request) {
|
|
|
|
for _, request := range requests {
|
|
|
|
c.work.Add(request)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-12-16 21:49:26 +00:00
|
|
|
// reconcile wraps the reconciler in a panic handler
|
|
|
|
func (c *controller) reconcile(ctx context.Context, req Request) (err error) {
|
|
|
|
defer func() {
|
|
|
|
if r := recover(); r != nil {
|
|
|
|
err = fmt.Errorf("panic [recovered]: %v", r)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}()
|
|
|
|
return c.reconciler.Reconcile(ctx, req)
|
|
|
|
}
|
|
|
|
|
|
|
|
// reconcileHandler invokes the reconciler and looks at its return value
|
|
|
|
// to determine whether the request should be rescheduled
|
|
|
|
func (c *controller) reconcileHandler(ctx context.Context, req Request) {
|
|
|
|
if err := c.reconcile(ctx, req); err != nil {
|
|
|
|
// handle the case where we're specifically told to requeue later
|
|
|
|
var requeueAfter RequeueAfterError
|
|
|
|
if errors.As(err, &requeueAfter) {
|
|
|
|
c.work.Forget(req)
|
|
|
|
c.work.AddAfter(req, time.Duration(requeueAfter))
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// fallback to rate limit ourselves
|
|
|
|
c.work.AddRateLimited(req)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// if no error then Forget this request so it is not retried
|
|
|
|
c.work.Forget(req)
|
|
|
|
}
|