luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity
open-consul/.golangci.yml

27 lines
522 B
YAML
Raw Normal View History

ci: Use golangci-lint for linting Using golangci-lint has a number of advantages: - adding new linters becomes much easier, its a couple lines of yaml config instead of more bash scripting - it enables whitelisting of issues using inline comments or regex - when running multiple linters less work is done. The parsed source can be reused by multiple linters - linters are run in parallel to reduce CI runtime.
2020-03-12 01:18:03 +00:00
linters:
disable-all: true
enable:
- gofmt
- govet
Add unconvert linter To find unnecessary type convertions
2020-04-16 17:35:28 +00:00
- unconvert
ci: Add staticcheck and fix most errors Three of the checks are temporarily disabled to limit the size of the diff, and allow us to enable all the other checks in CI. In a follow up we can fix the issues reported by the other checks one at a time, and enable them.
2020-05-14 21:02:52 +00:00
- staticcheck
ci: Add ineffsign linter And fix an additional ineffective assignment that was not caught by staticcheck
2020-06-05 22:08:30 +00:00
- ineffassign
ci: Use golangci-lint for linting Using golangci-lint has a number of advantages: - adding new linters becomes much easier, its a couple lines of yaml config instead of more bash scripting - it enables whitelisting of issues using inline comments or regex - when running multiple linters less work is done. The parsed source can be reused by multiple linters - linters are run in parallel to reduce CI runtime.
2020-03-12 01:18:03 +00:00
issues:
# Disable the default exclude list so that all excludes are explicitly
# defined in this file.
exclude-use-default: false
ci: Add staticcheck and fix most errors Three of the checks are temporarily disabled to limit the size of the diff, and allow us to enable all the other checks in CI. In a follow up we can fix the issues reported by the other checks one at a time, and enable them.
2020-05-14 21:02:52 +00:00
exclude-rules:
# Temp Ignore SA9004: only the first constant in this group has an explicit type
# https://staticcheck.io/docs/checks#SA9004
- linters: [staticcheck]
text: "SA9004:"
ci: Use golangci-lint for linting Using golangci-lint has a number of advantages: - adding new linters becomes much easier, its a couple lines of yaml config instead of more bash scripting - it enables whitelisting of issues using inline comments or regex - when running multiple linters less work is done. The parsed source can be reused by multiple linters - linters are run in parallel to reduce CI runtime.
2020-03-12 01:18:03 +00:00
linters-settings:
gofmt:
Enable gofmt simplify Code changes done automatically with 'gofmt -s -w'
2020-06-16 17:19:31 +00:00
simplify: true
Add lint to makefile And support for setting build tags in CI lint job. Removed the unused 'test-ci' target.
2020-03-24 20:14:12 +00:00
run:
Increase lint timeout We occasionally see the lint job fail due to this timeout. Likely when the node running lint is under heavy load, because normally it runs much faster. This commit increases the timeout substantially to work around that problem.
2020-06-03 20:50:35 +00:00
timeout: 10m