2014-08-08 22:32:43 +00:00
|
|
|
package consul
|
|
|
|
|
|
|
|
import (
|
2015-06-11 23:46:15 +00:00
|
|
|
"fmt"
|
2019-04-08 18:19:09 +00:00
|
|
|
"sort"
|
2018-06-28 07:06:14 +00:00
|
|
|
"sync"
|
2014-08-08 22:32:43 +00:00
|
|
|
"time"
|
|
|
|
|
2019-04-08 18:19:09 +00:00
|
|
|
metrics "github.com/armon/go-metrics"
|
2014-08-08 22:32:43 +00:00
|
|
|
"github.com/hashicorp/consul/acl"
|
2017-07-06 10:34:00 +00:00
|
|
|
"github.com/hashicorp/consul/agent/structs"
|
2020-01-28 23:50:41 +00:00
|
|
|
"github.com/hashicorp/consul/logging"
|
|
|
|
"github.com/hashicorp/go-hclog"
|
2019-03-14 14:35:34 +00:00
|
|
|
"golang.org/x/sync/singleflight"
|
2018-10-19 16:04:07 +00:00
|
|
|
"golang.org/x/time/rate"
|
2014-08-08 22:52:52 +00:00
|
|
|
)
|
|
|
|
|
2016-12-14 07:21:14 +00:00
|
|
|
// These must be kept in sync with the constants in command/agent/acl.go.
|
2014-08-08 22:52:52 +00:00
|
|
|
const (
|
2016-12-14 07:21:14 +00:00
|
|
|
// anonymousToken is the token ID we re-write to if there is no token ID
|
|
|
|
// provided.
|
2014-08-11 21:54:18 +00:00
|
|
|
anonymousToken = "anonymous"
|
2015-06-18 23:18:10 +00:00
|
|
|
|
Creates new "prepared-query" ACL type and new token capture behavior.
Prior to this change, prepared queries had the following behavior for
ACLs, which will need to change to support templates:
1. A management token, or a token with read access to the service being
queried needed to be provided in order to create a prepared query.
2. The token used to create the prepared query was stored with the query
in the state store and used to execute the query.
3. A management token, or the token used to create the query needed to be
supplied to perform and CRUD operations on an existing prepared query.
This was pretty subtle and complicated behavior, and won't work for
templates since the service name is computed at execution time. To solve
this, we introduce a new "prepared-query" ACL type, where the prefix
applies to the query name for static prepared query types and to the
prefix for template prepared query types.
With this change, the new behavior is:
1. A management token, or a token with "prepared-query" write access to
the query name or (soon) the given template prefix is required to do
any CRUD operations on a prepared query, or to list prepared queries
(the list is filtered by this ACL).
2. You will no longer need a management token to list prepared queries,
but you will only be able to see prepared queries that you have access
to (you get an empty list instead of permission denied).
3. When listing or getting a query, because it was easy to capture
management tokens given the past behavior, this will always blank out
the "Token" field (replacing the contents as <hidden>) for all tokens
unless a management token is supplied. Going forward, we should
discourage people from binding tokens for execution unless strictly
necessary.
4. No token will be captured by default when a prepared query is created.
If the user wishes to supply an execution token then can pass it in via
the "Token" field in the prepared query definition. Otherwise, this
field will default to empty.
5. At execution time, we will use the captured token if it exists with the
prepared query definition, otherwise we will use the token that's passed
in with the request, just like we do for other RPCs (or you can use the
agent's configured token for DNS).
6. Prepared queries with no name (accessible only by ID) will not require
ACLs to create or modify (execution time will depend on the service ACL
configuration). Our argument here is that these are designed to be
ephemeral and the IDs are as good as an ACL. Management tokens will be
able to list all of these.
These changes enable templates, but also enable delegation of authority to
manage the prepared query namespace.
2016-02-23 08:12:58 +00:00
|
|
|
// redactedToken is shown in structures with embedded tokens when they
|
2016-12-14 07:21:14 +00:00
|
|
|
// are not allowed to be displayed.
|
Creates new "prepared-query" ACL type and new token capture behavior.
Prior to this change, prepared queries had the following behavior for
ACLs, which will need to change to support templates:
1. A management token, or a token with read access to the service being
queried needed to be provided in order to create a prepared query.
2. The token used to create the prepared query was stored with the query
in the state store and used to execute the query.
3. A management token, or the token used to create the query needed to be
supplied to perform and CRUD operations on an existing prepared query.
This was pretty subtle and complicated behavior, and won't work for
templates since the service name is computed at execution time. To solve
this, we introduce a new "prepared-query" ACL type, where the prefix
applies to the query name for static prepared query types and to the
prefix for template prepared query types.
With this change, the new behavior is:
1. A management token, or a token with "prepared-query" write access to
the query name or (soon) the given template prefix is required to do
any CRUD operations on a prepared query, or to list prepared queries
(the list is filtered by this ACL).
2. You will no longer need a management token to list prepared queries,
but you will only be able to see prepared queries that you have access
to (you get an empty list instead of permission denied).
3. When listing or getting a query, because it was easy to capture
management tokens given the past behavior, this will always blank out
the "Token" field (replacing the contents as <hidden>) for all tokens
unless a management token is supplied. Going forward, we should
discourage people from binding tokens for execution unless strictly
necessary.
4. No token will be captured by default when a prepared query is created.
If the user wishes to supply an execution token then can pass it in via
the "Token" field in the prepared query definition. Otherwise, this
field will default to empty.
5. At execution time, we will use the captured token if it exists with the
prepared query definition, otherwise we will use the token that's passed
in with the request, just like we do for other RPCs (or you can use the
agent's configured token for DNS).
6. Prepared queries with no name (accessible only by ID) will not require
ACLs to create or modify (execution time will depend on the service ACL
configuration). Our argument here is that these are designed to be
ephemeral and the IDs are as good as an ACL. Management tokens will be
able to list all of these.
These changes enable templates, but also enable delegation of authority to
manage the prepared query namespace.
2016-02-23 08:12:58 +00:00
|
|
|
redactedToken = "<hidden>"
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
// aclUpgradeBatchSize controls how many tokens we look at during each round of upgrading. Individual raft logs
|
|
|
|
// will be further capped using the aclBatchUpsertSize. This limit just prevents us from creating a single slice
|
|
|
|
// with all tokens in it.
|
|
|
|
aclUpgradeBatchSize = 128
|
|
|
|
|
2019-04-08 17:05:51 +00:00
|
|
|
// aclUpgradeRateLimit is the number of batch upgrade requests per second allowed.
|
2018-10-19 16:04:07 +00:00
|
|
|
aclUpgradeRateLimit rate.Limit = 1.0
|
|
|
|
|
2019-04-08 17:05:51 +00:00
|
|
|
// aclTokenReapingRateLimit is the number of batch token reaping requests per second allowed.
|
|
|
|
aclTokenReapingRateLimit rate.Limit = 1.0
|
|
|
|
|
|
|
|
// aclTokenReapingBurst is the number of batch token reaping requests per second
|
|
|
|
// that can burst after a period of idleness.
|
|
|
|
aclTokenReapingBurst = 5
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
// aclBatchDeleteSize is the number of deletions to send in a single batch operation. 4096 should produce a batch that is <150KB
|
|
|
|
// in size but should be sufficiently large to handle 1 replication round in a single batch
|
|
|
|
aclBatchDeleteSize = 4096
|
|
|
|
|
|
|
|
// aclBatchUpsertSize is the target size in bytes we want to submit for a batch upsert request. We estimate the size at runtime
|
|
|
|
// due to the data being more variable in its size.
|
|
|
|
aclBatchUpsertSize = 256 * 1024
|
|
|
|
|
|
|
|
// DEPRECATED (ACL-Legacy-Compat) aclModeCheck* are all only for legacy usage
|
|
|
|
// aclModeCheckMinInterval is the minimum amount of time between checking if the
|
|
|
|
// agent should be using the new or legacy ACL system. All the places it is
|
|
|
|
// currently used will backoff as it detects that it is remaining in legacy mode.
|
|
|
|
// However the initial min value is kept small so that new cluster creation
|
|
|
|
// can enter into new ACL mode quickly.
|
|
|
|
aclModeCheckMinInterval = 50 * time.Millisecond
|
|
|
|
|
|
|
|
// aclModeCheckMaxInterval controls the maximum interval for how often the agent
|
|
|
|
// checks if it should be using the new or legacy ACL system.
|
|
|
|
aclModeCheckMaxInterval = 30 * time.Second
|
2019-01-22 18:14:43 +00:00
|
|
|
|
|
|
|
// Maximum number of re-resolution requests to be made if the token is modified between
|
|
|
|
// resolving the token and resolving its policies that would remove one of its policies.
|
|
|
|
tokenPolicyResolutionMaxRetries = 5
|
2019-04-15 20:43:19 +00:00
|
|
|
|
|
|
|
// Maximum number of re-resolution requests to be made if the token is modified between
|
|
|
|
// resolving the token and resolving its roles that would remove one of its roles.
|
|
|
|
tokenRoleResolutionMaxRetries = 5
|
2014-08-08 22:32:43 +00:00
|
|
|
)
|
|
|
|
|
2019-12-18 18:46:53 +00:00
|
|
|
// missingIdentity is used to return some identity in the event that the real identity cannot be ascertained
|
|
|
|
type missingIdentity struct {
|
|
|
|
reason string
|
|
|
|
token string
|
|
|
|
}
|
|
|
|
|
|
|
|
func (id *missingIdentity) ID() string {
|
|
|
|
return id.reason
|
|
|
|
}
|
|
|
|
|
|
|
|
func (id *missingIdentity) SecretToken() string {
|
|
|
|
return id.token
|
|
|
|
}
|
|
|
|
|
|
|
|
func (id *missingIdentity) PolicyIDs() []string {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (id *missingIdentity) RoleIDs() []string {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (id *missingIdentity) EmbeddedPolicy() *structs.ACLPolicy {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (id *missingIdentity) ServiceIdentityList() []*structs.ACLServiceIdentity {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2020-06-16 16:54:27 +00:00
|
|
|
func (id *missingIdentity) NodeIdentityList() []*structs.ACLNodeIdentity {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2019-12-18 18:46:53 +00:00
|
|
|
func (id *missingIdentity) IsExpired(asOf time.Time) bool {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
2020-03-10 16:15:22 +00:00
|
|
|
func (id *missingIdentity) IsLocal() bool {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
2019-12-18 18:46:53 +00:00
|
|
|
func (id *missingIdentity) EnterpriseMetadata() *structs.EnterpriseMeta {
|
|
|
|
return structs.DefaultEnterpriseMeta()
|
|
|
|
}
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
func minTTL(a time.Duration, b time.Duration) time.Duration {
|
|
|
|
if a < b {
|
|
|
|
return a
|
|
|
|
}
|
|
|
|
return b
|
2014-08-08 22:32:43 +00:00
|
|
|
}
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
type ACLRemoteError struct {
|
|
|
|
Err error
|
|
|
|
}
|
2014-08-12 17:38:57 +00:00
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
func (e ACLRemoteError) Error() string {
|
|
|
|
return fmt.Sprintf("Error communicating with the ACL Datacenter: %v", e.Err)
|
|
|
|
}
|
2014-08-12 17:38:57 +00:00
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
func IsACLRemoteError(err error) bool {
|
|
|
|
_, ok := err.(ACLRemoteError)
|
|
|
|
return ok
|
2014-08-08 22:32:43 +00:00
|
|
|
}
|
|
|
|
|
2019-10-25 17:05:43 +00:00
|
|
|
func tokenSecretCacheID(token string) string {
|
|
|
|
return "token-secret:" + token
|
|
|
|
}
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
type ACLResolverDelegate interface {
|
|
|
|
ACLDatacenter(legacy bool) string
|
|
|
|
UseLegacyACLs() bool
|
|
|
|
ResolveIdentityFromToken(token string) (bool, structs.ACLIdentity, error)
|
|
|
|
ResolvePolicyFromID(policyID string) (bool, *structs.ACLPolicy, error)
|
2019-04-15 20:43:19 +00:00
|
|
|
ResolveRoleFromID(roleID string) (bool, *structs.ACLRole, error)
|
2018-10-19 16:04:07 +00:00
|
|
|
RPC(method string, args interface{}, reply interface{}) error
|
2019-10-25 15:06:16 +00:00
|
|
|
EnterpriseACLResolverDelegate
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
2014-08-08 22:32:43 +00:00
|
|
|
|
2019-04-15 20:43:19 +00:00
|
|
|
type policyOrRoleTokenError struct {
|
2019-01-22 18:14:43 +00:00
|
|
|
Err error
|
|
|
|
token string
|
|
|
|
}
|
|
|
|
|
2019-04-15 20:43:19 +00:00
|
|
|
func (e policyOrRoleTokenError) Error() string {
|
2019-01-22 18:14:43 +00:00
|
|
|
return e.Err.Error()
|
|
|
|
}
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
// ACLResolverConfig holds all the configuration necessary to create an ACLResolver
|
|
|
|
type ACLResolverConfig struct {
|
|
|
|
Config *Config
|
2020-01-28 23:50:41 +00:00
|
|
|
Logger hclog.Logger
|
2018-10-19 16:04:07 +00:00
|
|
|
|
|
|
|
// CacheConfig is a pass through configuration for ACL cache limits
|
|
|
|
CacheConfig *structs.ACLCachesConfig
|
|
|
|
|
|
|
|
// Delegate that implements some helper functionality that is server/client specific
|
|
|
|
Delegate ACLResolverDelegate
|
2015-06-18 23:18:10 +00:00
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
// AutoDisable indicates that RPC responses should be checked and if they indicate ACLs are disabled
|
|
|
|
// remotely then disable them locally as well. This is particularly useful for the client agent
|
|
|
|
// so that it can detect when the servers have gotten ACLs enabled.
|
|
|
|
AutoDisable bool
|
|
|
|
|
2020-01-13 20:51:40 +00:00
|
|
|
// ACLConfig is the configuration necessary to pass through to the acl package when creating authorizers
|
|
|
|
// and when authorizing access
|
|
|
|
ACLConfig *acl.Config
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// ACLResolver is the type to handle all your token and policy resolution needs.
|
|
|
|
//
|
|
|
|
// Supports:
|
|
|
|
// - Resolving tokens locally via the ACLResolverDelegate
|
|
|
|
// - Resolving policies locally via the ACLResolverDelegate
|
2019-04-15 20:43:19 +00:00
|
|
|
// - Resolving roles locally via the ACLResolverDelegate
|
2020-01-27 19:54:32 +00:00
|
|
|
// - Resolving legacy tokens remotely via an ACL.GetPolicy RPC
|
2018-10-19 16:04:07 +00:00
|
|
|
// - Resolving tokens remotely via an ACL.TokenRead RPC
|
|
|
|
// - Resolving policies remotely via an ACL.PolicyResolve RPC
|
2019-04-15 20:43:19 +00:00
|
|
|
// - Resolving roles remotely via an ACL.RoleResolve RPC
|
2018-10-19 16:04:07 +00:00
|
|
|
//
|
|
|
|
// Remote Resolution:
|
2019-04-08 18:19:09 +00:00
|
|
|
// Remote resolution can be done synchronously or asynchronously depending
|
2018-10-19 16:04:07 +00:00
|
|
|
// on the ACLDownPolicy in the Config passed to the resolver.
|
|
|
|
//
|
|
|
|
// When the down policy is set to async-cache and we have already cached values
|
|
|
|
// then go routines will be spawned to perform the RPCs in the background
|
2019-03-14 14:35:34 +00:00
|
|
|
// and then will update the cache with either the positive or negative result.
|
2018-10-19 16:04:07 +00:00
|
|
|
//
|
2019-04-15 20:43:19 +00:00
|
|
|
// When the down policy is set to extend-cache or the token/policy/role is not already
|
2018-10-19 16:04:07 +00:00
|
|
|
// cached then the same go routines are spawned to do the RPCs in the background.
|
|
|
|
// However in this mode channels are created to receive the results of the RPC
|
|
|
|
// and are registered with the resolver. Those channels are immediately read/blocked
|
|
|
|
// upon.
|
|
|
|
//
|
|
|
|
type ACLResolver struct {
|
2015-06-18 23:18:10 +00:00
|
|
|
config *Config
|
2020-01-28 23:50:41 +00:00
|
|
|
logger hclog.Logger
|
2015-06-18 23:18:10 +00:00
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
delegate ACLResolverDelegate
|
2020-01-13 20:51:40 +00:00
|
|
|
aclConf *acl.Config
|
2017-09-14 19:31:01 +00:00
|
|
|
|
2019-03-14 14:35:34 +00:00
|
|
|
cache *structs.ACLCaches
|
|
|
|
identityGroup singleflight.Group
|
|
|
|
policyGroup singleflight.Group
|
2019-04-15 20:43:19 +00:00
|
|
|
roleGroup singleflight.Group
|
2019-03-14 14:35:34 +00:00
|
|
|
legacyGroup singleflight.Group
|
2016-08-04 00:01:32 +00:00
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
down acl.Authorizer
|
2018-06-28 07:06:14 +00:00
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
autoDisable bool
|
|
|
|
disabled time.Time
|
|
|
|
disabledLock sync.RWMutex
|
2015-06-18 23:18:10 +00:00
|
|
|
}
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
func NewACLResolver(config *ACLResolverConfig) (*ACLResolver, error) {
|
|
|
|
if config == nil {
|
|
|
|
return nil, fmt.Errorf("ACL Resolver must be initialized with a config")
|
2015-06-18 23:18:10 +00:00
|
|
|
}
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
if config.Config == nil {
|
|
|
|
return nil, fmt.Errorf("ACLResolverConfig.Config must not be nil")
|
2015-06-18 23:18:10 +00:00
|
|
|
}
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
if config.Delegate == nil {
|
|
|
|
return nil, fmt.Errorf("ACL Resolver must be initialized with a valid delegate")
|
2015-06-18 23:18:10 +00:00
|
|
|
}
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
if config.Logger == nil {
|
2020-01-28 23:50:41 +00:00
|
|
|
config.Logger = hclog.New(&hclog.LoggerOptions{})
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
2018-06-28 07:06:14 +00:00
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
cache, err := structs.NewACLCaches(config.CacheConfig)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
2014-08-08 22:32:43 +00:00
|
|
|
}
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
var down acl.Authorizer
|
|
|
|
switch config.Config.ACLDownPolicy {
|
|
|
|
case "allow":
|
|
|
|
down = acl.AllowAll()
|
|
|
|
case "deny":
|
|
|
|
down = acl.DenyAll()
|
|
|
|
case "async-cache", "extend-cache":
|
|
|
|
// Leave the down policy as nil to signal this.
|
|
|
|
default:
|
|
|
|
return nil, fmt.Errorf("invalid ACL down policy %q", config.Config.ACLDownPolicy)
|
2014-08-08 22:32:43 +00:00
|
|
|
}
|
2018-10-19 16:04:07 +00:00
|
|
|
|
|
|
|
return &ACLResolver{
|
2019-03-14 14:35:34 +00:00
|
|
|
config: config.Config,
|
2020-01-28 23:50:41 +00:00
|
|
|
logger: config.Logger.Named(logging.ACL),
|
2019-03-14 14:35:34 +00:00
|
|
|
delegate: config.Delegate,
|
2020-01-13 20:51:40 +00:00
|
|
|
aclConf: config.ACLConfig,
|
2019-03-14 14:35:34 +00:00
|
|
|
cache: cache,
|
|
|
|
autoDisable: config.AutoDisable,
|
|
|
|
down: down,
|
2018-10-19 16:04:07 +00:00
|
|
|
}, nil
|
2018-06-28 07:06:14 +00:00
|
|
|
}
|
2014-08-08 22:32:43 +00:00
|
|
|
|
2019-12-06 19:01:34 +00:00
|
|
|
func (r *ACLResolver) Close() {
|
2020-01-13 20:51:40 +00:00
|
|
|
r.aclConf.Close()
|
2019-12-06 19:01:34 +00:00
|
|
|
}
|
|
|
|
|
2019-03-14 14:35:34 +00:00
|
|
|
func (r *ACLResolver) fetchAndCacheTokenLegacy(token string, cached *structs.AuthorizerCacheEntry) (acl.Authorizer, error) {
|
2018-10-19 16:04:07 +00:00
|
|
|
req := structs.ACLPolicyResolveLegacyRequest{
|
|
|
|
Datacenter: r.delegate.ACLDatacenter(true),
|
|
|
|
ACL: token,
|
2014-08-08 22:52:52 +00:00
|
|
|
}
|
2018-10-19 16:04:07 +00:00
|
|
|
|
|
|
|
cacheTTL := r.config.ACLTokenTTL
|
2014-08-18 22:20:21 +00:00
|
|
|
if cached != nil {
|
2018-10-19 16:04:07 +00:00
|
|
|
cacheTTL = cached.TTL
|
2014-08-18 22:20:21 +00:00
|
|
|
}
|
2018-10-19 16:04:07 +00:00
|
|
|
|
|
|
|
var reply structs.ACLPolicyResolveLegacyResponse
|
|
|
|
err := r.delegate.RPC("ACL.GetPolicy", &req, &reply)
|
2014-08-08 22:52:52 +00:00
|
|
|
if err == nil {
|
2018-10-19 16:04:07 +00:00
|
|
|
parent := acl.RootAuthorizer(reply.Parent)
|
|
|
|
if parent == nil {
|
2019-03-14 14:35:34 +00:00
|
|
|
var authorizer acl.Authorizer
|
|
|
|
if cached != nil {
|
|
|
|
authorizer = cached.Authorizer
|
|
|
|
}
|
|
|
|
r.cache.PutAuthorizerWithTTL(token, authorizer, cacheTTL)
|
|
|
|
return authorizer, acl.ErrInvalidParent
|
2018-06-28 07:06:14 +00:00
|
|
|
}
|
2018-10-19 16:04:07 +00:00
|
|
|
|
|
|
|
var policies []*acl.Policy
|
|
|
|
policy := reply.Policy
|
|
|
|
if policy != nil {
|
|
|
|
policies = append(policies, policy.ConvertFromLegacy())
|
|
|
|
}
|
|
|
|
|
2020-01-13 20:51:40 +00:00
|
|
|
authorizer, err := acl.NewPolicyAuthorizerWithDefaults(parent, policies, r.aclConf)
|
2019-03-14 14:35:34 +00:00
|
|
|
|
|
|
|
r.cache.PutAuthorizerWithTTL(token, authorizer, reply.TTL)
|
|
|
|
return authorizer, err
|
2014-08-08 22:52:52 +00:00
|
|
|
}
|
|
|
|
|
2017-08-23 14:52:48 +00:00
|
|
|
if acl.IsErrNotFound(err) {
|
2018-10-19 16:04:07 +00:00
|
|
|
// Make sure to remove from the cache if it was deleted
|
2019-03-14 14:35:34 +00:00
|
|
|
r.cache.PutAuthorizerWithTTL(token, nil, cacheTTL)
|
|
|
|
return nil, acl.ErrNotFound
|
|
|
|
|
2014-08-08 22:52:52 +00:00
|
|
|
}
|
2014-08-08 22:32:43 +00:00
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
// some other RPC error
|
|
|
|
switch r.config.ACLDownPolicy {
|
2014-08-08 22:32:43 +00:00
|
|
|
case "allow":
|
2019-03-14 14:35:34 +00:00
|
|
|
r.cache.PutAuthorizerWithTTL(token, acl.AllowAll(), cacheTTL)
|
|
|
|
return acl.AllowAll(), nil
|
2018-07-02 15:39:34 +00:00
|
|
|
case "async-cache", "extend-cache":
|
2014-08-08 22:32:43 +00:00
|
|
|
if cached != nil {
|
2019-03-14 14:35:34 +00:00
|
|
|
r.cache.PutAuthorizerWithTTL(token, cached.Authorizer, cacheTTL)
|
|
|
|
return cached.Authorizer, nil
|
2014-08-08 22:32:43 +00:00
|
|
|
}
|
|
|
|
fallthrough
|
|
|
|
default:
|
2019-03-14 14:35:34 +00:00
|
|
|
r.cache.PutAuthorizerWithTTL(token, acl.DenyAll(), cacheTTL)
|
|
|
|
return acl.DenyAll(), nil
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-12-18 18:46:53 +00:00
|
|
|
func (r *ACLResolver) resolveTokenLegacy(token string) (structs.ACLIdentity, acl.Authorizer, error) {
|
2018-10-19 16:04:07 +00:00
|
|
|
defer metrics.MeasureSince([]string{"acl", "resolveTokenLegacy"}, time.Now())
|
|
|
|
|
|
|
|
// Attempt to resolve locally first (local results are not cached)
|
|
|
|
// This is only useful for servers where either legacy replication is being
|
|
|
|
// done or the server is within the primary datacenter.
|
|
|
|
if done, identity, err := r.delegate.ResolveIdentityFromToken(token); done {
|
|
|
|
if err == nil && identity != nil {
|
|
|
|
policies, err := r.resolvePoliciesForIdentity(identity)
|
|
|
|
if err != nil {
|
2019-12-18 18:46:53 +00:00
|
|
|
return identity, nil, err
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
2020-01-13 20:51:40 +00:00
|
|
|
authz, err := policies.Compile(r.cache, r.aclConf)
|
2019-10-25 15:06:16 +00:00
|
|
|
if err != nil {
|
2019-12-18 18:46:53 +00:00
|
|
|
return identity, nil, err
|
2019-10-25 15:06:16 +00:00
|
|
|
}
|
|
|
|
|
2019-12-18 18:46:53 +00:00
|
|
|
return identity, acl.NewChainedAuthorizer([]acl.Authorizer{authz, acl.RootAuthorizer(r.config.ACLDefaultPolicy)}), nil
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
2019-12-18 18:46:53 +00:00
|
|
|
return nil, nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
identity := &missingIdentity{
|
|
|
|
reason: "legacy-token",
|
|
|
|
token: token,
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Look in the cache prior to making a RPC request
|
|
|
|
entry := r.cache.GetAuthorizer(token)
|
|
|
|
|
|
|
|
if entry != nil && entry.Age() <= minTTL(entry.TTL, r.config.ACLTokenTTL) {
|
|
|
|
metrics.IncrCounter([]string{"acl", "token", "cache_hit"}, 1)
|
|
|
|
if entry.Authorizer != nil {
|
2019-12-18 18:46:53 +00:00
|
|
|
return identity, entry.Authorizer, nil
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
2019-12-18 18:46:53 +00:00
|
|
|
return identity, nil, acl.ErrNotFound
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
metrics.IncrCounter([]string{"acl", "token", "cache_miss"}, 1)
|
|
|
|
|
|
|
|
// Resolve the token in the background and wait on the result if we must
|
2019-03-14 14:35:34 +00:00
|
|
|
waitChan := r.legacyGroup.DoChan(token, func() (interface{}, error) {
|
|
|
|
authorizer, err := r.fetchAndCacheTokenLegacy(token, entry)
|
|
|
|
return authorizer, err
|
|
|
|
})
|
2018-10-19 16:04:07 +00:00
|
|
|
|
2019-03-14 14:35:34 +00:00
|
|
|
waitForResult := entry == nil || r.config.ACLDownPolicy != "async-cache"
|
2018-10-19 16:04:07 +00:00
|
|
|
if !waitForResult {
|
|
|
|
// waitForResult being false requires the cacheEntry to not be nil
|
|
|
|
if entry.Authorizer != nil {
|
2019-12-18 18:46:53 +00:00
|
|
|
return identity, entry.Authorizer, nil
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
2019-12-18 18:46:53 +00:00
|
|
|
return identity, nil, acl.ErrNotFound
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// block waiting for the async RPC to finish.
|
|
|
|
res := <-waitChan
|
|
|
|
|
2019-03-14 14:35:34 +00:00
|
|
|
var authorizer acl.Authorizer
|
|
|
|
if res.Val != nil { // avoid a nil-not-nil bug
|
|
|
|
authorizer = res.Val.(acl.Authorizer)
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
2019-03-14 14:35:34 +00:00
|
|
|
|
2019-12-18 18:46:53 +00:00
|
|
|
return identity, authorizer, res.Err
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
2019-03-14 14:35:34 +00:00
|
|
|
func (r *ACLResolver) fetchAndCacheIdentityFromToken(token string, cached *structs.IdentityCacheEntry) (structs.ACLIdentity, error) {
|
2019-10-25 17:05:43 +00:00
|
|
|
cacheID := tokenSecretCacheID(token)
|
|
|
|
|
2018-10-31 20:00:46 +00:00
|
|
|
req := structs.ACLTokenGetRequest{
|
2018-10-19 16:04:07 +00:00
|
|
|
Datacenter: r.delegate.ACLDatacenter(false),
|
|
|
|
TokenID: token,
|
|
|
|
TokenIDType: structs.ACLTokenSecret,
|
|
|
|
QueryOptions: structs.QueryOptions{
|
|
|
|
Token: token,
|
|
|
|
AllowStale: true,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
var resp structs.ACLTokenResponse
|
|
|
|
err := r.delegate.RPC("ACL.TokenRead", &req, &resp)
|
|
|
|
if err == nil {
|
|
|
|
if resp.Token == nil {
|
2019-10-25 17:05:43 +00:00
|
|
|
r.cache.PutIdentity(cacheID, nil)
|
2019-03-14 14:35:34 +00:00
|
|
|
return nil, acl.ErrNotFound
|
2020-06-09 19:13:09 +00:00
|
|
|
} else if resp.Token.Local && r.config.Datacenter != resp.SourceDatacenter {
|
|
|
|
r.cache.PutIdentity(cacheID, nil)
|
|
|
|
return nil, acl.PermissionDeniedError{Cause: fmt.Sprintf("This is a local token in datacenter %q", resp.SourceDatacenter)}
|
2018-10-19 16:04:07 +00:00
|
|
|
} else {
|
2019-10-25 17:05:43 +00:00
|
|
|
r.cache.PutIdentity(cacheID, resp.Token)
|
2019-03-14 14:35:34 +00:00
|
|
|
return resp.Token, nil
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if acl.IsErrNotFound(err) {
|
|
|
|
// Make sure to remove from the cache if it was deleted
|
2019-10-25 17:05:43 +00:00
|
|
|
r.cache.PutIdentity(cacheID, nil)
|
2019-03-14 14:35:34 +00:00
|
|
|
return nil, acl.ErrNotFound
|
|
|
|
|
2018-06-28 07:06:14 +00:00
|
|
|
}
|
2018-10-19 16:04:07 +00:00
|
|
|
|
|
|
|
// some other RPC error
|
|
|
|
if cached != nil && (r.config.ACLDownPolicy == "extend-cache" || r.config.ACLDownPolicy == "async-cache") {
|
|
|
|
// extend the cache
|
2019-10-25 17:05:43 +00:00
|
|
|
r.cache.PutIdentity(cacheID, cached.Identity)
|
2019-03-14 14:35:34 +00:00
|
|
|
return cached.Identity, nil
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
2019-10-25 17:05:43 +00:00
|
|
|
r.cache.PutIdentity(cacheID, nil)
|
2019-03-14 14:35:34 +00:00
|
|
|
return nil, err
|
2018-06-28 07:06:14 +00:00
|
|
|
}
|
|
|
|
|
2020-01-27 19:54:32 +00:00
|
|
|
// resolveIdentityFromToken takes a token secret as a string and returns an ACLIdentity.
|
|
|
|
// We read the value from ACLResolver's cache if available, and if the read misses
|
|
|
|
// we initiate an RPC for the value.
|
2018-10-19 16:04:07 +00:00
|
|
|
func (r *ACLResolver) resolveIdentityFromToken(token string) (structs.ACLIdentity, error) {
|
|
|
|
// Attempt to resolve locally first (local results are not cached)
|
|
|
|
if done, identity, err := r.delegate.ResolveIdentityFromToken(token); done {
|
|
|
|
return identity, err
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check the cache before making any RPC requests
|
2019-10-25 17:05:43 +00:00
|
|
|
cacheEntry := r.cache.GetIdentity(tokenSecretCacheID(token))
|
2018-10-19 16:04:07 +00:00
|
|
|
if cacheEntry != nil && cacheEntry.Age() <= r.config.ACLTokenTTL {
|
|
|
|
metrics.IncrCounter([]string{"acl", "token", "cache_hit"}, 1)
|
|
|
|
return cacheEntry.Identity, nil
|
2018-06-28 07:06:14 +00:00
|
|
|
}
|
2018-10-19 16:04:07 +00:00
|
|
|
|
|
|
|
metrics.IncrCounter([]string{"acl", "token", "cache_miss"}, 1)
|
|
|
|
|
|
|
|
// Background a RPC request and wait on it if we must
|
2019-03-14 14:35:34 +00:00
|
|
|
waitChan := r.identityGroup.DoChan(token, func() (interface{}, error) {
|
|
|
|
identity, err := r.fetchAndCacheIdentityFromToken(token, cacheEntry)
|
|
|
|
return identity, err
|
|
|
|
})
|
2018-10-19 16:04:07 +00:00
|
|
|
|
|
|
|
waitForResult := cacheEntry == nil || r.config.ACLDownPolicy != "async-cache"
|
|
|
|
if !waitForResult {
|
|
|
|
// waitForResult being false requires the cacheEntry to not be nil
|
|
|
|
return cacheEntry.Identity, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// block on the read here, this is why we don't need chan buffering
|
|
|
|
res := <-waitChan
|
|
|
|
|
2019-03-14 14:35:34 +00:00
|
|
|
var identity structs.ACLIdentity
|
|
|
|
if res.Val != nil { // avoid a nil-not-nil bug
|
|
|
|
identity = res.Val.(structs.ACLIdentity)
|
2018-06-28 07:06:14 +00:00
|
|
|
}
|
2018-10-19 16:04:07 +00:00
|
|
|
|
2019-03-14 14:35:34 +00:00
|
|
|
if res.Err != nil && !acl.IsErrNotFound(res.Err) {
|
|
|
|
return identity, ACLRemoteError{Err: res.Err}
|
2014-08-08 22:32:43 +00:00
|
|
|
}
|
2019-03-14 14:35:34 +00:00
|
|
|
return identity, res.Err
|
2014-08-08 22:32:43 +00:00
|
|
|
}
|
2014-08-09 00:38:39 +00:00
|
|
|
|
2019-03-14 14:35:34 +00:00
|
|
|
func (r *ACLResolver) fetchAndCachePoliciesForIdentity(identity structs.ACLIdentity, policyIDs []string, cached map[string]*structs.PolicyCacheEntry) (map[string]*structs.ACLPolicy, error) {
|
2018-10-31 20:00:46 +00:00
|
|
|
req := structs.ACLPolicyBatchGetRequest{
|
2018-10-19 16:04:07 +00:00
|
|
|
Datacenter: r.delegate.ACLDatacenter(false),
|
|
|
|
PolicyIDs: policyIDs,
|
|
|
|
QueryOptions: structs.QueryOptions{
|
|
|
|
Token: identity.SecretToken(),
|
|
|
|
AllowStale: true,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
2018-10-31 20:00:46 +00:00
|
|
|
var resp structs.ACLPolicyBatchResponse
|
2018-10-19 16:04:07 +00:00
|
|
|
err := r.delegate.RPC("ACL.PolicyResolve", &req, &resp)
|
|
|
|
if err == nil {
|
2019-03-14 14:35:34 +00:00
|
|
|
out := make(map[string]*structs.ACLPolicy)
|
2018-10-19 16:04:07 +00:00
|
|
|
for _, policy := range resp.Policies {
|
2019-03-14 14:35:34 +00:00
|
|
|
out[policy.ID] = policy
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
for _, policyID := range policyIDs {
|
2019-03-14 14:35:34 +00:00
|
|
|
if policy, ok := out[policyID]; ok {
|
|
|
|
r.cache.PutPolicy(policyID, policy)
|
|
|
|
} else {
|
|
|
|
r.cache.PutPolicy(policyID, nil)
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
2014-08-09 00:38:39 +00:00
|
|
|
}
|
2019-03-14 14:35:34 +00:00
|
|
|
return out, nil
|
2014-08-09 00:38:39 +00:00
|
|
|
}
|
|
|
|
|
2019-04-26 17:49:28 +00:00
|
|
|
if handledErr := r.maybeHandleIdentityErrorDuringFetch(identity, err); handledErr != nil {
|
|
|
|
return nil, handledErr
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// other RPC error - use cache if available
|
|
|
|
|
|
|
|
extendCache := r.config.ACLDownPolicy == "extend-cache" || r.config.ACLDownPolicy == "async-cache"
|
2019-03-14 14:35:34 +00:00
|
|
|
|
|
|
|
out := make(map[string]*structs.ACLPolicy)
|
|
|
|
insufficientCache := false
|
2018-10-19 16:04:07 +00:00
|
|
|
for _, policyID := range policyIDs {
|
|
|
|
if entry, ok := cached[policyID]; extendCache && ok {
|
2019-03-14 14:35:34 +00:00
|
|
|
r.cache.PutPolicy(policyID, entry.Policy)
|
|
|
|
if entry.Policy != nil {
|
|
|
|
out[policyID] = entry.Policy
|
|
|
|
}
|
2018-10-19 16:04:07 +00:00
|
|
|
} else {
|
2019-03-14 14:35:34 +00:00
|
|
|
r.cache.PutPolicy(policyID, nil)
|
|
|
|
insufficientCache = true
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
}
|
2019-03-14 14:35:34 +00:00
|
|
|
if insufficientCache {
|
|
|
|
return nil, ACLRemoteError{Err: err}
|
|
|
|
}
|
|
|
|
return out, nil
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
2019-04-15 20:43:19 +00:00
|
|
|
func (r *ACLResolver) fetchAndCacheRolesForIdentity(identity structs.ACLIdentity, roleIDs []string, cached map[string]*structs.RoleCacheEntry) (map[string]*structs.ACLRole, error) {
|
|
|
|
req := structs.ACLRoleBatchGetRequest{
|
|
|
|
Datacenter: r.delegate.ACLDatacenter(false),
|
|
|
|
RoleIDs: roleIDs,
|
|
|
|
QueryOptions: structs.QueryOptions{
|
|
|
|
Token: identity.SecretToken(),
|
|
|
|
AllowStale: true,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
var resp structs.ACLRoleBatchResponse
|
|
|
|
err := r.delegate.RPC("ACL.RoleResolve", &req, &resp)
|
|
|
|
if err == nil {
|
|
|
|
out := make(map[string]*structs.ACLRole)
|
|
|
|
for _, role := range resp.Roles {
|
|
|
|
out[role.ID] = role
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, roleID := range roleIDs {
|
|
|
|
if role, ok := out[roleID]; ok {
|
|
|
|
r.cache.PutRole(roleID, role)
|
|
|
|
} else {
|
|
|
|
r.cache.PutRole(roleID, nil)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return out, nil
|
|
|
|
}
|
|
|
|
|
2019-04-26 17:49:28 +00:00
|
|
|
if handledErr := r.maybeHandleIdentityErrorDuringFetch(identity, err); handledErr != nil {
|
|
|
|
return nil, handledErr
|
2019-04-15 20:43:19 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// other RPC error - use cache if available
|
|
|
|
|
|
|
|
extendCache := r.config.ACLDownPolicy == "extend-cache" || r.config.ACLDownPolicy == "async-cache"
|
|
|
|
|
|
|
|
out := make(map[string]*structs.ACLRole)
|
|
|
|
insufficientCache := false
|
|
|
|
for _, roleID := range roleIDs {
|
|
|
|
if entry, ok := cached[roleID]; extendCache && ok {
|
|
|
|
r.cache.PutRole(roleID, entry.Role)
|
|
|
|
if entry.Role != nil {
|
|
|
|
out[roleID] = entry.Role
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
r.cache.PutRole(roleID, nil)
|
|
|
|
insufficientCache = true
|
|
|
|
}
|
|
|
|
}
|
2019-04-26 17:49:28 +00:00
|
|
|
|
2019-04-15 20:43:19 +00:00
|
|
|
if insufficientCache {
|
|
|
|
return nil, ACLRemoteError{Err: err}
|
|
|
|
}
|
2019-04-26 17:49:28 +00:00
|
|
|
|
2019-04-15 20:43:19 +00:00
|
|
|
return out, nil
|
|
|
|
}
|
|
|
|
|
2019-04-26 17:49:28 +00:00
|
|
|
func (r *ACLResolver) maybeHandleIdentityErrorDuringFetch(identity structs.ACLIdentity, err error) error {
|
|
|
|
if acl.IsErrNotFound(err) {
|
|
|
|
// make sure to indicate that this identity is no longer valid within
|
|
|
|
// the cache
|
2019-10-25 17:05:43 +00:00
|
|
|
r.cache.PutIdentity(tokenSecretCacheID(identity.SecretToken()), nil)
|
2019-04-26 17:49:28 +00:00
|
|
|
|
|
|
|
// Do not touch the cache. Getting a top level ACL not found error
|
|
|
|
// only indicates that the secret token used in the request
|
|
|
|
// no longer exists
|
|
|
|
return &policyOrRoleTokenError{acl.ErrNotFound, identity.SecretToken()}
|
|
|
|
}
|
|
|
|
|
|
|
|
if acl.IsErrPermissionDenied(err) {
|
|
|
|
// invalidate our ID cache so that identity resolution will take place
|
|
|
|
// again in the future
|
2019-10-25 17:05:43 +00:00
|
|
|
r.cache.RemoveIdentity(tokenSecretCacheID(identity.SecretToken()))
|
2019-04-26 17:49:28 +00:00
|
|
|
|
|
|
|
// Do not remove from the cache for permission denied
|
|
|
|
// what this does indicate is that our view of the token is out of date
|
|
|
|
return &policyOrRoleTokenError{acl.ErrPermissionDenied, identity.SecretToken()}
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
func (r *ACLResolver) filterPoliciesByScope(policies structs.ACLPolicies) structs.ACLPolicies {
|
|
|
|
var out structs.ACLPolicies
|
|
|
|
for _, policy := range policies {
|
|
|
|
if len(policy.Datacenters) == 0 {
|
|
|
|
out = append(out, policy)
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, dc := range policy.Datacenters {
|
|
|
|
if dc == r.config.Datacenter {
|
|
|
|
out = append(out, policy)
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return out
|
|
|
|
}
|
|
|
|
|
|
|
|
func (r *ACLResolver) resolvePoliciesForIdentity(identity structs.ACLIdentity) (structs.ACLPolicies, error) {
|
|
|
|
policyIDs := identity.PolicyIDs()
|
2019-04-15 20:43:19 +00:00
|
|
|
roleIDs := identity.RoleIDs()
|
2019-04-08 18:19:09 +00:00
|
|
|
serviceIdentities := identity.ServiceIdentityList()
|
2020-06-16 16:54:27 +00:00
|
|
|
nodeIdentities := identity.NodeIdentityList()
|
2019-04-08 18:19:09 +00:00
|
|
|
|
2020-06-16 16:54:27 +00:00
|
|
|
if len(policyIDs) == 0 && len(serviceIdentities) == 0 && len(roleIDs) == 0 && len(nodeIdentities) == 0 {
|
2018-10-19 16:04:07 +00:00
|
|
|
policy := identity.EmbeddedPolicy()
|
|
|
|
if policy != nil {
|
|
|
|
return []*structs.ACLPolicy{policy}, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// In this case the default policy will be all that is in effect.
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
|
2019-04-15 20:43:19 +00:00
|
|
|
// Collect all of the roles tied to this token.
|
|
|
|
roles, err := r.collectRolesForIdentity(identity, roleIDs)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
// Merge the policies and service identities across Token and Role fields.
|
|
|
|
for _, role := range roles {
|
|
|
|
for _, link := range role.Policies {
|
|
|
|
policyIDs = append(policyIDs, link.ID)
|
|
|
|
}
|
|
|
|
serviceIdentities = append(serviceIdentities, role.ServiceIdentities...)
|
2020-06-16 16:54:27 +00:00
|
|
|
nodeIdentities = append(nodeIdentities, role.NodeIdentityList()...)
|
2019-04-15 20:43:19 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Now deduplicate any policies or service identities that occur more than once.
|
|
|
|
policyIDs = dedupeStringSlice(policyIDs)
|
|
|
|
serviceIdentities = dedupeServiceIdentities(serviceIdentities)
|
2020-06-16 16:54:27 +00:00
|
|
|
nodeIdentities = dedupeNodeIdentities(nodeIdentities)
|
2019-04-15 20:43:19 +00:00
|
|
|
|
|
|
|
// Generate synthetic policies for all service identities in effect.
|
2019-10-24 18:38:09 +00:00
|
|
|
syntheticPolicies := r.synthesizePoliciesForServiceIdentities(serviceIdentities, identity.EnterpriseMetadata())
|
2020-06-16 16:54:27 +00:00
|
|
|
syntheticPolicies = append(syntheticPolicies, r.synthesizePoliciesForNodeIdentities(nodeIdentities)...)
|
2019-04-08 18:19:09 +00:00
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
// For the new ACLs policy replication is mandatory for correct operation on servers. Therefore
|
|
|
|
// we only attempt to resolve policies locally
|
2019-04-08 18:19:09 +00:00
|
|
|
policies, err := r.collectPoliciesForIdentity(identity, policyIDs, len(syntheticPolicies))
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
policies = append(policies, syntheticPolicies...)
|
|
|
|
filtered := r.filterPoliciesByScope(policies)
|
|
|
|
return filtered, nil
|
|
|
|
}
|
|
|
|
|
2019-10-24 18:38:09 +00:00
|
|
|
func (r *ACLResolver) synthesizePoliciesForServiceIdentities(serviceIdentities []*structs.ACLServiceIdentity, entMeta *structs.EnterpriseMeta) []*structs.ACLPolicy {
|
2019-04-08 18:19:09 +00:00
|
|
|
if len(serviceIdentities) == 0 {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
syntheticPolicies := make([]*structs.ACLPolicy, 0, len(serviceIdentities))
|
|
|
|
for _, s := range serviceIdentities {
|
2019-10-24 18:38:09 +00:00
|
|
|
syntheticPolicies = append(syntheticPolicies, s.SyntheticPolicy(entMeta))
|
2019-04-08 18:19:09 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return syntheticPolicies
|
|
|
|
}
|
|
|
|
|
2020-06-16 16:54:27 +00:00
|
|
|
func (r *ACLResolver) synthesizePoliciesForNodeIdentities(nodeIdentities []*structs.ACLNodeIdentity) []*structs.ACLPolicy {
|
|
|
|
if len(nodeIdentities) == 0 {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
syntheticPolicies := make([]*structs.ACLPolicy, 0, len(nodeIdentities))
|
|
|
|
for _, n := range nodeIdentities {
|
|
|
|
syntheticPolicies = append(syntheticPolicies, n.SyntheticPolicy())
|
|
|
|
}
|
|
|
|
|
|
|
|
return syntheticPolicies
|
|
|
|
}
|
|
|
|
|
2019-04-08 18:19:09 +00:00
|
|
|
func dedupeServiceIdentities(in []*structs.ACLServiceIdentity) []*structs.ACLServiceIdentity {
|
|
|
|
// From: https://github.com/golang/go/wiki/SliceTricks#in-place-deduplicate-comparable
|
|
|
|
|
|
|
|
if len(in) <= 1 {
|
|
|
|
return in
|
|
|
|
}
|
|
|
|
|
|
|
|
sort.Slice(in, func(i, j int) bool {
|
|
|
|
return in[i].ServiceName < in[j].ServiceName
|
|
|
|
})
|
|
|
|
|
|
|
|
j := 0
|
|
|
|
for i := 1; i < len(in); i++ {
|
|
|
|
if in[j].ServiceName == in[i].ServiceName {
|
|
|
|
// Prefer increasing scope.
|
|
|
|
if len(in[j].Datacenters) == 0 || len(in[i].Datacenters) == 0 {
|
|
|
|
in[j].Datacenters = nil
|
|
|
|
} else {
|
|
|
|
in[j].Datacenters = mergeStringSlice(in[j].Datacenters, in[i].Datacenters)
|
|
|
|
}
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
j++
|
|
|
|
in[j] = in[i]
|
|
|
|
}
|
|
|
|
|
|
|
|
// Discard the skipped items.
|
|
|
|
for i := j + 1; i < len(in); i++ {
|
|
|
|
in[i] = nil
|
|
|
|
}
|
|
|
|
|
|
|
|
return in[:j+1]
|
|
|
|
}
|
|
|
|
|
2020-06-16 16:54:27 +00:00
|
|
|
func dedupeNodeIdentities(in []*structs.ACLNodeIdentity) []*structs.ACLNodeIdentity {
|
|
|
|
// From: https://github.com/golang/go/wiki/SliceTricks#in-place-deduplicate-comparable
|
|
|
|
|
|
|
|
if len(in) <= 1 {
|
|
|
|
return in
|
|
|
|
}
|
|
|
|
|
|
|
|
sort.Slice(in, func(i, j int) bool {
|
|
|
|
if in[i].NodeName < in[j].NodeName {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
|
|
|
return in[i].Datacenter < in[j].Datacenter
|
|
|
|
})
|
|
|
|
|
|
|
|
j := 0
|
|
|
|
for i := 1; i < len(in); i++ {
|
|
|
|
if in[j].NodeName == in[i].NodeName && in[j].Datacenter == in[i].Datacenter {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
j++
|
|
|
|
in[j] = in[i]
|
|
|
|
}
|
|
|
|
|
|
|
|
// Discard the skipped items.
|
|
|
|
for i := j + 1; i < len(in); i++ {
|
|
|
|
in[i] = nil
|
|
|
|
}
|
|
|
|
|
|
|
|
return in[:j+1]
|
|
|
|
}
|
|
|
|
|
2019-04-08 18:19:09 +00:00
|
|
|
func mergeStringSlice(a, b []string) []string {
|
|
|
|
out := make([]string, 0, len(a)+len(b))
|
|
|
|
out = append(out, a...)
|
|
|
|
out = append(out, b...)
|
|
|
|
return dedupeStringSlice(out)
|
|
|
|
}
|
|
|
|
|
|
|
|
func dedupeStringSlice(in []string) []string {
|
|
|
|
// From: https://github.com/golang/go/wiki/SliceTricks#in-place-deduplicate-comparable
|
|
|
|
|
2019-04-15 20:43:19 +00:00
|
|
|
if len(in) <= 1 {
|
|
|
|
return in
|
|
|
|
}
|
|
|
|
|
2019-04-08 18:19:09 +00:00
|
|
|
sort.Strings(in)
|
|
|
|
|
|
|
|
j := 0
|
|
|
|
for i := 1; i < len(in); i++ {
|
|
|
|
if in[j] == in[i] {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
j++
|
|
|
|
in[j] = in[i]
|
|
|
|
}
|
|
|
|
|
|
|
|
return in[:j+1]
|
|
|
|
}
|
|
|
|
|
|
|
|
func (r *ACLResolver) collectPoliciesForIdentity(identity structs.ACLIdentity, policyIDs []string, extraCap int) ([]*structs.ACLPolicy, error) {
|
|
|
|
policies := make([]*structs.ACLPolicy, 0, len(policyIDs)+extraCap)
|
2018-10-19 16:04:07 +00:00
|
|
|
|
|
|
|
// Get all associated policies
|
|
|
|
var missing []string
|
|
|
|
var expired []*structs.ACLPolicy
|
|
|
|
expCacheMap := make(map[string]*structs.PolicyCacheEntry)
|
|
|
|
|
2020-01-27 19:54:32 +00:00
|
|
|
var accessorID string
|
|
|
|
if identity != nil {
|
|
|
|
accessorID = identity.ID()
|
|
|
|
}
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
for _, policyID := range policyIDs {
|
|
|
|
if done, policy, err := r.delegate.ResolvePolicyFromID(policyID); done {
|
|
|
|
if err != nil && !acl.IsErrNotFound(err) {
|
2014-08-12 17:54:56 +00:00
|
|
|
return nil, err
|
|
|
|
}
|
2018-10-19 16:04:07 +00:00
|
|
|
|
|
|
|
if policy != nil {
|
|
|
|
policies = append(policies, policy)
|
|
|
|
} else {
|
2020-01-28 23:50:41 +00:00
|
|
|
r.logger.Warn("policy not found for identity",
|
|
|
|
"policy", policyID,
|
2020-01-29 17:16:08 +00:00
|
|
|
"accessorID", accessorID,
|
|
|
|
)
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
// create the missing list which we can execute an RPC to get all the missing policies at once
|
|
|
|
entry := r.cache.GetPolicy(policyID)
|
|
|
|
if entry == nil {
|
|
|
|
missing = append(missing, policyID)
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
if entry.Policy == nil {
|
2019-04-15 20:43:19 +00:00
|
|
|
// this happens when we cache a negative response for the policy's existence
|
2018-10-19 16:04:07 +00:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
if entry.Age() >= r.config.ACLPolicyTTL {
|
|
|
|
expired = append(expired, entry.Policy)
|
|
|
|
expCacheMap[policyID] = entry
|
|
|
|
} else {
|
|
|
|
policies = append(policies, entry.Policy)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Hot-path if we have no missing or expired policies
|
|
|
|
if len(missing)+len(expired) == 0 {
|
2019-04-08 18:19:09 +00:00
|
|
|
return policies, nil
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
2019-03-14 14:35:34 +00:00
|
|
|
hasMissing := len(missing) > 0
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
fetchIDs := missing
|
|
|
|
for _, policy := range expired {
|
|
|
|
fetchIDs = append(fetchIDs, policy.ID)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Background a RPC request and wait on it if we must
|
2019-03-14 14:35:34 +00:00
|
|
|
waitChan := r.policyGroup.DoChan(identity.SecretToken(), func() (interface{}, error) {
|
|
|
|
policies, err := r.fetchAndCachePoliciesForIdentity(identity, fetchIDs, expCacheMap)
|
|
|
|
return policies, err
|
|
|
|
})
|
2014-08-09 00:38:39 +00:00
|
|
|
|
2019-03-14 14:35:34 +00:00
|
|
|
waitForResult := hasMissing || r.config.ACLDownPolicy != "async-cache"
|
2018-10-19 16:04:07 +00:00
|
|
|
if !waitForResult {
|
|
|
|
// waitForResult being false requires that all the policies were cached already
|
|
|
|
policies = append(policies, expired...)
|
2019-04-08 18:19:09 +00:00
|
|
|
return policies, nil
|
2014-08-09 00:38:39 +00:00
|
|
|
}
|
|
|
|
|
2019-03-14 14:35:34 +00:00
|
|
|
res := <-waitChan
|
2018-10-19 16:04:07 +00:00
|
|
|
|
2019-03-14 14:35:34 +00:00
|
|
|
if res.Err != nil {
|
|
|
|
return nil, res.Err
|
|
|
|
}
|
2018-10-19 16:04:07 +00:00
|
|
|
|
2019-03-14 14:35:34 +00:00
|
|
|
if res.Val != nil {
|
|
|
|
foundPolicies := res.Val.(map[string]*structs.ACLPolicy)
|
2019-01-22 18:14:43 +00:00
|
|
|
|
2019-03-14 14:35:34 +00:00
|
|
|
for _, policy := range foundPolicies {
|
|
|
|
policies = append(policies, policy)
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
2014-08-09 00:38:39 +00:00
|
|
|
}
|
2018-10-19 16:04:07 +00:00
|
|
|
|
2019-04-08 18:19:09 +00:00
|
|
|
return policies, nil
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
2019-04-15 20:43:19 +00:00
|
|
|
func (r *ACLResolver) resolveRolesForIdentity(identity structs.ACLIdentity) (structs.ACLRoles, error) {
|
|
|
|
return r.collectRolesForIdentity(identity, identity.RoleIDs())
|
|
|
|
}
|
|
|
|
|
|
|
|
func (r *ACLResolver) collectRolesForIdentity(identity structs.ACLIdentity, roleIDs []string) (structs.ACLRoles, error) {
|
|
|
|
if len(roleIDs) == 0 {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// For the new ACLs policy & role replication is mandatory for correct operation
|
|
|
|
// on servers. Therefore we only attempt to resolve roles locally
|
|
|
|
roles := make([]*structs.ACLRole, 0, len(roleIDs))
|
|
|
|
|
|
|
|
var missing []string
|
|
|
|
var expired []*structs.ACLRole
|
|
|
|
expCacheMap := make(map[string]*structs.RoleCacheEntry)
|
|
|
|
|
|
|
|
for _, roleID := range roleIDs {
|
|
|
|
if done, role, err := r.delegate.ResolveRoleFromID(roleID); done {
|
|
|
|
if err != nil && !acl.IsErrNotFound(err) {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
if role != nil {
|
|
|
|
roles = append(roles, role)
|
|
|
|
} else {
|
2020-01-27 19:54:32 +00:00
|
|
|
var accessorID string
|
|
|
|
if identity != nil {
|
|
|
|
accessorID = identity.ID()
|
|
|
|
}
|
2020-01-28 23:50:41 +00:00
|
|
|
r.logger.Warn("role not found for identity",
|
|
|
|
"role", roleID,
|
|
|
|
"accessorID", accessorID,
|
|
|
|
)
|
2019-04-15 20:43:19 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
// create the missing list which we can execute an RPC to get all the missing roles at once
|
|
|
|
entry := r.cache.GetRole(roleID)
|
|
|
|
if entry == nil {
|
|
|
|
missing = append(missing, roleID)
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
if entry.Role == nil {
|
|
|
|
// this happens when we cache a negative response for the role's existence
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
if entry.Age() >= r.config.ACLRoleTTL {
|
|
|
|
expired = append(expired, entry.Role)
|
|
|
|
expCacheMap[roleID] = entry
|
|
|
|
} else {
|
|
|
|
roles = append(roles, entry.Role)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Hot-path if we have no missing or expired roles
|
|
|
|
if len(missing)+len(expired) == 0 {
|
|
|
|
return roles, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
hasMissing := len(missing) > 0
|
|
|
|
|
|
|
|
fetchIDs := missing
|
|
|
|
for _, role := range expired {
|
|
|
|
fetchIDs = append(fetchIDs, role.ID)
|
|
|
|
}
|
|
|
|
|
|
|
|
waitChan := r.roleGroup.DoChan(identity.SecretToken(), func() (interface{}, error) {
|
|
|
|
roles, err := r.fetchAndCacheRolesForIdentity(identity, fetchIDs, expCacheMap)
|
|
|
|
return roles, err
|
|
|
|
})
|
|
|
|
|
|
|
|
waitForResult := hasMissing || r.config.ACLDownPolicy != "async-cache"
|
|
|
|
if !waitForResult {
|
|
|
|
// waitForResult being false requires that all the roles were cached already
|
|
|
|
roles = append(roles, expired...)
|
|
|
|
return roles, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
res := <-waitChan
|
|
|
|
|
|
|
|
if res.Err != nil {
|
|
|
|
return nil, res.Err
|
|
|
|
}
|
|
|
|
|
|
|
|
if res.Val != nil {
|
|
|
|
foundRoles := res.Val.(map[string]*structs.ACLRole)
|
|
|
|
|
|
|
|
for _, role := range foundRoles {
|
|
|
|
roles = append(roles, role)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return roles, nil
|
|
|
|
}
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
func (r *ACLResolver) resolveTokenToPolicies(token string) (structs.ACLPolicies, error) {
|
2019-01-22 18:14:43 +00:00
|
|
|
_, policies, err := r.resolveTokenToIdentityAndPolicies(token)
|
|
|
|
return policies, err
|
|
|
|
}
|
|
|
|
|
|
|
|
func (r *ACLResolver) resolveTokenToIdentityAndPolicies(token string) (structs.ACLIdentity, structs.ACLPolicies, error) {
|
|
|
|
var lastErr error
|
|
|
|
var lastIdentity structs.ACLIdentity
|
|
|
|
|
|
|
|
for i := 0; i < tokenPolicyResolutionMaxRetries; i++ {
|
|
|
|
// Resolve the token to an ACLIdentity
|
|
|
|
identity, err := r.resolveIdentityFromToken(token)
|
|
|
|
if err != nil {
|
|
|
|
return nil, nil, err
|
|
|
|
} else if identity == nil {
|
|
|
|
return nil, nil, acl.ErrNotFound
|
2019-04-08 17:05:51 +00:00
|
|
|
} else if identity.IsExpired(time.Now()) {
|
|
|
|
return nil, nil, acl.ErrNotFound
|
2019-01-22 18:14:43 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
lastIdentity = identity
|
|
|
|
|
|
|
|
policies, err := r.resolvePoliciesForIdentity(identity)
|
|
|
|
if err == nil {
|
|
|
|
return identity, policies, nil
|
|
|
|
}
|
|
|
|
lastErr = err
|
|
|
|
|
2019-04-15 20:43:19 +00:00
|
|
|
if tokenErr, ok := err.(*policyOrRoleTokenError); ok {
|
2019-01-22 18:14:43 +00:00
|
|
|
if acl.IsErrNotFound(err) && tokenErr.token == identity.SecretToken() {
|
|
|
|
// token was deleted while resolving policies
|
|
|
|
return nil, nil, acl.ErrNotFound
|
|
|
|
}
|
|
|
|
|
2019-04-15 20:43:19 +00:00
|
|
|
// other types of policyOrRoleTokenErrors should cause retrying the whole token
|
|
|
|
// resolution process
|
|
|
|
} else {
|
|
|
|
return identity, nil, err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return lastIdentity, nil, lastErr
|
|
|
|
}
|
|
|
|
|
|
|
|
func (r *ACLResolver) resolveTokenToIdentityAndRoles(token string) (structs.ACLIdentity, structs.ACLRoles, error) {
|
|
|
|
var lastErr error
|
|
|
|
var lastIdentity structs.ACLIdentity
|
|
|
|
|
|
|
|
for i := 0; i < tokenRoleResolutionMaxRetries; i++ {
|
|
|
|
// Resolve the token to an ACLIdentity
|
|
|
|
identity, err := r.resolveIdentityFromToken(token)
|
|
|
|
if err != nil {
|
|
|
|
return nil, nil, err
|
|
|
|
} else if identity == nil {
|
|
|
|
return nil, nil, acl.ErrNotFound
|
|
|
|
} else if identity.IsExpired(time.Now()) {
|
|
|
|
return nil, nil, acl.ErrNotFound
|
|
|
|
}
|
|
|
|
|
|
|
|
lastIdentity = identity
|
|
|
|
|
|
|
|
roles, err := r.resolveRolesForIdentity(identity)
|
|
|
|
if err == nil {
|
|
|
|
return identity, roles, nil
|
|
|
|
}
|
|
|
|
lastErr = err
|
|
|
|
|
|
|
|
if tokenErr, ok := err.(*policyOrRoleTokenError); ok {
|
|
|
|
if acl.IsErrNotFound(err) && tokenErr.token == identity.SecretToken() {
|
|
|
|
// token was deleted while resolving roles
|
|
|
|
return nil, nil, acl.ErrNotFound
|
|
|
|
}
|
|
|
|
|
|
|
|
// other types of policyOrRoleTokenErrors should cause retrying the whole token
|
2019-01-22 18:14:43 +00:00
|
|
|
// resolution process
|
|
|
|
} else {
|
|
|
|
return identity, nil, err
|
|
|
|
}
|
2014-08-09 00:38:39 +00:00
|
|
|
}
|
2018-10-19 16:04:07 +00:00
|
|
|
|
2019-01-22 18:14:43 +00:00
|
|
|
return lastIdentity, nil, lastErr
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
func (r *ACLResolver) disableACLsWhenUpstreamDisabled(err error) error {
|
|
|
|
if !r.autoDisable || err == nil || !acl.IsErrDisabled(err) {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2020-01-28 23:50:41 +00:00
|
|
|
r.logger.Debug("ACLs disabled on upstream servers, will retry", "retry_interval", r.config.ACLDisabledTTL)
|
2018-10-19 16:04:07 +00:00
|
|
|
r.disabledLock.Lock()
|
|
|
|
r.disabled = time.Now().Add(r.config.ACLDisabledTTL)
|
|
|
|
r.disabledLock.Unlock()
|
|
|
|
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2019-12-18 18:46:53 +00:00
|
|
|
func (r *ACLResolver) ResolveTokenToIdentityAndAuthorizer(token string) (structs.ACLIdentity, acl.Authorizer, error) {
|
2018-10-19 16:04:07 +00:00
|
|
|
if !r.ACLsEnabled() {
|
2019-12-18 18:46:53 +00:00
|
|
|
return nil, nil, nil
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if acl.RootAuthorizer(token) != nil {
|
2019-12-18 18:46:53 +00:00
|
|
|
return nil, nil, acl.ErrRootDenied
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// handle the anonymous token
|
|
|
|
if token == "" {
|
|
|
|
token = anonymousToken
|
|
|
|
}
|
|
|
|
|
|
|
|
if r.delegate.UseLegacyACLs() {
|
2019-12-18 18:46:53 +00:00
|
|
|
identity, authorizer, err := r.resolveTokenLegacy(token)
|
|
|
|
return identity, authorizer, r.disableACLsWhenUpstreamDisabled(err)
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
defer metrics.MeasureSince([]string{"acl", "ResolveToken"}, time.Now())
|
|
|
|
|
2019-10-25 15:06:16 +00:00
|
|
|
identity, policies, err := r.resolveTokenToIdentityAndPolicies(token)
|
2018-10-19 16:04:07 +00:00
|
|
|
if err != nil {
|
|
|
|
r.disableACLsWhenUpstreamDisabled(err)
|
|
|
|
if IsACLRemoteError(err) {
|
2020-01-28 23:50:41 +00:00
|
|
|
r.logger.Error("Error resolving token", "error", err)
|
2019-12-18 18:46:53 +00:00
|
|
|
return &missingIdentity{reason: "primary-dc-down", token: token}, r.down, nil
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
2019-12-18 18:46:53 +00:00
|
|
|
return nil, nil, err
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Build the Authorizer
|
2019-10-25 15:06:16 +00:00
|
|
|
var chain []acl.Authorizer
|
|
|
|
|
2020-01-13 20:51:40 +00:00
|
|
|
authz, err := policies.Compile(r.cache, r.aclConf)
|
2019-10-25 15:06:16 +00:00
|
|
|
if err != nil {
|
2019-12-18 18:46:53 +00:00
|
|
|
return nil, nil, err
|
2019-10-25 15:06:16 +00:00
|
|
|
}
|
|
|
|
chain = append(chain, authz)
|
|
|
|
|
|
|
|
authz, err = r.resolveEnterpriseDefaultsForIdentity(identity)
|
|
|
|
if err != nil {
|
|
|
|
if IsACLRemoteError(err) {
|
2020-01-28 23:50:41 +00:00
|
|
|
r.logger.Error("Error resolving identity defaults", "error", err)
|
2019-12-18 18:46:53 +00:00
|
|
|
return identity, r.down, nil
|
2019-10-25 15:06:16 +00:00
|
|
|
}
|
2019-12-18 18:46:53 +00:00
|
|
|
return nil, nil, err
|
2019-10-25 15:06:16 +00:00
|
|
|
} else if authz != nil {
|
|
|
|
chain = append(chain, authz)
|
|
|
|
}
|
2018-10-19 16:04:07 +00:00
|
|
|
|
2019-10-25 15:06:16 +00:00
|
|
|
chain = append(chain, acl.RootAuthorizer(r.config.ACLDefaultPolicy))
|
2019-12-18 18:46:53 +00:00
|
|
|
return identity, acl.NewChainedAuthorizer(chain), nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (r *ACLResolver) ResolveToken(token string) (acl.Authorizer, error) {
|
|
|
|
_, authz, err := r.ResolveTokenToIdentityAndAuthorizer(token)
|
|
|
|
return authz, err
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
2020-05-13 17:00:08 +00:00
|
|
|
func (r *ACLResolver) ResolveTokenToIdentity(token string) (structs.ACLIdentity, error) {
|
|
|
|
if !r.ACLsEnabled() {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
if acl.RootAuthorizer(token) != nil {
|
|
|
|
return nil, acl.ErrRootDenied
|
|
|
|
}
|
|
|
|
|
|
|
|
// handle the anonymous token
|
|
|
|
if token == "" {
|
|
|
|
token = anonymousToken
|
|
|
|
}
|
|
|
|
|
|
|
|
if r.delegate.UseLegacyACLs() {
|
|
|
|
identity, _, err := r.resolveTokenLegacy(token)
|
|
|
|
return identity, r.disableACLsWhenUpstreamDisabled(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
defer metrics.MeasureSince([]string{"acl", "ResolveTokenToIdentity"}, time.Now())
|
|
|
|
|
|
|
|
return r.resolveIdentityFromToken(token)
|
|
|
|
}
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
func (r *ACLResolver) ACLsEnabled() bool {
|
|
|
|
// Whether we desire ACLs to be enabled according to configuration
|
2020-07-03 20:52:08 +00:00
|
|
|
if !r.config.ACLsEnabled {
|
2018-10-19 16:04:07 +00:00
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
if r.autoDisable {
|
|
|
|
// Whether ACLs are disabled according to RPCs failing with a ACLs Disabled error
|
|
|
|
r.disabledLock.RLock()
|
|
|
|
defer r.disabledLock.RUnlock()
|
|
|
|
return !time.Now().Before(r.disabled)
|
|
|
|
}
|
|
|
|
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
2020-06-03 15:22:22 +00:00
|
|
|
func (r *ACLResolver) GetMergedPolicyForToken(token string) (structs.ACLIdentity, *acl.Policy, error) {
|
|
|
|
ident, policies, err := r.resolveTokenToIdentityAndPolicies(token)
|
2018-10-19 16:04:07 +00:00
|
|
|
if err != nil {
|
2020-06-03 15:22:22 +00:00
|
|
|
return nil, nil, err
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
if len(policies) == 0 {
|
2020-06-03 15:22:22 +00:00
|
|
|
return nil, nil, acl.ErrNotFound
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
|
|
|
|
2020-06-03 15:22:22 +00:00
|
|
|
policy, err := policies.Merge(r.cache, r.aclConf)
|
|
|
|
return ident, policy, err
|
2014-08-09 00:38:39 +00:00
|
|
|
}
|
2015-06-09 19:36:25 +00:00
|
|
|
|
2015-06-11 19:08:21 +00:00
|
|
|
// aclFilter is used to filter results from our state store based on ACL rules
|
|
|
|
// configured for the provided token.
|
|
|
|
type aclFilter struct {
|
2020-05-29 21:16:03 +00:00
|
|
|
authorizer acl.Authorizer
|
|
|
|
logger hclog.Logger
|
2015-06-11 19:08:21 +00:00
|
|
|
}
|
|
|
|
|
2017-04-21 00:02:42 +00:00
|
|
|
// newACLFilter constructs a new aclFilter.
|
2020-05-29 21:16:03 +00:00
|
|
|
func newACLFilter(authorizer acl.Authorizer, logger hclog.Logger) *aclFilter {
|
2015-06-11 21:14:43 +00:00
|
|
|
if logger == nil {
|
2020-01-28 23:50:41 +00:00
|
|
|
logger = hclog.New(&hclog.LoggerOptions{})
|
2015-06-11 21:14:43 +00:00
|
|
|
}
|
2016-12-11 00:00:11 +00:00
|
|
|
return &aclFilter{
|
2020-05-29 21:16:03 +00:00
|
|
|
authorizer: authorizer,
|
|
|
|
logger: logger,
|
2016-12-11 00:00:11 +00:00
|
|
|
}
|
2015-06-11 21:14:43 +00:00
|
|
|
}
|
|
|
|
|
2016-12-11 21:22:14 +00:00
|
|
|
// allowNode is used to determine if a node is accessible for an ACL.
|
2019-12-18 18:43:24 +00:00
|
|
|
func (f *aclFilter) allowNode(node string, ent *acl.AuthorizerContext) bool {
|
2019-10-15 20:58:50 +00:00
|
|
|
return f.authorizer.NodeRead(node, ent) == acl.Allow
|
2016-12-11 21:22:14 +00:00
|
|
|
}
|
|
|
|
|
2020-05-11 17:35:17 +00:00
|
|
|
// allowNode is used to determine if the gateway and service are accessible for an ACL
|
|
|
|
func (f *aclFilter) allowGateway(gs *structs.GatewayService) bool {
|
|
|
|
var authzContext acl.AuthorizerContext
|
|
|
|
|
|
|
|
// Need read on service and gateway. Gateway may have different EnterpriseMeta so we fill authzContext twice
|
|
|
|
gs.Gateway.FillAuthzContext(&authzContext)
|
2020-06-12 14:57:41 +00:00
|
|
|
if !f.allowService(gs.Gateway.Name, &authzContext) {
|
2020-05-11 17:35:17 +00:00
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
gs.Service.FillAuthzContext(&authzContext)
|
2020-06-12 14:57:41 +00:00
|
|
|
if !f.allowService(gs.Service.Name, &authzContext) {
|
2020-05-11 17:35:17 +00:00
|
|
|
return false
|
|
|
|
}
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
2016-12-11 21:22:14 +00:00
|
|
|
// allowService is used to determine if a service is accessible for an ACL.
|
2019-12-18 18:43:24 +00:00
|
|
|
func (f *aclFilter) allowService(service string, ent *acl.AuthorizerContext) bool {
|
2017-03-23 23:10:50 +00:00
|
|
|
if service == "" {
|
2015-06-11 19:08:21 +00:00
|
|
|
return true
|
2015-06-09 19:36:25 +00:00
|
|
|
}
|
2017-03-23 23:10:50 +00:00
|
|
|
|
2019-10-15 20:58:50 +00:00
|
|
|
return f.authorizer.ServiceRead(service, ent) == acl.Allow
|
2015-06-11 19:08:21 +00:00
|
|
|
}
|
2015-06-09 19:36:25 +00:00
|
|
|
|
2016-12-13 05:59:22 +00:00
|
|
|
// allowSession is used to determine if a session for a node is accessible for
|
|
|
|
// an ACL.
|
2019-12-18 18:43:24 +00:00
|
|
|
func (f *aclFilter) allowSession(node string, ent *acl.AuthorizerContext) bool {
|
2019-10-15 20:58:50 +00:00
|
|
|
return f.authorizer.SessionRead(node, ent) == acl.Allow
|
2016-12-13 05:59:22 +00:00
|
|
|
}
|
|
|
|
|
2015-06-11 19:08:21 +00:00
|
|
|
// filterHealthChecks is used to filter a set of health checks down based on
|
|
|
|
// the configured ACL rules for a token.
|
|
|
|
func (f *aclFilter) filterHealthChecks(checks *structs.HealthChecks) {
|
|
|
|
hc := *checks
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
|
2015-06-11 19:08:21 +00:00
|
|
|
for i := 0; i < len(hc); i++ {
|
|
|
|
check := hc[i]
|
2019-12-10 02:26:41 +00:00
|
|
|
check.FillAuthzContext(&authzContext)
|
|
|
|
if f.allowNode(check.Node, &authzContext) && f.allowService(check.ServiceName, &authzContext) {
|
2015-06-11 19:08:21 +00:00
|
|
|
continue
|
|
|
|
}
|
2019-12-10 02:26:41 +00:00
|
|
|
|
2020-01-28 23:50:41 +00:00
|
|
|
f.logger.Debug("dropping check from result due to ACLs", "check", check.CheckID)
|
2015-06-11 19:08:21 +00:00
|
|
|
hc = append(hc[:i], hc[i+1:]...)
|
|
|
|
i--
|
2015-06-09 19:36:25 +00:00
|
|
|
}
|
2015-06-11 19:08:21 +00:00
|
|
|
*checks = hc
|
|
|
|
}
|
2015-06-09 19:36:25 +00:00
|
|
|
|
2015-06-11 19:08:21 +00:00
|
|
|
// filterServices is used to filter a set of services based on ACLs.
|
2019-12-10 02:26:41 +00:00
|
|
|
func (f *aclFilter) filterServices(services structs.Services, entMeta *structs.EnterpriseMeta) {
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
entMeta.FillAuthzContext(&authzContext)
|
|
|
|
|
2017-04-20 18:42:22 +00:00
|
|
|
for svc := range services {
|
2019-12-10 02:26:41 +00:00
|
|
|
if f.allowService(svc, &authzContext) {
|
2015-06-11 19:08:21 +00:00
|
|
|
continue
|
2015-06-09 19:36:25 +00:00
|
|
|
}
|
2020-01-28 23:50:41 +00:00
|
|
|
f.logger.Debug("dropping service from result due to ACLs", "service", svc)
|
2015-06-11 19:08:21 +00:00
|
|
|
delete(services, svc)
|
|
|
|
}
|
|
|
|
}
|
2015-06-09 19:36:25 +00:00
|
|
|
|
2015-06-11 19:08:21 +00:00
|
|
|
// filterServiceNodes is used to filter a set of nodes for a given service
|
|
|
|
// based on the configured ACL rules.
|
|
|
|
func (f *aclFilter) filterServiceNodes(nodes *structs.ServiceNodes) {
|
|
|
|
sn := *nodes
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
|
2015-06-11 19:08:21 +00:00
|
|
|
for i := 0; i < len(sn); i++ {
|
|
|
|
node := sn[i]
|
2019-12-10 02:26:41 +00:00
|
|
|
|
|
|
|
node.FillAuthzContext(&authzContext)
|
|
|
|
if f.allowNode(node.Node, &authzContext) && f.allowService(node.ServiceName, &authzContext) {
|
2015-06-11 19:08:21 +00:00
|
|
|
continue
|
2015-06-09 19:36:25 +00:00
|
|
|
}
|
2020-01-28 23:50:41 +00:00
|
|
|
f.logger.Debug("dropping node from result due to ACLs", "node", node.Node)
|
2015-06-11 19:08:21 +00:00
|
|
|
sn = append(sn[:i], sn[i+1:]...)
|
|
|
|
i--
|
2015-06-09 19:36:25 +00:00
|
|
|
}
|
2015-06-11 19:08:21 +00:00
|
|
|
*nodes = sn
|
|
|
|
}
|
2015-06-09 19:36:25 +00:00
|
|
|
|
2015-06-11 19:08:21 +00:00
|
|
|
// filterNodeServices is used to filter services on a given node base on ACLs.
|
2016-12-13 00:53:31 +00:00
|
|
|
func (f *aclFilter) filterNodeServices(services **structs.NodeServices) {
|
|
|
|
if *services == nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
structs.WildcardEnterpriseMeta().FillAuthzContext(&authzContext)
|
|
|
|
if !f.allowNode((*services).Node.Node, &authzContext) {
|
2016-12-13 00:53:31 +00:00
|
|
|
*services = nil
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2019-12-10 02:26:41 +00:00
|
|
|
for svcName, svc := range (*services).Services {
|
|
|
|
svc.FillAuthzContext(&authzContext)
|
|
|
|
|
|
|
|
if f.allowNode((*services).Node.Node, &authzContext) && f.allowService(svcName, &authzContext) {
|
2015-06-11 19:08:21 +00:00
|
|
|
continue
|
2015-06-09 19:36:25 +00:00
|
|
|
}
|
2020-01-28 23:50:41 +00:00
|
|
|
f.logger.Debug("dropping service from result due to ACLs", "service", svc.CompoundServiceID())
|
2019-12-10 02:26:41 +00:00
|
|
|
delete((*services).Services, svcName)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// filterNodeServices is used to filter services on a given node base on ACLs.
|
|
|
|
func (f *aclFilter) filterNodeServiceList(services **structs.NodeServiceList) {
|
|
|
|
if services == nil || *services == nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
structs.WildcardEnterpriseMeta().FillAuthzContext(&authzContext)
|
|
|
|
if !f.allowNode((*services).Node.Node, &authzContext) {
|
|
|
|
*services = nil
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
svcs := (*services).Services
|
|
|
|
modified := false
|
|
|
|
for i := 0; i < len(svcs); i++ {
|
|
|
|
svc := svcs[i]
|
|
|
|
svc.FillAuthzContext(&authzContext)
|
|
|
|
|
|
|
|
if f.allowNode((*services).Node.Node, &authzContext) && f.allowService(svc.Service, &authzContext) {
|
|
|
|
continue
|
|
|
|
}
|
2020-01-28 23:50:41 +00:00
|
|
|
f.logger.Debug("dropping service from result due to ACLs", "service", svc.CompoundServiceID())
|
2019-12-10 02:26:41 +00:00
|
|
|
svcs = append(svcs[:i], svcs[i+1:]...)
|
|
|
|
i--
|
|
|
|
modified = true
|
|
|
|
}
|
|
|
|
|
|
|
|
if modified {
|
|
|
|
*services = &structs.NodeServiceList{
|
|
|
|
Node: (*services).Node,
|
|
|
|
Services: svcs,
|
|
|
|
}
|
2015-06-11 19:08:21 +00:00
|
|
|
}
|
|
|
|
}
|
2015-06-09 19:36:25 +00:00
|
|
|
|
2015-06-11 19:08:21 +00:00
|
|
|
// filterCheckServiceNodes is used to filter nodes based on ACL rules.
|
|
|
|
func (f *aclFilter) filterCheckServiceNodes(nodes *structs.CheckServiceNodes) {
|
|
|
|
csn := *nodes
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
|
2015-06-11 19:08:21 +00:00
|
|
|
for i := 0; i < len(csn); i++ {
|
|
|
|
node := csn[i]
|
2019-12-10 02:26:41 +00:00
|
|
|
node.Service.FillAuthzContext(&authzContext)
|
|
|
|
if f.allowNode(node.Node.Node, &authzContext) && f.allowService(node.Service.Service, &authzContext) {
|
2015-06-11 19:08:21 +00:00
|
|
|
continue
|
2015-06-09 19:36:25 +00:00
|
|
|
}
|
2020-01-28 23:50:41 +00:00
|
|
|
f.logger.Debug("dropping node from result due to ACLs", "node", node.Node.Node)
|
2015-06-11 19:08:21 +00:00
|
|
|
csn = append(csn[:i], csn[i+1:]...)
|
|
|
|
i--
|
|
|
|
}
|
|
|
|
*nodes = csn
|
|
|
|
}
|
2015-06-09 19:36:25 +00:00
|
|
|
|
2020-03-09 20:59:02 +00:00
|
|
|
// filterDatacenterCheckServiceNodes is used to filter nodes based on ACL rules.
|
|
|
|
func (f *aclFilter) filterDatacenterCheckServiceNodes(datacenterNodes *map[string]structs.CheckServiceNodes) {
|
|
|
|
dn := *datacenterNodes
|
|
|
|
out := make(map[string]structs.CheckServiceNodes)
|
2020-06-16 17:19:31 +00:00
|
|
|
for dc := range dn {
|
2020-03-09 20:59:02 +00:00
|
|
|
nodes := dn[dc]
|
|
|
|
f.filterCheckServiceNodes(&nodes)
|
|
|
|
if len(nodes) > 0 {
|
|
|
|
out[dc] = nodes
|
|
|
|
}
|
|
|
|
}
|
|
|
|
*datacenterNodes = out
|
|
|
|
}
|
|
|
|
|
2016-12-13 05:59:22 +00:00
|
|
|
// filterSessions is used to filter a set of sessions based on ACLs.
|
|
|
|
func (f *aclFilter) filterSessions(sessions *structs.Sessions) {
|
|
|
|
s := *sessions
|
|
|
|
for i := 0; i < len(s); i++ {
|
|
|
|
session := s[i]
|
2019-12-06 19:01:34 +00:00
|
|
|
|
2019-12-18 18:43:24 +00:00
|
|
|
var entCtx acl.AuthorizerContext
|
2019-12-06 19:01:34 +00:00
|
|
|
session.FillAuthzContext(&entCtx)
|
|
|
|
|
|
|
|
if f.allowSession(session.Node, &entCtx) {
|
2016-12-13 05:59:22 +00:00
|
|
|
continue
|
|
|
|
}
|
2020-01-28 23:50:41 +00:00
|
|
|
f.logger.Debug("dropping session from result due to ACLs", "session", session.ID)
|
2016-12-13 05:59:22 +00:00
|
|
|
s = append(s[:i], s[i+1:]...)
|
|
|
|
i--
|
|
|
|
}
|
|
|
|
*sessions = s
|
|
|
|
}
|
|
|
|
|
2016-12-12 19:58:31 +00:00
|
|
|
// filterCoordinates is used to filter nodes in a coordinate dump based on ACL
|
|
|
|
// rules.
|
|
|
|
func (f *aclFilter) filterCoordinates(coords *structs.Coordinates) {
|
|
|
|
c := *coords
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
structs.WildcardEnterpriseMeta().FillAuthzContext(&authzContext)
|
|
|
|
|
2016-12-12 19:58:31 +00:00
|
|
|
for i := 0; i < len(c); i++ {
|
|
|
|
node := c[i].Node
|
2019-12-10 02:26:41 +00:00
|
|
|
if f.allowNode(node, &authzContext) {
|
2016-12-12 19:58:31 +00:00
|
|
|
continue
|
|
|
|
}
|
2020-01-28 23:50:41 +00:00
|
|
|
f.logger.Debug("dropping node from result due to ACLs", "node", node)
|
2016-12-12 19:58:31 +00:00
|
|
|
c = append(c[:i], c[i+1:]...)
|
|
|
|
i--
|
|
|
|
}
|
|
|
|
*coords = c
|
|
|
|
}
|
|
|
|
|
2018-03-04 19:53:52 +00:00
|
|
|
// filterIntentions is used to filter intentions based on ACL rules.
|
|
|
|
// We prune entries the user doesn't have access to, and we redact any tokens
|
|
|
|
// if the user doesn't have a management token.
|
|
|
|
func (f *aclFilter) filterIntentions(ixns *structs.Intentions) {
|
|
|
|
ret := make(structs.Intentions, 0, len(*ixns))
|
|
|
|
for _, ixn := range *ixns {
|
2020-01-13 20:51:40 +00:00
|
|
|
if !ixn.CanRead(f.authorizer) {
|
2020-01-28 23:50:41 +00:00
|
|
|
f.logger.Debug("dropping intention from result due to ACLs", "intention", ixn.ID)
|
2018-03-04 19:53:52 +00:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = append(ret, ixn)
|
|
|
|
}
|
|
|
|
|
|
|
|
*ixns = ret
|
|
|
|
}
|
|
|
|
|
2015-06-11 19:08:21 +00:00
|
|
|
// filterNodeDump is used to filter through all parts of a node dump and
|
|
|
|
// remove elements the provided ACL token cannot access.
|
|
|
|
func (f *aclFilter) filterNodeDump(dump *structs.NodeDump) {
|
|
|
|
nd := *dump
|
2019-12-10 02:26:41 +00:00
|
|
|
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2015-06-11 19:08:21 +00:00
|
|
|
for i := 0; i < len(nd); i++ {
|
|
|
|
info := nd[i]
|
|
|
|
|
2016-12-13 02:21:00 +00:00
|
|
|
// Filter nodes
|
2019-12-10 02:26:41 +00:00
|
|
|
structs.WildcardEnterpriseMeta().FillAuthzContext(&authzContext)
|
|
|
|
if node := info.Node; !f.allowNode(node, &authzContext) {
|
2020-01-28 23:50:41 +00:00
|
|
|
f.logger.Debug("dropping node from result due to ACLs", "node", node)
|
2016-12-13 02:21:00 +00:00
|
|
|
nd = append(nd[:i], nd[i+1:]...)
|
|
|
|
i--
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
2015-06-11 19:08:21 +00:00
|
|
|
// Filter services
|
2016-12-13 02:21:00 +00:00
|
|
|
for j := 0; j < len(info.Services); j++ {
|
|
|
|
svc := info.Services[j].Service
|
2019-12-10 02:26:41 +00:00
|
|
|
info.Services[j].FillAuthzContext(&authzContext)
|
|
|
|
if f.allowNode(info.Node, &authzContext) && f.allowService(svc, &authzContext) {
|
2015-06-09 19:36:25 +00:00
|
|
|
continue
|
|
|
|
}
|
2020-01-28 23:50:41 +00:00
|
|
|
f.logger.Debug("dropping service from result due to ACLs", "service", svc)
|
2016-12-13 02:21:00 +00:00
|
|
|
info.Services = append(info.Services[:j], info.Services[j+1:]...)
|
|
|
|
j--
|
2015-06-09 19:36:25 +00:00
|
|
|
}
|
|
|
|
|
2015-06-11 19:08:21 +00:00
|
|
|
// Filter checks
|
2016-12-13 02:21:00 +00:00
|
|
|
for j := 0; j < len(info.Checks); j++ {
|
|
|
|
chk := info.Checks[j]
|
2019-12-10 02:26:41 +00:00
|
|
|
chk.FillAuthzContext(&authzContext)
|
|
|
|
if f.allowNode(info.Node, &authzContext) && f.allowService(chk.ServiceName, &authzContext) {
|
2015-06-09 19:36:25 +00:00
|
|
|
continue
|
|
|
|
}
|
2020-01-28 23:50:41 +00:00
|
|
|
f.logger.Debug("dropping check from result due to ACLs", "check", chk.CheckID)
|
2016-12-13 02:21:00 +00:00
|
|
|
info.Checks = append(info.Checks[:j], info.Checks[j+1:]...)
|
|
|
|
j--
|
2015-06-09 19:36:25 +00:00
|
|
|
}
|
2015-06-11 19:08:21 +00:00
|
|
|
}
|
2015-06-11 20:05:33 +00:00
|
|
|
*dump = nd
|
2015-06-11 19:08:21 +00:00
|
|
|
}
|
|
|
|
|
2020-05-11 17:35:17 +00:00
|
|
|
// filterServiceDump is used to filter nodes based on ACL rules.
|
|
|
|
func (f *aclFilter) filterServiceDump(services *structs.ServiceDump) {
|
|
|
|
svcs := *services
|
|
|
|
var authzContext acl.AuthorizerContext
|
|
|
|
|
|
|
|
for i := 0; i < len(svcs); i++ {
|
|
|
|
service := svcs[i]
|
|
|
|
|
|
|
|
if f.allowGateway(service.GatewayService) {
|
|
|
|
// ServiceDump might only have gateway config and no node information
|
|
|
|
if service.Node == nil {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
service.Service.FillAuthzContext(&authzContext)
|
|
|
|
if f.allowNode(service.Node.Node, &authzContext) {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
f.logger.Debug("dropping service from result due to ACLs", "service", service.GatewayService.Service)
|
|
|
|
svcs = append(svcs[:i], svcs[i+1:]...)
|
|
|
|
i--
|
|
|
|
}
|
|
|
|
*services = svcs
|
|
|
|
}
|
|
|
|
|
2016-12-11 00:00:11 +00:00
|
|
|
// filterNodes is used to filter through all parts of a node list and remove
|
|
|
|
// elements the provided ACL token cannot access.
|
|
|
|
func (f *aclFilter) filterNodes(nodes *structs.Nodes) {
|
|
|
|
n := *nodes
|
2019-12-10 02:26:41 +00:00
|
|
|
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
structs.WildcardEnterpriseMeta().FillAuthzContext(&authzContext)
|
|
|
|
|
2016-12-11 00:00:11 +00:00
|
|
|
for i := 0; i < len(n); i++ {
|
|
|
|
node := n[i].Node
|
2019-12-10 02:26:41 +00:00
|
|
|
if f.allowNode(node, &authzContext) {
|
2016-12-11 00:00:11 +00:00
|
|
|
continue
|
|
|
|
}
|
2020-01-28 23:50:41 +00:00
|
|
|
f.logger.Debug("dropping node from result due to ACLs", "node", node)
|
2016-12-11 00:00:11 +00:00
|
|
|
n = append(n[:i], n[i+1:]...)
|
|
|
|
i--
|
|
|
|
}
|
|
|
|
*nodes = n
|
|
|
|
}
|
|
|
|
|
2016-02-26 23:59:00 +00:00
|
|
|
// redactPreparedQueryTokens will redact any tokens unless the client has a
|
|
|
|
// management token. This eases the transition to delegated authority over
|
|
|
|
// prepared queries, since it was easy to capture management tokens in Consul
|
|
|
|
// 0.6.3 and earlier, and we don't want to willy-nilly show those. This does
|
|
|
|
// have the limitation of preventing delegated non-management users from seeing
|
|
|
|
// captured tokens, but they can at least see whether or not a token is set.
|
|
|
|
func (f *aclFilter) redactPreparedQueryTokens(query **structs.PreparedQuery) {
|
|
|
|
// Management tokens can see everything with no filtering.
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
structs.DefaultEnterpriseMeta().FillAuthzContext(&authzContext)
|
|
|
|
if f.authorizer.ACLWrite(&authzContext) == acl.Allow {
|
2016-02-26 23:59:00 +00:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// Let the user see if there's a blank token, otherwise we need
|
|
|
|
// to redact it, since we know they don't have a management
|
|
|
|
// token.
|
|
|
|
if (*query).Token != "" {
|
|
|
|
// Redact the token, using a copy of the query structure
|
|
|
|
// since we could be pointed at a live instance from the
|
|
|
|
// state store so it's not safe to modify it. Note that
|
|
|
|
// this clone will still point to things like underlying
|
|
|
|
// arrays in the original, but for modifying just the
|
|
|
|
// token it will be safe to use.
|
|
|
|
clone := *(*query)
|
|
|
|
clone.Token = redactedToken
|
|
|
|
*query = &clone
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
Creates new "prepared-query" ACL type and new token capture behavior.
Prior to this change, prepared queries had the following behavior for
ACLs, which will need to change to support templates:
1. A management token, or a token with read access to the service being
queried needed to be provided in order to create a prepared query.
2. The token used to create the prepared query was stored with the query
in the state store and used to execute the query.
3. A management token, or the token used to create the query needed to be
supplied to perform and CRUD operations on an existing prepared query.
This was pretty subtle and complicated behavior, and won't work for
templates since the service name is computed at execution time. To solve
this, we introduce a new "prepared-query" ACL type, where the prefix
applies to the query name for static prepared query types and to the
prefix for template prepared query types.
With this change, the new behavior is:
1. A management token, or a token with "prepared-query" write access to
the query name or (soon) the given template prefix is required to do
any CRUD operations on a prepared query, or to list prepared queries
(the list is filtered by this ACL).
2. You will no longer need a management token to list prepared queries,
but you will only be able to see prepared queries that you have access
to (you get an empty list instead of permission denied).
3. When listing or getting a query, because it was easy to capture
management tokens given the past behavior, this will always blank out
the "Token" field (replacing the contents as <hidden>) for all tokens
unless a management token is supplied. Going forward, we should
discourage people from binding tokens for execution unless strictly
necessary.
4. No token will be captured by default when a prepared query is created.
If the user wishes to supply an execution token then can pass it in via
the "Token" field in the prepared query definition. Otherwise, this
field will default to empty.
5. At execution time, we will use the captured token if it exists with the
prepared query definition, otherwise we will use the token that's passed
in with the request, just like we do for other RPCs (or you can use the
agent's configured token for DNS).
6. Prepared queries with no name (accessible only by ID) will not require
ACLs to create or modify (execution time will depend on the service ACL
configuration). Our argument here is that these are designed to be
ephemeral and the IDs are as good as an ACL. Management tokens will be
able to list all of these.
These changes enable templates, but also enable delegation of authority to
manage the prepared query namespace.
2016-02-23 08:12:58 +00:00
|
|
|
// filterPreparedQueries is used to filter prepared queries based on ACL rules.
|
|
|
|
// We prune entries the user doesn't have access to, and we redact any tokens
|
2016-02-26 23:59:00 +00:00
|
|
|
// if the user doesn't have a management token.
|
Creates new "prepared-query" ACL type and new token capture behavior.
Prior to this change, prepared queries had the following behavior for
ACLs, which will need to change to support templates:
1. A management token, or a token with read access to the service being
queried needed to be provided in order to create a prepared query.
2. The token used to create the prepared query was stored with the query
in the state store and used to execute the query.
3. A management token, or the token used to create the query needed to be
supplied to perform and CRUD operations on an existing prepared query.
This was pretty subtle and complicated behavior, and won't work for
templates since the service name is computed at execution time. To solve
this, we introduce a new "prepared-query" ACL type, where the prefix
applies to the query name for static prepared query types and to the
prefix for template prepared query types.
With this change, the new behavior is:
1. A management token, or a token with "prepared-query" write access to
the query name or (soon) the given template prefix is required to do
any CRUD operations on a prepared query, or to list prepared queries
(the list is filtered by this ACL).
2. You will no longer need a management token to list prepared queries,
but you will only be able to see prepared queries that you have access
to (you get an empty list instead of permission denied).
3. When listing or getting a query, because it was easy to capture
management tokens given the past behavior, this will always blank out
the "Token" field (replacing the contents as <hidden>) for all tokens
unless a management token is supplied. Going forward, we should
discourage people from binding tokens for execution unless strictly
necessary.
4. No token will be captured by default when a prepared query is created.
If the user wishes to supply an execution token then can pass it in via
the "Token" field in the prepared query definition. Otherwise, this
field will default to empty.
5. At execution time, we will use the captured token if it exists with the
prepared query definition, otherwise we will use the token that's passed
in with the request, just like we do for other RPCs (or you can use the
agent's configured token for DNS).
6. Prepared queries with no name (accessible only by ID) will not require
ACLs to create or modify (execution time will depend on the service ACL
configuration). Our argument here is that these are designed to be
ephemeral and the IDs are as good as an ACL. Management tokens will be
able to list all of these.
These changes enable templates, but also enable delegation of authority to
manage the prepared query namespace.
2016-02-23 08:12:58 +00:00
|
|
|
func (f *aclFilter) filterPreparedQueries(queries *structs.PreparedQueries) {
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
structs.DefaultEnterpriseMeta().FillAuthzContext(&authzContext)
|
2016-02-24 09:26:16 +00:00
|
|
|
// Management tokens can see everything with no filtering.
|
2019-12-10 02:26:41 +00:00
|
|
|
// TODO is this check even necessary - this looks like a search replace from
|
2019-10-15 20:58:50 +00:00
|
|
|
// the 1.4 ACL rewrite. The global-management token will provide unrestricted query privileges
|
|
|
|
// so asking for ACLWrite should be unnecessary.
|
2019-12-10 02:26:41 +00:00
|
|
|
if f.authorizer.ACLWrite(&authzContext) == acl.Allow {
|
2016-02-24 09:26:16 +00:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// Otherwise, we need to see what the token has access to.
|
Creates new "prepared-query" ACL type and new token capture behavior.
Prior to this change, prepared queries had the following behavior for
ACLs, which will need to change to support templates:
1. A management token, or a token with read access to the service being
queried needed to be provided in order to create a prepared query.
2. The token used to create the prepared query was stored with the query
in the state store and used to execute the query.
3. A management token, or the token used to create the query needed to be
supplied to perform and CRUD operations on an existing prepared query.
This was pretty subtle and complicated behavior, and won't work for
templates since the service name is computed at execution time. To solve
this, we introduce a new "prepared-query" ACL type, where the prefix
applies to the query name for static prepared query types and to the
prefix for template prepared query types.
With this change, the new behavior is:
1. A management token, or a token with "prepared-query" write access to
the query name or (soon) the given template prefix is required to do
any CRUD operations on a prepared query, or to list prepared queries
(the list is filtered by this ACL).
2. You will no longer need a management token to list prepared queries,
but you will only be able to see prepared queries that you have access
to (you get an empty list instead of permission denied).
3. When listing or getting a query, because it was easy to capture
management tokens given the past behavior, this will always blank out
the "Token" field (replacing the contents as <hidden>) for all tokens
unless a management token is supplied. Going forward, we should
discourage people from binding tokens for execution unless strictly
necessary.
4. No token will be captured by default when a prepared query is created.
If the user wishes to supply an execution token then can pass it in via
the "Token" field in the prepared query definition. Otherwise, this
field will default to empty.
5. At execution time, we will use the captured token if it exists with the
prepared query definition, otherwise we will use the token that's passed
in with the request, just like we do for other RPCs (or you can use the
agent's configured token for DNS).
6. Prepared queries with no name (accessible only by ID) will not require
ACLs to create or modify (execution time will depend on the service ACL
configuration). Our argument here is that these are designed to be
ephemeral and the IDs are as good as an ACL. Management tokens will be
able to list all of these.
These changes enable templates, but also enable delegation of authority to
manage the prepared query namespace.
2016-02-23 08:12:58 +00:00
|
|
|
ret := make(structs.PreparedQueries, 0, len(*queries))
|
|
|
|
for _, query := range *queries {
|
2016-02-24 09:26:16 +00:00
|
|
|
// If no prefix ACL applies to this query then filter it, since
|
|
|
|
// we know at this point the user doesn't have a management
|
2016-02-25 00:26:43 +00:00
|
|
|
// token, otherwise see what the policy says.
|
|
|
|
prefix, ok := query.GetACLPrefix()
|
2019-12-10 02:26:41 +00:00
|
|
|
if !ok || f.authorizer.PreparedQueryRead(prefix, &authzContext) != acl.Allow {
|
2020-01-28 23:50:41 +00:00
|
|
|
f.logger.Debug("dropping prepared query from result due to ACLs", "query", query.ID)
|
Creates new "prepared-query" ACL type and new token capture behavior.
Prior to this change, prepared queries had the following behavior for
ACLs, which will need to change to support templates:
1. A management token, or a token with read access to the service being
queried needed to be provided in order to create a prepared query.
2. The token used to create the prepared query was stored with the query
in the state store and used to execute the query.
3. A management token, or the token used to create the query needed to be
supplied to perform and CRUD operations on an existing prepared query.
This was pretty subtle and complicated behavior, and won't work for
templates since the service name is computed at execution time. To solve
this, we introduce a new "prepared-query" ACL type, where the prefix
applies to the query name for static prepared query types and to the
prefix for template prepared query types.
With this change, the new behavior is:
1. A management token, or a token with "prepared-query" write access to
the query name or (soon) the given template prefix is required to do
any CRUD operations on a prepared query, or to list prepared queries
(the list is filtered by this ACL).
2. You will no longer need a management token to list prepared queries,
but you will only be able to see prepared queries that you have access
to (you get an empty list instead of permission denied).
3. When listing or getting a query, because it was easy to capture
management tokens given the past behavior, this will always blank out
the "Token" field (replacing the contents as <hidden>) for all tokens
unless a management token is supplied. Going forward, we should
discourage people from binding tokens for execution unless strictly
necessary.
4. No token will be captured by default when a prepared query is created.
If the user wishes to supply an execution token then can pass it in via
the "Token" field in the prepared query definition. Otherwise, this
field will default to empty.
5. At execution time, we will use the captured token if it exists with the
prepared query definition, otherwise we will use the token that's passed
in with the request, just like we do for other RPCs (or you can use the
agent's configured token for DNS).
6. Prepared queries with no name (accessible only by ID) will not require
ACLs to create or modify (execution time will depend on the service ACL
configuration). Our argument here is that these are designed to be
ephemeral and the IDs are as good as an ACL. Management tokens will be
able to list all of these.
These changes enable templates, but also enable delegation of authority to
manage the prepared query namespace.
2016-02-23 08:12:58 +00:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
2016-02-26 23:59:00 +00:00
|
|
|
// Redact any tokens if necessary. We make a copy of just the
|
|
|
|
// pointer so we don't mess with the caller's slice.
|
|
|
|
final := query
|
|
|
|
f.redactPreparedQueryTokens(&final)
|
|
|
|
ret = append(ret, final)
|
Creates new "prepared-query" ACL type and new token capture behavior.
Prior to this change, prepared queries had the following behavior for
ACLs, which will need to change to support templates:
1. A management token, or a token with read access to the service being
queried needed to be provided in order to create a prepared query.
2. The token used to create the prepared query was stored with the query
in the state store and used to execute the query.
3. A management token, or the token used to create the query needed to be
supplied to perform and CRUD operations on an existing prepared query.
This was pretty subtle and complicated behavior, and won't work for
templates since the service name is computed at execution time. To solve
this, we introduce a new "prepared-query" ACL type, where the prefix
applies to the query name for static prepared query types and to the
prefix for template prepared query types.
With this change, the new behavior is:
1. A management token, or a token with "prepared-query" write access to
the query name or (soon) the given template prefix is required to do
any CRUD operations on a prepared query, or to list prepared queries
(the list is filtered by this ACL).
2. You will no longer need a management token to list prepared queries,
but you will only be able to see prepared queries that you have access
to (you get an empty list instead of permission denied).
3. When listing or getting a query, because it was easy to capture
management tokens given the past behavior, this will always blank out
the "Token" field (replacing the contents as <hidden>) for all tokens
unless a management token is supplied. Going forward, we should
discourage people from binding tokens for execution unless strictly
necessary.
4. No token will be captured by default when a prepared query is created.
If the user wishes to supply an execution token then can pass it in via
the "Token" field in the prepared query definition. Otherwise, this
field will default to empty.
5. At execution time, we will use the captured token if it exists with the
prepared query definition, otherwise we will use the token that's passed
in with the request, just like we do for other RPCs (or you can use the
agent's configured token for DNS).
6. Prepared queries with no name (accessible only by ID) will not require
ACLs to create or modify (execution time will depend on the service ACL
configuration). Our argument here is that these are designed to be
ephemeral and the IDs are as good as an ACL. Management tokens will be
able to list all of these.
These changes enable templates, but also enable delegation of authority to
manage the prepared query namespace.
2016-02-23 08:12:58 +00:00
|
|
|
}
|
|
|
|
*queries = ret
|
|
|
|
}
|
|
|
|
|
2019-10-24 18:38:09 +00:00
|
|
|
func (f *aclFilter) filterToken(token **structs.ACLToken) {
|
2019-12-18 18:43:24 +00:00
|
|
|
var entCtx acl.AuthorizerContext
|
2019-10-24 18:38:09 +00:00
|
|
|
if token == nil || *token == nil || f == nil {
|
2018-10-19 16:04:07 +00:00
|
|
|
return
|
2015-06-11 19:08:21 +00:00
|
|
|
}
|
2019-10-24 18:38:09 +00:00
|
|
|
|
|
|
|
(*token).FillAuthzContext(&entCtx)
|
|
|
|
|
|
|
|
if f.authorizer.ACLRead(&entCtx) != acl.Allow {
|
|
|
|
// no permissions to read
|
|
|
|
*token = nil
|
|
|
|
} else if f.authorizer.ACLWrite(&entCtx) != acl.Allow {
|
|
|
|
// no write permissions - redact secret
|
|
|
|
clone := *(*token)
|
|
|
|
clone.SecretID = redactedToken
|
|
|
|
*token = &clone
|
|
|
|
}
|
2018-10-19 16:04:07 +00:00
|
|
|
}
|
2015-06-11 19:08:21 +00:00
|
|
|
|
2019-10-24 18:38:09 +00:00
|
|
|
func (f *aclFilter) filterTokens(tokens *structs.ACLTokens) {
|
2018-10-19 16:04:07 +00:00
|
|
|
ret := make(structs.ACLTokens, 0, len(*tokens))
|
|
|
|
for _, token := range *tokens {
|
|
|
|
final := token
|
2019-10-24 18:38:09 +00:00
|
|
|
f.filterToken(&final)
|
|
|
|
if final != nil {
|
|
|
|
ret = append(ret, final)
|
|
|
|
}
|
2015-06-11 19:08:21 +00:00
|
|
|
}
|
2018-10-19 16:04:07 +00:00
|
|
|
*tokens = ret
|
|
|
|
}
|
2015-06-11 19:08:21 +00:00
|
|
|
|
2019-10-24 18:38:09 +00:00
|
|
|
func (f *aclFilter) filterTokenStub(token **structs.ACLTokenListStub) {
|
2019-12-18 18:43:24 +00:00
|
|
|
var entCtx acl.AuthorizerContext
|
2019-10-24 18:38:09 +00:00
|
|
|
if token == nil || *token == nil || f == nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
(*token).FillAuthzContext(&entCtx)
|
|
|
|
|
|
|
|
if f.authorizer.ACLRead(&entCtx) != acl.Allow {
|
|
|
|
*token = nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *aclFilter) filterTokenStubs(tokens *[]*structs.ACLTokenListStub) {
|
|
|
|
ret := make(structs.ACLTokenListStubs, 0, len(*tokens))
|
|
|
|
for _, token := range *tokens {
|
|
|
|
final := token
|
|
|
|
f.filterTokenStub(&final)
|
|
|
|
if final != nil {
|
|
|
|
ret = append(ret, final)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
*tokens = ret
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *aclFilter) filterPolicy(policy **structs.ACLPolicy) {
|
2019-12-18 18:43:24 +00:00
|
|
|
var entCtx acl.AuthorizerContext
|
2019-10-24 18:38:09 +00:00
|
|
|
if policy == nil || *policy == nil || f == nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
(*policy).FillAuthzContext(&entCtx)
|
|
|
|
|
|
|
|
if f.authorizer.ACLRead(&entCtx) != acl.Allow {
|
|
|
|
// no permissions to read
|
|
|
|
*policy = nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *aclFilter) filterPolicies(policies *structs.ACLPolicies) {
|
|
|
|
ret := make(structs.ACLPolicies, 0, len(*policies))
|
|
|
|
for _, policy := range *policies {
|
|
|
|
final := policy
|
|
|
|
f.filterPolicy(&final)
|
|
|
|
if final != nil {
|
|
|
|
ret = append(ret, final)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
*policies = ret
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *aclFilter) filterRole(role **structs.ACLRole) {
|
2019-12-18 18:43:24 +00:00
|
|
|
var entCtx acl.AuthorizerContext
|
2019-10-24 18:38:09 +00:00
|
|
|
if role == nil || *role == nil || f == nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
(*role).FillAuthzContext(&entCtx)
|
|
|
|
|
|
|
|
if f.authorizer.ACLRead(&entCtx) != acl.Allow {
|
|
|
|
// no permissions to read
|
|
|
|
*role = nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *aclFilter) filterRoles(roles *structs.ACLRoles) {
|
|
|
|
ret := make(structs.ACLRoles, 0, len(*roles))
|
|
|
|
for _, role := range *roles {
|
|
|
|
final := role
|
|
|
|
f.filterRole(&final)
|
|
|
|
if final != nil {
|
|
|
|
ret = append(ret, final)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
*roles = ret
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *aclFilter) filterBindingRule(rule **structs.ACLBindingRule) {
|
2019-12-18 18:43:24 +00:00
|
|
|
var entCtx acl.AuthorizerContext
|
2019-10-24 18:38:09 +00:00
|
|
|
if rule == nil || *rule == nil || f == nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
(*rule).FillAuthzContext(&entCtx)
|
|
|
|
|
|
|
|
if f.authorizer.ACLRead(&entCtx) != acl.Allow {
|
|
|
|
// no permissions to read
|
|
|
|
*rule = nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *aclFilter) filterBindingRules(rules *structs.ACLBindingRules) {
|
|
|
|
ret := make(structs.ACLBindingRules, 0, len(*rules))
|
|
|
|
for _, rule := range *rules {
|
|
|
|
final := rule
|
|
|
|
f.filterBindingRule(&final)
|
|
|
|
if final != nil {
|
|
|
|
ret = append(ret, final)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
*rules = ret
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *aclFilter) filterAuthMethod(method **structs.ACLAuthMethod) {
|
2019-12-18 18:43:24 +00:00
|
|
|
var entCtx acl.AuthorizerContext
|
2019-10-24 18:38:09 +00:00
|
|
|
if method == nil || *method == nil || f == nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
(*method).FillAuthzContext(&entCtx)
|
|
|
|
|
|
|
|
if f.authorizer.ACLRead(&entCtx) != acl.Allow {
|
|
|
|
// no permissions to read
|
|
|
|
*method = nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *aclFilter) filterAuthMethods(methods *structs.ACLAuthMethods) {
|
|
|
|
ret := make(structs.ACLAuthMethods, 0, len(*methods))
|
|
|
|
for _, method := range *methods {
|
|
|
|
final := method
|
|
|
|
f.filterAuthMethod(&final)
|
|
|
|
if final != nil {
|
|
|
|
ret = append(ret, final)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
*methods = ret
|
|
|
|
}
|
|
|
|
|
2020-01-24 15:04:58 +00:00
|
|
|
func (f *aclFilter) filterServiceList(services *structs.ServiceList) {
|
|
|
|
ret := make(structs.ServiceList, 0, len(*services))
|
|
|
|
for _, svc := range *services {
|
|
|
|
var authzContext acl.AuthorizerContext
|
|
|
|
|
|
|
|
svc.FillAuthzContext(&authzContext)
|
|
|
|
|
|
|
|
if f.authorizer.ServiceRead(svc.Name, &authzContext) != acl.Allow {
|
|
|
|
sid := structs.NewServiceID(svc.Name, &svc.EnterpriseMeta)
|
2020-01-28 23:50:41 +00:00
|
|
|
f.logger.Debug("dropping service from result due to ACLs", "service", sid.String())
|
2020-01-24 15:04:58 +00:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = append(ret, svc)
|
|
|
|
}
|
|
|
|
|
|
|
|
*services = ret
|
|
|
|
}
|
|
|
|
|
2020-04-08 18:37:24 +00:00
|
|
|
// filterGatewayServices is used to filter gateway to service mappings based on ACL rules.
|
|
|
|
func (f *aclFilter) filterGatewayServices(mappings *structs.GatewayServices) {
|
|
|
|
ret := make(structs.GatewayServices, 0, len(*mappings))
|
|
|
|
for _, s := range *mappings {
|
|
|
|
// This filter only checks ServiceRead on the linked service.
|
|
|
|
// ServiceRead on the gateway is checked in the GatewayServices endpoint before filtering.
|
|
|
|
var authzContext acl.AuthorizerContext
|
|
|
|
s.Service.FillAuthzContext(&authzContext)
|
|
|
|
|
2020-06-12 14:57:41 +00:00
|
|
|
if f.authorizer.ServiceRead(s.Service.Name, &authzContext) != acl.Allow {
|
2020-04-08 18:37:24 +00:00
|
|
|
f.logger.Debug("dropping service from result due to ACLs", "service", s.Service.String())
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
ret = append(ret, s)
|
|
|
|
}
|
|
|
|
*mappings = ret
|
|
|
|
}
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
func (r *ACLResolver) filterACLWithAuthorizer(authorizer acl.Authorizer, subj interface{}) error {
|
|
|
|
if authorizer == nil {
|
|
|
|
return nil
|
|
|
|
}
|
2015-06-11 19:08:21 +00:00
|
|
|
// Create the filter
|
2020-05-29 21:16:03 +00:00
|
|
|
filt := newACLFilter(authorizer, r.logger)
|
2015-06-11 19:08:21 +00:00
|
|
|
|
|
|
|
switch v := subj.(type) {
|
2016-12-11 00:00:11 +00:00
|
|
|
case *structs.CheckServiceNodes:
|
|
|
|
filt.filterCheckServiceNodes(v)
|
|
|
|
|
|
|
|
case *structs.IndexedCheckServiceNodes:
|
|
|
|
filt.filterCheckServiceNodes(&v.Nodes)
|
|
|
|
|
2020-03-09 20:59:02 +00:00
|
|
|
case *structs.DatacenterIndexedCheckServiceNodes:
|
|
|
|
filt.filterDatacenterCheckServiceNodes(&v.DatacenterNodes)
|
|
|
|
|
2016-12-12 19:58:31 +00:00
|
|
|
case *structs.IndexedCoordinates:
|
|
|
|
filt.filterCoordinates(&v.Coordinates)
|
|
|
|
|
2015-06-11 19:08:21 +00:00
|
|
|
case *structs.IndexedHealthChecks:
|
|
|
|
filt.filterHealthChecks(&v.HealthChecks)
|
2018-03-04 19:53:52 +00:00
|
|
|
|
|
|
|
case *structs.IndexedIntentions:
|
|
|
|
filt.filterIntentions(&v.Intentions)
|
2015-06-11 19:08:21 +00:00
|
|
|
|
2016-12-11 00:00:11 +00:00
|
|
|
case *structs.IndexedNodeDump:
|
|
|
|
filt.filterNodeDump(&v.Dump)
|
2015-06-11 19:08:21 +00:00
|
|
|
|
2020-05-11 17:35:17 +00:00
|
|
|
case *structs.IndexedServiceDump:
|
|
|
|
filt.filterServiceDump(&v.Dump)
|
|
|
|
|
2016-12-11 00:00:11 +00:00
|
|
|
case *structs.IndexedNodes:
|
|
|
|
filt.filterNodes(&v.Nodes)
|
2015-06-11 19:08:21 +00:00
|
|
|
|
|
|
|
case *structs.IndexedNodeServices:
|
2016-12-13 00:53:31 +00:00
|
|
|
filt.filterNodeServices(&v.NodeServices)
|
2015-06-09 19:36:25 +00:00
|
|
|
|
2019-12-10 02:26:41 +00:00
|
|
|
case **structs.NodeServiceList:
|
|
|
|
filt.filterNodeServiceList(v)
|
|
|
|
|
2016-12-11 00:00:11 +00:00
|
|
|
case *structs.IndexedServiceNodes:
|
|
|
|
filt.filterServiceNodes(&v.ServiceNodes)
|
Creates new "prepared-query" ACL type and new token capture behavior.
Prior to this change, prepared queries had the following behavior for
ACLs, which will need to change to support templates:
1. A management token, or a token with read access to the service being
queried needed to be provided in order to create a prepared query.
2. The token used to create the prepared query was stored with the query
in the state store and used to execute the query.
3. A management token, or the token used to create the query needed to be
supplied to perform and CRUD operations on an existing prepared query.
This was pretty subtle and complicated behavior, and won't work for
templates since the service name is computed at execution time. To solve
this, we introduce a new "prepared-query" ACL type, where the prefix
applies to the query name for static prepared query types and to the
prefix for template prepared query types.
With this change, the new behavior is:
1. A management token, or a token with "prepared-query" write access to
the query name or (soon) the given template prefix is required to do
any CRUD operations on a prepared query, or to list prepared queries
(the list is filtered by this ACL).
2. You will no longer need a management token to list prepared queries,
but you will only be able to see prepared queries that you have access
to (you get an empty list instead of permission denied).
3. When listing or getting a query, because it was easy to capture
management tokens given the past behavior, this will always blank out
the "Token" field (replacing the contents as <hidden>) for all tokens
unless a management token is supplied. Going forward, we should
discourage people from binding tokens for execution unless strictly
necessary.
4. No token will be captured by default when a prepared query is created.
If the user wishes to supply an execution token then can pass it in via
the "Token" field in the prepared query definition. Otherwise, this
field will default to empty.
5. At execution time, we will use the captured token if it exists with the
prepared query definition, otherwise we will use the token that's passed
in with the request, just like we do for other RPCs (or you can use the
agent's configured token for DNS).
6. Prepared queries with no name (accessible only by ID) will not require
ACLs to create or modify (execution time will depend on the service ACL
configuration). Our argument here is that these are designed to be
ephemeral and the IDs are as good as an ACL. Management tokens will be
able to list all of these.
These changes enable templates, but also enable delegation of authority to
manage the prepared query namespace.
2016-02-23 08:12:58 +00:00
|
|
|
|
2016-12-11 00:00:11 +00:00
|
|
|
case *structs.IndexedServices:
|
2019-12-10 02:26:41 +00:00
|
|
|
filt.filterServices(v.Services, &v.EnterpriseMeta)
|
2015-06-11 23:46:15 +00:00
|
|
|
|
2016-12-13 05:59:22 +00:00
|
|
|
case *structs.IndexedSessions:
|
|
|
|
filt.filterSessions(&v.Sessions)
|
|
|
|
|
Creates new "prepared-query" ACL type and new token capture behavior.
Prior to this change, prepared queries had the following behavior for
ACLs, which will need to change to support templates:
1. A management token, or a token with read access to the service being
queried needed to be provided in order to create a prepared query.
2. The token used to create the prepared query was stored with the query
in the state store and used to execute the query.
3. A management token, or the token used to create the query needed to be
supplied to perform and CRUD operations on an existing prepared query.
This was pretty subtle and complicated behavior, and won't work for
templates since the service name is computed at execution time. To solve
this, we introduce a new "prepared-query" ACL type, where the prefix
applies to the query name for static prepared query types and to the
prefix for template prepared query types.
With this change, the new behavior is:
1. A management token, or a token with "prepared-query" write access to
the query name or (soon) the given template prefix is required to do
any CRUD operations on a prepared query, or to list prepared queries
(the list is filtered by this ACL).
2. You will no longer need a management token to list prepared queries,
but you will only be able to see prepared queries that you have access
to (you get an empty list instead of permission denied).
3. When listing or getting a query, because it was easy to capture
management tokens given the past behavior, this will always blank out
the "Token" field (replacing the contents as <hidden>) for all tokens
unless a management token is supplied. Going forward, we should
discourage people from binding tokens for execution unless strictly
necessary.
4. No token will be captured by default when a prepared query is created.
If the user wishes to supply an execution token then can pass it in via
the "Token" field in the prepared query definition. Otherwise, this
field will default to empty.
5. At execution time, we will use the captured token if it exists with the
prepared query definition, otherwise we will use the token that's passed
in with the request, just like we do for other RPCs (or you can use the
agent's configured token for DNS).
6. Prepared queries with no name (accessible only by ID) will not require
ACLs to create or modify (execution time will depend on the service ACL
configuration). Our argument here is that these are designed to be
ephemeral and the IDs are as good as an ACL. Management tokens will be
able to list all of these.
These changes enable templates, but also enable delegation of authority to
manage the prepared query namespace.
2016-02-23 08:12:58 +00:00
|
|
|
case *structs.IndexedPreparedQueries:
|
|
|
|
filt.filterPreparedQueries(&v.Queries)
|
|
|
|
|
2016-02-26 23:59:00 +00:00
|
|
|
case **structs.PreparedQuery:
|
|
|
|
filt.redactPreparedQueryTokens(v)
|
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
case *structs.ACLTokens:
|
2019-10-24 18:38:09 +00:00
|
|
|
filt.filterTokens(v)
|
2018-10-19 16:04:07 +00:00
|
|
|
case **structs.ACLToken:
|
2019-10-24 18:38:09 +00:00
|
|
|
filt.filterToken(v)
|
|
|
|
case *[]*structs.ACLTokenListStub:
|
|
|
|
filt.filterTokenStubs(v)
|
|
|
|
case **structs.ACLTokenListStub:
|
|
|
|
filt.filterTokenStub(v)
|
|
|
|
|
|
|
|
case *structs.ACLPolicies:
|
|
|
|
filt.filterPolicies(v)
|
|
|
|
case **structs.ACLPolicy:
|
|
|
|
filt.filterPolicy(v)
|
|
|
|
|
|
|
|
case *structs.ACLRoles:
|
|
|
|
filt.filterRoles(v)
|
|
|
|
case **structs.ACLRole:
|
|
|
|
filt.filterRole(v)
|
|
|
|
|
|
|
|
case *structs.ACLBindingRules:
|
|
|
|
filt.filterBindingRules(v)
|
|
|
|
case **structs.ACLBindingRule:
|
|
|
|
filt.filterBindingRule(v)
|
|
|
|
|
|
|
|
case *structs.ACLAuthMethods:
|
|
|
|
filt.filterAuthMethods(v)
|
|
|
|
case **structs.ACLAuthMethod:
|
|
|
|
filt.filterAuthMethod(v)
|
2018-10-19 16:04:07 +00:00
|
|
|
|
2020-01-24 15:04:58 +00:00
|
|
|
case *structs.IndexedServiceList:
|
|
|
|
filt.filterServiceList(&v.Services)
|
2020-04-08 18:37:24 +00:00
|
|
|
|
|
|
|
case *structs.GatewayServices:
|
|
|
|
filt.filterGatewayServices(v)
|
|
|
|
|
2015-06-11 23:46:15 +00:00
|
|
|
default:
|
2019-10-24 18:38:09 +00:00
|
|
|
panic(fmt.Errorf("Unhandled type passed to ACL filter: %T %#v", subj, subj))
|
2015-06-09 19:36:25 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
2016-12-09 00:01:01 +00:00
|
|
|
|
2018-10-19 16:04:07 +00:00
|
|
|
// filterACL is used to filter results from our service catalog based on the
|
|
|
|
// rules configured for the provided token.
|
|
|
|
func (r *ACLResolver) filterACL(token string, subj interface{}) error {
|
|
|
|
// Get the ACL from the token
|
|
|
|
authorizer, err := r.ResolveToken(token)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
// Fast path if ACLs are not enabled
|
|
|
|
if authorizer == nil {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
return r.filterACLWithAuthorizer(authorizer, subj)
|
|
|
|
}
|
|
|
|
|
2016-12-09 00:01:01 +00:00
|
|
|
// vetRegisterWithACL applies the given ACL's policy to the catalog update and
|
|
|
|
// determines if it is allowed. Since the catalog register request is so
|
|
|
|
// dynamic, this is a pretty complex algorithm and was worth breaking out of the
|
2016-12-10 03:15:44 +00:00
|
|
|
// endpoint. The NodeServices record for the node must be supplied, and can be
|
|
|
|
// nil.
|
2016-12-09 00:01:01 +00:00
|
|
|
//
|
|
|
|
// This is a bit racy because we have to check the state store outside of a
|
|
|
|
// transaction. It's the best we can do because we don't want to flow ACL
|
|
|
|
// checking down there. The node information doesn't change in practice, so this
|
|
|
|
// will be fine. If we expose ways to change node addresses in a later version,
|
|
|
|
// then we should split the catalog API at the node and service level so we can
|
|
|
|
// address this race better (even then it would be super rare, and would at
|
|
|
|
// worst let a service update revert a recent node update, so it doesn't open up
|
|
|
|
// too much abuse).
|
2018-10-19 16:04:07 +00:00
|
|
|
func vetRegisterWithACL(rule acl.Authorizer, subj *structs.RegisterRequest,
|
2016-12-10 03:15:44 +00:00
|
|
|
ns *structs.NodeServices) error {
|
2016-12-09 00:01:01 +00:00
|
|
|
// Fast path if ACLs are not enabled.
|
2017-08-23 14:52:48 +00:00
|
|
|
if rule == nil {
|
2016-12-09 00:01:01 +00:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
subj.FillAuthzContext(&authzContext)
|
2017-09-14 19:31:01 +00:00
|
|
|
|
2016-12-09 00:01:01 +00:00
|
|
|
// Vet the node info. This allows service updates to re-post the required
|
|
|
|
// node info for each request without having to have node "write"
|
|
|
|
// privileges.
|
|
|
|
needsNode := ns == nil || subj.ChangesNode(ns.Node)
|
2017-09-14 19:31:01 +00:00
|
|
|
|
2019-12-10 02:26:41 +00:00
|
|
|
if needsNode && rule.NodeWrite(subj.Node, &authzContext) != acl.Allow {
|
2017-08-23 14:52:48 +00:00
|
|
|
return acl.ErrPermissionDenied
|
2016-12-09 00:01:01 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Vet the service change. This includes making sure they can register
|
|
|
|
// the given service, and that we can write to any existing service that
|
|
|
|
// is being modified by id (if any).
|
|
|
|
if subj.Service != nil {
|
2019-12-10 02:26:41 +00:00
|
|
|
if rule.ServiceWrite(subj.Service.Service, &authzContext) != acl.Allow {
|
2017-08-23 14:52:48 +00:00
|
|
|
return acl.ErrPermissionDenied
|
2016-12-09 00:01:01 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if ns != nil {
|
|
|
|
other, ok := ns.Services[subj.Service.ID]
|
2017-09-14 19:31:01 +00:00
|
|
|
|
2019-12-10 02:26:41 +00:00
|
|
|
if ok {
|
|
|
|
// This is effectively a delete, so we DO NOT apply the
|
|
|
|
// sentinel scope to the service we are overwriting, just
|
|
|
|
// the regular ACL policy.
|
2019-12-18 18:43:24 +00:00
|
|
|
var secondaryCtx acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
other.FillAuthzContext(&secondaryCtx)
|
|
|
|
|
|
|
|
if rule.ServiceWrite(other.Service, &secondaryCtx) != acl.Allow {
|
|
|
|
return acl.ErrPermissionDenied
|
|
|
|
}
|
2016-12-09 00:01:01 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Make sure that the member was flattened before we got there. This
|
|
|
|
// keeps us from having to verify this check as well.
|
|
|
|
if subj.Check != nil {
|
|
|
|
return fmt.Errorf("check member must be nil")
|
|
|
|
}
|
|
|
|
|
|
|
|
// Vet the checks. Node-level checks require node write, and
|
|
|
|
// service-level checks require service write.
|
|
|
|
for _, check := range subj.Checks {
|
|
|
|
// Make sure that the node matches - we don't allow you to mix
|
|
|
|
// checks from other nodes because we'd have to pull a bunch
|
|
|
|
// more state store data to check this. If ACLs are enabled then
|
|
|
|
// we simply require them to match in a given request. There's a
|
|
|
|
// note in state_store.go to ban this down there in Consul 0.8,
|
|
|
|
// but it's good to leave this here because it's required for
|
|
|
|
// correctness wrt. ACLs.
|
|
|
|
if check.Node != subj.Node {
|
|
|
|
return fmt.Errorf("Node '%s' for check '%s' doesn't match register request node '%s'",
|
|
|
|
check.Node, check.CheckID, subj.Node)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Node-level check.
|
|
|
|
if check.ServiceID == "" {
|
2019-12-10 02:26:41 +00:00
|
|
|
if rule.NodeWrite(subj.Node, &authzContext) != acl.Allow {
|
2017-08-23 14:52:48 +00:00
|
|
|
return acl.ErrPermissionDenied
|
2016-12-09 00:01:01 +00:00
|
|
|
}
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
// Service-level check, check the common case where it
|
|
|
|
// matches the service part of this request, which has
|
|
|
|
// already been vetted above, and might be being registered
|
|
|
|
// along with its checks.
|
|
|
|
if subj.Service != nil && subj.Service.ID == check.ServiceID {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
// Service-level check for some other service. Make sure they've
|
|
|
|
// got write permissions for that service.
|
|
|
|
if ns == nil {
|
2017-04-21 01:59:42 +00:00
|
|
|
return fmt.Errorf("Unknown service '%s' for check '%s'", check.ServiceID, check.CheckID)
|
|
|
|
}
|
|
|
|
|
|
|
|
other, ok := ns.Services[check.ServiceID]
|
|
|
|
if !ok {
|
|
|
|
return fmt.Errorf("Unknown service '%s' for check '%s'", check.ServiceID, check.CheckID)
|
|
|
|
}
|
|
|
|
|
2017-09-14 19:31:01 +00:00
|
|
|
// We are only adding a check here, so we don't add the scope,
|
|
|
|
// since the sentinel policy doesn't apply to adding checks at
|
|
|
|
// this time.
|
2019-12-18 18:43:24 +00:00
|
|
|
var secondaryCtx acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
other.FillAuthzContext(&secondaryCtx)
|
|
|
|
|
|
|
|
if rule.ServiceWrite(other.Service, &secondaryCtx) != acl.Allow {
|
2017-08-23 14:52:48 +00:00
|
|
|
return acl.ErrPermissionDenied
|
2016-12-09 00:01:01 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
2016-12-10 03:15:44 +00:00
|
|
|
|
|
|
|
// vetDeregisterWithACL applies the given ACL's policy to the catalog update and
|
|
|
|
// determines if it is allowed. Since the catalog deregister request is so
|
|
|
|
// dynamic, this is a pretty complex algorithm and was worth breaking out of the
|
|
|
|
// endpoint. The NodeService for the referenced service must be supplied, and can
|
|
|
|
// be nil; similar for the HealthCheck for the referenced health check.
|
2018-10-19 16:04:07 +00:00
|
|
|
func vetDeregisterWithACL(rule acl.Authorizer, subj *structs.DeregisterRequest,
|
2016-12-10 03:15:44 +00:00
|
|
|
ns *structs.NodeService, nc *structs.HealthCheck) error {
|
2017-09-14 19:31:01 +00:00
|
|
|
|
2016-12-10 03:15:44 +00:00
|
|
|
// Fast path if ACLs are not enabled.
|
2017-08-23 14:52:48 +00:00
|
|
|
if rule == nil {
|
2016-12-10 03:15:44 +00:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2017-09-14 19:31:01 +00:00
|
|
|
// We don't apply sentinel in this path, since at this time sentinel
|
|
|
|
// only applies to create and update operations.
|
|
|
|
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
// fill with the defaults for use with the NodeWrite check
|
|
|
|
subj.FillAuthzContext(&authzContext)
|
|
|
|
|
2019-06-27 12:24:35 +00:00
|
|
|
// Allow service deregistration if the token has write permission for the node.
|
|
|
|
// This accounts for cases where the agent no longer has a token with write permission
|
|
|
|
// on the service to deregister it.
|
2019-12-10 02:26:41 +00:00
|
|
|
if rule.NodeWrite(subj.Node, &authzContext) == acl.Allow {
|
2019-06-27 12:24:35 +00:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// This order must match the code in applyDeregister() in
|
|
|
|
// fsm/commands_oss.go since it also evaluates things in this order,
|
|
|
|
// and will ignore fields based on this precedence. This lets us also
|
|
|
|
// ignore them from an ACL perspective.
|
2016-12-10 03:15:44 +00:00
|
|
|
if subj.ServiceID != "" {
|
|
|
|
if ns == nil {
|
|
|
|
return fmt.Errorf("Unknown service '%s'", subj.ServiceID)
|
|
|
|
}
|
2019-12-10 02:26:41 +00:00
|
|
|
|
|
|
|
ns.FillAuthzContext(&authzContext)
|
|
|
|
|
|
|
|
if rule.ServiceWrite(ns.Service, &authzContext) != acl.Allow {
|
2017-08-23 14:52:48 +00:00
|
|
|
return acl.ErrPermissionDenied
|
2016-12-10 03:15:44 +00:00
|
|
|
}
|
|
|
|
} else if subj.CheckID != "" {
|
|
|
|
if nc == nil {
|
|
|
|
return fmt.Errorf("Unknown check '%s'", subj.CheckID)
|
|
|
|
}
|
2019-12-10 02:26:41 +00:00
|
|
|
|
|
|
|
nc.FillAuthzContext(&authzContext)
|
|
|
|
|
2016-12-10 03:15:44 +00:00
|
|
|
if nc.ServiceID != "" {
|
2019-12-10 02:26:41 +00:00
|
|
|
if rule.ServiceWrite(nc.ServiceName, &authzContext) != acl.Allow {
|
2017-08-23 14:52:48 +00:00
|
|
|
return acl.ErrPermissionDenied
|
2016-12-10 03:15:44 +00:00
|
|
|
}
|
|
|
|
} else {
|
2019-12-10 02:26:41 +00:00
|
|
|
if rule.NodeWrite(subj.Node, &authzContext) != acl.Allow {
|
2017-08-23 14:52:48 +00:00
|
|
|
return acl.ErrPermissionDenied
|
2016-12-10 03:15:44 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
} else {
|
2019-06-27 12:24:35 +00:00
|
|
|
// Since NodeWrite is not given - otherwise the earlier check
|
|
|
|
// would've returned already - we can deny here.
|
|
|
|
return acl.ErrPermissionDenied
|
2016-12-10 03:15:44 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
2018-12-12 10:29:54 +00:00
|
|
|
|
|
|
|
// vetNodeTxnOp applies the given ACL policy to a node transaction operation.
|
|
|
|
func vetNodeTxnOp(op *structs.TxnNodeOp, rule acl.Authorizer) error {
|
2018-12-12 13:22:25 +00:00
|
|
|
// Fast path if ACLs are not enabled.
|
|
|
|
if rule == nil {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
op.FillAuthzContext(&authzContext)
|
|
|
|
|
|
|
|
if rule != nil && rule.NodeWrite(op.Node.Node, &authzContext) != acl.Allow {
|
2018-12-12 10:29:54 +00:00
|
|
|
return acl.ErrPermissionDenied
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// vetServiceTxnOp applies the given ACL policy to a service transaction operation.
|
|
|
|
func vetServiceTxnOp(op *structs.TxnServiceOp, rule acl.Authorizer) error {
|
2018-12-12 13:22:25 +00:00
|
|
|
// Fast path if ACLs are not enabled.
|
|
|
|
if rule == nil {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
op.FillAuthzContext(&authzContext)
|
|
|
|
|
|
|
|
if rule.ServiceWrite(op.Service.Service, &authzContext) != acl.Allow {
|
2018-12-12 10:29:54 +00:00
|
|
|
return acl.ErrPermissionDenied
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// vetCheckTxnOp applies the given ACL policy to a check transaction operation.
|
|
|
|
func vetCheckTxnOp(op *structs.TxnCheckOp, rule acl.Authorizer) error {
|
2018-12-12 13:22:25 +00:00
|
|
|
// Fast path if ACLs are not enabled.
|
|
|
|
if rule == nil {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2019-12-18 18:43:24 +00:00
|
|
|
var authzContext acl.AuthorizerContext
|
2019-12-10 02:26:41 +00:00
|
|
|
op.FillAuthzContext(&authzContext)
|
|
|
|
|
2018-12-12 10:29:54 +00:00
|
|
|
if op.Check.ServiceID == "" {
|
|
|
|
// Node-level check.
|
2019-12-10 02:26:41 +00:00
|
|
|
if rule.NodeWrite(op.Check.Node, &authzContext) != acl.Allow {
|
2018-12-12 10:29:54 +00:00
|
|
|
return acl.ErrPermissionDenied
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
// Service-level check.
|
2019-12-10 02:26:41 +00:00
|
|
|
if rule.ServiceWrite(op.Check.ServiceName, &authzContext) != acl.Allow {
|
2018-12-12 10:29:54 +00:00
|
|
|
return acl.ErrPermissionDenied
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|