luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity
open-consul/GNUmakefile

91 lines
2.7 KiB
Makefile
Raw Normal View History

build: Use bash for building
2017-04-27 18:49:43 +00:00
SHELL = bash
Add `tools/cmd/cover` to GOTOOLS
2016-05-07 20:02:12 +00:00
GOTOOLS = \
github.com/elazarl/go-bindata-assetfs/... \
github.com/jteeuwen/go-bindata/... \
github.com/mitchellh/gox \
golang.org/x/tools/cmd/cover \
golang.org/x/tools/cmd/stringer
Modernize makefile a bit
2017-03-23 23:06:25 +00:00
GOTAGS ?= consul
build: Simplify make test and log output
2017-04-26 22:47:57 +00:00
GOFILES ?= $(shell go list ./... | grep -v /vendor/)
Faster dev builds (#2924) This patch runs 'go install' instead of gox which runs 'go build' for 'make dev' and copies the binary into ./bin and ./pkg/${GOOS}_${GOARCH} to mimick the previous behavior. This reduces the roundtrip times for a dev build from 11 sec to 500ms if there weren't any changes.
2017-04-18 22:03:51 +00:00
GOOS=$(shell go env GOOS)
GOARCH=$(shell go env GOARCH)
# Get the git commit
GIT_COMMIT=$(shell git rev-parse --short HEAD)
GIT_DIRTY=$(shell test -n "`git status --porcelain`" && echo "+CHANGES" || true)
GIT_DESCRIBE=$(shell git describe --tags --always)
GIT_IMPORT=github.com/hashicorp/consul/version
GOLDFLAGS=-X $(GIT_IMPORT).GitCommit=$(GIT_COMMIT)$(GIT_DIRTY) -X $(GIT_IMPORT).GitDescribe=$(GIT_DESCRIBE)
export GOLDFLAGS
consul: adding basic skeleton
2013-12-06 23:43:07 +00:00
Tweaks some of the default makefile targets.
2016-02-18 04:36:48 +00:00
# all builds binaries for all targets
Only builds the binary stuff under master branch CI.
2016-10-25 20:49:57 +00:00
all: bin
bin: tools
consul: adding basic skeleton
2013-12-06 23:43:07 +00:00
@mkdir -p bin/
Modernize makefile a bit
2017-03-23 23:06:25 +00:00
@GOTAGS='$(GOTAGS)' sh -c "'$(CURDIR)/scripts/build.sh'"
Use gox for building
2015-10-22 18:16:01 +00:00
Typos
2015-10-22 19:00:35 +00:00
# dev creates binaries for testing locally - these are put into ./bin and $GOPATH
Faster dev builds (#2924) This patch runs 'go install' instead of gox which runs 'go build' for 'make dev' and copies the binary into ./bin and ./pkg/${GOOS}_${GOARCH} to mimick the previous behavior. This reduces the roundtrip times for a dev build from 11 sec to 500ms if there weren't any changes.
2017-04-18 22:03:51 +00:00
dev:
Add make target for linux binary
2017-05-04 11:31:56 +00:00
mkdir -p pkg/$(GOOS)_$(GOARCH)/ bin/
Faster dev builds (#2924) This patch runs 'go install' instead of gox which runs 'go build' for 'make dev' and copies the binary into ./bin and ./pkg/${GOOS}_${GOARCH} to mimick the previous behavior. This reduces the roundtrip times for a dev build from 11 sec to 500ms if there weren't any changes.
2017-04-18 22:03:51 +00:00
go install -ldflags '$(GOLDFLAGS)' -tags '$(GOTAGS)'
Fix `make dev` when the `bin/` directory doesn't exist. Without this patch you end up with a nifty consul build named `bin`, not `bin/consul`.
2017-04-28 23:40:50 +00:00
cp $(GOPATH)/bin/consul bin/
Faster dev builds (#2924) This patch runs 'go install' instead of gox which runs 'go build' for 'make dev' and copies the binary into ./bin and ./pkg/${GOOS}_${GOARCH} to mimick the previous behavior. This reduces the roundtrip times for a dev build from 11 sec to 500ms if there weren't any changes.
2017-04-18 22:03:51 +00:00
cp $(GOPATH)/bin/consul pkg/$(GOOS)_$(GOARCH)
Use gox for building
2015-10-22 18:16:01 +00:00
Add make target for linux binary
2017-05-04 11:31:56 +00:00
# linux builds a linux package indpendent of the source platform
linux:
mkdir -p pkg/linux_amd64/
GOOS=linux GOARCH=amd64 go build -ldflags '$(GOLDFLAGS)' -tags '$(GOTAGS)' -o pkg/linux_amd64/consul
Tweaks some of the default makefile targets.
2016-02-18 04:36:48 +00:00
# dist builds binaries for all platforms and packages them for distribution
dist:
Modernize makefile a bit
2017-03-23 23:06:25 +00:00
@GOTAGS='$(GOTAGS)' sh -c "'$(CURDIR)/scripts/dist.sh'"
Use gox for building
2015-10-22 18:16:01 +00:00
consul: adding basic skeleton
2013-12-06 23:43:07 +00:00
cov:
build: Simplify make test and log output
2017-04-26 22:47:57 +00:00
gocov test $(GOFILES) | gocov-html > /tmp/coverage.html
consul: adding basic skeleton
2013-12-06 23:43:07 +00:00
open /tmp/coverage.html
build: Simplify make test and log output
2017-04-26 22:47:57 +00:00
test: dev
go test -tags "$(GOTAGS)" -i -run '^$$' ./...
test: run all tests together again Looks like I have eliminated the troublesome tests for now.
2017-05-31 08:00:10 +00:00
go test -tags "$(GOTAGS)" -v ./... > test.log 2>&1 || true
build: update makefile * capture all output to test.log only and print only failures * always print output on travis * test github.com/hashicorp/consul/consul separately until we've found the interactions with the other packages during testing.
2017-05-24 09:26:49 +00:00
@if [ "$$TRAVIS" == "true" ] ; then cat test.log ; fi
@if grep -q 'FAIL:' test.log ; then grep 'FAIL:' test.log ; exit 1 ; else echo 'PASS' ; fi
Adding fast-path for testing without depedency updates
2015-01-20 23:31:57 +00:00
build: add target for running tests with race detector
2017-05-22 19:24:38 +00:00
test-race: dev
go test -tags "$(GOTAGS)" -i -run '^$$' ./...
( set -o pipefail ; go test -race -tags "$(GOTAGS)" -v ./... 2>&1 | tee test-race.log )
Manage dependencies via Godep Embrace the future and use Go 1.6's vendor support via Godep. Go 1.5 users should `export GO15VENDOREXPERIMENT=1`
2016-02-13 00:50:37 +00:00
cover:
build: Simplify make test and log output
2017-04-26 22:47:57 +00:00
go test $(GOFILES) --cover
consul: adding basic skeleton
2013-12-06 23:43:07 +00:00
Manage dependencies via Godep Embrace the future and use Go 1.6's vendor support via Godep. Go 1.5 users should `export GO15VENDOREXPERIMENT=1`
2016-02-13 00:50:37 +00:00
format:
Add format task to all and silence large output
2014-05-06 05:45:54 +00:00
@echo "--> Running go fmt"
build: Simplify make test and log output
2017-04-26 22:47:57 +00:00
@go fmt $(GOFILES)
Add make format task
2014-05-06 05:38:21 +00:00
Makefile: add vet target Add a vet target in order to catch suspicious constructs reported by go vet. Vet has successfully detected problems in the past, for example, see c9333b1b9b472feb5cad80e2c8276d41b64bde88 Some vet flags are noisy. In particular, the following flags reports a large amount of generally unharmful constructs: ``` -assign: check for useless assignments -composites: check that composite literals used field-keyed elements -shadow: check for shadowed variables -shadowstrict: whether to be strict about shadowing -unreachable: check for unreachable code ``` In order to skip running the flags mentioned above, vet is invoked on a directory basis with `go tool vet .` since package- level type-checking with `go vet` doesn't accept flags. Hence, each file is vetted in isolation, which is weaker than package-level type-checking. But nevertheless, it might catch suspicious constructs that pose a real issue. The vet target runs the following flags on the entire repo: ``` -asmdecl: check assembly against Go declarations -atomic: check for common mistaken usages of the sync/atomic package -bool: check for mistakes involving boolean operators -buildtags: check that +build tags are valid -copylocks: check that locks are not passed by value -methods: check that canonically named methods are canonically defined -nilfunc: check for comparisons between functions and nil -printf: check printf-like invocations -rangeloops: check that range loop variables are used correctly -shift: check for useless shifts -structtags: check that struct field tags have canonical format and apply to exported fields as needed -unsafeptr: check for misuse of unsafe.Pointer ``` Now and then, it might make sense to check the output of the disabled flags manually. For example, `VETARGS=-unreachable make vet` can detect several lines of dead code that can be deleted, etc.
2015-01-17 06:44:10 +00:00
vet:
Modernize makefile a bit
2017-03-23 23:06:25 +00:00
@echo "--> Running go vet"
build: Simplify make test and log output
2017-04-26 22:47:57 +00:00
@go vet $(GOFILES); if [ $$? -eq 1 ]; then \
Makefile: add vet target Add a vet target in order to catch suspicious constructs reported by go vet. Vet has successfully detected problems in the past, for example, see c9333b1b9b472feb5cad80e2c8276d41b64bde88 Some vet flags are noisy. In particular, the following flags reports a large amount of generally unharmful constructs: ``` -assign: check for useless assignments -composites: check that composite literals used field-keyed elements -shadow: check for shadowed variables -shadowstrict: whether to be strict about shadowing -unreachable: check for unreachable code ``` In order to skip running the flags mentioned above, vet is invoked on a directory basis with `go tool vet .` since package- level type-checking with `go vet` doesn't accept flags. Hence, each file is vetted in isolation, which is weaker than package-level type-checking. But nevertheless, it might catch suspicious constructs that pose a real issue. The vet target runs the following flags on the entire repo: ``` -asmdecl: check assembly against Go declarations -atomic: check for common mistaken usages of the sync/atomic package -bool: check for mistakes involving boolean operators -buildtags: check that +build tags are valid -copylocks: check that locks are not passed by value -methods: check that canonically named methods are canonically defined -nilfunc: check for comparisons between functions and nil -printf: check printf-like invocations -rangeloops: check that range loop variables are used correctly -shift: check for useless shifts -structtags: check that struct field tags have canonical format and apply to exported fields as needed -unsafeptr: check for misuse of unsafe.Pointer ``` Now and then, it might make sense to check the output of the disabled flags manually. For example, `VETARGS=-unreachable make vet` can detect several lines of dead code that can be deleted, etc.
2015-01-17 06:44:10 +00:00
echo ""; \
echo "Vet found suspicious constructs. Please check the reported constructs"; \
Modernize makefile a bit
2017-03-23 23:06:25 +00:00
echo "and fix them if necessary before submitting the code for review."; \
exit 1; \
Makefile: add vet target Add a vet target in order to catch suspicious constructs reported by go vet. Vet has successfully detected problems in the past, for example, see c9333b1b9b472feb5cad80e2c8276d41b64bde88 Some vet flags are noisy. In particular, the following flags reports a large amount of generally unharmful constructs: ``` -assign: check for useless assignments -composites: check that composite literals used field-keyed elements -shadow: check for shadowed variables -shadowstrict: whether to be strict about shadowing -unreachable: check for unreachable code ``` In order to skip running the flags mentioned above, vet is invoked on a directory basis with `go tool vet .` since package- level type-checking with `go vet` doesn't accept flags. Hence, each file is vetted in isolation, which is weaker than package-level type-checking. But nevertheless, it might catch suspicious constructs that pose a real issue. The vet target runs the following flags on the entire repo: ``` -asmdecl: check assembly against Go declarations -atomic: check for common mistaken usages of the sync/atomic package -bool: check for mistakes involving boolean operators -buildtags: check that +build tags are valid -copylocks: check that locks are not passed by value -methods: check that canonically named methods are canonically defined -nilfunc: check for comparisons between functions and nil -printf: check printf-like invocations -rangeloops: check that range loop variables are used correctly -shift: check for useless shifts -structtags: check that struct field tags have canonical format and apply to exported fields as needed -unsafeptr: check for misuse of unsafe.Pointer ``` Now and then, it might make sense to check the output of the disabled flags manually. For example, `VETARGS=-unreachable make vet` can detect several lines of dead code that can be deleted, etc.
2015-01-17 06:44:10 +00:00
fi
Runs the static asset packaging inside the container; updates assets.
2016-11-08 23:14:08 +00:00
# build the static web ui and build static assets inside a Docker container, the
# same way a release build works
Adds a UI build in a Docker container. (#2462)
2016-11-02 22:53:02 +00:00
ui:
@sh -c "'$(CURDIR)/scripts/ui.sh'"
Removes from cruft from the makefile.
2016-02-18 04:30:06 +00:00
# generates the static web ui that's compiled into the binary
Manage dependencies via Godep Embrace the future and use Go 1.6's vendor support via Godep. Go 1.5 users should `export GO15VENDOREXPERIMENT=1`
2016-02-13 00:50:37 +00:00
static-assets:
agent: compile web assets into consul binary
2015-11-30 19:24:08 +00:00
@echo "--> Generating static assets"
Fixes the static asset generator for new pkg path, updates assets.
2016-01-15 18:21:42 +00:00
@go-bindata-assetfs -pkg agent -prefix pkg ./pkg/web_ui/...
agent: compile web assets into consul binary
2015-11-30 19:24:08 +00:00
@mv bindata_assetfs.go command/agent
$(MAKE) format
Add a tools target that fetches various build-time tools
2016-02-13 01:09:18 +00:00
tools:
go get -u -v $(GOTOOLS)
Adds a UI build in a Docker container. (#2462)
2016-11-02 22:53:02 +00:00
.PHONY: all ci bin dev dist cov test cover format vet ui static-assets tools