2018-02-28 18:04:27 +00:00
|
|
|
package consul
|
|
|
|
|
|
|
|
import (
|
|
|
|
"os"
|
|
|
|
"testing"
|
2018-03-03 16:43:19 +00:00
|
|
|
"time"
|
2018-02-28 18:04:27 +00:00
|
|
|
|
2018-03-04 08:39:56 +00:00
|
|
|
"github.com/hashicorp/consul/acl"
|
2018-02-28 18:04:27 +00:00
|
|
|
"github.com/hashicorp/consul/agent/structs"
|
|
|
|
"github.com/hashicorp/consul/testrpc"
|
2020-01-13 20:51:40 +00:00
|
|
|
msgpackrpc "github.com/hashicorp/net-rpc-msgpackrpc"
|
2018-03-06 18:35:20 +00:00
|
|
|
"github.com/stretchr/testify/assert"
|
2018-05-11 05:35:47 +00:00
|
|
|
"github.com/stretchr/testify/require"
|
2018-02-28 18:04:27 +00:00
|
|
|
)
|
|
|
|
|
2018-03-01 05:11:35 +00:00
|
|
|
// Test basic creation
|
2018-02-28 18:28:07 +00:00
|
|
|
func TestIntentionApply_new(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:35:20 +00:00
|
|
|
|
|
|
|
assert := assert.New(t)
|
2018-02-28 18:28:07 +00:00
|
|
|
dir1, s1 := testServer(t)
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Setup a basic record to create
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: &structs.Intention{
|
2018-03-03 16:51:40 +00:00
|
|
|
SourceNS: structs.IntentionDefaultNamespace,
|
|
|
|
SourceName: "test",
|
|
|
|
DestinationNS: structs.IntentionDefaultNamespace,
|
|
|
|
DestinationName: "test",
|
2018-03-03 17:43:37 +00:00
|
|
|
Action: structs.IntentionActionAllow,
|
2018-03-03 17:55:27 +00:00
|
|
|
SourceType: structs.IntentionSourceConsul,
|
2018-03-03 17:43:37 +00:00
|
|
|
Meta: map[string]string{},
|
2018-02-28 18:28:07 +00:00
|
|
|
},
|
|
|
|
}
|
|
|
|
var reply string
|
|
|
|
|
2018-03-03 16:43:19 +00:00
|
|
|
// Record now to check created at time
|
|
|
|
now := time.Now()
|
|
|
|
|
2018-02-28 18:28:07 +00:00
|
|
|
// Create
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
|
|
|
assert.NotEmpty(reply)
|
2018-02-28 18:28:07 +00:00
|
|
|
|
2018-02-28 18:44:49 +00:00
|
|
|
// Read
|
|
|
|
ixn.Intention.ID = reply
|
|
|
|
{
|
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
IntentionID: ixn.Intention.ID,
|
|
|
|
}
|
|
|
|
var resp structs.IndexedIntentions
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Get", req, &resp))
|
|
|
|
assert.Len(resp.Intentions, 1)
|
2018-02-28 18:44:49 +00:00
|
|
|
actual := resp.Intentions[0]
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Equal(resp.Index, actual.ModifyIndex)
|
|
|
|
assert.WithinDuration(now, actual.CreatedAt, 5*time.Second)
|
|
|
|
assert.WithinDuration(now, actual.UpdatedAt, 5*time.Second)
|
2018-03-03 16:43:19 +00:00
|
|
|
|
2018-02-28 18:44:49 +00:00
|
|
|
actual.CreateIndex, actual.ModifyIndex = 0, 0
|
2018-03-03 16:43:19 +00:00
|
|
|
actual.CreatedAt = ixn.Intention.CreatedAt
|
|
|
|
actual.UpdatedAt = ixn.Intention.UpdatedAt
|
2019-06-18 00:52:01 +00:00
|
|
|
actual.Hash = ixn.Intention.Hash
|
2018-06-07 04:11:37 +00:00
|
|
|
ixn.Intention.UpdatePrecedence()
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Equal(ixn.Intention, actual)
|
2018-02-28 18:44:49 +00:00
|
|
|
}
|
2018-02-28 18:28:07 +00:00
|
|
|
}
|
|
|
|
|
2018-03-03 17:55:27 +00:00
|
|
|
// Test the source type defaults
|
|
|
|
func TestIntentionApply_defaultSourceType(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:35:20 +00:00
|
|
|
|
|
|
|
assert := assert.New(t)
|
2018-03-03 17:55:27 +00:00
|
|
|
dir1, s1 := testServer(t)
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Setup a basic record to create
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: &structs.Intention{
|
|
|
|
SourceNS: structs.IntentionDefaultNamespace,
|
|
|
|
SourceName: "test",
|
|
|
|
DestinationNS: structs.IntentionDefaultNamespace,
|
|
|
|
DestinationName: "test",
|
|
|
|
Action: structs.IntentionActionAllow,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
var reply string
|
|
|
|
|
|
|
|
// Create
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
|
|
|
assert.NotEmpty(reply)
|
2018-03-03 17:55:27 +00:00
|
|
|
|
|
|
|
// Read
|
|
|
|
ixn.Intention.ID = reply
|
|
|
|
{
|
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
IntentionID: ixn.Intention.ID,
|
|
|
|
}
|
|
|
|
var resp structs.IndexedIntentions
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Get", req, &resp))
|
|
|
|
assert.Len(resp.Intentions, 1)
|
2018-03-03 17:55:27 +00:00
|
|
|
actual := resp.Intentions[0]
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Equal(structs.IntentionSourceConsul, actual.SourceType)
|
2018-03-03 17:55:27 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-03-01 05:16:45 +00:00
|
|
|
// Shouldn't be able to create with an ID set
|
|
|
|
func TestIntentionApply_createWithID(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:35:20 +00:00
|
|
|
|
|
|
|
assert := assert.New(t)
|
2018-03-01 05:16:45 +00:00
|
|
|
dir1, s1 := testServer(t)
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Setup a basic record to create
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: &structs.Intention{
|
|
|
|
ID: generateUUID(),
|
|
|
|
SourceName: "test",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
var reply string
|
|
|
|
|
|
|
|
// Create
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply)
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.NotNil(err)
|
|
|
|
assert.Contains(err, "ID must be empty")
|
2018-03-01 05:16:45 +00:00
|
|
|
}
|
|
|
|
|
2018-03-01 05:11:35 +00:00
|
|
|
// Test basic updating
|
|
|
|
func TestIntentionApply_updateGood(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:35:20 +00:00
|
|
|
|
|
|
|
assert := assert.New(t)
|
2018-03-01 05:11:35 +00:00
|
|
|
dir1, s1 := testServer(t)
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Setup a basic record to create
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: &structs.Intention{
|
2018-03-03 16:51:40 +00:00
|
|
|
SourceNS: structs.IntentionDefaultNamespace,
|
|
|
|
SourceName: "test",
|
|
|
|
DestinationNS: structs.IntentionDefaultNamespace,
|
|
|
|
DestinationName: "test",
|
2018-03-03 17:43:37 +00:00
|
|
|
Action: structs.IntentionActionAllow,
|
2018-03-03 17:55:27 +00:00
|
|
|
SourceType: structs.IntentionSourceConsul,
|
2018-03-03 17:43:37 +00:00
|
|
|
Meta: map[string]string{},
|
2018-03-01 05:11:35 +00:00
|
|
|
},
|
|
|
|
}
|
|
|
|
var reply string
|
|
|
|
|
|
|
|
// Create
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
|
|
|
assert.NotEmpty(reply)
|
2018-03-01 05:11:35 +00:00
|
|
|
|
2018-03-03 16:43:19 +00:00
|
|
|
// Read CreatedAt
|
|
|
|
var createdAt time.Time
|
|
|
|
ixn.Intention.ID = reply
|
|
|
|
{
|
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
IntentionID: ixn.Intention.ID,
|
|
|
|
}
|
|
|
|
var resp structs.IndexedIntentions
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Get", req, &resp))
|
|
|
|
assert.Len(resp.Intentions, 1)
|
2018-03-03 16:43:19 +00:00
|
|
|
actual := resp.Intentions[0]
|
|
|
|
createdAt = actual.CreatedAt
|
|
|
|
}
|
|
|
|
|
|
|
|
// Sleep a bit so that the updated at will definitely be different, not much
|
|
|
|
time.Sleep(1 * time.Millisecond)
|
|
|
|
|
2018-03-01 05:11:35 +00:00
|
|
|
// Update
|
|
|
|
ixn.Op = structs.IntentionOpUpdate
|
|
|
|
ixn.Intention.ID = reply
|
2018-06-07 04:11:37 +00:00
|
|
|
ixn.Intention.SourceName = "*"
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-03-01 05:11:35 +00:00
|
|
|
|
|
|
|
// Read
|
|
|
|
ixn.Intention.ID = reply
|
|
|
|
{
|
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
IntentionID: ixn.Intention.ID,
|
|
|
|
}
|
|
|
|
var resp structs.IndexedIntentions
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Get", req, &resp))
|
|
|
|
assert.Len(resp.Intentions, 1)
|
2018-03-01 05:11:35 +00:00
|
|
|
actual := resp.Intentions[0]
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Equal(createdAt, actual.CreatedAt)
|
|
|
|
assert.WithinDuration(time.Now(), actual.UpdatedAt, 5*time.Second)
|
2018-03-03 16:43:19 +00:00
|
|
|
|
2018-03-01 05:11:35 +00:00
|
|
|
actual.CreateIndex, actual.ModifyIndex = 0, 0
|
2018-03-03 16:43:19 +00:00
|
|
|
actual.CreatedAt = ixn.Intention.CreatedAt
|
|
|
|
actual.UpdatedAt = ixn.Intention.UpdatedAt
|
2019-06-18 00:52:01 +00:00
|
|
|
actual.Hash = ixn.Intention.Hash
|
2018-06-07 04:11:37 +00:00
|
|
|
ixn.Intention.UpdatePrecedence()
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Equal(ixn.Intention, actual)
|
2018-03-01 05:11:35 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Shouldn't be able to update a non-existent intention
|
|
|
|
func TestIntentionApply_updateNonExist(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:35:20 +00:00
|
|
|
|
|
|
|
assert := assert.New(t)
|
2018-03-01 05:11:35 +00:00
|
|
|
dir1, s1 := testServer(t)
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Setup a basic record to create
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpUpdate,
|
|
|
|
Intention: &structs.Intention{
|
|
|
|
ID: generateUUID(),
|
|
|
|
SourceName: "test",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
var reply string
|
|
|
|
|
|
|
|
// Create
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply)
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.NotNil(err)
|
|
|
|
assert.Contains(err, "Cannot modify non-existent intention")
|
2018-03-01 05:11:35 +00:00
|
|
|
}
|
|
|
|
|
2018-03-01 23:48:48 +00:00
|
|
|
// Test basic deleting
|
|
|
|
func TestIntentionApply_deleteGood(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:35:20 +00:00
|
|
|
|
|
|
|
assert := assert.New(t)
|
2018-03-01 23:48:48 +00:00
|
|
|
dir1, s1 := testServer(t)
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Setup a basic record to create
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: &structs.Intention{
|
2018-03-03 17:43:37 +00:00
|
|
|
SourceNS: "test",
|
|
|
|
SourceName: "test",
|
|
|
|
DestinationNS: "test",
|
|
|
|
DestinationName: "test",
|
|
|
|
Action: structs.IntentionActionAllow,
|
2018-03-01 23:48:48 +00:00
|
|
|
},
|
|
|
|
}
|
|
|
|
var reply string
|
|
|
|
|
|
|
|
// Create
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
|
|
|
assert.NotEmpty(reply)
|
2018-03-01 23:48:48 +00:00
|
|
|
|
|
|
|
// Delete
|
|
|
|
ixn.Op = structs.IntentionOpDelete
|
|
|
|
ixn.Intention.ID = reply
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-03-01 23:48:48 +00:00
|
|
|
|
|
|
|
// Read
|
|
|
|
ixn.Intention.ID = reply
|
|
|
|
{
|
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
IntentionID: ixn.Intention.ID,
|
|
|
|
}
|
|
|
|
var resp structs.IndexedIntentions
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Get", req, &resp)
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.NotNil(err)
|
|
|
|
assert.Contains(err, ErrIntentionNotFound.Error())
|
2018-03-01 23:48:48 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-03-04 08:39:56 +00:00
|
|
|
// Test apply with a deny ACL
|
|
|
|
func TestIntentionApply_aclDeny(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:51:26 +00:00
|
|
|
|
|
|
|
assert := assert.New(t)
|
2018-03-04 08:39:56 +00:00
|
|
|
dir1, s1 := testServerWithConfig(t, func(c *Config) {
|
|
|
|
c.ACLDatacenter = "dc1"
|
2018-10-19 16:04:07 +00:00
|
|
|
c.ACLsEnabled = true
|
2018-03-04 08:39:56 +00:00
|
|
|
c.ACLMasterToken = "root"
|
|
|
|
c.ACLDefaultPolicy = "deny"
|
|
|
|
})
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Create an ACL with write permissions
|
|
|
|
var token string
|
|
|
|
{
|
|
|
|
var rules = `
|
|
|
|
service "foo" {
|
|
|
|
policy = "deny"
|
|
|
|
intentions = "write"
|
|
|
|
}`
|
|
|
|
|
|
|
|
req := structs.ACLRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.ACLSet,
|
|
|
|
ACL: structs.ACL{
|
|
|
|
Name: "User token",
|
2018-10-19 16:04:07 +00:00
|
|
|
Type: structs.ACLTokenTypeClient,
|
2018-03-04 08:39:56 +00:00
|
|
|
Rules: rules,
|
|
|
|
},
|
|
|
|
WriteRequest: structs.WriteRequest{Token: "root"},
|
|
|
|
}
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "ACL.Apply", &req, &token))
|
2018-03-04 08:39:56 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Setup a basic record to create
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: structs.TestIntention(t),
|
|
|
|
}
|
|
|
|
ixn.Intention.DestinationName = "foobar"
|
|
|
|
|
|
|
|
// Create without a token should error since default deny
|
|
|
|
var reply string
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply)
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.True(acl.IsErrPermissionDenied(err))
|
2018-03-04 08:39:56 +00:00
|
|
|
|
|
|
|
// Now add the token and try again.
|
|
|
|
ixn.WriteRequest.Token = token
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-03-04 08:39:56 +00:00
|
|
|
|
|
|
|
// Read
|
|
|
|
ixn.Intention.ID = reply
|
|
|
|
{
|
|
|
|
req := &structs.IntentionQueryRequest{
|
2018-03-06 18:51:26 +00:00
|
|
|
Datacenter: "dc1",
|
|
|
|
IntentionID: ixn.Intention.ID,
|
|
|
|
QueryOptions: structs.QueryOptions{Token: "root"},
|
2018-03-04 08:39:56 +00:00
|
|
|
}
|
|
|
|
var resp structs.IndexedIntentions
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Get", req, &resp))
|
|
|
|
assert.Len(resp.Intentions, 1)
|
2018-03-04 08:39:56 +00:00
|
|
|
actual := resp.Intentions[0]
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Equal(resp.Index, actual.ModifyIndex)
|
2018-03-04 08:39:56 +00:00
|
|
|
|
|
|
|
actual.CreateIndex, actual.ModifyIndex = 0, 0
|
|
|
|
actual.CreatedAt = ixn.Intention.CreatedAt
|
|
|
|
actual.UpdatedAt = ixn.Intention.UpdatedAt
|
2019-06-18 00:52:01 +00:00
|
|
|
actual.Hash = ixn.Intention.Hash
|
2018-06-07 04:11:37 +00:00
|
|
|
ixn.Intention.UpdatePrecedence()
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Equal(ixn.Intention, actual)
|
2018-03-04 08:39:56 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-01-13 20:51:40 +00:00
|
|
|
func TestIntention_WildcardACLEnforcement(t *testing.T) {
|
|
|
|
t.Parallel()
|
|
|
|
|
|
|
|
dir, srv := testACLServerWithConfig(t, nil, false)
|
|
|
|
defer os.RemoveAll(dir)
|
|
|
|
defer srv.Shutdown()
|
|
|
|
codec := rpcClient(t, srv)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, srv.RPC, "dc1")
|
|
|
|
|
|
|
|
// create some test policies.
|
|
|
|
|
|
|
|
writeToken, err := upsertTestTokenWithPolicyRules(codec, TestDefaultMasterToken, "dc1", `service_prefix "" { policy = "deny" intentions = "write" }`)
|
|
|
|
require.NoError(t, err)
|
|
|
|
readToken, err := upsertTestTokenWithPolicyRules(codec, TestDefaultMasterToken, "dc1", `service_prefix "" { policy = "deny" intentions = "read" }`)
|
|
|
|
require.NoError(t, err)
|
|
|
|
exactToken, err := upsertTestTokenWithPolicyRules(codec, TestDefaultMasterToken, "dc1", `service "*" { policy = "deny" intentions = "write" }`)
|
|
|
|
require.NoError(t, err)
|
|
|
|
wildcardPrefixToken, err := upsertTestTokenWithPolicyRules(codec, TestDefaultMasterToken, "dc1", `service_prefix "*" { policy = "deny" intentions = "write" }`)
|
|
|
|
require.NoError(t, err)
|
|
|
|
fooToken, err := upsertTestTokenWithPolicyRules(codec, TestDefaultMasterToken, "dc1", `service "foo" { policy = "deny" intentions = "write" }`)
|
|
|
|
require.NoError(t, err)
|
|
|
|
denyToken, err := upsertTestTokenWithPolicyRules(codec, TestDefaultMasterToken, "dc1", `service_prefix "" { policy = "deny" intentions = "deny" }`)
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
doIntentionCreate := func(t *testing.T, token string, deny bool) string {
|
|
|
|
t.Helper()
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: &structs.Intention{
|
|
|
|
SourceNS: "default",
|
|
|
|
SourceName: "*",
|
|
|
|
DestinationNS: "default",
|
|
|
|
DestinationName: "*",
|
|
|
|
Action: structs.IntentionActionAllow,
|
|
|
|
SourceType: structs.IntentionSourceConsul,
|
|
|
|
},
|
|
|
|
WriteRequest: structs.WriteRequest{Token: token},
|
|
|
|
}
|
|
|
|
var reply string
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply)
|
|
|
|
if deny {
|
|
|
|
require.Error(t, err)
|
|
|
|
require.True(t, acl.IsErrPermissionDenied(err))
|
|
|
|
return ""
|
|
|
|
} else {
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.NotEmpty(t, reply)
|
|
|
|
return reply
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
t.Run("deny-write-for-read-token", func(t *testing.T) {
|
|
|
|
// This tests ensures that tokens with only read access to all intentions
|
|
|
|
// cannot create a wildcard intention
|
|
|
|
doIntentionCreate(t, readToken.SecretID, true)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("deny-write-for-exact-wildcard-rule", func(t *testing.T) {
|
|
|
|
// This test ensures that having a rules like:
|
|
|
|
// service "*" {
|
|
|
|
// intentions = "write"
|
|
|
|
// }
|
|
|
|
// will not actually allow creating an intention with a wildcard service name
|
|
|
|
doIntentionCreate(t, exactToken.SecretID, true)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("deny-write-for-prefix-wildcard-rule", func(t *testing.T) {
|
|
|
|
// This test ensures that having a rules like:
|
|
|
|
// service_prefix "*" {
|
|
|
|
// intentions = "write"
|
|
|
|
// }
|
|
|
|
// will not actually allow creating an intention with a wildcard service name
|
|
|
|
doIntentionCreate(t, wildcardPrefixToken.SecretID, true)
|
|
|
|
})
|
|
|
|
|
|
|
|
var intentionID string
|
|
|
|
allowWriteOk := t.Run("allow-write", func(t *testing.T) {
|
|
|
|
// tests that a token with all the required privileges can create
|
|
|
|
// intentions with a wildcard destination
|
|
|
|
intentionID = doIntentionCreate(t, writeToken.SecretID, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
requireAllowWrite := func(t *testing.T) {
|
|
|
|
t.Helper()
|
|
|
|
if !allowWriteOk {
|
|
|
|
t.Skip("Skipping because the allow-write subtest failed")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
doIntentionRead := func(t *testing.T, token string, deny bool) {
|
|
|
|
t.Helper()
|
|
|
|
requireAllowWrite(t)
|
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
IntentionID: intentionID,
|
|
|
|
QueryOptions: structs.QueryOptions{Token: token},
|
|
|
|
}
|
|
|
|
|
|
|
|
var resp structs.IndexedIntentions
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Get", req, &resp)
|
|
|
|
if deny {
|
|
|
|
require.Error(t, err)
|
|
|
|
require.True(t, acl.IsErrPermissionDenied(err))
|
|
|
|
} else {
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Len(t, resp.Intentions, 1)
|
|
|
|
require.Equal(t, "*", resp.Intentions[0].DestinationName)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
t.Run("allow-read-for-write-token", func(t *testing.T) {
|
|
|
|
doIntentionRead(t, writeToken.SecretID, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("allow-read-for-read-token", func(t *testing.T) {
|
|
|
|
doIntentionRead(t, readToken.SecretID, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("allow-read-for-exact-wildcard-token", func(t *testing.T) {
|
|
|
|
// this is allowed because, the effect of the policy is to grant
|
|
|
|
// intention:write on the service named "*". When reading the
|
|
|
|
// intention we will validate that the token has read permissions
|
|
|
|
// for any intention that would match the wildcard.
|
|
|
|
doIntentionRead(t, exactToken.SecretID, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("allow-read-for-prefix-wildcard-token", func(t *testing.T) {
|
|
|
|
// this is allowed for the same reasons as for the
|
|
|
|
// exact-wildcard-token case
|
|
|
|
doIntentionRead(t, wildcardPrefixToken.SecretID, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("deny-read-for-deny-token", func(t *testing.T) {
|
|
|
|
doIntentionRead(t, denyToken.SecretID, true)
|
|
|
|
})
|
|
|
|
|
|
|
|
doIntentionList := func(t *testing.T, token string, deny bool) {
|
|
|
|
t.Helper()
|
|
|
|
requireAllowWrite(t)
|
|
|
|
req := &structs.DCSpecificRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
QueryOptions: structs.QueryOptions{Token: token},
|
|
|
|
}
|
|
|
|
|
|
|
|
var resp structs.IndexedIntentions
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.List", req, &resp)
|
|
|
|
// even with permission denied this should return success but with an empty list
|
|
|
|
require.NoError(t, err)
|
|
|
|
if deny {
|
|
|
|
require.Empty(t, resp.Intentions)
|
|
|
|
} else {
|
|
|
|
require.Len(t, resp.Intentions, 1)
|
|
|
|
require.Equal(t, "*", resp.Intentions[0].DestinationName)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
t.Run("allow-list-for-write-token", func(t *testing.T) {
|
|
|
|
doIntentionList(t, writeToken.SecretID, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("allow-list-for-read-token", func(t *testing.T) {
|
|
|
|
doIntentionList(t, readToken.SecretID, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("allow-list-for-exact-wildcard-token", func(t *testing.T) {
|
|
|
|
doIntentionList(t, exactToken.SecretID, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("allow-list-for-prefix-wildcard-token", func(t *testing.T) {
|
|
|
|
doIntentionList(t, wildcardPrefixToken.SecretID, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("deny-list-for-deny-token", func(t *testing.T) {
|
|
|
|
doIntentionList(t, denyToken.SecretID, true)
|
|
|
|
})
|
|
|
|
|
|
|
|
doIntentionMatch := func(t *testing.T, token string, deny bool) {
|
|
|
|
t.Helper()
|
|
|
|
requireAllowWrite(t)
|
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Match: &structs.IntentionQueryMatch{
|
|
|
|
Type: structs.IntentionMatchDestination,
|
|
|
|
Entries: []structs.IntentionMatchEntry{
|
|
|
|
structs.IntentionMatchEntry{
|
|
|
|
Namespace: "default",
|
|
|
|
Name: "*",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
QueryOptions: structs.QueryOptions{Token: token},
|
|
|
|
}
|
|
|
|
|
|
|
|
var resp structs.IndexedIntentionMatches
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Match", req, &resp)
|
|
|
|
if deny {
|
|
|
|
require.Error(t, err)
|
|
|
|
require.Empty(t, resp.Matches)
|
|
|
|
} else {
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Len(t, resp.Matches, 1)
|
|
|
|
require.Len(t, resp.Matches[0], 1)
|
|
|
|
require.Equal(t, "*", resp.Matches[0][0].DestinationName)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
t.Run("allow-match-for-write-token", func(t *testing.T) {
|
|
|
|
doIntentionMatch(t, writeToken.SecretID, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("allow-match-for-read-token", func(t *testing.T) {
|
|
|
|
doIntentionMatch(t, readToken.SecretID, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("allow-match-for-exact-wildcard-token", func(t *testing.T) {
|
|
|
|
doIntentionMatch(t, exactToken.SecretID, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("allow-match-for-prefix-wildcard-token", func(t *testing.T) {
|
|
|
|
doIntentionMatch(t, wildcardPrefixToken.SecretID, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("deny-match-for-deny-token", func(t *testing.T) {
|
|
|
|
doIntentionMatch(t, denyToken.SecretID, true)
|
|
|
|
})
|
|
|
|
|
|
|
|
doIntentionUpdate := func(t *testing.T, token string, dest string, deny bool) {
|
|
|
|
t.Helper()
|
|
|
|
requireAllowWrite(t)
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpUpdate,
|
|
|
|
Intention: &structs.Intention{
|
|
|
|
ID: intentionID,
|
|
|
|
SourceNS: "default",
|
|
|
|
SourceName: "*",
|
|
|
|
DestinationNS: "default",
|
|
|
|
DestinationName: dest,
|
|
|
|
Action: structs.IntentionActionAllow,
|
|
|
|
SourceType: structs.IntentionSourceConsul,
|
|
|
|
},
|
|
|
|
WriteRequest: structs.WriteRequest{Token: token},
|
|
|
|
}
|
|
|
|
var reply string
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply)
|
|
|
|
if deny {
|
|
|
|
require.Error(t, err)
|
|
|
|
require.True(t, acl.IsErrPermissionDenied(err))
|
|
|
|
} else {
|
|
|
|
require.NoError(t, err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
t.Run("deny-update-for-foo-token", func(t *testing.T) {
|
|
|
|
doIntentionUpdate(t, fooToken.SecretID, "foo", true)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("allow-update-for-prefix-token", func(t *testing.T) {
|
|
|
|
// this tests that regardless of going from a wildcard intention
|
|
|
|
// to a non-wildcard or the opposite direction that the permissions
|
|
|
|
// are checked correctly. This also happens to leave the intention
|
|
|
|
// in a state ready for verifying similar things with deletion
|
|
|
|
doIntentionUpdate(t, writeToken.SecretID, "foo", false)
|
|
|
|
doIntentionUpdate(t, writeToken.SecretID, "*", false)
|
|
|
|
})
|
|
|
|
|
|
|
|
doIntentionDelete := func(t *testing.T, token string, deny bool) {
|
|
|
|
t.Helper()
|
|
|
|
requireAllowWrite(t)
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpDelete,
|
|
|
|
Intention: &structs.Intention{
|
|
|
|
ID: intentionID,
|
|
|
|
},
|
|
|
|
WriteRequest: structs.WriteRequest{Token: token},
|
|
|
|
}
|
|
|
|
var reply string
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply)
|
|
|
|
if deny {
|
|
|
|
require.Error(t, err)
|
|
|
|
require.True(t, acl.IsErrPermissionDenied(err))
|
|
|
|
} else {
|
|
|
|
require.NoError(t, err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
t.Run("deny-delete-for-read-token", func(t *testing.T) {
|
|
|
|
doIntentionDelete(t, readToken.SecretID, true)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("deny-delete-for-exact-wildcard-rule", func(t *testing.T) {
|
|
|
|
// This test ensures that having a rules like:
|
|
|
|
// service "*" {
|
|
|
|
// intentions = "write"
|
|
|
|
// }
|
|
|
|
// will not actually allow deleting an intention with a wildcard service name
|
|
|
|
doIntentionDelete(t, exactToken.SecretID, true)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("deny-delete-for-prefix-wildcard-rule", func(t *testing.T) {
|
|
|
|
// This test ensures that having a rules like:
|
|
|
|
// service_prefix "*" {
|
|
|
|
// intentions = "write"
|
|
|
|
// }
|
|
|
|
// will not actually allow creating an intention with a wildcard service name
|
|
|
|
doIntentionDelete(t, wildcardPrefixToken.SecretID, true)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("allow-delete", func(t *testing.T) {
|
|
|
|
// tests that a token with all the required privileges can delete
|
|
|
|
// intentions with a wildcard destination
|
|
|
|
doIntentionDelete(t, writeToken.SecretID, false)
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2018-03-04 08:55:23 +00:00
|
|
|
// Test apply with delete and a default deny ACL
|
|
|
|
func TestIntentionApply_aclDelete(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:51:26 +00:00
|
|
|
|
|
|
|
assert := assert.New(t)
|
2018-03-04 08:55:23 +00:00
|
|
|
dir1, s1 := testServerWithConfig(t, func(c *Config) {
|
|
|
|
c.ACLDatacenter = "dc1"
|
2018-10-19 16:04:07 +00:00
|
|
|
c.ACLsEnabled = true
|
2018-03-04 08:55:23 +00:00
|
|
|
c.ACLMasterToken = "root"
|
|
|
|
c.ACLDefaultPolicy = "deny"
|
|
|
|
})
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Create an ACL with write permissions
|
|
|
|
var token string
|
|
|
|
{
|
|
|
|
var rules = `
|
|
|
|
service "foo" {
|
|
|
|
policy = "deny"
|
|
|
|
intentions = "write"
|
|
|
|
}`
|
|
|
|
|
|
|
|
req := structs.ACLRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.ACLSet,
|
|
|
|
ACL: structs.ACL{
|
|
|
|
Name: "User token",
|
2018-10-19 16:04:07 +00:00
|
|
|
Type: structs.ACLTokenTypeClient,
|
2018-03-04 08:55:23 +00:00
|
|
|
Rules: rules,
|
|
|
|
},
|
|
|
|
WriteRequest: structs.WriteRequest{Token: "root"},
|
|
|
|
}
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "ACL.Apply", &req, &token))
|
2018-03-04 08:55:23 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Setup a basic record to create
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: structs.TestIntention(t),
|
|
|
|
}
|
|
|
|
ixn.Intention.DestinationName = "foobar"
|
|
|
|
ixn.WriteRequest.Token = token
|
|
|
|
|
|
|
|
// Create
|
|
|
|
var reply string
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-03-04 08:55:23 +00:00
|
|
|
|
|
|
|
// Try to do a delete with no token; this should get rejected.
|
|
|
|
ixn.Op = structs.IntentionOpDelete
|
|
|
|
ixn.Intention.ID = reply
|
|
|
|
ixn.WriteRequest.Token = ""
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply)
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.True(acl.IsErrPermissionDenied(err))
|
2018-03-04 08:55:23 +00:00
|
|
|
|
|
|
|
// Try again with the original token. This should go through.
|
|
|
|
ixn.WriteRequest.Token = token
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-03-04 08:55:23 +00:00
|
|
|
|
|
|
|
// Verify it is gone
|
|
|
|
{
|
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
IntentionID: ixn.Intention.ID,
|
|
|
|
}
|
|
|
|
var resp structs.IndexedIntentions
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Get", req, &resp)
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.NotNil(err)
|
|
|
|
assert.Contains(err.Error(), ErrIntentionNotFound.Error())
|
2018-03-04 08:55:23 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test apply with update and a default deny ACL
|
|
|
|
func TestIntentionApply_aclUpdate(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:51:26 +00:00
|
|
|
|
|
|
|
assert := assert.New(t)
|
2018-03-04 08:55:23 +00:00
|
|
|
dir1, s1 := testServerWithConfig(t, func(c *Config) {
|
|
|
|
c.ACLDatacenter = "dc1"
|
2018-10-19 16:04:07 +00:00
|
|
|
c.ACLsEnabled = true
|
2018-03-04 08:55:23 +00:00
|
|
|
c.ACLMasterToken = "root"
|
|
|
|
c.ACLDefaultPolicy = "deny"
|
|
|
|
})
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Create an ACL with write permissions
|
|
|
|
var token string
|
|
|
|
{
|
|
|
|
var rules = `
|
|
|
|
service "foo" {
|
|
|
|
policy = "deny"
|
|
|
|
intentions = "write"
|
|
|
|
}`
|
|
|
|
|
|
|
|
req := structs.ACLRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.ACLSet,
|
|
|
|
ACL: structs.ACL{
|
|
|
|
Name: "User token",
|
2018-10-19 16:04:07 +00:00
|
|
|
Type: structs.ACLTokenTypeClient,
|
2018-03-04 08:55:23 +00:00
|
|
|
Rules: rules,
|
|
|
|
},
|
|
|
|
WriteRequest: structs.WriteRequest{Token: "root"},
|
|
|
|
}
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "ACL.Apply", &req, &token))
|
2018-03-04 08:55:23 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Setup a basic record to create
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: structs.TestIntention(t),
|
|
|
|
}
|
|
|
|
ixn.Intention.DestinationName = "foobar"
|
|
|
|
ixn.WriteRequest.Token = token
|
|
|
|
|
|
|
|
// Create
|
|
|
|
var reply string
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-03-04 08:55:23 +00:00
|
|
|
|
|
|
|
// Try to do an update without a token; this should get rejected.
|
|
|
|
ixn.Op = structs.IntentionOpUpdate
|
|
|
|
ixn.Intention.ID = reply
|
|
|
|
ixn.WriteRequest.Token = ""
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply)
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.True(acl.IsErrPermissionDenied(err))
|
2018-03-04 08:55:23 +00:00
|
|
|
|
|
|
|
// Try again with the original token; this should go through.
|
|
|
|
ixn.WriteRequest.Token = token
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-03-04 08:55:23 +00:00
|
|
|
}
|
|
|
|
|
2018-03-04 19:35:39 +00:00
|
|
|
// Test apply with a management token
|
|
|
|
func TestIntentionApply_aclManagement(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:51:26 +00:00
|
|
|
|
|
|
|
assert := assert.New(t)
|
2018-03-04 19:35:39 +00:00
|
|
|
dir1, s1 := testServerWithConfig(t, func(c *Config) {
|
|
|
|
c.ACLDatacenter = "dc1"
|
2018-10-19 16:04:07 +00:00
|
|
|
c.ACLsEnabled = true
|
2018-03-04 19:35:39 +00:00
|
|
|
c.ACLMasterToken = "root"
|
|
|
|
c.ACLDefaultPolicy = "deny"
|
|
|
|
})
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Setup a basic record to create
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: structs.TestIntention(t),
|
|
|
|
}
|
|
|
|
ixn.Intention.DestinationName = "foobar"
|
|
|
|
ixn.WriteRequest.Token = "root"
|
|
|
|
|
|
|
|
// Create
|
|
|
|
var reply string
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-03-04 19:35:39 +00:00
|
|
|
ixn.Intention.ID = reply
|
|
|
|
|
|
|
|
// Update
|
|
|
|
ixn.Op = structs.IntentionOpUpdate
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-03-04 19:35:39 +00:00
|
|
|
|
|
|
|
// Delete
|
|
|
|
ixn.Op = structs.IntentionOpDelete
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-03-04 19:35:39 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Test update changing the name where an ACL won't allow it
|
|
|
|
func TestIntentionApply_aclUpdateChange(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:51:26 +00:00
|
|
|
|
|
|
|
assert := assert.New(t)
|
2018-03-04 19:35:39 +00:00
|
|
|
dir1, s1 := testServerWithConfig(t, func(c *Config) {
|
|
|
|
c.ACLDatacenter = "dc1"
|
2018-10-19 16:04:07 +00:00
|
|
|
c.ACLsEnabled = true
|
2018-03-04 19:35:39 +00:00
|
|
|
c.ACLMasterToken = "root"
|
|
|
|
c.ACLDefaultPolicy = "deny"
|
|
|
|
})
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Create an ACL with write permissions
|
|
|
|
var token string
|
|
|
|
{
|
|
|
|
var rules = `
|
|
|
|
service "foo" {
|
|
|
|
policy = "deny"
|
|
|
|
intentions = "write"
|
|
|
|
}`
|
|
|
|
|
|
|
|
req := structs.ACLRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.ACLSet,
|
|
|
|
ACL: structs.ACL{
|
|
|
|
Name: "User token",
|
2018-10-19 16:04:07 +00:00
|
|
|
Type: structs.ACLTokenTypeClient,
|
2018-03-04 19:35:39 +00:00
|
|
|
Rules: rules,
|
|
|
|
},
|
|
|
|
WriteRequest: structs.WriteRequest{Token: "root"},
|
|
|
|
}
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "ACL.Apply", &req, &token))
|
2018-03-04 19:35:39 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Setup a basic record to create
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: structs.TestIntention(t),
|
|
|
|
}
|
|
|
|
ixn.Intention.DestinationName = "bar"
|
|
|
|
ixn.WriteRequest.Token = "root"
|
|
|
|
|
|
|
|
// Create
|
|
|
|
var reply string
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-03-04 19:35:39 +00:00
|
|
|
|
|
|
|
// Try to do an update without a token; this should get rejected.
|
|
|
|
ixn.Op = structs.IntentionOpUpdate
|
|
|
|
ixn.Intention.ID = reply
|
|
|
|
ixn.Intention.DestinationName = "foo"
|
|
|
|
ixn.WriteRequest.Token = token
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply)
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.True(acl.IsErrPermissionDenied(err))
|
2018-03-04 19:35:39 +00:00
|
|
|
}
|
|
|
|
|
2018-03-04 19:53:52 +00:00
|
|
|
// Test reading with ACLs
|
|
|
|
func TestIntentionGet_acl(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:51:26 +00:00
|
|
|
|
|
|
|
assert := assert.New(t)
|
2018-03-04 19:53:52 +00:00
|
|
|
dir1, s1 := testServerWithConfig(t, func(c *Config) {
|
|
|
|
c.ACLDatacenter = "dc1"
|
2018-10-19 16:04:07 +00:00
|
|
|
c.ACLsEnabled = true
|
2018-03-04 19:53:52 +00:00
|
|
|
c.ACLMasterToken = "root"
|
|
|
|
c.ACLDefaultPolicy = "deny"
|
|
|
|
})
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Create an ACL with service write permissions. This will grant
|
|
|
|
// intentions read.
|
|
|
|
var token string
|
|
|
|
{
|
|
|
|
var rules = `
|
|
|
|
service "foo" {
|
|
|
|
policy = "write"
|
|
|
|
}`
|
|
|
|
|
|
|
|
req := structs.ACLRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.ACLSet,
|
|
|
|
ACL: structs.ACL{
|
|
|
|
Name: "User token",
|
2018-10-19 16:04:07 +00:00
|
|
|
Type: structs.ACLTokenTypeClient,
|
2018-03-04 19:53:52 +00:00
|
|
|
Rules: rules,
|
|
|
|
},
|
|
|
|
WriteRequest: structs.WriteRequest{Token: "root"},
|
|
|
|
}
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "ACL.Apply", &req, &token))
|
2018-03-04 19:53:52 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Setup a basic record to create
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: structs.TestIntention(t),
|
|
|
|
}
|
|
|
|
ixn.Intention.DestinationName = "foobar"
|
|
|
|
ixn.WriteRequest.Token = "root"
|
|
|
|
|
|
|
|
// Create
|
|
|
|
var reply string
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-03-04 19:53:52 +00:00
|
|
|
ixn.Intention.ID = reply
|
|
|
|
|
|
|
|
// Read without token should be error
|
|
|
|
{
|
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
IntentionID: ixn.Intention.ID,
|
|
|
|
}
|
|
|
|
|
|
|
|
var resp structs.IndexedIntentions
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Get", req, &resp)
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.True(acl.IsErrPermissionDenied(err))
|
|
|
|
assert.Len(resp.Intentions, 0)
|
2018-03-04 19:53:52 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Read with token should work
|
|
|
|
{
|
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
IntentionID: ixn.Intention.ID,
|
|
|
|
QueryOptions: structs.QueryOptions{Token: token},
|
|
|
|
}
|
|
|
|
|
|
|
|
var resp structs.IndexedIntentions
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Get", req, &resp))
|
|
|
|
assert.Len(resp.Intentions, 1)
|
2018-03-04 19:53:52 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-02-28 18:04:27 +00:00
|
|
|
func TestIntentionList(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:35:20 +00:00
|
|
|
|
|
|
|
assert := assert.New(t)
|
2018-02-28 18:04:27 +00:00
|
|
|
dir1, s1 := testServer(t)
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Test with no intentions inserted yet
|
|
|
|
{
|
|
|
|
req := &structs.DCSpecificRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
}
|
|
|
|
var resp structs.IndexedIntentions
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.List", req, &resp))
|
|
|
|
assert.NotNil(resp.Intentions)
|
|
|
|
assert.Len(resp.Intentions, 0)
|
2018-02-28 18:04:27 +00:00
|
|
|
}
|
|
|
|
}
|
2018-03-02 21:40:03 +00:00
|
|
|
|
2018-03-05 02:32:28 +00:00
|
|
|
// Test listing with ACLs
|
|
|
|
func TestIntentionList_acl(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:51:26 +00:00
|
|
|
|
|
|
|
assert := assert.New(t)
|
2018-03-05 02:32:28 +00:00
|
|
|
dir1, s1 := testServerWithConfig(t, func(c *Config) {
|
|
|
|
c.ACLDatacenter = "dc1"
|
2018-10-19 16:04:07 +00:00
|
|
|
c.ACLsEnabled = true
|
2018-03-05 02:32:28 +00:00
|
|
|
c.ACLMasterToken = "root"
|
|
|
|
c.ACLDefaultPolicy = "deny"
|
|
|
|
})
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Create an ACL with service write permissions. This will grant
|
|
|
|
// intentions read.
|
|
|
|
var token string
|
|
|
|
{
|
|
|
|
var rules = `
|
|
|
|
service "foo" {
|
|
|
|
policy = "write"
|
|
|
|
}`
|
|
|
|
|
|
|
|
req := structs.ACLRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.ACLSet,
|
|
|
|
ACL: structs.ACL{
|
|
|
|
Name: "User token",
|
2018-10-19 16:04:07 +00:00
|
|
|
Type: structs.ACLTokenTypeClient,
|
2018-03-05 02:32:28 +00:00
|
|
|
Rules: rules,
|
|
|
|
},
|
|
|
|
WriteRequest: structs.WriteRequest{Token: "root"},
|
|
|
|
}
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "ACL.Apply", &req, &token))
|
2018-03-05 02:32:28 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Create a few records
|
|
|
|
for _, name := range []string{"foobar", "bar", "baz"} {
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: structs.TestIntention(t),
|
|
|
|
}
|
2020-01-24 15:04:58 +00:00
|
|
|
ixn.Intention.SourceNS = "default"
|
|
|
|
ixn.Intention.DestinationNS = "default"
|
2018-03-05 02:32:28 +00:00
|
|
|
ixn.Intention.DestinationName = name
|
|
|
|
ixn.WriteRequest.Token = "root"
|
|
|
|
|
|
|
|
// Create
|
|
|
|
var reply string
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-03-05 02:32:28 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Test with no token
|
|
|
|
{
|
|
|
|
req := &structs.DCSpecificRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
}
|
|
|
|
var resp structs.IndexedIntentions
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.List", req, &resp))
|
|
|
|
assert.Len(resp.Intentions, 0)
|
2018-03-05 02:32:28 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Test with management token
|
|
|
|
{
|
|
|
|
req := &structs.DCSpecificRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
QueryOptions: structs.QueryOptions{Token: "root"},
|
|
|
|
}
|
|
|
|
var resp structs.IndexedIntentions
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.List", req, &resp))
|
|
|
|
assert.Len(resp.Intentions, 3)
|
2018-03-05 02:32:28 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Test with user token
|
|
|
|
{
|
|
|
|
req := &structs.DCSpecificRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
QueryOptions: structs.QueryOptions{Token: token},
|
|
|
|
}
|
|
|
|
var resp structs.IndexedIntentions
|
2018-03-06 18:51:26 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.List", req, &resp))
|
|
|
|
assert.Len(resp.Intentions, 1)
|
2018-03-05 02:32:28 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-03-02 21:40:03 +00:00
|
|
|
// Test basic matching. We don't need to exhaustively test inputs since this
|
|
|
|
// is tested in the agent/consul/state package.
|
|
|
|
func TestIntentionMatch_good(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:35:20 +00:00
|
|
|
|
|
|
|
assert := assert.New(t)
|
2018-03-02 21:40:03 +00:00
|
|
|
dir1, s1 := testServer(t)
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Create some records
|
|
|
|
{
|
|
|
|
insert := [][]string{
|
2018-04-05 11:53:42 +00:00
|
|
|
{"foo", "*", "foo", "*"},
|
|
|
|
{"foo", "*", "foo", "bar"},
|
|
|
|
{"foo", "*", "foo", "baz"}, // shouldn't match
|
|
|
|
{"foo", "*", "bar", "bar"}, // shouldn't match
|
|
|
|
{"foo", "*", "bar", "*"}, // shouldn't match
|
|
|
|
{"foo", "*", "*", "*"},
|
|
|
|
{"bar", "*", "foo", "bar"}, // duplicate destination different source
|
2018-03-02 21:40:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
for _, v := range insert {
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: &structs.Intention{
|
2018-04-05 11:53:42 +00:00
|
|
|
SourceNS: v[0],
|
|
|
|
SourceName: v[1],
|
|
|
|
DestinationNS: v[2],
|
|
|
|
DestinationName: v[3],
|
2018-03-03 17:43:37 +00:00
|
|
|
Action: structs.IntentionActionAllow,
|
2018-03-02 21:40:03 +00:00
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
// Create
|
|
|
|
var reply string
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-03-02 21:40:03 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Match
|
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Match: &structs.IntentionQueryMatch{
|
|
|
|
Type: structs.IntentionMatchDestination,
|
|
|
|
Entries: []structs.IntentionMatchEntry{
|
|
|
|
{
|
|
|
|
Namespace: "foo",
|
|
|
|
Name: "bar",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
var resp structs.IndexedIntentionMatches
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Match", req, &resp))
|
|
|
|
assert.Len(resp.Matches, 1)
|
2018-03-02 21:40:03 +00:00
|
|
|
|
2018-04-05 11:53:42 +00:00
|
|
|
expected := [][]string{
|
|
|
|
{"bar", "*", "foo", "bar"},
|
|
|
|
{"foo", "*", "foo", "bar"},
|
|
|
|
{"foo", "*", "foo", "*"},
|
|
|
|
{"foo", "*", "*", "*"},
|
|
|
|
}
|
2018-03-02 21:40:03 +00:00
|
|
|
var actual [][]string
|
|
|
|
for _, ixn := range resp.Matches[0] {
|
2018-04-05 11:53:42 +00:00
|
|
|
actual = append(actual, []string{
|
|
|
|
ixn.SourceNS,
|
|
|
|
ixn.SourceName,
|
|
|
|
ixn.DestinationNS,
|
|
|
|
ixn.DestinationName,
|
|
|
|
})
|
2018-03-02 21:40:03 +00:00
|
|
|
}
|
2018-03-06 18:35:20 +00:00
|
|
|
assert.Equal(expected, actual)
|
2018-03-02 21:40:03 +00:00
|
|
|
}
|
2018-03-05 02:32:28 +00:00
|
|
|
|
|
|
|
// Test matching with ACLs
|
|
|
|
func TestIntentionMatch_acl(t *testing.T) {
|
|
|
|
t.Parallel()
|
2018-03-06 18:51:26 +00:00
|
|
|
|
2020-01-24 15:04:58 +00:00
|
|
|
dir1, s1 := testACLServerWithConfig(t, nil, false)
|
2018-03-05 02:32:28 +00:00
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
2020-01-24 15:04:58 +00:00
|
|
|
token, err := upsertTestTokenWithPolicyRules(codec, TestDefaultMasterToken, "dc1", `service "bar" { policy = "write" }`)
|
|
|
|
require.NoError(t, err)
|
2018-03-05 02:32:28 +00:00
|
|
|
|
|
|
|
// Create some records
|
|
|
|
{
|
2020-01-24 15:04:58 +00:00
|
|
|
insert := []string{
|
|
|
|
"*",
|
|
|
|
"bar",
|
|
|
|
"baz",
|
2018-03-05 02:32:28 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
for _, v := range insert {
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: structs.TestIntention(t),
|
|
|
|
}
|
2020-01-24 15:04:58 +00:00
|
|
|
ixn.Intention.DestinationName = v
|
|
|
|
ixn.WriteRequest.Token = TestDefaultMasterToken
|
2018-03-05 02:32:28 +00:00
|
|
|
|
|
|
|
// Create
|
|
|
|
var reply string
|
2020-01-24 15:04:58 +00:00
|
|
|
require.Nil(t, msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-03-05 02:32:28 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test with no token
|
|
|
|
{
|
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Match: &structs.IntentionQueryMatch{
|
|
|
|
Type: structs.IntentionMatchDestination,
|
|
|
|
Entries: []structs.IntentionMatchEntry{
|
|
|
|
{
|
2020-01-24 15:04:58 +00:00
|
|
|
Namespace: "default",
|
2018-03-05 02:32:28 +00:00
|
|
|
Name: "bar",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
var resp structs.IndexedIntentionMatches
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Match", req, &resp)
|
2020-01-24 15:04:58 +00:00
|
|
|
require.True(t, acl.IsErrPermissionDenied(err))
|
|
|
|
require.Len(t, resp.Matches, 0)
|
2018-03-05 02:32:28 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Test with proper token
|
|
|
|
{
|
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Match: &structs.IntentionQueryMatch{
|
|
|
|
Type: structs.IntentionMatchDestination,
|
|
|
|
Entries: []structs.IntentionMatchEntry{
|
|
|
|
{
|
2020-01-24 15:04:58 +00:00
|
|
|
Namespace: "default",
|
2018-03-05 02:32:28 +00:00
|
|
|
Name: "bar",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
2020-01-24 15:04:58 +00:00
|
|
|
QueryOptions: structs.QueryOptions{Token: token.SecretID},
|
2018-03-05 02:32:28 +00:00
|
|
|
}
|
|
|
|
var resp structs.IndexedIntentionMatches
|
2020-01-24 15:04:58 +00:00
|
|
|
require.NoError(t, msgpackrpc.CallWithCodec(codec, "Intention.Match", req, &resp))
|
|
|
|
require.Len(t, resp.Matches, 1)
|
2018-03-05 02:32:28 +00:00
|
|
|
|
2020-01-24 15:04:58 +00:00
|
|
|
expected := []string{"bar", "*"}
|
|
|
|
var actual []string
|
2018-03-05 02:32:28 +00:00
|
|
|
for _, ixn := range resp.Matches[0] {
|
2020-01-24 15:04:58 +00:00
|
|
|
actual = append(actual, ixn.DestinationName)
|
2018-03-05 02:32:28 +00:00
|
|
|
}
|
|
|
|
|
2020-01-24 15:04:58 +00:00
|
|
|
require.ElementsMatch(t, expected, actual)
|
2018-03-05 02:32:28 +00:00
|
|
|
}
|
|
|
|
}
|
2018-05-11 05:35:47 +00:00
|
|
|
|
2018-05-11 16:19:22 +00:00
|
|
|
// Test the Check method defaults to allow with no ACL set.
|
|
|
|
func TestIntentionCheck_defaultNoACL(t *testing.T) {
|
2018-05-11 05:35:47 +00:00
|
|
|
t.Parallel()
|
|
|
|
|
|
|
|
require := require.New(t)
|
|
|
|
dir1, s1 := testServer(t)
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Test
|
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
2018-05-11 16:19:22 +00:00
|
|
|
Check: &structs.IntentionQueryCheck{
|
2018-05-11 05:35:47 +00:00
|
|
|
SourceNS: "foo",
|
|
|
|
SourceName: "bar",
|
|
|
|
DestinationNS: "foo",
|
|
|
|
DestinationName: "qux",
|
|
|
|
SourceType: structs.IntentionSourceConsul,
|
|
|
|
},
|
|
|
|
}
|
2018-05-11 16:19:22 +00:00
|
|
|
var resp structs.IntentionQueryCheckResponse
|
|
|
|
require.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Check", req, &resp))
|
2018-05-11 05:35:47 +00:00
|
|
|
require.True(resp.Allowed)
|
|
|
|
}
|
|
|
|
|
2018-05-11 16:19:22 +00:00
|
|
|
// Test the Check method defaults to deny with whitelist ACLs.
|
|
|
|
func TestIntentionCheck_defaultACLDeny(t *testing.T) {
|
2018-05-11 05:35:47 +00:00
|
|
|
t.Parallel()
|
|
|
|
|
|
|
|
require := require.New(t)
|
|
|
|
dir1, s1 := testServerWithConfig(t, func(c *Config) {
|
|
|
|
c.ACLDatacenter = "dc1"
|
2018-10-19 16:04:07 +00:00
|
|
|
c.ACLsEnabled = true
|
2018-05-11 05:35:47 +00:00
|
|
|
c.ACLMasterToken = "root"
|
|
|
|
c.ACLDefaultPolicy = "deny"
|
|
|
|
})
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
2018-05-11 16:19:22 +00:00
|
|
|
// Check
|
2018-05-11 05:35:47 +00:00
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
2018-05-11 16:19:22 +00:00
|
|
|
Check: &structs.IntentionQueryCheck{
|
2018-05-11 05:35:47 +00:00
|
|
|
SourceNS: "foo",
|
|
|
|
SourceName: "bar",
|
|
|
|
DestinationNS: "foo",
|
|
|
|
DestinationName: "qux",
|
|
|
|
SourceType: structs.IntentionSourceConsul,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
req.Token = "root"
|
2018-05-11 16:19:22 +00:00
|
|
|
var resp structs.IntentionQueryCheckResponse
|
|
|
|
require.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Check", req, &resp))
|
2018-05-11 05:35:47 +00:00
|
|
|
require.False(resp.Allowed)
|
|
|
|
}
|
|
|
|
|
2018-05-11 16:19:22 +00:00
|
|
|
// Test the Check method defaults to deny with blacklist ACLs.
|
|
|
|
func TestIntentionCheck_defaultACLAllow(t *testing.T) {
|
2018-05-11 05:35:47 +00:00
|
|
|
t.Parallel()
|
|
|
|
|
|
|
|
require := require.New(t)
|
|
|
|
dir1, s1 := testServerWithConfig(t, func(c *Config) {
|
|
|
|
c.ACLDatacenter = "dc1"
|
2018-10-19 16:04:07 +00:00
|
|
|
c.ACLsEnabled = true
|
2018-05-11 05:35:47 +00:00
|
|
|
c.ACLMasterToken = "root"
|
|
|
|
c.ACLDefaultPolicy = "allow"
|
|
|
|
})
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
2018-05-11 16:19:22 +00:00
|
|
|
// Check
|
2018-05-11 05:35:47 +00:00
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
2018-05-11 16:19:22 +00:00
|
|
|
Check: &structs.IntentionQueryCheck{
|
2018-05-11 05:35:47 +00:00
|
|
|
SourceNS: "foo",
|
|
|
|
SourceName: "bar",
|
|
|
|
DestinationNS: "foo",
|
|
|
|
DestinationName: "qux",
|
|
|
|
SourceType: structs.IntentionSourceConsul,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
req.Token = "root"
|
2018-05-11 16:19:22 +00:00
|
|
|
var resp structs.IntentionQueryCheckResponse
|
|
|
|
require.Nil(msgpackrpc.CallWithCodec(codec, "Intention.Check", req, &resp))
|
2018-05-11 05:35:47 +00:00
|
|
|
require.True(resp.Allowed)
|
|
|
|
}
|
|
|
|
|
2018-05-11 16:19:22 +00:00
|
|
|
// Test the Check method requires service:read permission.
|
|
|
|
func TestIntentionCheck_aclDeny(t *testing.T) {
|
2018-05-11 05:35:47 +00:00
|
|
|
t.Parallel()
|
|
|
|
|
|
|
|
require := require.New(t)
|
|
|
|
dir1, s1 := testServerWithConfig(t, func(c *Config) {
|
|
|
|
c.ACLDatacenter = "dc1"
|
2018-10-19 16:04:07 +00:00
|
|
|
c.ACLsEnabled = true
|
2018-05-11 05:35:47 +00:00
|
|
|
c.ACLMasterToken = "root"
|
|
|
|
c.ACLDefaultPolicy = "deny"
|
|
|
|
})
|
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
|
|
|
// Create an ACL with service read permissions. This will grant permission.
|
|
|
|
var token string
|
|
|
|
{
|
|
|
|
var rules = `
|
|
|
|
service "bar" {
|
|
|
|
policy = "read"
|
|
|
|
}`
|
|
|
|
|
|
|
|
req := structs.ACLRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.ACLSet,
|
|
|
|
ACL: structs.ACL{
|
|
|
|
Name: "User token",
|
2018-10-19 16:04:07 +00:00
|
|
|
Type: structs.ACLTokenTypeClient,
|
2018-05-11 05:35:47 +00:00
|
|
|
Rules: rules,
|
|
|
|
},
|
|
|
|
WriteRequest: structs.WriteRequest{Token: "root"},
|
|
|
|
}
|
|
|
|
require.Nil(msgpackrpc.CallWithCodec(codec, "ACL.Apply", &req, &token))
|
|
|
|
}
|
|
|
|
|
2018-05-11 16:19:22 +00:00
|
|
|
// Check
|
2018-05-11 05:35:47 +00:00
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
2018-05-11 16:19:22 +00:00
|
|
|
Check: &structs.IntentionQueryCheck{
|
2018-05-11 05:35:47 +00:00
|
|
|
SourceNS: "foo",
|
|
|
|
SourceName: "qux",
|
|
|
|
DestinationNS: "foo",
|
|
|
|
DestinationName: "baz",
|
|
|
|
SourceType: structs.IntentionSourceConsul,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
req.Token = token
|
2018-05-11 16:19:22 +00:00
|
|
|
var resp structs.IntentionQueryCheckResponse
|
|
|
|
err := msgpackrpc.CallWithCodec(codec, "Intention.Check", req, &resp)
|
2018-05-11 05:35:47 +00:00
|
|
|
require.True(acl.IsErrPermissionDenied(err))
|
|
|
|
}
|
|
|
|
|
2018-05-11 16:19:22 +00:00
|
|
|
// Test the Check method returns allow/deny properly.
|
|
|
|
func TestIntentionCheck_match(t *testing.T) {
|
2018-05-11 05:35:47 +00:00
|
|
|
t.Parallel()
|
|
|
|
|
2020-01-13 20:51:40 +00:00
|
|
|
dir1, s1 := testACLServerWithConfig(t, nil, false)
|
2018-05-11 05:35:47 +00:00
|
|
|
defer os.RemoveAll(dir1)
|
|
|
|
defer s1.Shutdown()
|
|
|
|
codec := rpcClient(t, s1)
|
|
|
|
defer codec.Close()
|
|
|
|
|
|
|
|
testrpc.WaitForLeader(t, s1.RPC, "dc1")
|
|
|
|
|
2020-01-13 20:51:40 +00:00
|
|
|
token, err := upsertTestTokenWithPolicyRules(codec, TestDefaultMasterToken, "dc1", `service "api" { policy = "read" }`)
|
|
|
|
require.NoError(t, err)
|
2018-05-11 05:35:47 +00:00
|
|
|
|
|
|
|
// Create some intentions
|
|
|
|
{
|
|
|
|
insert := [][]string{
|
2020-01-13 20:51:40 +00:00
|
|
|
{"web", "db"},
|
|
|
|
{"api", "db"},
|
|
|
|
{"web", "api"},
|
2018-05-11 05:35:47 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
for _, v := range insert {
|
|
|
|
ixn := structs.IntentionRequest{
|
|
|
|
Datacenter: "dc1",
|
|
|
|
Op: structs.IntentionOpCreate,
|
|
|
|
Intention: &structs.Intention{
|
2020-01-13 20:51:40 +00:00
|
|
|
SourceNS: "default",
|
|
|
|
SourceName: v[0],
|
|
|
|
DestinationNS: "default",
|
|
|
|
DestinationName: v[1],
|
2018-05-11 05:35:47 +00:00
|
|
|
Action: structs.IntentionActionAllow,
|
|
|
|
},
|
2020-01-13 20:51:40 +00:00
|
|
|
WriteRequest: structs.WriteRequest{Token: TestDefaultMasterToken},
|
2018-05-11 05:35:47 +00:00
|
|
|
}
|
|
|
|
// Create
|
|
|
|
var reply string
|
2020-01-13 20:51:40 +00:00
|
|
|
require.NoError(t, msgpackrpc.CallWithCodec(codec, "Intention.Apply", &ixn, &reply))
|
2018-05-11 05:35:47 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-05-11 16:19:22 +00:00
|
|
|
// Check
|
2018-05-11 05:35:47 +00:00
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
2018-05-11 16:19:22 +00:00
|
|
|
Check: &structs.IntentionQueryCheck{
|
2020-01-13 20:51:40 +00:00
|
|
|
SourceNS: "default",
|
|
|
|
SourceName: "web",
|
|
|
|
DestinationNS: "default",
|
|
|
|
DestinationName: "api",
|
2018-05-11 05:35:47 +00:00
|
|
|
SourceType: structs.IntentionSourceConsul,
|
|
|
|
},
|
2020-01-13 20:51:40 +00:00
|
|
|
QueryOptions: structs.QueryOptions{Token: token.SecretID},
|
2018-05-11 05:35:47 +00:00
|
|
|
}
|
2018-05-11 16:19:22 +00:00
|
|
|
var resp structs.IntentionQueryCheckResponse
|
2020-01-13 20:51:40 +00:00
|
|
|
require.NoError(t, msgpackrpc.CallWithCodec(codec, "Intention.Check", req, &resp))
|
|
|
|
require.True(t, resp.Allowed)
|
2018-05-11 05:35:47 +00:00
|
|
|
|
|
|
|
// Test no match for sanity
|
|
|
|
{
|
|
|
|
req := &structs.IntentionQueryRequest{
|
|
|
|
Datacenter: "dc1",
|
2018-05-11 16:19:22 +00:00
|
|
|
Check: &structs.IntentionQueryCheck{
|
2020-01-13 20:51:40 +00:00
|
|
|
SourceNS: "default",
|
|
|
|
SourceName: "db",
|
|
|
|
DestinationNS: "default",
|
|
|
|
DestinationName: "api",
|
2018-05-11 05:35:47 +00:00
|
|
|
SourceType: structs.IntentionSourceConsul,
|
|
|
|
},
|
2020-01-13 20:51:40 +00:00
|
|
|
QueryOptions: structs.QueryOptions{Token: token.SecretID},
|
2018-05-11 05:35:47 +00:00
|
|
|
}
|
2018-05-11 16:19:22 +00:00
|
|
|
var resp structs.IntentionQueryCheckResponse
|
2020-01-13 20:51:40 +00:00
|
|
|
require.NoError(t, msgpackrpc.CallWithCodec(codec, "Intention.Check", req, &resp))
|
|
|
|
require.False(t, resp.Allowed)
|
2018-05-11 05:35:47 +00:00
|
|
|
}
|
|
|
|
}
|