open-consul/agent/consul/gateway_locator_test.go

package consul

import (
	"errors"
	"testing"
	"time"

	memdb "github.com/hashicorp/go-memdb"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"

	"github.com/hashicorp/consul/agent/consul/state"
	"github.com/hashicorp/consul/agent/structs"
	"github.com/hashicorp/consul/api"
	"github.com/hashicorp/consul/sdk/testutil"
)

func TestGatewayLocator(t *testing.T) {
	state := state.NewStateStore(nil)

	serverRoles := []string{"leader", "follower"}
	now := time.Now().UTC()

	dc1 := &structs.FederationState{
		Datacenter: "dc1",
		MeshGateways: []structs.CheckServiceNode{
			newTestMeshGatewayNode(
				"dc1", "gateway1", "1.2.3.4", 5555, map[string]string{structs.MetaWANFederationKey: "1"}, api.HealthPassing,
			),
			newTestMeshGatewayNode(
				"dc1", "gateway2", "4.3.2.1", 9999, map[string]string{structs.MetaWANFederationKey: "1"}, api.HealthPassing,
			),
		},
		UpdatedAt: time.Now().UTC(),
	}
	dc2 := &structs.FederationState{
		Datacenter: "dc2",
		MeshGateways: []structs.CheckServiceNode{
			newTestMeshGatewayNode(
				"dc2", "gateway1", "5.6.7.8", 5555, map[string]string{structs.MetaWANFederationKey: "1"}, api.HealthPassing,
			),
			newTestMeshGatewayNode(
				"dc2", "gateway2", "8.7.6.5", 9999, map[string]string{structs.MetaWANFederationKey: "1"}, api.HealthPassing,
			),
		},
		UpdatedAt: time.Now().UTC(),
	}

	t.Run("primary - no data", func(t *testing.T) {
		for _, role := range serverRoles {
			t.Run(role, func(t *testing.T) {
				isLeader := role == "leader"

				logger := testutil.Logger(t)
				tsd := &testServerDelegate{State: state, isLeader: isLeader}
				if !isLeader {
					tsd.lastContact = now
				}
				g := NewGatewayLocator(
					logger,
					tsd,
					"dc1",
					"dc1",
				)
				g.SetUseReplicationSignal(isLeader)

				idx, err := g.runOnce(0)
				require.NoError(t, err)
				assert.False(t, g.DialPrimaryThroughLocalGateway())
				assert.Equal(t, uint64(1), idx)
				assert.Len(t, tsd.Calls, 1)
				assert.Equal(t, []string(nil), g.listGateways(false))
				assert.Equal(t, []string(nil), g.listGateways(true))
			})
		}
	})

	t.Run("secondary - no data", func(t *testing.T) {
		for _, role := range serverRoles {
			t.Run(role, func(t *testing.T) {
				isLeader := role == "leader"

				logger := testutil.Logger(t)
				tsd := &testServerDelegate{State: state, isLeader: isLeader}
				if !isLeader {
					tsd.lastContact = now
				}
				g := NewGatewayLocator(
					logger,
					tsd,
					"dc2",
					"dc1",
				)
				g.SetUseReplicationSignal(isLeader)

				idx, err := g.runOnce(0)
				require.NoError(t, err)
				if isLeader {
					assert.False(t, g.DialPrimaryThroughLocalGateway())
				} else {
					assert.True(t, g.DialPrimaryThroughLocalGateway())
				}
				assert.Equal(t, uint64(1), idx)
				assert.Len(t, tsd.Calls, 1)
				assert.Equal(t, []string(nil), g.listGateways(false))
				assert.Equal(t, []string(nil), g.listGateways(true))
			})
		}
	})

	t.Run("secondary - just fallback", func(t *testing.T) {
		for _, role := range serverRoles {
			t.Run(role, func(t *testing.T) {
				isLeader := role == "leader"

				logger := testutil.Logger(t)
				tsd := &testServerDelegate{State: state, isLeader: isLeader}
				if !isLeader {
					tsd.lastContact = now
				}
				g := NewGatewayLocator(
					logger,
					tsd,
					"dc2",
					"dc1",
				)
				g.SetUseReplicationSignal(isLeader)
				g.RefreshPrimaryGatewayFallbackAddresses([]string{
					"7.7.7.7:7777",
					"8.8.8.8:8888",
				})

				idx, err := g.runOnce(0)
				require.NoError(t, err)
				if isLeader {
					assert.False(t, g.DialPrimaryThroughLocalGateway())
				} else {
					assert.True(t, g.DialPrimaryThroughLocalGateway())
				}
				assert.Equal(t, uint64(1), idx)
				assert.Len(t, tsd.Calls, 1)
				assert.Equal(t, []string(nil), g.listGateways(false))
				assert.Equal(t, []string{
					"7.7.7.7:7777",
					"8.8.8.8:8888",
				}, g.listGateways(true))
			})
		}
	})

	// Insert data for the dcs
	require.NoError(t, state.FederationStateSet(1, dc1))
	require.NoError(t, state.FederationStateSet(2, dc2))

	t.Run("primary - with data", func(t *testing.T) {
		for _, role := range serverRoles {
			t.Run(role, func(t *testing.T) {
				isLeader := role == "leader"

				logger := testutil.Logger(t)
				tsd := &testServerDelegate{State: state, isLeader: isLeader}
				if !isLeader {
					tsd.lastContact = now
				}
				g := NewGatewayLocator(
					logger,
					tsd,
					"dc1",
					"dc1",
				)
				g.SetUseReplicationSignal(isLeader)

				idx, err := g.runOnce(0)
				require.NoError(t, err)
				assert.False(t, g.DialPrimaryThroughLocalGateway())
				assert.Equal(t, uint64(2), idx)
				assert.Len(t, tsd.Calls, 1)
				assert.Equal(t, []string{
					"1.2.3.4:5555",
					"4.3.2.1:9999",
				}, g.listGateways(false))
				assert.Equal(t, []string{
					"1.2.3.4:5555",
					"4.3.2.1:9999",
				}, g.listGateways(true))
			})
		}
	})

	t.Run("secondary - with data", func(t *testing.T) {
		for _, role := range serverRoles {
			t.Run(role, func(t *testing.T) {
				isLeader := role == "leader"

				logger := testutil.Logger(t)
				tsd := &testServerDelegate{State: state, isLeader: isLeader}
				if !isLeader {
					tsd.lastContact = now
				}
				g := NewGatewayLocator(
					logger,
					tsd,
					"dc2",
					"dc1",
				)
				g.SetUseReplicationSignal(isLeader)

				idx, err := g.runOnce(0)
				require.NoError(t, err)
				if isLeader {
					assert.False(t, g.DialPrimaryThroughLocalGateway())
				} else {
					assert.True(t, g.DialPrimaryThroughLocalGateway())
				}
				assert.Equal(t, uint64(2), idx)
				assert.Len(t, tsd.Calls, 1)
				assert.Equal(t, []string{
					"5.6.7.8:5555",
					"8.7.6.5:9999",
				}, g.listGateways(false))
				if isLeader {
					assert.Equal(t, []string{
						"1.2.3.4:5555",
						"4.3.2.1:9999",
					}, g.listGateways(true))
				} else {
					assert.Equal(t, []string{
						"5.6.7.8:5555",
						"8.7.6.5:9999",
					}, g.listGateways(true))
				}
			})
		}
	})

	t.Run("secondary - with data and fallback - no repl", func(t *testing.T) {
		// Only run for the leader.
		logger := testutil.Logger(t)
		tsd := &testServerDelegate{State: state, isLeader: true}
		g := NewGatewayLocator(
			logger,
			tsd,
			"dc2",
			"dc1",
		)
		g.SetUseReplicationSignal(true)

		g.RefreshPrimaryGatewayFallbackAddresses([]string{
			"7.7.7.7:7777",
			"8.8.8.8:8888",
		})

		idx, err := g.runOnce(0)
		require.NoError(t, err)
		assert.False(t, g.DialPrimaryThroughLocalGateway())
		assert.Equal(t, uint64(2), idx)
		assert.Len(t, tsd.Calls, 1)
		assert.Equal(t, []string{
			"5.6.7.8:5555",
			"8.7.6.5:9999",
		}, g.listGateways(false))
		assert.Equal(t, []string{
			"1.2.3.4:5555",
			"4.3.2.1:9999",
			"7.7.7.7:7777",
			"8.8.8.8:8888",
		}, g.listGateways(true))
	})

	t.Run("secondary - with data and fallback - repl ok", func(t *testing.T) {
		// Only run for the leader.
		logger := testutil.Logger(t)
		tsd := &testServerDelegate{State: state, isLeader: true}
		g := NewGatewayLocator(
			logger,
			tsd,
			"dc2",
			"dc1",
		)
		g.SetUseReplicationSignal(true)

		g.RefreshPrimaryGatewayFallbackAddresses([]string{
			"7.7.7.7:7777",
			"8.8.8.8:8888",
		})

		g.SetLastFederationStateReplicationError(nil, true)

		idx, err := g.runOnce(0)
		require.NoError(t, err)
		assert.True(t, g.DialPrimaryThroughLocalGateway())
		assert.Equal(t, uint64(2), idx)
		assert.Len(t, tsd.Calls, 1)
		assert.Equal(t, []string{
			"5.6.7.8:5555",
			"8.7.6.5:9999",
		}, g.listGateways(false))
		assert.Equal(t, []string{
			"5.6.7.8:5555",
			"8.7.6.5:9999",
		}, g.listGateways(true))
	})

	t.Run("secondary - with data and fallback - repl ok then failed 2 times", func(t *testing.T) {
		// Only run for the leader.
		logger := testutil.Logger(t)
		tsd := &testServerDelegate{State: state, isLeader: true}
		g := NewGatewayLocator(
			logger,
			tsd,
			"dc2",
			"dc1",
		)
		g.SetUseReplicationSignal(true)

		g.RefreshPrimaryGatewayFallbackAddresses([]string{
			"7.7.7.7:7777",
			"8.8.8.8:8888",
		})

		g.SetLastFederationStateReplicationError(nil, true)
		g.SetLastFederationStateReplicationError(errors.New("fake"), true)
		g.SetLastFederationStateReplicationError(errors.New("fake"), true)

		idx, err := g.runOnce(0)
		require.NoError(t, err)
		assert.True(t, g.DialPrimaryThroughLocalGateway())
		assert.Equal(t, uint64(2), idx)
		assert.Len(t, tsd.Calls, 1)
		assert.Equal(t, []string{
			"5.6.7.8:5555",
			"8.7.6.5:9999",
		}, g.listGateways(false))
		assert.Equal(t, []string{
			"5.6.7.8:5555",
			"8.7.6.5:9999",
		}, g.listGateways(true))
	})

	t.Run("secondary - with data and fallback - repl ok then failed 3 times", func(t *testing.T) {
		// Only run for the leader.
		logger := testutil.Logger(t)
		tsd := &testServerDelegate{State: state, isLeader: true}
		g := NewGatewayLocator(
			logger,
			tsd,
			"dc2",
			"dc1",
		)
		g.SetUseReplicationSignal(true)

		g.RefreshPrimaryGatewayFallbackAddresses([]string{
			"7.7.7.7:7777",
			"8.8.8.8:8888",
		})

		g.SetLastFederationStateReplicationError(nil, true)
		g.SetLastFederationStateReplicationError(errors.New("fake"), true)
		g.SetLastFederationStateReplicationError(errors.New("fake"), true)
		g.SetLastFederationStateReplicationError(errors.New("fake"), true)

		idx, err := g.runOnce(0)
		require.NoError(t, err)
		assert.False(t, g.DialPrimaryThroughLocalGateway())
		assert.Equal(t, uint64(2), idx)
		assert.Len(t, tsd.Calls, 1)
		assert.Equal(t, []string{
			"5.6.7.8:5555",
			"8.7.6.5:9999",
		}, g.listGateways(false))
		assert.Equal(t, []string{
			"1.2.3.4:5555",
			"4.3.2.1:9999",
			"7.7.7.7:7777",
			"8.8.8.8:8888",
		}, g.listGateways(true))
	})

	t.Run("secondary - with data and fallback - repl ok then failed 3 times then ok again", func(t *testing.T) {
		// Only run for the leader.
		logger := testutil.Logger(t)
		tsd := &testServerDelegate{State: state, isLeader: true}
		g := NewGatewayLocator(
			logger,
			tsd,
			"dc2",
			"dc1",
		)
		g.SetUseReplicationSignal(true)

		g.RefreshPrimaryGatewayFallbackAddresses([]string{
			"7.7.7.7:7777",
			"8.8.8.8:8888",
		})

		g.SetLastFederationStateReplicationError(nil, true)
		g.SetLastFederationStateReplicationError(errors.New("fake"), true)
		g.SetLastFederationStateReplicationError(errors.New("fake"), true)
		g.SetLastFederationStateReplicationError(errors.New("fake"), true)
		g.SetLastFederationStateReplicationError(nil, true)

		idx, err := g.runOnce(0)
		require.NoError(t, err)
		assert.True(t, g.DialPrimaryThroughLocalGateway())
		assert.Equal(t, uint64(2), idx)
		assert.Len(t, tsd.Calls, 1)
		assert.Equal(t, []string{
			"5.6.7.8:5555",
			"8.7.6.5:9999",
		}, g.listGateways(false))
		assert.Equal(t, []string{
			"5.6.7.8:5555",
			"8.7.6.5:9999",
		}, g.listGateways(true))
	})
}

type testServerDelegate struct {
	State *state.Store

	Calls []uint64

	isLeader    bool
	lastContact time.Time
}

// This is just enough to exercise the logic.
func (d *testServerDelegate) blockingQuery(
	queryOpts structs.QueryOptionsCompat,
	queryMeta structs.QueryMetaCompat,
	fn queryFn,
) error {
	minQueryIndex := queryOpts.GetMinQueryIndex()

	d.Calls = append(d.Calls, minQueryIndex)

	var ws memdb.WatchSet

	err := fn(ws, d.State)
	if err == nil && queryMeta.GetIndex() < 1 {
		queryMeta.SetIndex(1)
	}

	return err
}

func (d *testServerDelegate) IsLeader() bool {
	return d.isLeader
}

func (d *testServerDelegate) LeaderLastContact() time.Time {
	return d.lastContact
}