mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-29 00:34:03 +00:00
499c9448d0
Summary: Although added to db_stress, testing of backup/restore was never integrated into the crash test, originally concerned about performance. I've enabled it now and to address the peformance concern, testing backup/restore is always skipped once the db exceeds a certain size threshold, default 100MB. This should provide sufficient opportunity for testing BackupEngine without bogging down everything else with heavier and heavier operations. Also fixed backup/restore in db_stress by making sure PurgeOldBackups can remove manifest files, which are normally kept around for db_stress. Added more coverage of backup options, and up to three backups being saved in one backup directory (in some cases). Pull Request resolved: https://github.com/facebook/rocksdb/pull/7348 Test Plan: ran 'make blackbox_crash_test' for a while, with heightened probabilitly of taking backups (1/10k). Also confirmed with some debug output that the code is being covered, TestBackupRestore only takes a few seconds to complete when triggered, and even at 1/10k and ~50MB database, there's <,~ 1 thread testing backups at any time. Reviewed By: ajkr Differential Revision: D23510835 Pulled By: pdillinger fbshipit-source-id: b6b8735591808141f81f10773ac31634cf03b6c0
39 lines
1.5 KiB
C++
39 lines
1.5 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#ifdef GFLAGS
|
|
#pragma once
|
|
#include "db_stress_tool/db_stress_common.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
class DbStressEnvWrapper : public EnvWrapper {
|
|
public:
|
|
explicit DbStressEnvWrapper(Env* t) : EnvWrapper(t) {}
|
|
|
|
Status DeleteFile(const std::string& f) override {
|
|
// We determine whether it is a manifest file by searching a strong,
|
|
// so that there will be false positive if the directory path contains the
|
|
// keyword but it is unlikely.
|
|
// Checkpoint, backup, and restore directories needs to be exempted.
|
|
if (!if_preserve_all_manifests ||
|
|
f.find("MANIFEST-") == std::string::npos ||
|
|
f.find("checkpoint") != std::string::npos ||
|
|
f.find(".backup") != std::string::npos ||
|
|
f.find(".restore") != std::string::npos) {
|
|
return target()->DeleteFile(f);
|
|
}
|
|
return Status::OK();
|
|
}
|
|
|
|
// If true, all manifest files will not be delted in DeleteFile().
|
|
bool if_preserve_all_manifests = true;
|
|
};
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
#endif // GFLAGS
|