mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-29 00:34:03 +00:00
e5e545a021
Summary: These code paths forked when checkpoint was introduced by copy/pasting the core backup logic. Over time they diverged and bug fixes were sometimes applied to one but not the other (like fix to include all relevant WALs for 2PC), or it required extra effort to fix both (like fix to forge CURRENT file). This diff reunites the code paths by extracting the core logic into a function, CreateCustomCheckpoint(), that is customizable via callbacks to implement both checkpoint and backup. Related changes: - flush_before_backup is now forcibly enabled when 2PC is enabled - Extracted CheckpointImpl class definition into a header file. This is so the function, CreateCustomCheckpoint(), can be called by internal rocksdb code but not exposed to users. - Implemented more functions in DummyDB/DummyLogFile (in backupable_db_test.cc) that are used by CreateCustomCheckpoint(). Closes https://github.com/facebook/rocksdb/pull/1932 Differential Revision: D4622986 Pulled By: ajkr fbshipit-source-id: 157723884236ee3999a682673b64f7457a7a0d87 |
||
|---|---|---|
| .. | ||
| backupable | ||
| blob_db | ||
| checkpoint | ||
| compaction_filters | ||
| convenience | ||
| date_tiered | ||
| document | ||
| geodb | ||
| leveldb_options | ||
| lua | ||
| memory | ||
| merge_operators | ||
| option_change_migration | ||
| options | ||
| persistent_cache | ||
| redis | ||
| simulator_cache | ||
| spatialdb | ||
| table_properties_collectors | ||
| transactions | ||
| ttl | ||
| write_batch_with_index | ||
| col_buf_decoder.cc | ||
| col_buf_decoder.h | ||
| col_buf_encoder.cc | ||
| col_buf_encoder.h | ||
| column_aware_encoding_exp.cc | ||
| column_aware_encoding_test.cc | ||
| column_aware_encoding_util.cc | ||
| column_aware_encoding_util.h | ||
| env_librados.cc | ||
| env_librados.md | ||
| env_librados_test.cc | ||
| env_mirror.cc | ||
| env_mirror_test.cc | ||
| env_timed.cc | ||
| env_timed_test.cc | ||
| merge_operators.h | ||
| object_registry_test.cc | ||
| util_merge_operators_test.cc | ||