mirror of
https://github.com/facebook/rocksdb.git
synced 2024-12-04 02:02:41 +00:00
f515d9d203
Summary:
This reverts commit f02c708aa3
since it introduced several bugs (see https://github.com/facebook/rocksdb/issues/11078 and https://github.com/facebook/rocksdb/issues/11067 for attempts to fix them) and that I do not have a high confidence to fix all of them and ensure no further ones before the next release branch cut. There are also come existing issue found during bug fixing. We will work on it and try to merge it to the release after.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/11089
Test Plan: existing CI.
Reviewed By: ajkr
Differential Revision: D42505972
Pulled By: cbi42
fbshipit-source-id: 2f66dcde6b85dc94977b317c2ce513872cfbc153
147 lines
3.4 KiB
C++
147 lines
3.4 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include <cassert>
|
|
|
|
#include "db/blob/blob_garbage_meter.h"
|
|
#include "rocksdb/rocksdb_namespace.h"
|
|
#include "rocksdb/status.h"
|
|
#include "table/internal_iterator.h"
|
|
#include "test_util/sync_point.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// An internal iterator that passes each key-value encountered to
|
|
// BlobGarbageMeter as inflow in order to measure the total number and size of
|
|
// blobs in the compaction input on a per-blob file basis.
|
|
class BlobCountingIterator : public InternalIterator {
|
|
public:
|
|
BlobCountingIterator(InternalIterator* iter,
|
|
BlobGarbageMeter* blob_garbage_meter)
|
|
: iter_(iter), blob_garbage_meter_(blob_garbage_meter) {
|
|
assert(iter_);
|
|
assert(blob_garbage_meter_);
|
|
|
|
UpdateAndCountBlobIfNeeded();
|
|
}
|
|
|
|
bool Valid() const override { return iter_->Valid() && status_.ok(); }
|
|
|
|
void SeekToFirst() override {
|
|
iter_->SeekToFirst();
|
|
UpdateAndCountBlobIfNeeded();
|
|
}
|
|
|
|
void SeekToLast() override {
|
|
iter_->SeekToLast();
|
|
UpdateAndCountBlobIfNeeded();
|
|
}
|
|
|
|
void Seek(const Slice& target) override {
|
|
iter_->Seek(target);
|
|
UpdateAndCountBlobIfNeeded();
|
|
}
|
|
|
|
void SeekForPrev(const Slice& target) override {
|
|
iter_->SeekForPrev(target);
|
|
UpdateAndCountBlobIfNeeded();
|
|
}
|
|
|
|
void Next() override {
|
|
assert(Valid());
|
|
|
|
iter_->Next();
|
|
UpdateAndCountBlobIfNeeded();
|
|
}
|
|
|
|
bool NextAndGetResult(IterateResult* result) override {
|
|
assert(Valid());
|
|
|
|
const bool res = iter_->NextAndGetResult(result);
|
|
UpdateAndCountBlobIfNeeded();
|
|
return res;
|
|
}
|
|
|
|
void Prev() override {
|
|
assert(Valid());
|
|
|
|
iter_->Prev();
|
|
UpdateAndCountBlobIfNeeded();
|
|
}
|
|
|
|
Slice key() const override {
|
|
assert(Valid());
|
|
return iter_->key();
|
|
}
|
|
|
|
Slice user_key() const override {
|
|
assert(Valid());
|
|
return iter_->user_key();
|
|
}
|
|
|
|
Slice value() const override {
|
|
assert(Valid());
|
|
return iter_->value();
|
|
}
|
|
|
|
Status status() const override { return status_; }
|
|
|
|
bool PrepareValue() override {
|
|
assert(Valid());
|
|
return iter_->PrepareValue();
|
|
}
|
|
|
|
bool MayBeOutOfLowerBound() override {
|
|
assert(Valid());
|
|
return iter_->MayBeOutOfLowerBound();
|
|
}
|
|
|
|
IterBoundCheck UpperBoundCheckResult() override {
|
|
assert(Valid());
|
|
return iter_->UpperBoundCheckResult();
|
|
}
|
|
|
|
void SetPinnedItersMgr(PinnedIteratorsManager* pinned_iters_mgr) override {
|
|
iter_->SetPinnedItersMgr(pinned_iters_mgr);
|
|
}
|
|
|
|
bool IsKeyPinned() const override {
|
|
assert(Valid());
|
|
return iter_->IsKeyPinned();
|
|
}
|
|
|
|
bool IsValuePinned() const override {
|
|
assert(Valid());
|
|
return iter_->IsValuePinned();
|
|
}
|
|
|
|
Status GetProperty(std::string prop_name, std::string* prop) override {
|
|
return iter_->GetProperty(prop_name, prop);
|
|
}
|
|
|
|
private:
|
|
void UpdateAndCountBlobIfNeeded() {
|
|
assert(!iter_->Valid() || iter_->status().ok());
|
|
|
|
if (!iter_->Valid()) {
|
|
status_ = iter_->status();
|
|
return;
|
|
}
|
|
|
|
TEST_SYNC_POINT(
|
|
"BlobCountingIterator::UpdateAndCountBlobIfNeeded:ProcessInFlow");
|
|
|
|
status_ = blob_garbage_meter_->ProcessInFlow(key(), value());
|
|
}
|
|
|
|
InternalIterator* iter_;
|
|
BlobGarbageMeter* blob_garbage_meter_;
|
|
Status status_;
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|