mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 13:41:46 +00:00
fec5c8deb8
Summary: benchmark-linux is failing on main branch after https://github.com/facebook/rocksdb/issues/11074 with the following error msg: ``` /usr/bin/time -f '%e %U %S' -o /tmp/benchmark-results/8.0.0/benchmark_overwriteandwait.t1.s0.log.time numactl --interleave=all timeout 1200 ./db_bench --benchmarks=overwrite,waitforcompaction,stats --use_existing_db=1 --sync=0 --level0_file_num_compaction_trigger=4 --level0_slowdown_writes_trigger=20 --level0_stop_writes_trigger=30 --max_background_jobs=4 --max_write_buffer_number=8 --undefok=use_blob_cache,use_shared_block_and_blob_cache,blob_cache_size,blob_cache_numshardbits,prepopulate_blob_cache,multiread_batched,cache_low_pri_pool_ratio,prepopulate_block_cache --db=/tmp/rocksdb-benchmark-datadir --wal_dir=/tmp/rocksdb-benchmark-datadir --num=20000000 --key_size=20 --value_size=400 --block_size=8192 --cache_size=10737418240 --cache_numshardbits=6 --compression_max_dict_bytes=0 --compression_ratio=0.5 --compression_type=none --bytes_per_sync=1048576 --cache_index_and_filter_blocks=1 --cache_high_pri_pool_ratio=0.5 --cache_low_pri_pool_ratio=0 --benchmark_write_rate_limit=0 --write_buffer_size=16777216 --target_file_size_base=16777216 --max_bytes_for_level_base=67108864 --verify_checksum=1 --delete_obsolete_files_period_micros=62914560 --max_bytes_for_level_multiplier=8 --statistics=0 --stats_per_interval=1 --stats_interval_seconds=20 --report_interval_seconds=1 --histogram=1 --memtablerep=skip_list --bloom_bits=10 --open_files=-1 --subcompactions=1 --compaction_style=0 --num_levels=8 --min_level_to_compress=3 --level_compaction_dynamic_level_bytes=true --pin_l0_filter_and_index_blocks_in_cache=1 --duration=600 --threads=1 --merge_operator="put" --seed=1675372532 --report_file=/tmp/benchmark-results/8.0.0/benchmark_overwriteandwait.t1.s0.log.r.csv 2>&1 | tee -a /tmp/benchmark-results/8.0.0/benchmark_overwriteandwait.t1.s0.log /usr/bin/time: cannot run numactl: No such file or directory ``` This PR removes the newly added NUMA setting. Pull Request resolved: https://github.com/facebook/rocksdb/pull/11180 Test Plan: check next main branch run for benchmark-linux Reviewed By: ajkr Differential Revision: D42975930 Pulled By: cbi42 fbshipit-source-id: f084d39aeba9877c0752502e879c5e612b507653
183 lines
5.2 KiB
Python
Executable file
183 lines
5.2 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
# This source code is licensed under both the GPLv2 (found in the
|
|
# COPYING file in the root directory) and Apache 2.0 License
|
|
# (found in the LICENSE.Apache file in the root directory).
|
|
|
|
"""Run benchmark_compare.sh on the most recent build, for CI
|
|
"""
|
|
|
|
import argparse
|
|
import glob
|
|
import logging
|
|
import os
|
|
import re
|
|
import shutil
|
|
import subprocess
|
|
import sys
|
|
|
|
logging.basicConfig(level=logging.INFO)
|
|
|
|
|
|
class Config:
|
|
def __init__(self, args):
|
|
self.version_file = "./include/rocksdb/version.h"
|
|
self.data_dir = os.path.expanduser(f"{args.db_dir}")
|
|
self.results_dir = os.path.expanduser(f"{args.output_dir}")
|
|
self.benchmark_script = f"{os.getcwd()}/tools/benchmark_compare.sh"
|
|
self.benchmark_cwd = f"{os.getcwd()}/tools"
|
|
|
|
benchmark_env_keys = [
|
|
"LD_LIBRARY_PATH",
|
|
"NUM_KEYS",
|
|
"KEY_SIZE",
|
|
"VALUE_SIZE",
|
|
"CACHE_SIZE_MB",
|
|
"DURATION_RW",
|
|
"DURATION_RO",
|
|
"MB_WRITE_PER_SEC",
|
|
"NUM_THREADS",
|
|
"COMPRESSION_TYPE",
|
|
"MIN_LEVEL_TO_COMPRESS",
|
|
"WRITE_BUFFER_SIZE_MB",
|
|
"TARGET_FILE_SIZE_BASE_MB",
|
|
"MAX_BYTES_FOR_LEVEL_BASE_MB",
|
|
"MAX_BACKGROUND_JOBS",
|
|
"CACHE_INDEX_AND_FILTER_BLOCKS",
|
|
"USE_O_DIRECT",
|
|
"STATS_INTERVAL_SECONDS",
|
|
"SUBCOMPACTIONS",
|
|
"COMPACTION_STYLE",
|
|
"CI_TESTS_ONLY",
|
|
]
|
|
|
|
|
|
def read_version(config):
|
|
majorRegex = re.compile(r"#define ROCKSDB_MAJOR\s([0-9]+)")
|
|
minorRegex = re.compile(r"#define ROCKSDB_MINOR\s([0-9]+)")
|
|
patchRegex = re.compile(r"#define ROCKSDB_PATCH\s([0-9]+)")
|
|
with open(config.version_file, "r") as reader:
|
|
major = None
|
|
minor = None
|
|
patch = None
|
|
for line in reader:
|
|
if major is None:
|
|
major = majorRegex.match(line)
|
|
elif minor is None:
|
|
minor = minorRegex.match(line)
|
|
elif patch is None:
|
|
patch = patchRegex.match(line)
|
|
|
|
if patch is not None:
|
|
break
|
|
|
|
if patch is not None:
|
|
return (major.group(1), minor.group(1), patch.group(1))
|
|
|
|
# Didn't complete a match
|
|
return None
|
|
|
|
|
|
def prepare(version_str, config):
|
|
old_files = glob.glob(f"{config.results_dir}/{version_str}/**", recursive=True)
|
|
for f in old_files:
|
|
if os.path.isfile(f):
|
|
logging.debug(f"remove file {f}")
|
|
os.remove(f)
|
|
for f in old_files:
|
|
if os.path.isdir(f):
|
|
logging.debug(f"remove dir {f}")
|
|
os.rmdir(f)
|
|
|
|
db_bench_vers = f"{config.benchmark_cwd}/db_bench.{version_str}"
|
|
|
|
# Create a symlink to the db_bench executable
|
|
os.symlink(f"{os.getcwd()}/db_bench", db_bench_vers)
|
|
|
|
|
|
def results(version_str, config):
|
|
# Copy the report TSV file back to the top level of results
|
|
shutil.copyfile(
|
|
f"{config.results_dir}/{version_str}/report.tsv",
|
|
f"{config.results_dir}/report.tsv",
|
|
)
|
|
|
|
|
|
def cleanup(version_str, config):
|
|
# Remove the symlink to the db_bench executable
|
|
db_bench_vers = f"{config.benchmark_cwd}/db_bench.{version_str}"
|
|
os.remove(db_bench_vers)
|
|
|
|
|
|
def get_benchmark_env():
|
|
env = []
|
|
for key in Config.benchmark_env_keys:
|
|
value = os.getenv(key)
|
|
if value is not None:
|
|
env.append((key, value))
|
|
return env
|
|
|
|
|
|
def main():
|
|
"""Tool for running benchmark_compare.sh on the most recent build, for CI
|
|
This tool will
|
|
|
|
(1) Work out the current version of RocksDB
|
|
(2) Run benchmark_compare with that version alone
|
|
"""
|
|
|
|
parser = argparse.ArgumentParser(
|
|
description="benchmark_compare.sh Python wrapper for CI."
|
|
)
|
|
|
|
# --tsvfile is the name of the file to read results from
|
|
# --esdocument is the ElasticSearch document to push these results into
|
|
#
|
|
parser.add_argument(
|
|
"--db_dir",
|
|
default="~/tmp/rocksdb-benchmark-datadir",
|
|
help="Database directory hierarchy to use",
|
|
)
|
|
parser.add_argument(
|
|
"--output_dir",
|
|
default="~/tmp/benchmark-results",
|
|
help="Benchmark output goes here",
|
|
)
|
|
parser.add_argument(
|
|
"--num_keys",
|
|
default="10000",
|
|
help="Number of database keys to use in benchmark test(s) (determines size of test job)",
|
|
)
|
|
args = parser.parse_args()
|
|
config = Config(args)
|
|
|
|
version = read_version(config)
|
|
if version is None:
|
|
raise Exception(f"Could not read RocksDB version from {config.version_file}")
|
|
version_str = f"{version[0]}.{version[1]}.{version[2]}"
|
|
logging.info(f"Run benchmark_ci with RocksDB version {version_str}")
|
|
|
|
prepare(version_str, config)
|
|
|
|
try:
|
|
env = get_benchmark_env()
|
|
env.append(("NUM_KEYS", args.num_keys))
|
|
cmd = [
|
|
config.benchmark_script,
|
|
config.data_dir,
|
|
config.results_dir,
|
|
version_str,
|
|
]
|
|
logging.info(f"Run {cmd} env={env} cwd={config.benchmark_cwd}")
|
|
subprocess.run(cmd, env=dict(env), cwd=config.benchmark_cwd)
|
|
|
|
results(version_str, config)
|
|
finally:
|
|
cleanup(version_str, config)
|
|
|
|
return 0
|
|
|
|
|
|
if __name__ == "__main__":
|
|
sys.exit(main())
|