mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 04:41:49 +00:00
f79b3d19a7
Summary:
**Context/Summary:**
Previous experience with bugs and flaky tests taught us there exist features in RocksDB vulnerable to race condition caused by acquiring db mutex at a particular timing. This PR aggressively exposes those vulnerable features by injecting spurious wakeup and sleep to cause acquiring db mutex at various timing in order to expose such race condition
**Testing:**
- `COERCE_CONTEXT_SWITCH=1 make -j56 check / make -j56 db_stress` should reveal
- flaky tests caused by db mutex related race condition
- Reverted https://github.com/facebook/rocksdb/pull/9528
- A/B testing on `COMPILE_WITH_TSAN=1 make -j56 listener_test` w/ and w/o `COERCE_CONTEXT_SWITCH=1` followed by `./listener_test --gtest_filter=EventListenerTest.MultiCF --gtest_repeat=10`
- `COERCE_CONTEXT_SWITCH=1` can cause expected test failure (i.e, expose target TSAN data race error) within 10 run while the other couldn't.
- This proves our injection can expose flaky tests caused by db mutex related race condition faster.
- known or new race-condition-type of internal bug by continuously running this PR
- Performance
- High ops-threads time: COERCE_CONTEXT_SWITCH=1 regressed by 4 times slower (2:01.16 vs 0:22.10 elapsed ). This PR will be run as a separate CI job so this regression won't affect any existing job.
```
TEST_TMPDIR=$db /usr/bin/time ./db_stress \
--ops_per_thread=100000 --expected_values_dir=$exp --clear_column_family_one_in=0 \
--write_buffer_size=524288 —target_file_size_base=524288 —ingest_external_file_one_in=100 —compact_files_one_in=1000 —compact_range_one_in=1000
```
- Start-up time: COERCE_CONTEXT_SWITCH=1 didn't regress by 25% (0:01.51 vs 0:01.29 elapsed)
```
TEST_TMPDIR=$db ./db_stress -ops_per_thread=100000000 -expected_values_dir=$exp --clear_column_family_one_in=0 & sleep 120; pkill -9 db_stress
TEST_TMPDIR=$db /usr/bin/time ./db_stress \
--ops_per_thread=1 -reopen=0 --expected_values_dir=$exp --clear_column_family_one_in=0 --destroy_db_initially=0
```
Pull Request resolved: https://github.com/facebook/rocksdb/pull/10291
Reviewed By: ajkr
Differential Revision: D39231182
Pulled By: hx235
fbshipit-source-id: 7ab6695430460e0826727fd8c66679b32b3e44b6
|
||
|---|---|---|
| .. | ||
| file_read_sample.h | ||
| histogram.cc | ||
| histogram.h | ||
| histogram_test.cc | ||
| histogram_windowing.cc | ||
| histogram_windowing.h | ||
| in_memory_stats_history.cc | ||
| in_memory_stats_history.h | ||
| instrumented_mutex.cc | ||
| instrumented_mutex.h | ||
| iostats_context.cc | ||
| iostats_context_imp.h | ||
| iostats_context_test.cc | ||
| perf_context.cc | ||
| perf_context_imp.h | ||
| perf_level.cc | ||
| perf_level_imp.h | ||
| perf_step_timer.h | ||
| persistent_stats_history.cc | ||
| persistent_stats_history.h | ||
| statistics.cc | ||
| statistics.h | ||
| statistics_test.cc | ||
| stats_history_test.cc | ||
| thread_status_impl.cc | ||
| thread_status_updater.cc | ||
| thread_status_updater.h | ||
| thread_status_updater_debug.cc | ||
| thread_status_util.cc | ||
| thread_status_util.h | ||
| thread_status_util_debug.cc | ||