Find a file
Igor Canadi eb5b637fb0 Fix condition for bottommost level
Summary:
The function GetBoundaryKeys() returns the smallest key from the first file and largest key from the last file. This is good for any level >0, but it's not correct for level 0. In level 0, files can overlap, so we need to check all files for boundary keys. This bug can cause wrong value for bottommost_level in compaction (value of true, although correct is false), which means we can set sequence numbers to 0 even if the key is not the oldest one in the database.

Herman reported corruption while testing MyRocks. Fortunately, the patch that added the bug was not released yet.

Test Plan: added a new test to compaction_picker_test.

Reviewers: hermanlee4, sdong

Reviewed By: sdong

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D48201
2015-10-05 17:40:18 -07:00
arcanist_util Fix linters on non-fb machines 2015-08-11 11:36:12 -07:00
build_tools Adding features to CI job description 2015-10-02 12:36:58 -07:00
coverage Fix coverage script 2014-11-03 14:53:00 -08:00
db Fix condition for bottommost level 2015-10-05 17:40:18 -07:00
doc Remove seek compaction 2014-06-20 10:23:02 +02:00
examples RocksDB Options file format and its serialization / deserialization. 2015-09-29 14:42:40 -07:00
hdfs [Cleanup] Remove RandomRWFile 2015-08-12 10:18:59 -07:00
include/rocksdb Add APIs PauseBackgroundWork() and ContinueBackgroundWork() 2015-10-02 13:17:34 -07:00
java [RocksJava] Fix test failure of InfoLogLevelTest 2015-09-21 18:26:21 -07:00
port Re-work to support size_t max constant for 32/64-bit. 2015-09-22 10:34:21 -07:00
table Fix the bug of using freed memory introduced by recent plain table reader patch 2015-09-23 16:16:26 -07:00
third-party "make format" against last 10 commits 2015-07-13 13:50:18 -07:00
tools Fixed a tsan warning in db_stress.cc 2015-09-28 12:06:43 -07:00
util [RocksDB Options] Support more options in RocksDBOptionParser for sanity check. 2015-10-02 15:35:32 -07:00
utilities Return MergeInProgress when fetching from transactions or WBWI with overwrite_key 2015-09-30 11:14:42 -07:00
.arcconfig Integrate Jenkins with Phabricator 2015-04-07 11:56:29 -07:00
.clang-format A script that automatically reformat affected lines 2014-01-14 12:21:24 -08:00
.gitignore New amalgamation target 2015-10-01 08:29:31 +13:00
.travis.yml Fix clang-format on Travis 2015-09-18 10:15:02 -07:00
appveyor.yml Improve CI build and build switches 2015-09-29 12:22:48 -07:00
appveyordailytests.yml Improve CI build and fix Windows build breakage 2015-09-30 11:20:23 -07:00
AUTHORS Add AUTHORS file. Fix #203 2014-09-29 10:52:18 -07:00
CMakeLists.txt Improve CI build and fix Windows build breakage 2015-09-30 11:20:23 -07:00
CONTRIBUTING.md facebook accounts are not required for CLA signers 2014-07-08 05:57:54 -04:00
DUMP_FORMAT.md First version of rocksdb_dump and rocksdb_undump. 2015-06-19 16:24:36 -07:00
HISTORY.md Add experimental DB::AddFile() to plug sst files into empty DB 2015-09-23 12:42:43 -07:00
INSTALL.md Fixed a typo in INSTALL.md 2015-09-03 19:46:09 -07:00
LICENSE Fix copyright year 2014-03-12 12:06:58 -07:00
Makefile New amalgamation target 2015-10-01 08:29:31 +13:00
PATENTS Update Patent Grant. 2015-04-13 10:33:43 +01:00
README.md Replaced "built on on earlier work" by "built on earlier work" in README.md 2014-09-17 01:16:17 -07:00
ROCKSDB_LITE.md Optimistic Transactions 2015-05-29 14:36:35 -07:00
src.mk New amalgamation target 2015-10-01 08:29:31 +13:00
thirdparty.inc Improve CI build and fix Windows build breakage 2015-09-30 11:20:23 -07:00
USERS.md Add Cloudera's blog post to USERS.md 2015-09-02 14:04:51 -07:00
Vagrantfile RocksDB on FreeBSD support 2015-02-26 15:19:17 -08:00
WINDOWS_PORT.md Commit both PR and internal code review changes 2015-07-07 16:58:20 -07:00

RocksDB: A Persistent Key-Value Store for Flash and RAM Storage

Build Status

RocksDB is developed and maintained by Facebook Database Engineering Team. It is built on earlier work on LevelDB by Sanjay Ghemawat (sanjay@google.com) and Jeff Dean (jeff@google.com)

This code is a library that forms the core building block for a fast key value server, especially suited for storing data on flash drives. It has a Log-Structured-Merge-Database (LSM) design with flexible tradeoffs between Write-Amplification-Factor (WAF), Read-Amplification-Factor (RAF) and Space-Amplification-Factor (SAF). It has multi-threaded compactions, making it specially suitable for storing multiple terabytes of data in a single database.

Start with example usage here: https://github.com/facebook/rocksdb/tree/master/examples

See the github wiki for more explanation.

The public interface is in include/. Callers should not include or rely on the details of any other header files in this package. Those internal APIs may be changed without warning.

Design discussions are conducted in https://www.facebook.com/groups/rocksdb.dev/