mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-27 02:44:18 +00:00
11526252cc
Summary:
PinnableSlice
Summary:
Currently the point lookup values are copied to a string provided by the
user. This incures an extra memcpy cost. This patch allows doing point lookup
via a PinnableSlice which pins the source memory location (instead of
copying their content) and releases them after the content is consumed
by the user. The old API of Get(string) is translated to the new API
underneath.
Here is the summary for improvements:
value 100 byte: 1.8% regular, 1.2% merge values
value 1k byte: 11.5% regular, 7.5% merge values
value 10k byte: 26% regular, 29.9% merge values
The improvement for merge could be more if we extend this approach to
pin the merge output and delay the full merge operation until the user
actually needs it. We have put that for future work.
PS:
Sometimes we observe a small decrease in performance when switching from
t5452014 to this patch but with the old Get(string) API. The d
Closes https://github.com/facebook/rocksdb/pull/1756
Differential Revision: D4391738
Pulled By: maysamyabandeh
fbshipit-source-id: 6f3edd3
103 lines
3.8 KiB
C++
103 lines
3.8 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
#pragma once
|
|
#ifndef ROCKSDB_LITE
|
|
#include "db/db_impl.h"
|
|
#include <vector>
|
|
#include <string>
|
|
|
|
namespace rocksdb {
|
|
|
|
class CompactedDBImpl : public DBImpl {
|
|
public:
|
|
CompactedDBImpl(const DBOptions& options, const std::string& dbname);
|
|
virtual ~CompactedDBImpl();
|
|
|
|
static Status Open(const Options& options, const std::string& dbname,
|
|
DB** dbptr);
|
|
|
|
// Implementations of the DB interface
|
|
using DB::Get;
|
|
virtual Status Get(const ReadOptions& options,
|
|
ColumnFamilyHandle* column_family, const Slice& key,
|
|
PinnableSlice* value) override;
|
|
using DB::MultiGet;
|
|
virtual std::vector<Status> MultiGet(
|
|
const ReadOptions& options,
|
|
const std::vector<ColumnFamilyHandle*>&,
|
|
const std::vector<Slice>& keys, std::vector<std::string>* values)
|
|
override;
|
|
|
|
using DBImpl::Put;
|
|
virtual Status Put(const WriteOptions& options,
|
|
ColumnFamilyHandle* column_family, const Slice& key,
|
|
const Slice& value) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
using DBImpl::Merge;
|
|
virtual Status Merge(const WriteOptions& options,
|
|
ColumnFamilyHandle* column_family, const Slice& key,
|
|
const Slice& value) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
using DBImpl::Delete;
|
|
virtual Status Delete(const WriteOptions& options,
|
|
ColumnFamilyHandle* column_family,
|
|
const Slice& key) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
virtual Status Write(const WriteOptions& options,
|
|
WriteBatch* updates) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
using DBImpl::CompactRange;
|
|
virtual Status CompactRange(const CompactRangeOptions& options,
|
|
ColumnFamilyHandle* column_family,
|
|
const Slice* begin, const Slice* end) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
|
|
virtual Status DisableFileDeletions() override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
virtual Status EnableFileDeletions(bool force) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
virtual Status GetLiveFiles(std::vector<std::string>&,
|
|
uint64_t* manifest_file_size,
|
|
bool flush_memtable = true) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
using DBImpl::Flush;
|
|
virtual Status Flush(const FlushOptions& options,
|
|
ColumnFamilyHandle* column_family) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
using DB::IngestExternalFile;
|
|
virtual Status IngestExternalFile(
|
|
ColumnFamilyHandle* column_family,
|
|
const std::vector<std::string>& external_files,
|
|
const IngestExternalFileOptions& ingestion_options) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
|
|
private:
|
|
friend class DB;
|
|
inline size_t FindFile(const Slice& key);
|
|
Status Init(const Options& options);
|
|
|
|
ColumnFamilyData* cfd_;
|
|
Version* version_;
|
|
const Comparator* user_comparator_;
|
|
LevelFilesBrief files_;
|
|
|
|
// No copying allowed
|
|
CompactedDBImpl(const CompactedDBImpl&);
|
|
void operator=(const CompactedDBImpl&);
|
|
};
|
|
}
|
|
#endif // ROCKSDB_LITE
|