mirror of https://github.com/facebook/rocksdb.git
514f0b0937
Summary:
For regular db instance and secondary instance, we return error and refuse to open DB if Logger creation fails.
Our current code allows it, but it is really difficult to debug because
there will be no LOG files. The same for OPTIONS file, which will be explored in another PR.
Furthermore, Arena::AllocateAligned(size_t bytes, size_t huge_page_size, Logger* logger) has an
assertion as the following:
```cpp
#ifdef MAP_HUGETLB
if (huge_page_size > 0 && bytes > 0) {
assert(logger != nullptr);
}
#endif
```
It can be removed.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/9984
Test Plan: make check
Reviewed By: jay-zhuang
Differential Revision: D36347754
Pulled By: riversand963
fbshipit-source-id: 529798c0511d2eaa2f0fd40cf7e61c4cbc6bc57e
|
||
|---|---|---|
| .. | ||
| allocator.h | ||
| arena.cc | ||
| arena.h | ||
| arena_test.cc | ||
| concurrent_arena.cc | ||
| concurrent_arena.h | ||
| jemalloc_nodump_allocator.cc | ||
| jemalloc_nodump_allocator.h | ||
| memkind_kmem_allocator.cc | ||
| memkind_kmem_allocator.h | ||
| memory_allocator.cc | ||
| memory_allocator.h | ||
| memory_allocator_test.cc | ||
| memory_usage.h | ||