mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-28 05:43:50 +00:00
09ea5d8944
Summary:
Fixes the below build failure for clang compiler using glibc and jemalloc.
Platform: linux x86-64
Compiler: clang version 6.0.0-1ubuntu2
Build failure:
```
$ CXX=clang++ CC=clang USE_CLANG=1 WITH_JEMALLOC_FLAG=1 JEMALLOC=1 EXTRA_LDFLAGS="-L/home/andrew/jemalloc/lib/" EXTRA_CXXFLAGS="-I/home/andrew/jemalloc/include/" make check -j12
...
CC memory/jemalloc_nodump_allocator.o
In file included from memory/jemalloc_nodump_allocator.cc:6:
In file included from ./memory/jemalloc_nodump_allocator.h:11:
In file included from ./port/jemalloc_helper.h:16:
/usr/include/clang/6.0.0/include/mm_malloc.h:39:16: error: 'posix_memalign' is missing exception specification 'throw()'
extern "C" int posix_memalign(void **__memptr, size_t __alignment, size_t __size);
^
/home/andrew/jemalloc/include/jemalloc/jemalloc.h:388:26: note: expanded from macro 'posix_memalign'
# define posix_memalign je_posix_memalign
^
/home/andrew/jemalloc/include/jemalloc/jemalloc.h:77:29: note: expanded from macro 'je_posix_memalign'
# define je_posix_memalign posix_memalign
^
/home/andrew/jemalloc/include/jemalloc/jemalloc.h:232:38: note: previous declaration is here
JEMALLOC_EXPORT int JEMALLOC_NOTHROW je_posix_memalign(void **memptr,
^
/home/andrew/jemalloc/include/jemalloc/jemalloc.h:77:29: note: expanded from macro 'je_posix_memalign'
# define je_posix_memalign posix_memalign
^
1 error generated.
Makefile:1972: recipe for target 'memory/jemalloc_nodump_allocator.o' failed
make: *** [memory/jemalloc_nodump_allocator.o] Error 1
```
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5522
Differential Revision: D16069869
Pulled By: miasantreble
fbshipit-source-id: c489bbc993adee194b9a550134c6237a264bc443
78 lines
3.4 KiB
C
78 lines
3.4 KiB
C
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#if defined(__clang__)
|
|
// glibc's `posix_memalign()` declaration specifies `throw()` while clang's
|
|
// declaration does not. There is a hack in clang to make its re-declaration
|
|
// compatible with glibc's if they are declared consecutively. That hack breaks
|
|
// if yet another `posix_memalign()` declaration comes between glibc's and
|
|
// clang's declarations. Include "mm_malloc.h" here ensures glibc's and clang's
|
|
// declarations both come before "jemalloc.h"'s `posix_memalign()` declaration.
|
|
//
|
|
// This problem could also be avoided if "jemalloc.h"'s `posix_memalign()`
|
|
// declaration did not specify `throw()` when built with clang.
|
|
#include <mm_malloc.h>
|
|
#endif
|
|
|
|
#ifdef ROCKSDB_JEMALLOC
|
|
#ifdef __FreeBSD__
|
|
#include <malloc_np.h>
|
|
#else
|
|
#define JEMALLOC_MANGLE
|
|
#include <jemalloc/jemalloc.h>
|
|
#endif
|
|
|
|
#ifndef JEMALLOC_CXX_THROW
|
|
#define JEMALLOC_CXX_THROW
|
|
#endif
|
|
|
|
#if defined(OS_WIN) && defined(_MSC_VER)
|
|
|
|
// MSVC does not have weak symbol support. As long as ROCKSDB_JEMALLOC is defined,
|
|
// Jemalloc memory allocator is used.
|
|
static inline bool HasJemalloc() { return true; }
|
|
|
|
#else
|
|
|
|
// Declare non-standard jemalloc APIs as weak symbols. We can null-check these
|
|
// symbols to detect whether jemalloc is linked with the binary.
|
|
extern "C" void* mallocx(size_t, int) __attribute__((__weak__));
|
|
extern "C" void* rallocx(void*, size_t, int) __attribute__((__weak__));
|
|
extern "C" size_t xallocx(void*, size_t, size_t, int) __attribute__((__weak__));
|
|
extern "C" size_t sallocx(const void*, int) __attribute__((__weak__));
|
|
extern "C" void dallocx(void*, int) __attribute__((__weak__));
|
|
extern "C" void sdallocx(void*, size_t, int) __attribute__((__weak__));
|
|
extern "C" size_t nallocx(size_t, int) __attribute__((__weak__));
|
|
extern "C" int mallctl(const char*, void*, size_t*, void*, size_t)
|
|
__attribute__((__weak__));
|
|
extern "C" int mallctlnametomib(const char*, size_t*, size_t*)
|
|
__attribute__((__weak__));
|
|
extern "C" int mallctlbymib(const size_t*, size_t, void*, size_t*, void*,
|
|
size_t) __attribute__((__weak__));
|
|
extern "C" void malloc_stats_print(void (*)(void*, const char*), void*,
|
|
const char*) __attribute__((__weak__));
|
|
extern "C" size_t malloc_usable_size(JEMALLOC_USABLE_SIZE_CONST void*)
|
|
JEMALLOC_CXX_THROW __attribute__((__weak__));
|
|
|
|
// Check if Jemalloc is linked with the binary. Note the main program might be
|
|
// using a different memory allocator even this method return true.
|
|
// It is loosely based on folly::usingJEMalloc(), minus the check that actually
|
|
// allocate memory and see if it is through jemalloc, to handle the dlopen()
|
|
// case:
|
|
// https://github.com/facebook/folly/blob/76cf8b5841fb33137cfbf8b224f0226437c855bc/folly/memory/Malloc.h#L147
|
|
static inline bool HasJemalloc() {
|
|
return mallocx != nullptr && rallocx != nullptr && xallocx != nullptr &&
|
|
sallocx != nullptr && dallocx != nullptr && sdallocx != nullptr &&
|
|
nallocx != nullptr && mallctl != nullptr &&
|
|
mallctlnametomib != nullptr && mallctlbymib != nullptr &&
|
|
malloc_stats_print != nullptr && malloc_usable_size != nullptr;
|
|
}
|
|
|
|
#endif
|
|
|
|
#endif // ROCKSDB_JEMALLOC
|