rocksdb/tools
Igor Canadi 469a9f32a7 Fix two nasty use-after-free-bugs
Summary:
These bugs were caught by ASAN crash test.
1. The first one, in table/filter_block.cc is very nasty. We first reference entries_ and store the reference to Slice prev. Then, we call entries_.append(), which can change the reference. The Slice prev now points to junk.
2. The second one is a bug in a test, so it's not very serious. Once we set read_opts.prefix, we never clear it, so some other function might still reference it.

Test Plan: asan crash test now runs more than 5 mins. Before, it failed immediately. I will run the full one, but the full one takes quite some time (5 hours)

Reviewers: dhruba, haobo, kailiu

Reviewed By: dhruba

CC: leveldb

Differential Revision: https://reviews.facebook.net/D14223
2013-11-19 21:01:48 -08:00
..
shell Fixed typos 2013-11-16 11:21:34 +00:00
blob_store_bench.cc Fix make release 2013-10-31 11:47:22 -07:00
db_crashtest.py Fixing crashing tests to include iterpercent param 2013-09-20 16:27:22 -07:00
db_crashtest2.py Fixed typos 2013-11-16 11:21:34 +00:00
db_repl_stress.cc make util/env_posix.cc work under mac 2013-11-16 23:44:39 -08:00
db_stress.cc Fix two nasty use-after-free-bugs 2013-11-19 21:01:48 -08:00
ldb.cc Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
ldb_test.py Fixed typos 2013-11-16 11:21:34 +00:00
reduce_levels_test.cc Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
sst_dump.cc Quick fix for a string format 2013-11-12 21:22:32 -08:00