rocksdb/build_tools
Igor Canadi fd4eca73e7 fPIC in x64 environment
Summary:
Check https://github.com/facebook/rocksdb/pull/15 for context.

Apparently [1], we need -fPIC in x64 environments (this is added only in non-fbcode).

In fbcode, I removed -fPIC per @dhruba's suggestion, since it introduces perf regression. I'm not sure what would are the implications of doing that, but looks like it works, and when releasing to the third-party, we're disabling -fPIC either way [2].

Would love a suggestion from someone who knows more about this

[1] http://eli.thegreenplace.net/2011/11/11/position-independent-code-pic-in-shared-libraries-on-x64/
[2] https://our.intern.facebook.com/intern/wiki/index.php/Database/RocksDB/Third_Party

Test Plan: make check works

Reviewers: dhruba, emayanke, kailiu

Reviewed By: dhruba

CC: leveldb, dhruba, reconnect.grayhat

Differential Revision: https://reviews.facebook.net/D14337
2013-11-25 21:21:01 -08:00
..
build_detect_platform fPIC in x64 environment 2013-11-25 21:21:01 -08:00
build_detect_version fix issue #11 2013-11-20 01:17:44 -08:00
fbcode.clang31.sh Remove libevent 2013-11-18 21:33:16 -08:00
fbcode.gcc471.sh We should compile with -fPIC on non-fbcode environments also 2013-11-25 15:49:02 -08:00
fbcode.gcc481.sh We should compile with -fPIC on non-fbcode environments also 2013-11-25 15:49:02 -08:00
mac-install-gflags.sh make util/env_posix.cc work under mac 2013-11-16 23:44:39 -08:00
regression_build_test.sh Memtable regression test 2013-11-25 15:34:23 -08:00
valgrind_test.sh Clean up the Makefile and the build scripts 2013-08-15 12:59:45 -07:00