mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-29 18:33:58 +00:00
72224104d3
Summary: This fixes a similar issue as D54711: "CURRENT" file can mutate between GetLiveFiles() and copy to the tmp directory, in which case it would reference the wrong manifest filename. To fix this, I forge the "CURRENT" file such that it simply contains the filename for the manifest returned by GetLiveFiles(). - Changed CreateCheckpoint() to forge current file - Added CreateFile() utility function - Added test case that rolls manifest during checkpoint creation Test Plan: $ ./checkpoint_test Reviewers: sdong, IslamAbdelRahman Reviewed By: IslamAbdelRahman Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D55065
98 lines
2.8 KiB
C++
98 lines
2.8 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
#include "util/file_util.h"
|
|
|
|
#include <string>
|
|
#include <algorithm>
|
|
|
|
#include "rocksdb/env.h"
|
|
#include "rocksdb/options.h"
|
|
#include "util/sst_file_manager_impl.h"
|
|
#include "util/file_reader_writer.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
// Utility function to copy a file up to a specified length
|
|
Status CopyFile(Env* env, const std::string& source,
|
|
const std::string& destination, uint64_t size) {
|
|
const EnvOptions soptions;
|
|
Status s;
|
|
unique_ptr<SequentialFileReader> src_reader;
|
|
unique_ptr<WritableFileWriter> dest_writer;
|
|
|
|
{
|
|
unique_ptr<SequentialFile> srcfile;
|
|
s = env->NewSequentialFile(source, &srcfile, soptions);
|
|
unique_ptr<WritableFile> destfile;
|
|
if (s.ok()) {
|
|
s = env->NewWritableFile(destination, &destfile, soptions);
|
|
} else {
|
|
return s;
|
|
}
|
|
|
|
if (size == 0) {
|
|
// default argument means copy everything
|
|
if (s.ok()) {
|
|
s = env->GetFileSize(source, &size);
|
|
} else {
|
|
return s;
|
|
}
|
|
}
|
|
src_reader.reset(new SequentialFileReader(std::move(srcfile)));
|
|
dest_writer.reset(new WritableFileWriter(std::move(destfile), soptions));
|
|
}
|
|
|
|
char buffer[4096];
|
|
Slice slice;
|
|
while (size > 0) {
|
|
size_t bytes_to_read = std::min(sizeof(buffer), static_cast<size_t>(size));
|
|
if (s.ok()) {
|
|
s = src_reader->Read(bytes_to_read, &slice, buffer);
|
|
}
|
|
if (s.ok()) {
|
|
if (slice.size() == 0) {
|
|
return Status::Corruption("file too small");
|
|
}
|
|
s = dest_writer->Append(slice);
|
|
}
|
|
if (!s.ok()) {
|
|
return s;
|
|
}
|
|
size -= slice.size();
|
|
}
|
|
return Status::OK();
|
|
}
|
|
|
|
// Utility function to create a file with the provided contents
|
|
Status CreateFile(Env* env, const std::string& destination,
|
|
const std::string& contents) {
|
|
const EnvOptions soptions;
|
|
Status s;
|
|
unique_ptr<WritableFileWriter> dest_writer;
|
|
|
|
unique_ptr<WritableFile> destfile;
|
|
s = env->NewWritableFile(destination, &destfile, soptions);
|
|
if (!s.ok()) {
|
|
return s;
|
|
}
|
|
dest_writer.reset(new WritableFileWriter(std::move(destfile), soptions));
|
|
return dest_writer->Append(Slice(contents));
|
|
}
|
|
|
|
Status DeleteSSTFile(const DBOptions* db_options, const std::string& fname,
|
|
uint32_t path_id) {
|
|
// TODO(tec): support sst_file_manager for multiple path_ids
|
|
auto sfm =
|
|
static_cast<SstFileManagerImpl*>(db_options->sst_file_manager.get());
|
|
if (sfm && path_id == 0) {
|
|
return sfm->ScheduleFileDeletion(fname);
|
|
} else {
|
|
return db_options->env->DeleteFile(fname);
|
|
}
|
|
}
|
|
|
|
} // namespace rocksdb
|