Find a file
Pengchao Wang e4234fbdcf collecting kValue type tombstone
Summary:
In our testing cluster, we found large amount tombstone has been promoted to kValue type from kMerge after reaching the top level of compaction. Since we used to only collecting tombstone in merge operator, those tombstones can never be collected.

This PR addresses the issue by adding a GC step in compaction filter, which is only for kValue type records. Since those record already reached the top of compaction (no earlier data exists) we can safely remove them in compaction filter without worrying old data appears.

This PR also removes an old optimization in cassandra merge operator for single merge operands.  We need to do GC even on a single operand, so the optimation does not make sense anymore.
Closes https://github.com/facebook/rocksdb/pull/2855

Reviewed By: sagar0

Differential Revision: D5806445

Pulled By: wpc

fbshipit-source-id: 6eb25629d4ce917eb5e8b489f64a6aa78c7d270b
2017-09-18 16:27:12 -07:00
buckifier rocksdb: make buildable on aarch64 2017-08-13 17:13:54 -07:00
build_tools update dependencies.sh 2017-08-31 15:26:24 -07:00
cache Add -DPORTABLE=1 to MSVC CI build 2017-08-31 16:42:48 -07:00
cmake CMake: Add support for CMake packages 2017-08-28 17:14:37 -07:00
coverage Fix /bin/bash shebangs 2017-08-03 15:56:46 -07:00
db WritePrepared Txn: Advance seq one per batch 2017-09-18 14:45:08 -07:00
docs Minor updates to FlushWAL blog 2017-08-27 07:41:02 -07:00
env Introduce bottom-pri thread pool for large universal compactions 2017-08-03 15:43:29 -07:00
examples Pinnableslice examples and blog post 2017-08-24 12:26:07 -07:00
hdfs Revert "comment out unused parameters" 2017-07-21 18:26:26 -07:00
include/rocksdb WritePrepared Txn: Advance seq one per batch 2017-09-18 14:45:08 -07:00
java collecting kValue type tombstone 2017-09-18 16:27:12 -07:00
memtable Fix CLANG Analyze 2017-09-07 14:28:06 -07:00
monitoring Directly refernce perf_context internally. 2017-09-15 17:15:10 -07:00
options WritePrepared Txn: Advance seq one per batch 2017-09-18 14:45:08 -07:00
port Add -DPORTABLE=1 to MSVC CI build 2017-08-31 16:42:48 -07:00
table Three code-level optimization to Iterator::Next() 2017-09-14 17:57:31 -07:00
third-party Revert "comment out unused parameters" 2017-07-21 18:26:26 -07:00
tools Fix naming in InternalKey 2017-09-12 17:17:42 -07:00
util Make InternalKeyComparator final and directly use it in merging iterator 2017-09-11 12:04:21 -07:00
utilities collecting kValue type tombstone 2017-09-18 16:27:12 -07:00
.clang-format
.gitignore Remove leftover references to phutil_module_cache 2017-08-23 12:12:21 -07:00
.travis.yml Add more unit test to write_prepared txns 2017-08-31 09:41:27 -07:00
appveyor.yml Add -DPORTABLE=1 to MSVC CI build 2017-08-31 16:42:48 -07:00
AUTHORS Add AUTHORS file. Fix #203 2014-09-29 10:52:18 -07:00
CMakeLists.txt Use cmake TIMESTAMP function 2017-09-12 17:17:42 -07:00
CONTRIBUTING.md Remove the licensing description in CONTRIBUTING.md 2017-07-16 15:57:18 -07:00
COPYING Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
DEFAULT_OPTIONS_HISTORY.md options.delayed_write_rate use the rate of rate_limiter by default. 2017-05-24 09:58:24 -07:00
DUMP_FORMAT.md First version of rocksdb_dump and rocksdb_undump. 2015-06-19 16:24:36 -07:00
HISTORY.md support opening zero backups during engine init 2017-09-12 13:26:34 -07:00
INSTALL.md add vcpkg as an windows option 2017-07-24 15:12:45 -07:00
LANGUAGE-BINDINGS.md add Erlang to the list of language bindings 2017-08-28 16:43:16 -07:00
LICENSE.Apache Change RocksDB License 2017-07-15 16:11:23 -07:00
LICENSE.leveldb Add back the LevelDB license file 2017-07-16 18:42:18 -07:00
Makefile Updated CRC32 Power Optimization Changes 2017-08-31 14:16:30 -07:00
README.md Appveyor badge to show master branch 2016-07-26 13:54:08 -07:00
ROCKSDB_LITE.md Optimistic Transactions 2015-05-29 14:36:35 -07:00
src.mk Updated CRC32 Power Optimization Changes 2017-08-31 14:16:30 -07:00
TARGETS Add more unit test to write_prepared txns 2017-08-31 09:41:27 -07:00
thirdparty.inc Introduce XPRESS compresssion on Windows. (#1081) 2016-04-19 22:54:24 -07:00
USERS.md Update USERS.md 2017-08-06 12:44:40 -07:00
Vagrantfile Update Vagrant file (test internal phabricator workflow) 2016-10-28 15:39:19 -07:00
WINDOWS_PORT.md Commit both PR and internal code review changes 2015-07-07 16:58:20 -07:00

RocksDB: A Persistent Key-Value Store for Flash and RAM Storage

Build Status Build status

RocksDB is developed and maintained by Facebook Database Engineering Team. It is built on earlier work on LevelDB by Sanjay Ghemawat (sanjay@google.com) and Jeff Dean (jeff@google.com)

This code is a library that forms the core building block for a fast key value server, especially suited for storing data on flash drives. It has a Log-Structured-Merge-Database (LSM) design with flexible tradeoffs between Write-Amplification-Factor (WAF), Read-Amplification-Factor (RAF) and Space-Amplification-Factor (SAF). It has multi-threaded compactions, making it specially suitable for storing multiple terabytes of data in a single database.

Start with example usage here: https://github.com/facebook/rocksdb/tree/master/examples

See the github wiki for more explanation.

The public interface is in include/. Callers should not include or rely on the details of any other header files in this package. Those internal APIs may be changed without warning.

Design discussions are conducted in https://www.facebook.com/groups/rocksdb.dev/