Zhichao Cao e102de7318 Fix assert(cfd->imm()->NumNotFlushed() > 0) in FlushMemtable (#7744) ... Summary: In current code base, in FlushMemtable, when `(Flush_reason == FlushReason::kErrorRecoveryRetryFlush && (!cfd->mem()->IsEmpty() || !cached_recoverable_state_empty_.load()))`, we assert that cfd->imm()->NumNotFlushed() > 0. However, there are some corner cases that can fail this assert: 1) if there are multiple CFs, some CF has immutable memtable, some CFs don't. In ResumeImpl, all CFs will call FlushMemtable, which will hit the assert. 2) Regular flush is scheduled and running, the resume thread is waiting. New KVs are inserted and SchedulePendingFlush is called. Regular flush will continue call MaybeScheduleFlushAndCompaction until all the immutable memtables are flushed. When regular flush ends and auto resume thread starts to schedule new flushes, cfd->imm()->NumNotFlushed() can be 0. Remove the assert and added the comments. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7744 Test Plan: make check and pass the stress test Reviewed By: riversand963 Differential Revision: D25340573 Pulled By: zhichao-cao fbshipit-source-id: eac357bdace660247c197f01a9ff6857e3c97672		2020-12-04 20:31:39 -08:00
..
db_impl.cc
db_impl.h	Write min_log_number_to_keep to MANIFEST during atomic flush under 2 phase commit (#7570)	2020-12-03 19:22:24 -08:00
db_impl_compaction_flush.cc	Fix assert(cfd->imm()->NumNotFlushed() > 0) in FlushMemtable (#7744)	2020-12-04 20:31:39 -08:00
db_impl_debug.cc
db_impl_experimental.cc
db_impl_files.cc	Write min_log_number_to_keep to MANIFEST during atomic flush under 2 phase commit (#7570)	2020-12-03 19:22:24 -08:00
db_impl_open.cc
db_impl_readonly.cc
db_impl_readonly.h
db_impl_secondary.cc
db_impl_secondary.h
db_impl_write.cc
db_secondary_test.cc