mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-26 07:30:54 +00:00
e0c84aa0dc
Summary: There is a race condition if WAL tracking in the MANIFEST is enabled in a database that disables 2PC. The race condition is between two background flush threads trying to install flush results to the MANIFEST. Consider an example database with two column families: "default" (cfd0) and "cf1" (cfd1). Initially, both column families have one mutable (active) memtable whose data backed by 6.log. 1. Trigger a manual flush for "cf1", creating a 7.log 2. Insert another key to "default", and trigger flush for "default", creating 8.log 3. BgFlushThread1 finishes writing 9.sst 4. BgFlushThread2 finishes writing 10.sst ``` Time BgFlushThread1 BgFlushThread2 | mutex_.Lock() | precompute min_wal_to_keep as 6 | mutex_.Unlock() | mutex_.Lock() | precompute min_wal_to_keep as 6 | join MANIFEST write queue and mutex_.Unlock() | write to MANIFEST | mutex_.Lock() | cfd1->log_number = 7 | Signal bg_flush_2 and mutex_.Unlock() | wake up and mutex_.Lock() | cfd0->log_number = 8 | FindObsoleteFiles() with job_context->log_number == 7 | mutex_.Unlock() | PurgeObsoleteFiles() deletes 6.log V ``` As shown in the above, BgFlushThread2 thinks that the min wal to keep is 6.log because "cf1" has unflushed data in 6.log (cf1.log_number=6). Similarly, BgThread1 thinks that min wal to keep is also 6.log because "default" has unflushed data (default.log_number=6). No WAL deletion will be written to MANIFEST because 6 is equal to `versions_->wals_.min_wal_number_to_keep`, due to https://github.com/facebook/rocksdb/blob/7.1.fb/db/memtable_list.cc#L513:L514. The bg flush thread that finishes last will perform file purging. `job_context.log_number` will be evaluated as 7, i.e. the min wal that contains unflushed data, causing 6.log to be deleted. However, MANIFEST thinks 6.log should still exist. If you close the db at this point, you won't be able to re-open it if `track_and_verify_wal_in_manifest` is true. We must handle the case of multiple bg flush threads, and it is difficult for one bg flush thread to know the correct min wal number until the other bg flush threads have finished committing to the manifest and updated the `cfd::log_number`. To fix this issue, we rename an existing variable `min_log_number_to_keep_2pc` to `min_log_number_to_keep`, and use it to track WAL file deletion in non-2pc mode as well. This variable is updated only 1) during recovery with mutex held, or 2) in the MANIFEST write thread. `min_log_number_to_keep` means RocksDB will delete WALs below it, although there may be WALs above it which are also obsolete. Formally, we will have [min_wal_to_keep, max_obsolete_wal]. During recovery, we make sure that only WALs above max_obsolete_wal are checked and added back to `alive_log_files_`. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9715 Test Plan: ``` make check ``` Also ran stress test below (with asan) to make sure it completes successfully. ``` TEST_TMPDIR=/dev/shm/rocksdb OPT=-g ASAN_OPTIONS=disable_coredump=0 \ CRASH_TEST_EXT_ARGS=--compression_type=zstd SKIP_FORMAT_BUCK_CHECKS=1 \ make J=52 -j52 blackbox_asan_crash_test ``` Reviewed By: ltamasi Differential Revision: D34984412 Pulled By: riversand963 fbshipit-source-id: c7b21a8d84751bb55ea79c9f387103d21b231005 |
||
|---|---|---|
| .. | ||
| blob | ||
| compaction | ||
| db_impl | ||
| arena_wrapped_db_iter.cc | ||
| arena_wrapped_db_iter.h | ||
| builder.cc | ||
| builder.h | ||
| c.cc | ||
| c_test.c | ||
| column_family.cc | ||
| column_family.h | ||
| column_family_test.cc | ||
| compact_files_test.cc | ||
| comparator_db_test.cc | ||
| convenience.cc | ||
| corruption_test.cc | ||
| cuckoo_table_db_test.cc | ||
| db_basic_test.cc | ||
| db_block_cache_test.cc | ||
| db_bloom_filter_test.cc | ||
| db_compaction_filter_test.cc | ||
| db_compaction_test.cc | ||
| db_dynamic_level_test.cc | ||
| db_encryption_test.cc | ||
| db_filesnapshot.cc | ||
| db_flush_test.cc | ||
| db_info_dumper.cc | ||
| db_info_dumper.h | ||
| db_inplace_update_test.cc | ||
| db_io_failure_test.cc | ||
| db_iter.cc | ||
| db_iter.h | ||
| db_iter_stress_test.cc | ||
| db_iter_test.cc | ||
| db_iterator_test.cc | ||
| db_kv_checksum_test.cc | ||
| db_log_iter_test.cc | ||
| db_logical_block_size_cache_test.cc | ||
| db_memtable_test.cc | ||
| db_merge_operand_test.cc | ||
| db_merge_operator_test.cc | ||
| db_options_test.cc | ||
| db_properties_test.cc | ||
| db_range_del_test.cc | ||
| db_rate_limiter_test.cc | ||
| db_secondary_test.cc | ||
| db_sst_test.cc | ||
| db_statistics_test.cc | ||
| db_table_properties_test.cc | ||
| db_tailing_iter_test.cc | ||
| db_test.cc | ||
| db_test2.cc | ||
| db_test_util.cc | ||
| db_test_util.h | ||
| db_universal_compaction_test.cc | ||
| db_wal_test.cc | ||
| db_with_timestamp_basic_test.cc | ||
| db_with_timestamp_compaction_test.cc | ||
| db_write_buffer_manager_test.cc | ||
| db_write_test.cc | ||
| dbformat.cc | ||
| dbformat.h | ||
| dbformat_test.cc | ||
| deletefile_test.cc | ||
| error_handler.cc | ||
| error_handler.h | ||
| error_handler_fs_test.cc | ||
| event_helpers.cc | ||
| event_helpers.h | ||
| experimental.cc | ||
| external_sst_file_basic_test.cc | ||
| external_sst_file_ingestion_job.cc | ||
| external_sst_file_ingestion_job.h | ||
| external_sst_file_test.cc | ||
| fault_injection_test.cc | ||
| file_indexer.cc | ||
| file_indexer.h | ||
| file_indexer_test.cc | ||
| filename_test.cc | ||
| flush_job.cc | ||
| flush_job.h | ||
| flush_job_test.cc | ||
| flush_scheduler.cc | ||
| flush_scheduler.h | ||
| forward_iterator.cc | ||
| forward_iterator.h | ||
| forward_iterator_bench.cc | ||
| history_trimming_iterator.h | ||
| import_column_family_job.cc | ||
| import_column_family_job.h | ||
| import_column_family_test.cc | ||
| internal_stats.cc | ||
| internal_stats.h | ||
| job_context.h | ||
| kv_checksum.h | ||
| listener_test.cc | ||
| log_format.h | ||
| log_reader.cc | ||
| log_reader.h | ||
| log_test.cc | ||
| log_writer.cc | ||
| log_writer.h | ||
| logs_with_prep_tracker.cc | ||
| logs_with_prep_tracker.h | ||
| lookup_key.h | ||
| malloc_stats.cc | ||
| malloc_stats.h | ||
| manual_compaction_test.cc | ||
| memtable.cc | ||
| memtable.h | ||
| memtable_list.cc | ||
| memtable_list.h | ||
| memtable_list_test.cc | ||
| merge_context.h | ||
| merge_helper.cc | ||
| merge_helper.h | ||
| merge_helper_test.cc | ||
| merge_operator.cc | ||
| merge_test.cc | ||
| obsolete_files_test.cc | ||
| options_file_test.cc | ||
| output_validator.cc | ||
| output_validator.h | ||
| perf_context_test.cc | ||
| periodic_work_scheduler.cc | ||
| periodic_work_scheduler.h | ||
| periodic_work_scheduler_test.cc | ||
| pinned_iterators_manager.h | ||
| plain_table_db_test.cc | ||
| pre_release_callback.h | ||
| prefix_test.cc | ||
| range_del_aggregator.cc | ||
| range_del_aggregator.h | ||
| range_del_aggregator_bench.cc | ||
| range_del_aggregator_test.cc | ||
| range_tombstone_fragmenter.cc | ||
| range_tombstone_fragmenter.h | ||
| range_tombstone_fragmenter_test.cc | ||
| read_callback.h | ||
| repair.cc | ||
| repair_test.cc | ||
| snapshot_checker.h | ||
| snapshot_impl.cc | ||
| snapshot_impl.h | ||
| table_cache.cc | ||
| table_cache.h | ||
| table_properties_collector.cc | ||
| table_properties_collector.h | ||
| table_properties_collector_test.cc | ||
| transaction_log_impl.cc | ||
| transaction_log_impl.h | ||
| trim_history_scheduler.cc | ||
| trim_history_scheduler.h | ||
| version_builder.cc | ||
| version_builder.h | ||
| version_builder_test.cc | ||
| version_edit.cc | ||
| version_edit.h | ||
| version_edit_handler.cc | ||
| version_edit_handler.h | ||
| version_edit_test.cc | ||
| version_set.cc | ||
| version_set.h | ||
| version_set_test.cc | ||
| version_util.h | ||
| wal_edit.cc | ||
| wal_edit.h | ||
| wal_edit_test.cc | ||
| wal_manager.cc | ||
| wal_manager.h | ||
| wal_manager_test.cc | ||
| write_batch.cc | ||
| write_batch_base.cc | ||
| write_batch_internal.h | ||
| write_batch_test.cc | ||
| write_callback.h | ||
| write_callback_test.cc | ||
| write_controller.cc | ||
| write_controller.h | ||
| write_controller_test.cc | ||
| write_thread.cc | ||
| write_thread.h | ||