mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-26 16:30:56 +00:00
bd45633b71
Summary: @igor pointed out that there is a potential data race because of the way we use the newly introduced LogBuffer. After "bg_compaction_scheduled_--" or "bg_flush_scheduled_--", they can both become 0. As soon as the lock is released after that, DBImpl's deconstructor can go ahead and deconstruct all the states inside DB, including the info_log object hold in a shared pointer of the options object it keeps. At that point it is not safe anymore to continue using the info logger to write the delayed logs. With the patch, lock is released temporarily for log buffer to be flushed before "bg_compaction_scheduled_--" or "bg_flush_scheduled_--". In order to make sure we don't miss any pending flush or compaction, a new flag bg_schedule_needed_ is added, which is set to be true if there is a pending flush or compaction but not scheduled because of the max thread limit. If the flag is set to be true, the scheduling function will be called before compaction or flush thread finishes. Thanks @igor for this finding! Test Plan: make all check Reviewers: haobo, igor Reviewed By: haobo CC: dhruba, ljin, yhchiang, igor, leveldb Differential Revision: https://reviews.facebook.net/D16767
49 lines
1.4 KiB
C++
49 lines
1.4 KiB
C++
// Copyright (c) 2014, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
#pragma once
|
|
|
|
#include "rocksdb/env.h"
|
|
#include "util/arena.h"
|
|
#include "util/autovector.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class Logger;
|
|
|
|
// A class to buffer info log entries and flush them in the end.
|
|
class LogBuffer {
|
|
public:
|
|
// log_level: the log level for all the logs
|
|
// info_log: logger to write the logs to
|
|
LogBuffer(const InfoLogLevel log_level, Logger* info_log);
|
|
|
|
// Add a log entry to the buffer.
|
|
void AddLogToBuffer(const char* format, va_list ap);
|
|
|
|
size_t IsEmpty() const { return logs_.empty(); }
|
|
|
|
// Flush all buffered log to the info log.
|
|
void FlushBufferToLog();
|
|
|
|
private:
|
|
// One log entry with its timestamp
|
|
struct BufferedLog {
|
|
struct timeval now_tv; // Timestamp of the log
|
|
char message[1]; // Beginning of log message
|
|
};
|
|
|
|
const InfoLogLevel log_level_;
|
|
Logger* info_log_;
|
|
Arena arena_;
|
|
autovector<BufferedLog*> logs_;
|
|
};
|
|
|
|
// Add log to the LogBuffer for a delayed info logging. It can be used when
|
|
// we want to add some logs inside a mutex.
|
|
extern void LogToBuffer(LogBuffer* log_buffer, const char* format, ...);
|
|
|
|
} // namespace rocksdb
|