mirror of https://github.com/facebook/rocksdb.git
d8e792e4cf
Summary:
Fixes lots of compile warnings related to missing override specifiers, e.g.
```
./3rdParty/rocksdb/trace_replay/block_cache_tracer.h:130:10: warning: ‘virtual rocksdb::Status rocksdb::BlockCacheTraceWriterImpl::WriteBlockAccess(const rocksdb::BlockCacheTraceRecord&, const rocksdb::Slice&, const rocksdb::Slice&, const rocksdb::Slice&)’ can be marked override [-Wsuggest-override]
130 | Status WriteBlockAccess(const BlockCacheTraceRecord& record,
| ^~~~~~~~~~~~~~~~
./3rdParty/rocksdb/trace_replay/block_cache_tracer.h:136:10: warning: ‘virtual rocksdb::Status rocksdb::BlockCacheTraceWriterImpl::WriteHeader()’ can be marked override [-Wsuggest-override]
136 | Status WriteHeader();
| ^~~~~~~~~~~
```
Pull Request resolved: https://github.com/facebook/rocksdb/pull/10976
Reviewed By: riversand963
Differential Revision: D41478588
Pulled By: ajkr
fbshipit-source-id: d30b0457241999e38b16aacf6dabe3e691f7c46f
|
||
|---|---|---|
| .. | ||
| block_cache_tracer.cc | ||
| block_cache_tracer.h | ||
| block_cache_tracer_test.cc | ||
| io_tracer.cc | ||
| io_tracer.h | ||
| io_tracer_test.cc | ||
| trace_record.cc | ||
| trace_record_handler.cc | ||
| trace_record_handler.h | ||
| trace_record_result.cc | ||
| trace_replay.cc | ||
| trace_replay.h | ||