mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-29 09:36:17 +00:00
dbbffbd772
Summary: VersionSet::next_file_number_ is always assumed to be strictly greater than VersionSet::log_number_. In our new recovery code, we artificially set log_number_ to be (log_number + 1), so that once we flush, we don't recover from the same log file again (this is important because of merge operator non-idempotence) When we set VersionSet::log_number_ to (log_number + 1), we also have to mark that file number used, such that next_file_number_ is increased to a legal level. Otherwise, VersionSet might assert. This has not be a problem so far because here's what happens: 1. assume next_file_number is 5, we're recovering log_number 10 2. in DBImpl::Recover() we call MarkFileNumberUsed with 10. This will set VersionSet::next_file_number_ to 11. 3. If there are some updates, we will call WriteTable0ForRecovery(), which will use file number 11 as a new table file and advance VersionSet::next_file_number_ to 12. 4. When we LogAndApply() with log_number 11, assertion is true: assert(11 <= 12); However, this was a lucky occurrence. Even though this diff doesn't cause a bug, I think the issue is important to fix. Test Plan: In column families I have different recovery logic and this code path asserted. When adding MarkFileNumberUsed(log_number + 1) assert is gone. Reviewers: dhruba, kailiu Reviewed By: kailiu CC: leveldb Differential Revision: https://reviews.facebook.net/D15783 |
||
---|---|---|
build_tools | ||
coverage | ||
db | ||
doc | ||
hdfs | ||
helpers/memenv | ||
include | ||
linters | ||
port | ||
table | ||
tools | ||
util | ||
utilities | ||
.arcconfig | ||
.clang-format | ||
.gitignore | ||
CONTRIBUTING.md | ||
HISTORY.md | ||
INSTALL.md | ||
LICENSE | ||
Makefile | ||
PATENTS | ||
README | ||
README.fb |
rocksdb: A persistent key-value store for flash storage Authors: * The Facebook Database Engineering Team * Build on earlier work on leveldb by Sanjay Ghemawat (sanjay@google.com) and Jeff Dean (jeff@google.com) This code is a library that forms the core building block for a fast key value server, especially suited for storing data on flash drives. It has an Log-Structured-Merge-Database (LSM) design with flexible tradeoffs between Write-Amplification-Factor(WAF), Read-Amplification-Factor (RAF) and Space-Amplification-Factor(SAF). It has multi-threaded compactions, making it specially suitable for storing multiple terabytes of data in a single database. The core of this code has been derived from open-source leveldb. The code under this directory implements a system for maintaining a persistent key/value store. See doc/index.html and github wiki (https://github.com/facebook/rocksdb/wiki) for more explanation. The public interface is in include/*. Callers should not include or rely on the details of any other header files in this package. Those internal APIs may be changed without warning. Guide to header files: include/rocksdb/db.h Main interface to the DB: Start here include/rocksdb/options.h Control over the behavior of an entire database, and also control over the behavior of individual reads and writes. include/rocksdb/comparator.h Abstraction for user-specified comparison function. If you want just bytewise comparison of keys, you can use the default comparator, but clients can write their own comparator implementations if they want custom ordering (e.g. to handle different character encodings, etc.) include/rocksdb/iterator.h Interface for iterating over data. You can get an iterator from a DB object. include/rocksdb/write_batch.h Interface for atomically applying multiple updates to a database. include/rocksdb/slice.h A simple module for maintaining a pointer and a length into some other byte array. include/rocksdb/status.h Status is returned from many of the public interfaces and is used to report success and various kinds of errors. include/rocksdb/env.h Abstraction of the OS environment. A posix implementation of this interface is in util/env_posix.cc include/rocksdb/table_builder.h Lower-level modules that most clients probably won't use directly include/rocksdb/cache.h An API for the block cache. include/rocksdb/compaction_filter.h An API for a application filter invoked on every compaction. include/rocksdb/filter_policy.h An API for configuring a bloom filter. include/rocksdb/memtablerep.h An API for implementing a memtable. include/rocksdb/statistics.h An API to retrieve various database statistics. include/rocksdb/transaction_log.h An API to retrieve transaction logs from a database. Design discussions are conducted in https://www.facebook.com/groups/rocksdb.dev/