dolysis/rocksdb
3
0
Fork 0
mirror of https://github.com/facebook/rocksdb.git synced 2024-11-28 05:43:50 +00:00
Code Issues Packages Projects Releases Wiki Activity
rocksdb/utilities/agg_merge
History
Peter Dillinger 4e60663b31 Remove unnecessary, confusing 'extern' (#12300) 
Summary:
In C++, `extern` is redundant in a number of cases:
* "Global" function declarations and definitions
* "Global" variable definitions when already declared `extern`

For consistency and simplicity, I've removed these in code that *we own*. In a couple of cases, I removed obsolete declarations, and for MagicNumber constants, I have consolidated the declarations into a header file (format.h)
as standard best practice would prescribe.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/12300

Test Plan: no functional changes, CI

Reviewed By: ajkr

Differential Revision: D53148629

Pulled By: pdillinger

fbshipit-source-id: fb8d927959892e03af09b0c0d542b0a3b38fd886
2024-01-29 10:38:08 -08:00
..
agg_merge.cc Change internal headers with duplicate names (#11408) 2023-05-17 11:27:09 -07:00
agg_merge_impl.h Remove unnecessary, confusing 'extern' (#12300) 2024-01-29 10:38:08 -08:00
agg_merge_test.cc Change internal headers with duplicate names (#11408) 2023-05-17 11:27:09 -07:00
test_agg_merge.cc Change internal headers with duplicate names (#11408) 2023-05-17 11:27:09 -07:00
test_agg_merge.h