rocksdb/microbench
Jay Zhuang 5490da20a5 Fix flaky db_basic_bench caused by unreleased iterator (#10058)
Summary:
Iterator is not freed after test is done (after the main for
loop), which could cause db close failed.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/10058

Test Plan:
Able to reproduce consistently with higher thread number,
like 100, make sure it passes after the fix

Reviewed By: ajkr

Differential Revision: D36685823

Pulled By: jay-zhuang

fbshipit-source-id: 4c98b8758d106bfe40cae670e689c3d284765bcf
2022-05-25 18:02:04 -07:00
..
CMakeLists.txt Add microbench document (#9781) 2022-03-31 17:17:44 -07:00
db_basic_bench.cc Fix flaky db_basic_bench caused by unreleased iterator (#10058) 2022-05-25 18:02:04 -07:00
README.md Add microbench document (#9781) 2022-03-31 17:17:44 -07:00
ribbon_bench.cc update buckifier, add support for microbenchmarks (#9598) 2022-02-18 11:23:18 -08:00

RocksDB Micro-Benchmark

Overview

RocksDB micro-benchmark is a set of tests for benchmarking a single component or simple DB operations. The test artificially generates input data and executes the same operation with it to collect and report performance metrics. As it's focusing on testing a single, well-defined operation, the result is more precise and reproducible, which also has its limitation of not representing a real production use case. The test author needs to carefully design the microbench to represent its true purpose.

The tests are based on Google Benchmark library, which provides a standard framework for writing benchmarks.

How to Run

Prerequisite

Install the Google Benchmark version 1.6.0 or above.

Note: Google Benchmark 1.6.x is incompatible with previous versions like 1.5.x, please make sure you're using the newer version.

Build and Run

With Makefile:

$ DEBUG_LEVEL=0 make run_microbench

Or with cmake:

$ mkdir build && cd build && cmake .. -DCMAKE_BUILD_TYPE=Release -DWITH_BENCHMARK
$ make run_microbench

Note: Please run the benchmark code in release build.

Run Single Test

Example:

$ make db_basic_bench
$ ./db_basic_bench --benchmark_filter=<TEST_NAME>

Best Practices

* Use the Same Test Directory Setting as Unittest

Most of the Micro-benchmark tests use the same test directory setup as unittest, so it could be overridden by:

$ TEST_TMPDIR=/mydata/tmp/ ./db_basic_bench --benchmark_filter=<TEST_NAME>

Please also follow that when designing new tests.

* Avoid Using Debug API

Even though micro-benchmark is a test, avoid using internal Debug API like TEST_WaitForRun() which is designed for unittest. As benchmark tests are designed for release build, don't use any of that.

* Pay Attention to Local Optimization

As a micro-benchmark is focusing on a single component or area, make sure it is a key part for impacting the overall application performance.

The compiler might be able to optimize the code that not the same way as the whole application, and if the test data input is simple and small, it may be able to all cached in CPU memory, which is leading to a wrong metric. Take these into consideration when designing the tests.

* Names of user-defined counters/metrics has to be [A-Za-z0-9_]

It's a restriction of the metrics collecting and reporting system RocksDB is using internally. It will also help integrate with more systems.

* Minimize the Metrics Variation

Try reducing the test result variation, one way to check that is running the test multiple times and check the CV (Coefficient of Variation) reported by gbenchmark.

$ ./db_basic_bench --benchmark_filter=<TEST_NAME> --benchmark_repetitions=10
...
<TEST_NAME>_cv    3.2%

RocksDB has background compaction jobs which may cause the test result to vary a lot. If the micro-benchmark is not purposely testing the operation while compaction is in progress, it should wait for the compaction to finish (db_impl->WaitForCompact()) or disable auto-compaction.