mirror of https://github.com/facebook/rocksdb.git
d5bc30befa
Summary: ... when compiled with ASSERT_STATUS_CHECKED = 1. The main change is in iterator_wrapper.h. The remaining changes are just fixing existing unit tests. Adding this check to IteratorWrapper gives a good coverage as the class is used in many places, including child iterators under merging iterator, merging iterator under DB iter, file_iter under level iterator, etc. This change can catch the bug fixed in https://github.com/facebook/rocksdb/issues/11782. Future follow up: enable `ASSERT_STATUS_CHECKED=1` for stress test and for DEBUG_LEVEL=0. Pull Request resolved: https://github.com/facebook/rocksdb/pull/11975 Test Plan: * `ASSERT_STATUS_CHECKED=1 DEBUG_LEVEL=2 make -j32 J=32 check` * I tried to run stress test with `ASSERT_STATUS_CHECKED=1`, but there are a lot of existing stress code that ignore status checking, and fail without the change in this PR. So defer that to a follow up task. Reviewed By: ajkr Differential Revision: D50383790 Pulled By: cbi42 fbshipit-source-id: 1a28ce0f5fdf1890f93400b26b3b1b3a287624ce |
||
|---|---|---|
| .. | ||
| file_read_sample.h | ||
| histogram.cc | ||
| histogram.h | ||
| histogram_test.cc | ||
| histogram_windowing.cc | ||
| histogram_windowing.h | ||
| in_memory_stats_history.cc | ||
| in_memory_stats_history.h | ||
| instrumented_mutex.cc | ||
| instrumented_mutex.h | ||
| iostats_context.cc | ||
| iostats_context_imp.h | ||
| iostats_context_test.cc | ||
| perf_context.cc | ||
| perf_context_imp.h | ||
| perf_level.cc | ||
| perf_level_imp.h | ||
| perf_step_timer.h | ||
| persistent_stats_history.cc | ||
| persistent_stats_history.h | ||
| statistics.cc | ||
| statistics_impl.h | ||
| statistics_test.cc | ||
| stats_history_test.cc | ||
| thread_status_impl.cc | ||
| thread_status_updater.cc | ||
| thread_status_updater.h | ||
| thread_status_updater_debug.cc | ||
| thread_status_util.cc | ||
| thread_status_util.h | ||
| thread_status_util_debug.cc | ||