Yanqin Jin 9586dcf1ce Expose the initial logger creation error (#10223) ... Summary: https://github.com/facebook/rocksdb/issues/9984 changes the behavior of RocksDB: if logger creation failed during `SanitizeOptions()`, `DB::Open()` will fail. However, since `SanitizeOptions()` is called in `DBImpl::DBImpl()`, we cannot directly expose the error to caller without some additional work. This is a first version proposal which: - Adds a new member `init_logger_creation_s` to `DBImpl` to store the result of init logger creation - Checks the error during `DB::Open()` and return it to caller if non-ok This is not very ideal. We can alternatively move the logger creation logic out of the `SanitizeOptions()`. Since `SanitizeOptions()` is used in other places, we need to check whether this change breaks anything in case other callers of `SanitizeOptions()` assumes that a logger should be created. Pull Request resolved: https://github.com/facebook/rocksdb/pull/10223 Test Plan: make check Reviewed By: pdillinger Differential Revision: D37321717 Pulled By: riversand963 fbshipit-source-id: 58042358a86369d606549dd9938933dd47591c4b		2022-06-22 08:26:38 -07:00
..
agg_merge	Add Aggregation Merge Operator (#9780)	2022-04-15 23:24:05 -07:00
backup	Expose the initial logger creation error (#10223)	2022-06-22 08:26:38 -07:00
blob_db	Remove own ToString() (#9955)	2022-05-06 13:03:58 -07:00
cassandra	Restore Regex support for ObjectLibrary::Register, rename new APIs to allow old one to be deprecated in the future (#9362)	2022-01-11 06:33:48 -08:00
checkpoint	Fix race condition with WAL tracking and FlushWAL(true /* sync */) (#10185)	2022-06-17 16:45:28 -07:00
compaction_filters	Make MergeOperator+CompactionFilter/Factory into Customizable Classes (#8481)	2021-08-06 08:27:25 -07:00
convenience	Add a SystemClock class to capture the time functions of an Env (#7858)	2021-01-25 22:09:11 -08:00
leveldb_options	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
memory	Remove own ToString() (#9955)	2022-05-06 13:03:58 -07:00
merge_operators	Remove using namespace (#9369)	2022-01-12 09:31:12 -08:00
option_change_migration	Fix some typos in comments and HISTORY.md (#9798)	2022-04-04 09:32:57 -07:00
options	Remove own ToString() (#9955)	2022-05-06 13:03:58 -07:00
persistent_cache	Remove code that only compiles for Visual Studio versions older than 2015 (#10065)	2022-05-26 16:55:08 -07:00
simulator_cache	Remove own ToString() (#9955)	2022-05-06 13:03:58 -07:00
table_properties_collectors	Remove own ToString() (#9955)	2022-05-06 13:03:58 -07:00
trace	Add rate limiter priority to ReadOptions (#9424)	2022-02-16 23:18:14 -08:00
transactions	Add WriteOptions::protection_bytes_per_key (#10037)	2022-06-16 23:10:07 -07:00
ttl	Work around some new clang-analyze failures (#9515)	2022-02-07 18:24:36 -08:00
write_batch_with_index	Add WriteOptions::protection_bytes_per_key (#10037)	2022-06-16 23:10:07 -07:00
cache_dump_load.cc	Introduce a mechanism to dump out blocks from block cache and re-insert to secondary cache (#8912)	2021-10-07 11:42:31 -07:00
cache_dump_load_impl.cc	Remove deprecated block-based filter (#10184)	2022-06-16 15:51:33 -07:00
cache_dump_load_impl.h	Remove deprecated block-based filter (#10184)	2022-06-16 15:51:33 -07:00
compaction_filters.cc	Restore Regex support for ObjectLibrary::Register, rename new APIs to allow old one to be deprecated in the future (#9362)	2022-01-11 06:33:48 -08:00
counted_fs.cc	Explicitly closing all directory file descriptors (#10049)	2022-06-01 18:03:34 -07:00
counted_fs.h	Explicitly closing all directory file descriptors (#10049)	2022-06-01 18:03:34 -07:00
debug.cc	In ParseInternalKey(), include corrupt key info in Status (#7515)	2020-10-28 10:12:58 -07:00
env_mirror.cc	Fix clang13 build error (#9374)	2022-01-11 10:36:22 -08:00
env_mirror_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
env_timed.cc	Make FileSystem a Customizable Class (#8649)	2021-11-02 09:07:11 -07:00
env_timed.h	Make FileSystem a Customizable Class (#8649)	2021-11-02 09:07:11 -07:00
env_timed_test.cc	Make env*_test work with ASSERT_STATUS_CHECKED (#7176)	2020-07-28 22:59:48 -07:00
fault_injection_env.cc	Explicitly closing all directory file descriptors (#10049)	2022-06-01 18:03:34 -07:00
fault_injection_env.h	Explicitly closing all directory file descriptors (#10049)	2022-06-01 18:03:34 -07:00
fault_injection_fs.cc	Explicitly closing all directory file descriptors (#10049)	2022-06-01 18:03:34 -07:00
fault_injection_fs.h	Explicitly closing all directory file descriptors (#10049)	2022-06-01 18:03:34 -07:00
fault_injection_secondary_cache.cc	Prevent double caching in the compressed secondary cache (#9747)	2022-04-11 13:28:33 -07:00
fault_injection_secondary_cache.h	Prevent double caching in the compressed secondary cache (#9747)	2022-04-11 13:28:33 -07:00
memory_allocators.h	Make MemoryAllocator into a Customizable class (#8980)	2021-12-17 04:20:47 -08:00
merge_operators.cc	Restore Regex support for ObjectLibrary::Register, rename new APIs to allow old one to be deprecated in the future (#9362)	2022-01-11 06:33:48 -08:00
merge_operators.h	Make MergeOperator+CompactionFilter/Factory into Customizable Classes (#8481)	2021-08-06 08:27:25 -07:00
object_registry.cc	Added GetFactoryCount/Names/Types to ObjectRegistry (#9358)	2022-05-16 09:44:43 -07:00
object_registry_test.cc	Added GetFactoryCount/Names/Types to ObjectRegistry (#9358)	2022-05-16 09:44:43 -07:00
util_merge_operators_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
wal_filter.cc	Make WalFilter, SstPartitionerFactory, FileChecksumGenFactory, and TableProperties Customizable (#8638)	2021-09-28 05:32:02 -07:00