mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-26 16:30:56 +00:00
c6d464a9da
Summary: I have manually audited the entire RocksJava code base. Sorry for the large pull-request, I have broken it down into many small atomic commits though. My initial intention was to fix the warnings that appear when running RocksJava on Java 8 with `-Xcheck:jni`, for example when running `make jtest` you would see many errors similar to: ``` WARNING in native method: JNI call made without checking exceptions when required to from CallObjectMethod WARNING in native method: JNI call made without checking exceptions when required to from CallVoidMethod WARNING in native method: JNI call made without checking exceptions when required to from CallStaticVoidMethod ... ``` A few of those warnings still remain, however they seem to come directly from the JVM and are not directly related to RocksJava; I am in contact with the OpenJDK hostpot-dev mailing list about these - http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-February/025981.html. As a result of fixing these, I realised we were not r Closes https://github.com/facebook/rocksdb/pull/1890 Differential Revision: D4591758 Pulled By: siying fbshipit-source-id: 7f7fdf4
184 lines
5.7 KiB
C++
184 lines
5.7 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
// This file implements the "bridge" between Java and C++ and enables
|
|
// calling c++ rocksdb::TtlDB methods.
|
|
// from Java side.
|
|
|
|
#include <jni.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string>
|
|
#include <vector>
|
|
#include <memory>
|
|
|
|
#include "include/org_rocksdb_TtlDB.h"
|
|
#include "rocksdb/utilities/db_ttl.h"
|
|
#include "rocksjni/portal.h"
|
|
|
|
/*
|
|
* Class: org_rocksdb_TtlDB
|
|
* Method: open
|
|
* Signature: (JLjava/lang/String;IZ)J
|
|
*/
|
|
jlong Java_org_rocksdb_TtlDB_open(JNIEnv* env,
|
|
jclass jcls, jlong joptions_handle, jstring jdb_path,
|
|
jint jttl, jboolean jread_only) {
|
|
const char* db_path = env->GetStringUTFChars(jdb_path, nullptr);
|
|
if(db_path == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
return 0;
|
|
}
|
|
|
|
auto* opt = reinterpret_cast<rocksdb::Options*>(joptions_handle);
|
|
rocksdb::DBWithTTL* db = nullptr;
|
|
rocksdb::Status s = rocksdb::DBWithTTL::Open(*opt, db_path, &db,
|
|
jttl, jread_only);
|
|
env->ReleaseStringUTFChars(jdb_path, db_path);
|
|
|
|
// as TTLDB extends RocksDB on the java side, we can reuse
|
|
// the RocksDB portal here.
|
|
if (s.ok()) {
|
|
return reinterpret_cast<jlong>(db);
|
|
} else {
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_TtlDB
|
|
* Method: openCF
|
|
* Signature: (JLjava/lang/String;[[B[J[IZ)[J
|
|
*/
|
|
jlongArray
|
|
Java_org_rocksdb_TtlDB_openCF(
|
|
JNIEnv* env, jclass jcls, jlong jopt_handle, jstring jdb_path,
|
|
jobjectArray jcolumn_names, jlongArray jcolumn_options,
|
|
jintArray jttls, jboolean jread_only) {
|
|
const char* db_path = env->GetStringUTFChars(jdb_path, nullptr);
|
|
if(db_path == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
return 0;
|
|
}
|
|
|
|
const jsize len_cols = env->GetArrayLength(jcolumn_names);
|
|
jlong* jco = env->GetLongArrayElements(jcolumn_options, nullptr);
|
|
if(jco == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
env->ReleaseStringUTFChars(jdb_path, db_path);
|
|
return nullptr;
|
|
}
|
|
|
|
std::vector<rocksdb::ColumnFamilyDescriptor> column_families;
|
|
jboolean has_exception = JNI_FALSE;
|
|
rocksdb::JniUtil::byteStrings<std::string>(
|
|
env,
|
|
jcolumn_names,
|
|
[](const char* str_data, const size_t str_len) {
|
|
return std::string(str_data, str_len);
|
|
},
|
|
[&jco, &column_families](size_t idx, std::string cf_name) {
|
|
rocksdb::ColumnFamilyOptions* cf_options =
|
|
reinterpret_cast<rocksdb::ColumnFamilyOptions*>(jco[idx]);
|
|
column_families.push_back(
|
|
rocksdb::ColumnFamilyDescriptor(cf_name, *cf_options));
|
|
},
|
|
&has_exception);
|
|
|
|
env->ReleaseLongArrayElements(jcolumn_options, jco, JNI_ABORT);
|
|
|
|
if(has_exception == JNI_TRUE) {
|
|
// exception occured
|
|
env->ReleaseStringUTFChars(jdb_path, db_path);
|
|
return nullptr;
|
|
}
|
|
|
|
std::vector<int32_t> ttl_values;
|
|
jint* jttlv = env->GetIntArrayElements(jttls, nullptr);
|
|
if(jttlv == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
env->ReleaseStringUTFChars(jdb_path, db_path);
|
|
return nullptr;
|
|
}
|
|
const jsize len_ttls = env->GetArrayLength(jttls);
|
|
for(jsize i = 0; i < len_ttls; i++) {
|
|
ttl_values.push_back(jttlv[i]);
|
|
}
|
|
env->ReleaseIntArrayElements(jttls, jttlv, JNI_ABORT);
|
|
|
|
auto* opt = reinterpret_cast<rocksdb::DBOptions*>(jopt_handle);
|
|
std::vector<rocksdb::ColumnFamilyHandle*> handles;
|
|
rocksdb::DBWithTTL* db = nullptr;
|
|
rocksdb::Status s = rocksdb::DBWithTTL::Open(*opt, db_path, column_families,
|
|
&handles, &db, ttl_values, jread_only);
|
|
|
|
// we have now finished with db_path
|
|
env->ReleaseStringUTFChars(jdb_path, db_path);
|
|
|
|
// check if open operation was successful
|
|
if (s.ok()) {
|
|
const jsize resultsLen = 1 + len_cols; //db handle + column family handles
|
|
std::unique_ptr<jlong[]> results =
|
|
std::unique_ptr<jlong[]>(new jlong[resultsLen]);
|
|
results[0] = reinterpret_cast<jlong>(db);
|
|
for(int i = 1; i <= len_cols; i++) {
|
|
results[i] = reinterpret_cast<jlong>(handles[i - 1]);
|
|
}
|
|
|
|
jlongArray jresults = env->NewLongArray(resultsLen);
|
|
if(jresults == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
return nullptr;
|
|
}
|
|
|
|
env->SetLongArrayRegion(jresults, 0, resultsLen, results.get());
|
|
if(env->ExceptionCheck()) {
|
|
// exception thrown: ArrayIndexOutOfBoundsException
|
|
env->DeleteLocalRef(jresults);
|
|
return nullptr;
|
|
}
|
|
|
|
return jresults;
|
|
} else {
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
return NULL;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_TtlDB
|
|
* Method: createColumnFamilyWithTtl
|
|
* Signature: (JLorg/rocksdb/ColumnFamilyDescriptor;[BJI)J;
|
|
*/
|
|
jlong Java_org_rocksdb_TtlDB_createColumnFamilyWithTtl(
|
|
JNIEnv* env, jobject jobj, jlong jdb_handle,
|
|
jbyteArray jcolumn_name, jlong jcolumn_options, jint jttl) {
|
|
|
|
jbyte* cfname = env->GetByteArrayElements(jcolumn_name, nullptr);
|
|
if(cfname == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
return 0;
|
|
}
|
|
const jsize len = env->GetArrayLength(jcolumn_name);
|
|
|
|
auto* cfOptions =
|
|
reinterpret_cast<rocksdb::ColumnFamilyOptions*>(jcolumn_options);
|
|
|
|
auto* db_handle = reinterpret_cast<rocksdb::DBWithTTL*>(jdb_handle);
|
|
rocksdb::ColumnFamilyHandle* handle;
|
|
rocksdb::Status s = db_handle->CreateColumnFamilyWithTtl(
|
|
*cfOptions, std::string(reinterpret_cast<char *>(cfname),
|
|
len), &handle, jttl);
|
|
|
|
env->ReleaseByteArrayElements(jcolumn_name, cfname, 0);
|
|
|
|
if (s.ok()) {
|
|
return reinterpret_cast<jlong>(handle);
|
|
}
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
return 0;
|
|
}
|