mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-29 18:33:58 +00:00
c6d464a9da
Summary: I have manually audited the entire RocksJava code base. Sorry for the large pull-request, I have broken it down into many small atomic commits though. My initial intention was to fix the warnings that appear when running RocksJava on Java 8 with `-Xcheck:jni`, for example when running `make jtest` you would see many errors similar to: ``` WARNING in native method: JNI call made without checking exceptions when required to from CallObjectMethod WARNING in native method: JNI call made without checking exceptions when required to from CallVoidMethod WARNING in native method: JNI call made without checking exceptions when required to from CallStaticVoidMethod ... ``` A few of those warnings still remain, however they seem to come directly from the JVM and are not directly related to RocksJava; I am in contact with the OpenJDK hostpot-dev mailing list about these - http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-February/025981.html. As a result of fixing these, I realised we were not r Closes https://github.com/facebook/rocksdb/pull/1890 Differential Revision: D4591758 Pulled By: siying fbshipit-source-id: 7f7fdf4
69 lines
2 KiB
C++
69 lines
2 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
// This file implements the "bridge" between Java and C++ and enables
|
|
// calling c++ rocksdb::Checkpoint methods from Java side.
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <jni.h>
|
|
#include <string>
|
|
|
|
#include "include/org_rocksdb_Checkpoint.h"
|
|
#include "rocksjni/portal.h"
|
|
#include "rocksdb/db.h"
|
|
#include "rocksdb/utilities/checkpoint.h"
|
|
/*
|
|
* Class: org_rocksdb_Checkpoint
|
|
* Method: newCheckpoint
|
|
* Signature: (J)J
|
|
*/
|
|
jlong Java_org_rocksdb_Checkpoint_newCheckpoint(JNIEnv* env,
|
|
jclass jclazz, jlong jdb_handle) {
|
|
auto* db = reinterpret_cast<rocksdb::DB*>(jdb_handle);
|
|
rocksdb::Checkpoint* checkpoint;
|
|
rocksdb::Checkpoint::Create(db, &checkpoint);
|
|
return reinterpret_cast<jlong>(checkpoint);
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_Checkpoint
|
|
* Method: dispose
|
|
* Signature: (J)V
|
|
*/
|
|
void Java_org_rocksdb_Checkpoint_disposeInternal(JNIEnv* env, jobject jobj,
|
|
jlong jhandle) {
|
|
auto* checkpoint = reinterpret_cast<rocksdb::Checkpoint*>(jhandle);
|
|
assert(checkpoint != nullptr);
|
|
delete checkpoint;
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_Checkpoint
|
|
* Method: createCheckpoint
|
|
* Signature: (JLjava/lang/String;)V
|
|
*/
|
|
void Java_org_rocksdb_Checkpoint_createCheckpoint(
|
|
JNIEnv* env, jobject jobj, jlong jcheckpoint_handle,
|
|
jstring jcheckpoint_path) {
|
|
const char* checkpoint_path = env->GetStringUTFChars(
|
|
jcheckpoint_path, 0);
|
|
if(checkpoint_path == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
return;
|
|
}
|
|
|
|
auto* checkpoint = reinterpret_cast<rocksdb::Checkpoint*>(
|
|
jcheckpoint_handle);
|
|
rocksdb::Status s = checkpoint->CreateCheckpoint(
|
|
checkpoint_path);
|
|
|
|
env->ReleaseStringUTFChars(jcheckpoint_path, checkpoint_path);
|
|
|
|
if (!s.ok()) {
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
}
|
|
}
|